Uh oh!
There was an error while loading. Please reload this page.
password-hash: add Error::OutputSize - #1026
Conversation
Uh oh!
There was an error while loading. Please reload this page.
password_hash::Error::OutputSizeError::OutputSizecf55a17 to
c1f7018Comparetarcieri
commented
Jul 24, 2022
This is back to having three different variants that effectively mean different flavors of the same thing. What about this instead? OutputSize{expected:Ordering,size: usize } |
3387d43 to
c80afb1Compare
I wasn't sure how you mean that, I kinda turned it around, the Also squashed the commits. EDIT: I hope the documentation is sufficient and alright. |
7808718 to
ea87046CompareUh oh!
There was an error while loading. Please reload this page.
ea87046 to
a396237Compare
tarcieri
left a comment
There was a problem hiding this comment.
This looks good to me now.
It's a breaking change though, so I might keep this open until we're ready to start working on the next version of password-hash.
daxpedda
commented
Jan 9, 2023
@tarcieri just saw the new update to 0.5.0-pre.0, are we ready to add this breaking change now? |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Tony Arcieri <bascule@gmail.com>
70af450 to
91e2049Comparetarcieri
commented
Jan 9, 2023
Thanks! |
See RustCrypto/password-hashes#313.
Sometimes a very specific output size is expected. Any bike-shedding is very welcome.