crypto-common: migrate to `hybrid-array`; MSRV 1.65 by tarcieri · Pull Request #1319 · RustCrypto/traits

tarcieri · 2023-05-30T23:35:57Z

Replaces generic-array with hybrid-array, which is built on a combination of typenum and const generics, providing a degree of interoperability between the two systems.

hybrid-array is designed to be a largely drop-in replacement, and the number of changes required to switch are relatively minimal aside from some idiosyncracies.

newpavlov

Looks good, but it would be nice to see migration of the other trait crates as well to be safe against potential unforeseen issues.

Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`

tarcieri · 2023-09-05T01:50:30Z

Since block-buffer depends on crypto-common, I've opened the next step of this migration in the utils repo: RustCrypto/utils#944

Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`

newpavlov · 2023-09-13T14:59:46Z

generic-array v1.0 has implemented Try/From for arrays using const generics and simplified the ArrayLength trait. Is this PR still relevant in the light of it?

tarcieri · 2023-09-13T15:04:34Z

Yes, hybrid-array is natively built on const generic arrays at its core. Array is a newtype of the inner array type, which is pub.

generic-array instead has an opaque inner type and uses large amounts of unsafe code to achieve its goals. It has wrappers to use const generics which use a similar technique to hybrid-array (and thus have similar limitations), but if you use that approach like hybrid-array has done you can go all-in and get rid of (most of) the unsafe code.

newpavlov · 2023-09-13T15:08:20Z

Ok. Should we migrate to generic-array v1.0 in the next release cycle first or would you prefer to try hybrid-array migration without it?

tarcieri · 2023-09-13T15:09:52Z

Personally I'd prefer to go straight to hybrid-array and have already done some of the work, see also RustCrypto/utils#944

I can do cipher and digest next.

Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`

tarcieri · 2023-10-26T01:37:35Z

The minimal-versions failure seems to be a nightly regression and probably impacts master as well

Replaces `generic-array` with `hybrid-array`, which is built on a combination of `typenum` and const generics, providing a degree of interoperability between the two systems. `hybrid-array` is designed to be a largely drop-in replacement, and the number of changes required to switch are relatively minimal aside from some idiosyncracies.

tarcieri · 2023-10-26T15:23:19Z

@newpavlov this is ready now

newpavlov

Can you also change bound for the BlockSize sealed impl from Self: IsLess<U256> + IsGreater<U1> to Self: IsLess<U256> + IsGreater<U0>? I intended to do it in #1174.

The `ArraySize` trait already bounds on `'static`

### Added - Sealed `BlockSizes` trait implemented for types from `U1` to `U255` ([#1172]) - `SerializableState` trait under `hazmat` module ([#1369]) - `OutputSize` type alias ([#1533]) - `IvState` trait ([#1636]) - `core::error::Error` impls for error types ([#1660]) - `Generate` trait as a common RNG API ([#2096], [#2145]) - `TryKeyInit` trait ([#2097]) - Re-export `getrandom` ([#2152]) - `KeyExport` trait ([#2213]) ### Changed - Replaced `generic-array` with `hybrid-array` ([#1319], [#1976]) - `BlockUser::BlockSize` is now bounded by the `BlockSizes` trait - Edition changed to 2024 and MSRV bumped to 1.85 ([#1759]) - `generate_*` methods on `KeyInit` and `KeyIvInit` traits have been deprecated in favor of the new `Generate` trait ([#2162]) - Bump `rand_core` to v0.10 ([#2250]) - Bump `getrandom` to v0.4 ([#2258]) ### Removed - `std` feature ([#1680]) [#1172]: #1172 [#1319]: #1319 [#1369]: #1369 [#1533]: #1533 [#1636]: #1636 [#1660]: #1660 [#1680]: #1680 [#1759]: #1759 [#1976]: #1976 [#2096]: #2096 [#2097]: #2097 [#2145]: #2145 [#2152]: #2152 [#2162]: #2162 [#2213]: #2213 [#2250]: #2250 [#2258]: #2258

tarcieri requested a review from newpavlov May 30, 2023 23:35

tarcieri commented May 30, 2023
View reviewed changes

Comment threadcrypto-common/src/lib.rs Outdated

tarcieri commented May 30, 2023
View reviewed changes

Comment threadcrypto-common/src/lib.rs Outdated

tarcieri force-pushed the crypto-common/hybrid-array branch 3 times, most recently from 5e808f0 to 0856ad0Compare May 31, 2023 02:57

newpavlov reviewed May 31, 2023
View reviewed changes

tarcieri force-pushed the crypto-common/hybrid-array branch 3 times, most recently from 5a6327f to 0c9a9bbCompare September 5, 2023 01:34

tarcieri mentioned this pull request Sep 5, 2023
Migrate to hybrid-array; MSRV 1.65 RustCrypto/utils#944
Merged

tarcieri force-pushed the crypto-common/hybrid-array branch from 0c9a9bb to 9a65db3Compare September 5, 2023 19:13

sinui0 mentioned this pull request Sep 13, 2023
Update RustCrypto dependencies to next release candidate and migrate to hybrid-arrayethereum/mpz#61
Closed

tarcieri mentioned this pull request Sep 22, 2023
Bump dependency on generic-array to version 1.0.0 RustCrypto/AEADs#553
Closed

tarcieri mentioned this pull request Oct 8, 2023
[WIP] cipher: migrate to hybrid array #1357
Closed

tarcieri mentioned this pull request Oct 8, 2023
cipher+digest: migrate to hybrid array; MSRV 1.65 #1358
Merged

tarcieri force-pushed the crypto-common/hybrid-array branch 2 times, most recently from 2854b76 to 11330b0Compare October 26, 2023 01:30

tarcieri changed the title ~~[WIP] crypto-common: migrate to hybrid-array; MSRV 1.65~~crypto-common: migrate to hybrid-array; MSRV 1.65Oct 26, 2023

tarcieri force-pushed the crypto-common/hybrid-array branch from 11330b0 to 3ada46bCompare October 26, 2023 15:02

tarcieri marked this pull request as ready for review October 26, 2023 15:22

tarcieri requested a review from newpavlov October 26, 2023 15:23

newpavlov approved these changes Oct 26, 2023
View reviewed changes

Comment threadcrypto-common/src/lib.rs Outdated

tarcieri added 2 commits October 26, 2023 10:34

crypto-common: remove 'static bounds on ArraySizes
c3ede80
The `ArraySize` trait already bounds on `'static`

crypto-common: allow U1-sized BlockSizes
2542396

tarcieri requested a review from newpavlov October 26, 2023 16:37

newpavlov approved these changes Oct 26, 2023
View reviewed changes

tarcieri merged commit 766c138 into masterOct 26, 2023

tarcieri deleted the crypto-common/hybrid-array branch October 26, 2023 17:19

akoshelev mentioned this pull request Mar 27, 2024
Hashing functionality needed to support Fiat-Shamir private-attribution/ipa#993
Merged

This was referenced Sep 18, 2024
deprecate use of GenericArray lora-rs/lora-rs#126
Closed
Migration guide from GenericArray? RustCrypto/hybrid-array#91
Closed

ifsheldon mentioned this pull request Nov 15, 2025
Upgrade and clean dependencies jasonwhite/rudolfs#82
Merged

tarcieri mentioned this pull request Feb 3, 2026
crypto-common v0.2.0 #2276
Merged

Navigation Menu

Uh oh!

crypto-common: migrate to `hybrid-array`; MSRV 1.65 - #1319

crypto-common: migrate to `hybrid-array`; MSRV 1.65#1319
tarcieri merged 3 commits into
masterfrom
crypto-common/hybrid-array

tarcieri commented May 30, 2023

Uh oh!

Uh oh!

Uh oh!

newpavlov left a comment

Uh oh!

tarcieri commented Sep 5, 2023

Uh oh!

newpavlov commented Sep 13, 2023

Uh oh!

tarcieri commented Sep 13, 2023•
edited
Loading

Uh oh!

newpavlov commented Sep 13, 2023

Uh oh!

tarcieri commented Sep 13, 2023

Uh oh!

tarcieri commented Oct 26, 2023

Uh oh!

tarcieri commented Oct 26, 2023

Uh oh!

newpavlov left a comment •
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tarcieri commented May 30, 2023

Uh oh!

Uh oh!

Uh oh!

newpavlov left a comment

Choose a reason for hiding this comment

Uh oh!

tarcieri commented Sep 5, 2023

Uh oh!

newpavlov commented Sep 13, 2023

Uh oh!

tarcieri commented Sep 13, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

newpavlov commented Sep 13, 2023

Uh oh!

tarcieri commented Sep 13, 2023

Uh oh!

tarcieri commented Oct 26, 2023

Uh oh!

tarcieri commented Oct 26, 2023

Uh oh!

newpavlov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tarcieri commented Sep 13, 2023•
edited
Loading

newpavlov left a comment •
edited
Loading