signature: replace `signature_derive` with blanket impls by tarcieri · Pull Request #1827 · RustCrypto/traits

tarcieri · 2025-04-20T21:08:08Z

Adds blanket impls of:

Signer for types which impl PrehashSignature + DigestSignature
Verifier for types which impl PrehashSignature + DigestVerifier

These blanket impls eliminate the need to have a signature_derive crate, which only existed to write the Signer and Verifier impls for this particular case.

Since this is a breaking change, bumps the version to 3.0.0-pre

Adds blanket impls of: - `Signer` for types which impl `PrehashSignature + DigestSignature` - `Verifier` for types which impl `PrehashSignature + DigestVerifier` These blanket impls eliminate the need to have a `signature_derive` crate, which only existed to write the `Signer` and `Verifier` impls for this particular case. Since this is a breaking change, bumps the version to `3.0.0-pre`

tarcieri · 2025-04-20T21:12:58Z

I think we're at the point where we can do a major version bump, and getting rid of signature_derive would be a great reason to do so, IMO.

IIRC this change was originally suggested by @baloo but I can't find where.

We'll need to verify it works against https://github.com/RustCrypto/signatures

baloo · 2025-04-20T22:21:33Z

I think that was for the AsyncSigner? (#1419 (comment))

tarcieri · 2025-04-20T22:33:02Z

Aah, right!

tarcieri · 2025-04-21T15:06:32Z

@baloo hmm, unfortunately it isn't possible to add that blanket impl because it conflicts with the blanket impl of AsyncSigner for Signer

Getting back to my original complaint on #1419, that means that the sync and async impls will be inconsistent, which is at the very least somewhat annoying

baloo · 2025-04-21T21:39:15Z

I think that works (see RustCrypto/signatures#945), there are a couple feature flags (downstream) to tweak but otherwise that looks good.

tarcieri · 2025-04-21T21:49:09Z

Okay, let’s go with it despite the inconsistency. I guess we could add macro_rules to do the other delegations which is simpler than custom derive

…)" This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

…)" (#1840) This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

tarcieri · 2025-04-20T21:08:08Z

Adds blanket impls of:

Signer for types which impl PrehashSignature + DigestSignature
Verifier for types which impl PrehashSignature + DigestVerifier

These blanket impls eliminate the need to have a signature_derive crate, which only existed to write the Signer and Verifier impls for this particular case.

Since this is a breaking change, bumps the version to 3.0.0-pre

Adds blanket impls of: - `Signer` for types which impl `PrehashSignature + DigestSignature` - `Verifier` for types which impl `PrehashSignature + DigestVerifier` These blanket impls eliminate the need to have a `signature_derive` crate, which only existed to write the `Signer` and `Verifier` impls for this particular case. Since this is a breaking change, bumps the version to `3.0.0-pre`

tarcieri · 2025-04-20T21:12:58Z

I think we're at the point where we can do a major version bump, and getting rid of signature_derive would be a great reason to do so, IMO.

IIRC this change was originally suggested by @baloo but I can't find where.

We'll need to verify it works against https://github.com/RustCrypto/signatures

baloo · 2025-04-20T22:21:33Z

I think that was for the AsyncSigner? (#1419 (comment))

tarcieri · 2025-04-20T22:33:02Z

Aah, right!

tarcieri · 2025-04-21T15:06:32Z

@baloo hmm, unfortunately it isn't possible to add that blanket impl because it conflicts with the blanket impl of AsyncSigner for Signer

Getting back to my original complaint on #1419, that means that the sync and async impls will be inconsistent, which is at the very least somewhat annoying

baloo · 2025-04-21T21:39:15Z

I think that works (see RustCrypto/signatures#945), there are a couple feature flags (downstream) to tweak but otherwise that looks good.

tarcieri · 2025-04-21T21:49:09Z

Okay, let’s go with it despite the inconsistency. I guess we could add macro_rules to do the other delegations which is simpler than custom derive

…)" This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

…)" (#1840) This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

tarcieri · 2025-04-20T21:08:08Z

Adds blanket impls of:

Signer for types which impl PrehashSignature + DigestSignature
Verifier for types which impl PrehashSignature + DigestVerifier

These blanket impls eliminate the need to have a signature_derive crate, which only existed to write the Signer and Verifier impls for this particular case.

Since this is a breaking change, bumps the version to 3.0.0-pre

Adds blanket impls of: - `Signer` for types which impl `PrehashSignature + DigestSignature` - `Verifier` for types which impl `PrehashSignature + DigestVerifier` These blanket impls eliminate the need to have a `signature_derive` crate, which only existed to write the `Signer` and `Verifier` impls for this particular case. Since this is a breaking change, bumps the version to `3.0.0-pre`

tarcieri · 2025-04-20T21:12:58Z

I think we're at the point where we can do a major version bump, and getting rid of signature_derive would be a great reason to do so, IMO.

IIRC this change was originally suggested by @baloo but I can't find where.

We'll need to verify it works against https://github.com/RustCrypto/signatures

baloo · 2025-04-20T22:21:33Z

I think that was for the AsyncSigner? (#1419 (comment))

tarcieri · 2025-04-20T22:33:02Z

Aah, right!

tarcieri · 2025-04-21T15:06:32Z

@baloo hmm, unfortunately it isn't possible to add that blanket impl because it conflicts with the blanket impl of AsyncSigner for Signer

Getting back to my original complaint on #1419, that means that the sync and async impls will be inconsistent, which is at the very least somewhat annoying

baloo · 2025-04-21T21:39:15Z

I think that works (see RustCrypto/signatures#945), there are a couple feature flags (downstream) to tweak but otherwise that looks good.

tarcieri · 2025-04-21T21:49:09Z

Okay, let’s go with it despite the inconsistency. I guess we could add macro_rules to do the other delegations which is simpler than custom derive

…)" This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

…)" (#1840) This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

tarcieri · 2025-04-20T21:08:08Z

Adds blanket impls of:

Signer for types which impl PrehashSignature + DigestSignature
Verifier for types which impl PrehashSignature + DigestVerifier

These blanket impls eliminate the need to have a signature_derive crate, which only existed to write the Signer and Verifier impls for this particular case.

Since this is a breaking change, bumps the version to 3.0.0-pre

Adds blanket impls of: - `Signer` for types which impl `PrehashSignature + DigestSignature` - `Verifier` for types which impl `PrehashSignature + DigestVerifier` These blanket impls eliminate the need to have a `signature_derive` crate, which only existed to write the `Signer` and `Verifier` impls for this particular case. Since this is a breaking change, bumps the version to `3.0.0-pre`

tarcieri · 2025-04-20T21:12:58Z

I think we're at the point where we can do a major version bump, and getting rid of signature_derive would be a great reason to do so, IMO.

IIRC this change was originally suggested by @baloo but I can't find where.

We'll need to verify it works against https://github.com/RustCrypto/signatures

baloo · 2025-04-20T22:21:33Z

I think that was for the AsyncSigner? (#1419 (comment))

tarcieri · 2025-04-20T22:33:02Z

Aah, right!

tarcieri · 2025-04-21T15:06:32Z

@baloo hmm, unfortunately it isn't possible to add that blanket impl because it conflicts with the blanket impl of AsyncSigner for Signer

Getting back to my original complaint on #1419, that means that the sync and async impls will be inconsistent, which is at the very least somewhat annoying

baloo · 2025-04-21T21:39:15Z

I think that works (see RustCrypto/signatures#945), there are a couple feature flags (downstream) to tweak but otherwise that looks good.

tarcieri · 2025-04-21T21:49:09Z

Okay, let’s go with it despite the inconsistency. I guess we could add macro_rules to do the other delegations which is simpler than custom derive

…)" This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

…)" (#1840) This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

tarcieri · 2025-04-20T21:08:08Z

Adds blanket impls of:

Signer for types which impl PrehashSignature + DigestSignature
Verifier for types which impl PrehashSignature + DigestVerifier

These blanket impls eliminate the need to have a signature_derive crate, which only existed to write the Signer and Verifier impls for this particular case.

Since this is a breaking change, bumps the version to 3.0.0-pre

Adds blanket impls of: - `Signer` for types which impl `PrehashSignature + DigestSignature` - `Verifier` for types which impl `PrehashSignature + DigestVerifier` These blanket impls eliminate the need to have a `signature_derive` crate, which only existed to write the `Signer` and `Verifier` impls for this particular case. Since this is a breaking change, bumps the version to `3.0.0-pre`

tarcieri · 2025-04-20T21:12:58Z

I think we're at the point where we can do a major version bump, and getting rid of signature_derive would be a great reason to do so, IMO.

IIRC this change was originally suggested by @baloo but I can't find where.

We'll need to verify it works against https://github.com/RustCrypto/signatures

baloo · 2025-04-20T22:21:33Z

I think that was for the AsyncSigner? (#1419 (comment))

tarcieri · 2025-04-20T22:33:02Z

Aah, right!

tarcieri · 2025-04-21T15:06:32Z

@baloo hmm, unfortunately it isn't possible to add that blanket impl because it conflicts with the blanket impl of AsyncSigner for Signer

Getting back to my original complaint on #1419, that means that the sync and async impls will be inconsistent, which is at the very least somewhat annoying

baloo · 2025-04-21T21:39:15Z

I think that works (see RustCrypto/signatures#945), there are a couple feature flags (downstream) to tweak but otherwise that looks good.

tarcieri · 2025-04-21T21:49:09Z

Okay, let’s go with it despite the inconsistency. I guess we could add macro_rules to do the other delegations which is simpler than custom derive

…)" This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

…)" (#1840) This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

tarcieri · 2025-04-20T21:08:08Z

Adds blanket impls of:

Signer for types which impl PrehashSignature + DigestSignature
Verifier for types which impl PrehashSignature + DigestVerifier

These blanket impls eliminate the need to have a signature_derive crate, which only existed to write the Signer and Verifier impls for this particular case.

Since this is a breaking change, bumps the version to 3.0.0-pre

Adds blanket impls of: - `Signer` for types which impl `PrehashSignature + DigestSignature` - `Verifier` for types which impl `PrehashSignature + DigestVerifier` These blanket impls eliminate the need to have a `signature_derive` crate, which only existed to write the `Signer` and `Verifier` impls for this particular case. Since this is a breaking change, bumps the version to `3.0.0-pre`

tarcieri · 2025-04-20T21:12:58Z

I think we're at the point where we can do a major version bump, and getting rid of signature_derive would be a great reason to do so, IMO.

IIRC this change was originally suggested by @baloo but I can't find where.

We'll need to verify it works against https://github.com/RustCrypto/signatures

baloo · 2025-04-20T22:21:33Z

I think that was for the AsyncSigner? (#1419 (comment))

tarcieri · 2025-04-20T22:33:02Z

Aah, right!

tarcieri · 2025-04-21T15:06:32Z

@baloo hmm, unfortunately it isn't possible to add that blanket impl because it conflicts with the blanket impl of AsyncSigner for Signer

Getting back to my original complaint on #1419, that means that the sync and async impls will be inconsistent, which is at the very least somewhat annoying

baloo · 2025-04-21T21:39:15Z

I think that works (see RustCrypto/signatures#945), there are a couple feature flags (downstream) to tweak but otherwise that looks good.

tarcieri · 2025-04-21T21:49:09Z

Okay, let’s go with it despite the inconsistency. I guess we could add macro_rules to do the other delegations which is simpler than custom derive

…)" This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

…)" (#1840) This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

tarcieri · 2025-04-20T21:08:08Z

Adds blanket impls of:

Signer for types which impl PrehashSignature + DigestSignature
Verifier for types which impl PrehashSignature + DigestVerifier

These blanket impls eliminate the need to have a signature_derive crate, which only existed to write the Signer and Verifier impls for this particular case.

Since this is a breaking change, bumps the version to 3.0.0-pre

Adds blanket impls of: - `Signer` for types which impl `PrehashSignature + DigestSignature` - `Verifier` for types which impl `PrehashSignature + DigestVerifier` These blanket impls eliminate the need to have a `signature_derive` crate, which only existed to write the `Signer` and `Verifier` impls for this particular case. Since this is a breaking change, bumps the version to `3.0.0-pre`

tarcieri · 2025-04-20T21:12:58Z

I think we're at the point where we can do a major version bump, and getting rid of signature_derive would be a great reason to do so, IMO.

IIRC this change was originally suggested by @baloo but I can't find where.

We'll need to verify it works against https://github.com/RustCrypto/signatures

baloo · 2025-04-20T22:21:33Z

I think that was for the AsyncSigner? (#1419 (comment))

tarcieri · 2025-04-20T22:33:02Z

Aah, right!

tarcieri · 2025-04-21T15:06:32Z

@baloo hmm, unfortunately it isn't possible to add that blanket impl because it conflicts with the blanket impl of AsyncSigner for Signer

Getting back to my original complaint on #1419, that means that the sync and async impls will be inconsistent, which is at the very least somewhat annoying

baloo · 2025-04-21T21:39:15Z

I think that works (see RustCrypto/signatures#945), there are a couple feature flags (downstream) to tweak but otherwise that looks good.

tarcieri · 2025-04-21T21:49:09Z

Okay, let’s go with it despite the inconsistency. I guess we could add macro_rules to do the other delegations which is simpler than custom derive

…)" This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

…)" (#1840) This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes#1831

tarcieri requested review from baloo and newpavlov April 20, 2025 21:08

tarcieri force-pushed the signature/blanket-signature-for-digestsignature-impl branch from 0395a6b to 73f2019Compare April 20, 2025 21:09

newpavlov approved these changes Apr 21, 2025
View reviewed changes

Blanket impl RandomizedSigner for RandomizedDigestSigner
8ee15a1

baloo mentioned this pull request Apr 21, 2025
ecdsa: use blanket impl from signature 3 RustCrypto/signatures#945
Merged

tarcieri merged commit bf47748 into masterApr 21, 2025

tarcieri deleted the signature/blanket-signature-for-digestsignature-impl branch April 21, 2025 21:49

tarcieri mentioned this pull request Apr 24, 2025
signature v3: type inference regression #1831
Closed

tarcieri requested review from baloo and newpavlov April 20, 2025 21:08

tarcieri force-pushed the signature/blanket-signature-for-digestsignature-impl branch from 0395a6b to 73f2019Compare April 20, 2025 21:09

newpavlov approved these changes Apr 21, 2025
View reviewed changes

Blanket impl RandomizedSigner for RandomizedDigestSigner
8ee15a1

baloo mentioned this pull request Apr 21, 2025
ecdsa: use blanket impl from signature 3 RustCrypto/signatures#945
Merged

tarcieri merged commit bf47748 into masterApr 21, 2025

tarcieri deleted the signature/blanket-signature-for-digestsignature-impl branch April 21, 2025 21:49

tarcieri mentioned this pull request Apr 24, 2025
signature v3: type inference regression #1831
Closed

tarcieri requested review from baloo and newpavlov April 20, 2025 21:08

tarcieri force-pushed the signature/blanket-signature-for-digestsignature-impl branch from 0395a6b to 73f2019Compare April 20, 2025 21:09

newpavlov approved these changes Apr 21, 2025
View reviewed changes

Blanket impl RandomizedSigner for RandomizedDigestSigner
8ee15a1

baloo mentioned this pull request Apr 21, 2025
ecdsa: use blanket impl from signature 3 RustCrypto/signatures#945
Merged

tarcieri merged commit bf47748 into masterApr 21, 2025

tarcieri deleted the signature/blanket-signature-for-digestsignature-impl branch April 21, 2025 21:49

tarcieri mentioned this pull request Apr 24, 2025
signature v3: type inference regression #1831
Closed

tarcieri requested review from baloo and newpavlov April 20, 2025 21:08

tarcieri force-pushed the signature/blanket-signature-for-digestsignature-impl branch from 0395a6b to 73f2019Compare April 20, 2025 21:09

newpavlov approved these changes Apr 21, 2025
View reviewed changes

Blanket impl RandomizedSigner for RandomizedDigestSigner
8ee15a1

baloo mentioned this pull request Apr 21, 2025
ecdsa: use blanket impl from signature 3 RustCrypto/signatures#945
Merged

tarcieri merged commit bf47748 into masterApr 21, 2025

tarcieri deleted the signature/blanket-signature-for-digestsignature-impl branch April 21, 2025 21:49

tarcieri mentioned this pull request Apr 24, 2025
signature v3: type inference regression #1831
Closed

tarcieri requested review from baloo and newpavlov April 20, 2025 21:08

tarcieri force-pushed the signature/blanket-signature-for-digestsignature-impl branch from 0395a6b to 73f2019Compare April 20, 2025 21:09

newpavlov approved these changes Apr 21, 2025
View reviewed changes

Blanket impl RandomizedSigner for RandomizedDigestSigner
8ee15a1

baloo mentioned this pull request Apr 21, 2025
ecdsa: use blanket impl from signature 3 RustCrypto/signatures#945
Merged

tarcieri merged commit bf47748 into masterApr 21, 2025

tarcieri deleted the signature/blanket-signature-for-digestsignature-impl branch April 21, 2025 21:49

tarcieri mentioned this pull request Apr 24, 2025
signature v3: type inference regression #1831
Closed

tarcieri requested review from baloo and newpavlov April 20, 2025 21:08

tarcieri force-pushed the signature/blanket-signature-for-digestsignature-impl branch from 0395a6b to 73f2019Compare April 20, 2025 21:09

newpavlov approved these changes Apr 21, 2025
View reviewed changes

Blanket impl RandomizedSigner for RandomizedDigestSigner
8ee15a1

baloo mentioned this pull request Apr 21, 2025
ecdsa: use blanket impl from signature 3 RustCrypto/signatures#945
Merged

tarcieri merged commit bf47748 into masterApr 21, 2025

tarcieri deleted the signature/blanket-signature-for-digestsignature-impl branch April 21, 2025 21:49

tarcieri mentioned this pull request Apr 24, 2025
signature v3: type inference regression #1831
Closed

tarcieri requested review from baloo and newpavlov April 20, 2025 21:08

tarcieri force-pushed the signature/blanket-signature-for-digestsignature-impl branch from 0395a6b to 73f2019Compare April 20, 2025 21:09

newpavlov approved these changes Apr 21, 2025
View reviewed changes

Blanket impl RandomizedSigner for RandomizedDigestSigner
8ee15a1

baloo mentioned this pull request Apr 21, 2025
ecdsa: use blanket impl from signature 3 RustCrypto/signatures#945
Merged

tarcieri merged commit bf47748 into masterApr 21, 2025

tarcieri deleted the signature/blanket-signature-for-digestsignature-impl branch April 21, 2025 21:49

tarcieri mentioned this pull request Apr 24, 2025
signature v3: type inference regression #1831
Closed

Uh oh!

Conversation

tarcieri commented Apr 20, 2025

Uh oh!

tarcieri commented Apr 20, 2025

Uh oh!

baloo commented Apr 20, 2025

Uh oh!

tarcieri commented Apr 20, 2025

Uh oh!

tarcieri commented Apr 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

baloo commented Apr 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarcieri commented Apr 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tarcieri commented Apr 20, 2025

Uh oh!

tarcieri commented Apr 20, 2025

Uh oh!

baloo commented Apr 20, 2025

Uh oh!

tarcieri commented Apr 20, 2025

Uh oh!

tarcieri commented Apr 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

baloo commented Apr 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarcieri commented Apr 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tarcieri commented Apr 20, 2025

Uh oh!

tarcieri commented Apr 20, 2025

Uh oh!

baloo commented Apr 20, 2025

Uh oh!

tarcieri commented Apr 20, 2025

Uh oh!

tarcieri commented Apr 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

baloo commented Apr 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarcieri commented Apr 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tarcieri commented Apr 21, 2025•
edited
Loading

baloo commented Apr 21, 2025•
edited
Loading

tarcieri commented Apr 21, 2025•
edited
Loading

baloo commented Apr 21, 2025•
edited
Loading

tarcieri commented Apr 21, 2025•
edited
Loading

baloo commented Apr 21, 2025•
edited
Loading

tarcieri commented Apr 21, 2025•
edited
Loading

baloo commented Apr 21, 2025•
edited
Loading

tarcieri commented Apr 21, 2025•
edited
Loading

baloo commented Apr 21, 2025•
edited
Loading