Uh oh!
There was an error while loading. Please reload this page.
digest: improve implementations of the SerializableState trait - #1953
Merged
Conversation
SerializableState traitUh oh!
There was an error while loading. Please reload this page.
Merged
tarcieri added a commit
that referenced
this pull request
Feb 13, 2026
## Added - `CustomizedInit` trait (#1334) - `SerializableState` support (#1369) - `DynDigestWithOid` wrapper trait (#1390) - `VariableOutputCoreCustomized` trait (#1787, #2043) - `buffer_fixed`, `buffer_ct_variable`, `buffer_rt_variable`, and `buffer_xof` macros (#1799) - `XofFixedWrapper` (#1815) - `CollisionResistance` trait (#1820) - `CoreProxy::compose/decompose` methods (#1898) - `EagerHash` trait (#2014) ## Changed - Replaced `generic-array` with `hybrid-array` (#1358) - `crypto-common` dependency bumped to v0.2 (#1173) - Edition changed to 2024 and MSRV bumped to 1.85 (#1759) - Bump `const-oid` dependency to v0.10 (#1772) - `digest::core_api` renamed to `digest::block_api` (#1799) - `CtVariableCoreWrapper` renamed to `CtOutWrapper` (#1799) - Removed the OID type parameter from `CtOutWrapper` (#1799) - Implementations of the `SerializableState` trait (#1953) - `new_test!` and `new_mac_test!` macros (#1958) - Bump `block-buffer` to v0.11 (#2082) - Re-export of `crypto-common` moved to `digest::common` (#2237) - Bump `crypto-common` to v0.2 (#2276) - Replace `subtle` with `ctutils` (#2301) ## Removed - `Mac::{new, new_from_slice, generate_key}` methods (#1173) - `CoreWrapper`, `RtVariableCoreWrapper`, and `XofReaderCoreWrapper` types (#1799) - `io::Write/Read` implementations in favor of the `digest_io::IoWrapper` type (#1809) - `VariableOutput` trait (#2043) - Implementation of `subtle::ConstantTimeEq` for `CtOutput`. Note that implementation of `PartialEq`/`Eq` trait is still const time. (#2292)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were using block size + 1 byte to serialize eager block buffers while block size is sufficient. It resulted in odd serialization state sizes. The
SerializableStateimpl also a bit convoluted.The new implementation results in more efficient serialization and more straightforward code. The main drawback is that it inevitably involves a breaking change in the serialization format.
Depends on RustCrypto/utils#1200.