Uh oh!
There was an error while loading. Please reload this page.
digest: add TryCustomizedInit trait - #2395
Merged
Merged
Conversation
newpavlov
commented
Apr 27, 2026
| fn try_new_customized(customization: &[u8]) -> Result<Self, Self::Error>; | ||
| } | ||
| impl<T: CustomizedInit> TryCustomizedInit for T { |
MemberAuthor
There was a problem hiding this comment.
Usually I would prefer to do this instead:
pubtraitTryCustomizedInit:Sized{typeError;fntry_new_customized(customization:&[u8]) -> Result<Self,Self::Error>;}pubtraitCustomizedInit:TryCustomizedInit<Error = Infallible>{fnnew_customized(customization:&[u8]) -> Self{letOk(res) = self.try_new_customized(customization);
res
}}impl<T:TryCustomizedInit<Error = Infallible>CustomizedInitforT{}But it would be a breaking change, so it has to be deferred until a future breaking release.
tarcieri
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some algorithms (e.g. Ascon-CXOF128 and
bash-prg-hash) place restrictions on customization strings, so with the current version ofdigestwe either have to panic on invalid strings or use inherent methods. This PR amends this by introducing a fallible variant ofCustomizedInitwith the blanket impl to act as a bridge between the traits.