Uh oh!
There was an error while loading. Please reload this page.
elliptic-curve: basic OID support - #240
Merged
Merged
Conversation
tarcieri
commented
Jul 31, 2020
MemberAuthor
I took a look at the |
Adds a (very simple, const-and-no_std-friendly) `ObjectIdentifier` type and an `Identifier` trait for attaching an OID to a curve. No validation of the nodes is presently performed (and since it's impl'd as a `const fn`, it'd require a MSRV bump to do so). Also requires the OID be specified as an array literal: no parsing is supported for either string or binary-encoded OIDs. Only string serialization is supported for now. A `no_std`-friendly binary serializer will be somewhat tricky.
tarcieriforce-pushed
the
elliptic-curve/oid
branch
from
July 31, 2020 02:26
d5aa20f to
f52c062Comparenewpavlov
commented
Jul 31, 2020
Member
Ideally we should specify OID for other algorithms as well, so if |
tarcieri
commented
Jul 31, 2020
MemberAuthor
Yeah, good point, we could potentially split this out into a separate crate somewhere, although I can't think of a good name. |
Member
|
tarcieri
commented
Jul 31, 2020
MemberAuthor
|
tarcieri added a commit
to RustCrypto/utils
that referenced
this pull request
Aug 4, 2020
This is an extraction of the const OID support added to the `elliptic-curve` crate in RustCrypto/traits#240.
tarcieri added a commit
to RustCrypto/utils
that referenced
this pull request
Aug 4, 2020
This is an extraction of the const OID support added to the `elliptic-curve` crate in RustCrypto/traits#240.
Merged
dns2utf8 pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
Changes the B64 decoder to return a `Result`, returning an error if the input is invalid instead of panicking. FixesRustCrypto#240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a (very simple, const-and-no_std-friendly)
ObjectIdentifiertype and anIdentifiertrait for attaching an OID to a curve.No validation of the nodes is presently performed (and since it's impl'd as a
const fn, it'd require a MSRV bump to do so). Also requires the OID be specified as an array literal: no parsing is supported for either string or binary-encoded OIDs.Only string serialization is supported for now (via
Display). Ano_std-friendly binary serializer will be somewhat tricky.