Skip to content

Add crypto-common crate - #537

Merged
newpavlov merged 23 commits into
masterfrom
common
Feb 26, 2021
Merged

Add crypto-common crate#537
newpavlov merged 23 commits into
masterfrom
common

Conversation

@newpavlov

@newpavlovnewpavlov commented Feb 11, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Closes#536
Closes#259
Closes#503

tarcieri
tarcieri reviewed Feb 11, 2021
View reviewed changes
Comment threadcrypto-common/src/lib.rs
}

/// Trait for types which can be created from key.
pub trait FromKey: Sized {

@tarcieritarcieriFeb 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@newpavlov

newpavlov commented Feb 11, 2021

Copy link
Copy Markdown
MemberAuthor

Argh, because FromKeyNonce is now defined in another crate we can not write the following impl in cipher:

impl<C>FromKeyNonceforCwhereC:FromBlockCipherNonce,C::BlockCipher:FromKey,{ .. }

I hope such implementations (when generic type is bound by a trait defined in the current crate) will be allowed one day. We could use it for generic implementation of io::Write in terms of Update as well. Until then the easiest solution probably will be to implement FromKeyNonce in implementation crates directly...

@tarcieri

tarcieri commented Feb 11, 2021

Copy link
Copy Markdown
Member

@newpavlov failing everything else there's always macros

@newpavlov

newpavlov commented Feb 11, 2021

Copy link
Copy Markdown
MemberAuthor

Well, on a plus side with the macro approach we do not need the FromBlockCipher trait anymore...

It looks like this PR is more or less ready, but before merging I would like to try migrate the downstream crates first.

@newpavlov
newpavlov marked this pull request as ready for review February 11, 2021 04:12
@newpavlov
newpavlov merged commit 77e0fc2 into masterFeb 26, 2021
@newpavlov
newpavlov deleted the common branch February 26, 2021 12:47
@daviddrysdaledaviddrysdale mentioned this pull request Feb 28, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crate for common traits? digest: compatibility with lazy buffers aead: add FromBlockCipher trait?

2 participants

@newpavlov@tarcieri