Uh oh!
There was an error while loading. Please reload this page.
Defined the SignerMut trait - #734
Merged
Merged
Conversation
tarcieri
commented
Sep 4, 2021
Member
Our other stateful types are named |
rozbb
commented
Sep 5, 2021
ContributorAuthor
Fixed |
tarcieri
approved these changes
Sep 5, 2021
tarcieri
left a comment
Member
There was a problem hiding this comment.
This looks fine to me.
Our other *Mut traits also have blanket impls of the stateful *Mut trait for types which impl the stateless trait, which might also make sense here.
tarcieri
commented
Sep 5, 2021
Member
Thank you! |
rozbb
commented
Sep 5, 2021
ContributorAuthor
Sorry one more thing: I just pushed another commit to this branch. It wasn't 100% clear to me that my blanket impl wasn't trivially gonna loop forever. Feel free to copy into the tree |
tarcieri
commented
Sep 5, 2021
Member
Oh huh, can you make sure one way or another and open another PR if it's broken? |
rozbb
commented
Sep 5, 2021
via email
ContributorAuthor
Will do … El sep. 5, 2021, a la(s) 10:41, Tony Arcieri ***@***.***> escribió:
Oh huh, can you make sure one way or another and open another PR if it's broken?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe. |
rozbb
commented
Sep 6, 2021
via email
ContributorAuthor
Update: it's not broken. I still don't love how it looks (under the hood, the steps it takes are x := &&mut self, y := &**x, y.sign(...)), but you can decide if it's worth changing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per our discussion on the RCIG Zulip, there seems to be a need for a stateful version of the
Signertrait. This lets us support "Key Evolving Signature Schemes" such as XMSS.One thing that is unclear so far is whether we also want to do stateful versions of
DigestSigner,RandomizedSigner, andAsyncSigner. I think the latter two won't be an issue for now, since XMSS is a deterministic scheme, and HSMs do not support XMSS.