Skip to content

block-padding: remove PadType and add pad_detached method - #1225

Merged
newpavlov merged 11 commits into
masterfrom
block-padding/rm_pad_type
Sep 26, 2025
Merged

block-padding: remove PadType and add pad_detached method#1225
newpavlov merged 11 commits into
masterfrom
block-padding/rm_pad_type

Conversation

@newpavlov

@newpavlovnewpavlov commented Sep 23, 2025•
edited
Loading

Copy link
Copy Markdown
Member

PadType is used only in the default implementation of unpad_blocks and in inout. To handle the latter case Padding::pad_detached is added.

@newpavlov

newpavlov commented Sep 23, 2025

Copy link
Copy Markdown
MemberAuthor

PadType is used in inout, I will look into whether it's necessary.

@newpavlovnewpavlov changed the title block-padding: remove PadTypeblock-padding: remove PadType and add pad_detached methodSep 26, 2025
@newpavlov
newpavlov merged commit 1b849b1 into masterSep 26, 2025
100 checks passed
@newpavlov
newpavlov deleted the block-padding/rm_pad_type branch September 26, 2025 07:44
@newpavlovnewpavlov mentioned this pull request Sep 26, 2025
Merged
@newpavlovnewpavlov mentioned this pull request Oct 6, 2025
Merged
newpavlov added a commit that referenced this pull request Oct 6, 2025
@newpavlov
Release block-padding v0.4.0 (#1233)
e0020c5
### Added
- `Padding::pad_detached` method ([#1225])
### Changed
- Migrated from `generic-array` to `hybrid-array` ([#944])
- Edition changed to 2024 and MSRV bumped to 1.85 ([#1149])
- Merged `RawPadding` and `Padding` traits ([#1217])
- Renamed `UnpadError` to `Error` ([#1225])
### Removed
- `Block` type alias ([#1217])
- `PadType` enum and associated type on the `Padding` trait ([#1225])
[#944]: #944
[#1149]: #1149
[#1217]: #1217
[#1225]: #1225
newpavlov added a commit that referenced this pull request Oct 6, 2025
@newpavlov
block-padding: fixpad_detachedforNoPaddingandZeroPadding(#…
9118661
…1227)
In #1225 I forgot to overwrite the default implementation of
`pad_detached` for `NoPadding` and `ZeroPadding`.
Additionally, this PR adds `PaddedData` enum to make return type of
`pad_detached` less complex.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@newpavlov@tarcieri