Add multiple database support - #23
Merged
Merged
Conversation
RyanConnell
approved these changes
Feb 27, 2021
| "database/sql" | ||
| "fmt" | ||
| _ "github.com/go-sql-driver/mysql" |
There was a problem hiding this comment.
You need to update go.mod for this:
database/database.go:8:2: no required module provides package github.com/mattn/go-sqlite3; to add it:
go get github.com/mattn/go-sqlite3
CollaboratorAuthor
There was a problem hiding this comment.
This was accidentally merged in #21, I just rebased the branch so it includes the changes.
In the future this will allow to use other databases.
VoyTechnologyforce-pushed
the
multi-database
branch
from
February 27, 2021 20:58
b7070d1 to
f2c82a0CompareVoyTechnology added a commit
to VoyTechnology/ryanconnell-tracker
that referenced
this pull request
Mar 6, 2021
In the future this will allow to use other databases.
VoyTechnology added a commit
to VoyTechnology/ryanconnell-tracker
that referenced
this pull request
Mar 6, 2021
In the future this will allow to use other databases.
VoyTechnology added a commit
to VoyTechnology/ryanconnell-tracker
that referenced
this pull request
Mar 6, 2021
In the future this will allow to use other databases.
RyanConnell pushed a commit
that referenced
this pull request
Mar 14, 2021
* Add multiple database support (#23) In the future this will allow to use other databases. * Add user database interface This change add an interface which can be implemented by various systems to store the data. This means that we won't have to always rely on SQL. It is up to implementation to return the correct information. * Removed the shrug Ryan didn't want the shrug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the future this will allow to use other databases.