Uh oh!
There was an error while loading. Please reload this page.
feature: async support - #225
Merged
Merged
Conversation
rewrite tests using pytest-aiohttp
add pytest-aiohttp remove pytest-asyncio remove aiohttp
phanak-sap
marked this pull request as draft
August 11, 2022 14:26
Codecov Report
@@ Coverage Diff @@## master #225 +/- ##
==========================================
- Coverage 92.90% 92.34% -0.57%
==========================================
Files 6 6 Lines 2792 2847 +55 ==========================================
+ Hits 2594 2629 +35 - Misses 198 218 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Switch "from unittest.mock import patch" to pytest.warns. Maybe it is the reason why aiohttp and python 3.7 does not go together on CI builds, and if it is not a root cause, it looks cleaner anyway. Stick to one testing framework stuff.
…into async-feature
Switch "from unittest.mock import patch" to pytest.warns.
phanak-sap
marked this pull request as ready for review
August 19, 2022 08:52
7 tasks
7 tasks
7 tasks
jfilak
reviewed
Sep 5, 2022
| url = url.rstrip('/') + '/' | ||
| if metadata is None: | ||
| metadata = await _async_fetch_metadata(connection, url, logger) |
Contributor
There was a problem hiding this comment.
Don't you kill all async here? What's the difference between the regular client?
ContributorAuthor
There was a problem hiding this comment.
no, await (asynchronous wait) is calling the asynchronous _async_fetch_metadata function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically the code from PR #210 (that one merged to feature-branch), by @Albo90, with more tests.
This mess will be squashed to one "feature" commit to master.