Skip to content

Add CRT-PMT flash classification to TPC-PMT flash-matching producer - #613

Open
rtriozzi wants to merge 2 commits into
developfrom
feature/rtriozzi_flashClassification_FM
Open

Add CRT-PMT flash classification to TPC-PMT flash-matching producer#613
rtriozzi wants to merge 2 commits into
developfrom
feature/rtriozzi_flashClassification_FM

Conversation

@rtriozzi

Copy link
Copy Markdown
Contributor

This PR (based off of v10_04_04) adds the flash classification from the CRT-PMT matching information to the best-matched flash in the TPC-PMT barycenter flash-matching producer.


Associated PRs


Review

Tagging for review @francescopoppi and @PetrilloAtWork as the CRT & light gurus. Thanks!


Checklist

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • [] Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • [] Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@rtriozzirtriozzi self-assigned this Dec 4, 2025
@rtriozzirtriozzi added the enhancement New feature or request label Dec 4, 2025
@rtriozzirtriozzi changed the title introduced flashClassification at the slc level via barycenterFMAdd CRT-PMT flash classification to TPC-PMT flash-matching producerDec 4, 2025
@kjplowskjplows moved this to Open pull requests in SBN software developmentDec 14, 2025

@PetrilloAtWorkPetrilloAtWork left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (although if one of my suggestions in another PR is received, an explicit conversion to int will be needed here).

@kjplowskjplows moved this from Open pull requests to Partially reviewed in SBN software developmentJan 15, 2026
@kjplows

Copy link
Copy Markdown
Contributor

Just bumping this -- @francescopoppi does this look good to you? Thanks!

@kjplowskjplows moved this from Todo to In Progress in PR archaeologyFeb 11, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

Status: In Progress
Status: Partially reviewed

Development

Successfully merging this pull request may close these issues.

3 participants

@rtriozzi@kjplows@PetrilloAtWork