Skip to content

Fix cmake warnings - #651

Merged
hgreenlee merged 11 commits into
SBNSoftware:developfrom
hgreenlee:greenlee_fix_cmake
Jul 6, 2026
Merged

Fix cmake warnings#651
hgreenlee merged 11 commits into
SBNSoftware:developfrom
hgreenlee:greenlee_fix_cmake

Conversation

@hgreenlee

@hgreenleehgreenlee commented May 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fix cmake warnings. Mainly one definition rule violations, but some others also.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?

Companion PR:
SBNSoftware/sbndcode#938

@hgreenleehgreenlee added the bugfix Addresses one or more bugs label May 8, 2026
PetrilloAtWork
PetrilloAtWork reviewed Jul 2, 2026
View reviewed changes

@PetrilloAtWorkPetrilloAtWork left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of file name strings left to change, and a question about one change.
Plus, I was told off-line that there is one more change pending.

Comment threadsbncode/Metadata/FileCatalogMetadataSBN.cc Outdated
Comment threadsbncode/Metadata/MetadataSBN.cc Outdated
Comment threadups/product_deps
Comment threadsbncode/EventGenerator/WireModGen/CMakeLists.txt
@hgreenlee
Add interface library for PDMapAlg.
e21a3c0
Remove unnecessary include dependency in PDMapAlg.h.
@hgreenleehgreenlee mentioned this pull request Jul 2, 2026
Merged
7 tasks
@hgreenlee

hgreenlee commented Jul 2, 2026

Copy link
Copy Markdown
ContributorAuthor

Added interface library for tool PDMapAlg.

Made companion PR SBNSoftware/sbndcode#938

PetrilloAtWork
PetrilloAtWork approved these changes Jul 2, 2026
View reviewed changes

@PetrilloAtWorkPetrilloAtWork left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me (not tested though).

@hgreenlee
hgreenlee merged commit a097a22 into SBNSoftware:developJul 6, 2026
@hgreenleehgreenlee mentioned this pull request Jul 15, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PetrilloAtWorkPetrilloAtWorkPetrilloAtWork approved these changes

Assignees

No one assigned

Labels

bugfixAddresses one or more bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hgreenlee@PetrilloAtWork