Uh oh!
There was an error while loading. Please reload this page.
Feature/prod fom grabber - #652
Merged
Merged
Conversation
Updated BNBSpillInfo creation to include additional parameters and set epsilon values for new BeamFolder instances.
nathanielerowe
marked this pull request as ready for review
May 22, 2026 15:15
nathanielerowe
commented
May 22, 2026
ContributorAuthor
No additional changes needed for cafs or data product changes. |
gputnam
approved these changes
May 28, 2026
justinjmueller
approved these changes
May 29, 2026
nathanielerowe
commented
May 30, 2026
ContributorAuthor
Now requires SBNSoftware/sbnanaobj#190 and SBNSoftware/sbnobj#172 |
nathanielerowe
commented
Jun 1, 2026
ContributorAuthor
No longer requires SBNSoftware/sbnanaobj#190 but still requires SBNSoftware/sbnobj#172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR for backporting some ICARUS FOM features from develop to prod. Will require some additional changes to the BNBSpillInfo data product. (PR pending)