Inherit genie config from genie_beam_settings.fcl in sbncode

[marcodeltutto]

Description

sbncode PR SBNSoftware/sbncode#492 introduces a common genie settings file to be used across SBN. With this PR, SBND inherits the GENIE configuration from it.

Fixes#588.

Running fhicl-dump on prodgenie_corsika_proton_rockbox_sbnd.fcl gives the following differences:

New	Original	Comment
BeamCenter: [0,0,0]	BeamCenter: [-1400, -350, 0]	Good to change, used if we had a histogram-based flux
N/A	BeamRadius: 3	Good to change, used if we had a histogram-based flux
DefinedVtxHistRange: false	DefinedVtxHistRange: true	Good to change, used if we had a histogram-based flux
N/A	EventsPerSpill: 0	Same as 0, OK
GHepPrintLevel: -1	N/A	OK, -1 is no print
N/A	MonoEnergy: 2	OK, we should not set options for FluxType = "mono"
SpillTimeConfig: "\n evgb::EvtTimeFNALBeam booster\n nperbatch 84\n nfilled 81\n intensity 1.0\n dtbucket 18.936\n sigma 1.308\n global 0.0\n "	SpillTimeConfig: "evgb::EvtTimeFNALBeam booster, dtbucket=18.936, sigma=1.308"	OK, as nperbatch 84 nfilled 81 intensity 1.0 are defaults
N/A	RandomTimeOffset: 10000	OK
N/A	SurroundingMass: 0	OK, we shouldn't set this, it's for fluxes that don't know pot normalization
VtxPosHistRange: []	VtxPosHistRange: [-210, 210, -210, 210, 10, 510]	Good to change, used if we had a histogram-based flux

Checklist

• Added at least 1 label from available labels.
• Assigned at least 1 reviewer under Reviewers,
• Assigned all contributers including yourself under Assignees
• Linked any relevant issues under Developement
• Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer. No
• Does this affect the standard workflow? Yes

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

[bear-is-asleep]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[marcodeltutto]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[marcodeltutto]

I think the ref files may need to be re-generated again as it's picking up changes in older PRs. In any case, the changes on the GENIE config shown in the fcl checks are expected.

[bear-is-asleep]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[marcodeltutto]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[marcodeltutto]

Thanks @bear-is-asleep, I was actually able to spot one missing line, which I fixed the last commit. I think the CI output looks as expected.

There is a difference in masked channels in detsim output that is not related to this PR, I also see it in other PRs.

[bear-is-asleep]

Approved