sbndcode/OpDetSim: link sbndPDMapAlg_tool to sbncode::OpDet_PDMapAlg link library not sbncode::OpDet_PDMapAlgSimple_tool.

[gartung]

sbndcode/OpDetSim: link sbndPDMapAlg_tool to sbncode::OpDet_PDMapAlg link library not sbncode::OpDet_PDMapAlgSimple_tool. This fixes a cetmodules error from linking a tool library to another tool library.

Resubmit of #943 accidentally closed by force push.

Description

This fixes the cetmodules error from linking a tool library to another tool library found when building with spack mpd

CMake Error at /scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/CetProcessLiblist.cmake:68 (message):
target sbndcode_OpDetSim_sbndPDMapAlg_tool cannot link to target
sbncode::OpDet_PDMapAlgSimple_tool of CMake type "MODULE_LIBRARY".
Separate implementation from plugin registration code (e.g. X.cc vs
X_<plugin-suffix>.cc) (strongly recommended), specify PUBLIC dependencies
to basic_plugin() (temporary solution only), or set sbndcode_MODULE_PLUGINS
to FALSE (not recommended)
Call Stack (most recent call first):
/scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/CetProcessLiblist.cmake:24 (_cet_convert_target_arg)
/scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/CetProcessLiblist.cmake:12 (cet_convert_target_args)
/scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/CetMakeLibrary.cmake:295 (cet_process_liblist)
/scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/BasicPlugin.cmake:312 (cet_make_library)
/scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/compat/art/art::tool.cmake:35 (basic_plugin)
/scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/BasicPlugin.cmake:373 (art::tool)
/scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/BasicPlugin.cmake:373 (cmake_language)
sbndcode/sbndcode/OpDetSim/CMakeLists.txt:2 (cet_build_plugin)
CMake Error at /scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/CetMakeLibrary.cmake:456 (target_link_libraries):
Target "sbncode::OpDet_PDMapAlgSimple_tool" of type MODULE_LIBRARY may not
be linked into another target. One may link only to INTERFACE, OBJECT,
STATIC or SHARED libraries, or to executables with the ENABLE_EXPORTS
property set.
Call Stack (most recent call first):
/scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/BasicPlugin.cmake:312 (cet_make_library)
/scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/compat/art/art::tool.cmake:35 (basic_plugin)
/scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/BasicPlugin.cmake:373 (art::tool)
/scratch/gartung/devtest/mpddev/local/.spack-env/view/Modules/BasicPlugin.cmake:373 (cmake_language)
sbndcode/sbndcode/OpDetSim/CMakeLists.txt:2 (cet_build_plugin)

Relevant PR links (optional)

Can be tested with or without SBNSoftware/sbncode#662

[gartung]

@aantonakis can this be merged?

[gartung]

trigger build #945SBNSoftware/sbncode#662 LArSoft/lar*@LARSOFT_SUITE_v10_22_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@develop

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Succeeded with warning at phase build on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

[aantonakis]

Hi @gartung , sorry for the late response on this. Can you check if this PR is still necessary. When cutting the latest integration releases of sbndcode and sbncode (now at v10_21_02), this problem may have been fixed by Herbert Greenlee's PRs: see sbndcode merged PR#938. I needed to update sbndcode to merge Herbert's PR that came first and this has potentially addressed the issue.

[gartung]

Fixed in #938