Skip to content
This repository was archived by the owner on Dec 4, 2021. It is now read-only.

Add RPC Client API - #44

Merged
evanugarte merged 1 commit into
masterfrom
node-server
Jun 20, 2020
Merged

Add RPC Client API#44
evanugarte merged 1 commit into
masterfrom
node-server

Conversation

@evanugarte

@evanugarteevanugarte commented Jun 10, 2020

Copy link
Copy Markdown
Collaborator

Resolves#40

This pr adds a standalone Express server to handle requests to our printing, LED sign and 3D printing Services.

Diagram

hi
This PR adds the right box.

What about API tests?

I moved the corresponding API tests from Core-v4 to here.

@evanugarteevanugarte self-assigned this Jun 10, 2020
@evanugarteevanugarte added the enhancement New feature or request label Jun 10, 2020
@evanugarte
evanugarteforce-pushed the node-server branch 2 times, most recently from fb33248 to f8291bdCompareJune 20, 2020 00:38

@law-nguyenlaw-nguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to put an empty line at the ends of your files!!!

Comment threadclient/api/routes.js
@evanugarte
evanugarteforce-pushed the node-server branch 2 times, most recently from d9ebf17 to 76f142bCompareJune 20, 2020 00:58

@aashravaashrav left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@IsitaBIsitaB left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@evanugarte
evanugarte merged commit dca8502 into masterJun 20, 2020
@evanugarte
evanugarte deleted the node-server branch June 20, 2020 16:39
Programmerryoki pushed a commit that referenced this pull request Feb 18, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HTTP Endpoints to Client Functions

4 participants

@evanugarte@aashrav@law-nguyen@IsitaB