Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Dec 4, 2021. It is now read-only.
AddMessageToQueue and ClearMessageQueue - #47
Merged
Merged
Conversation
evanugarte
suggested changes
Jun 11, 2020
evanugarte
left a comment
Collaborator
There was a problem hiding this comment.
Nice!! You will need to modify some existing client and server code to finish this change.
See links below:
- defining
healthCheckRequestinclient/ledsign/led_sign_client.js:19 - Defining
responseinserver/led_sign/led_sign_server.py:43
| message LedSignRequest{ | ||
| string officer_name = 1; | ||
| } | ||
| // message LedSignRequest{ |
Collaborator
There was a problem hiding this comment.
remove commented out protos
Uh oh!
There was an error while loading. Please reload this page.
jerrylee17
suggested changes
Jun 11, 2020
jerrylee17
left a comment
Member
There was a problem hiding this comment.
Delete the .exe file. Not used anywhere
law-nguyen
approved these changes
Jun 11, 2020
law-nguyen
left a comment
Collaborator
There was a problem hiding this comment.
Good job! Fix what Jerry and Evan pointed out.
evanugarte
approved these changes
Jun 13, 2020
jerrylee17
approved these changes
Jun 18, 2020
Programmerryoki pushed a commit
that referenced
this pull request
Feb 18, 2021
* Added AddMessageToQueue and ClearMessageQueue RPC and regenerated python files * Removed exe file and fixed client and server files * Fixed merge conflict Co-authored-by: Nanar Boursalian <nanar.boursalian01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added AddMessageToQueue and ClearMessageQueue RPC and regenerated python files