Skip to content
This repository was archived by the owner on Dec 4, 2021. It is now read-only.

Create Printer Health Check - #52

Merged
evanugarte merged 1 commit into
masterfrom
PrinterHealthCheck
Jul 7, 2020
Merged

Create Printer Health Check#52
evanugarte merged 1 commit into
masterfrom
PrinterHealthCheck

Conversation

@Annabel1054

Copy link
Copy Markdown
Contributor

No description provided.

@Annabel1054
Annabel1054 requested review from evanugarte, jerrylee17 and law-nguyen and removed request for evanugarte and jerrylee17July 5, 2020 02:40
@Annabel1054Annabel1054 self-assigned this Jul 5, 2020
@Annabel1054Annabel1054 added the enhancement New feature or request label Jul 5, 2020
@evanugarteevanugarte changed the title Created Printer Health CheckCreate Printer Health CheckJul 6, 2020
Comment threadproto/print.proto

message PrinterHealthStatus {
string message = 1;
} No newline at end of file

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a blank new line at the bottom of this file

@evanugarteevanugarte left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow great job!! This is a super clean change.

@law-nguyenlaw-nguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great job.

Comment threadproto/print.proto

message PrinterHealthStatus {
string message = 1;
} No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line

@hsorathiahsorathia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

Comment threadclient/printing/print_pb.js
Comment threadclient/printing/print_pb.js
@evanugarte
evanugarte merged commit 441e7b5 into masterJul 7, 2020
@evanugarte
evanugarte deleted the PrinterHealthCheck branch July 7, 2020 03:37
Programmerryoki pushed a commit that referenced this pull request Feb 18, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Annabel1054@jerrylee17@evanugarte@hsorathia@law-nguyen