Skip to content
This repository was archived by the owner on Dec 4, 2021. It is now read-only.

Printer Health Check RPC (routes and tests) - #56

Merged
Annabel1054 merged 2 commits into
masterfrom
PrinterHealthCheck
Sep 9, 2020
Merged

Printer Health Check RPC (routes and tests)#56
Annabel1054 merged 2 commits into
masterfrom
PrinterHealthCheck

Conversation

@Annabel1054

@Annabel1054Annabel1054 commented Jul 12, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@Annabel1054
Annabel1054force-pushed the PrinterHealthCheck branch 2 times, most recently from e26e992 to 0eaab9bCompareJuly 12, 2020 23:14
@Annabel1054Annabel1054 self-assigned this Jul 12, 2020
@Annabel1054Annabel1054 added the enhancement New feature or request label Jul 12, 2020
evanugarte
evanugarte reviewed Jul 14, 2020
View reviewed changes
Comment threadclient/api/2DPrinting.js Outdated
evanugarte
evanugarte reviewed Jul 14, 2020
View reviewed changes
Comment threadproto/print.proto Outdated
evanugarte
evanugarte reviewed Jul 14, 2020
View reviewed changes
Comment threadproto/print.proto Outdated
evanugarte
evanugarte reviewed Jul 14, 2020
View reviewed changes
Comment threadproto/print.proto Outdated
hsorathia
hsorathia reviewed Jul 17, 2020
View reviewed changes
Comment threadclient/printing/print_grpc_pb.js
@evanugarte

evanugarte commented Aug 7, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

rebase homie

law-nguyen
law-nguyen approved these changes Aug 7, 2020
View reviewed changes

@law-nguyenlaw-nguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Annabel1054
Annabel1054 merged commit 810ca47 into masterSep 9, 2020
@Annabel1054
Annabel1054 deleted the PrinterHealthCheck branch September 9, 2020 18:13
Programmerryoki pushed a commit that referenced this pull request Feb 18, 2021
@Annabel1054
Printer Health Check RPC (routes and tests) (#56)
813f349
* Adds routes and tests for PrinterHealthCheck
* Regenerated client and server files for Printer Health Check RPC
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@evanugarteevanugarteAwaiting requested review from evanugarte
@hsorathiahsorathiaAwaiting requested review from hsorathia
3 more reviewers
@jerrylee17jerrylee17jerrylee17 approved these changes
@law-nguyenlaw-nguyenlaw-nguyen approved these changes
@IsitaBIsitaBIsitaB approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Annabel1054Annabel1054

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Annabel1054@evanugarte@jerrylee17@hsorathia@law-nguyen@IsitaB