Uh oh!
There was an error while loading. Please reload this page.
Add repository compute sandbox policy guard - #392
Closed
karollooool wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new self-contained repository-compute-sandbox-policy-guard module that evaluates synthetic SCIBASE repository release candidates against a compute/sandbox policy, producing JSON/Markdown/SVG reviewer artifacts (and an optional ffmpeg-rendered MP4).
Changes:
- New evaluator (
index.js) with policy checks for pinned images, network egress, compute budgets, writable mounts, and hash checkpoints, plus Markdown/SVG renderers. - Synthetic fixtures, demo script, test script, and pre-generated reviewer artifacts under
reports/. - Top-level README link added to surface the new module.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| repository-compute-sandbox-policy-guard/index.js | Core policy evaluator and renderers. |
| repository-compute-sandbox-policy-guard/sample-data.js | Synthetic candidate fixtures (ready/blocked/needs_review). |
| repository-compute-sandbox-policy-guard/demo.js | Generates JSON/Markdown/SVG reports from fixtures. |
| repository-compute-sandbox-policy-guard/test.js | Node assert coverage for evaluator and renderers. |
| repository-compute-sandbox-policy-guard/scripts/render-demo-video.js | Optional ffmpeg MP4 renderer. |
| repository-compute-sandbox-policy-guard/package.json | npm scripts for check/test/demo/demo:video. |
| repository-compute-sandbox-policy-guard/README.md | Module documentation and scope. |
| repository-compute-sandbox-policy-guard/reports/demo.{json,md,svg} | Pre-generated deterministic reviewer artifacts. |
| README.md | Adds a pointer to the new module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ]; | ||
| const font = candidates.find((candidate) => fs.existsSync(candidate)); | ||
| if (!font) { | ||
| return "font=Sans"; |
Comment on lines
+255
to
+257
| const doiOnly = | ||
| mode !== "doi-resolution-only" || | ||
| allowlist.every((host) => policy.doiResolverAllowlist.includes(host)); |
| const sizeOk = numberAtMost(mount.maxGb, policy.maxWritableGb); | ||
| addCheck( | ||
| pipeline.id, | ||
| `WRITABLE_MOUNT_${mount.path || "missing"}`, |
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.