fix(installer): repair five Windows installer defects (#233-#237)

[fupelaqu]

Fixes the five defects filed against PR #232. All are Windows-only — install.sh bootstraps no JDK, so it shares none of these paths.

Closes#233
Closes#234
Closes#235
Closes#236
Closes#237

What changed

install.ps1

• install.ps1: Resolve-Java never probes the JDK it bootstrapped, so every re-run re-downloads ~180 MB #233 — <install>\jdk is now step 1 of Resolve-Java. It never probed the JDK a previous run had bundled, so every re-run (upgrade, -NoExtensions, retry after a failed download) re-downloaded the ~180 MB Temurin zip over a perfectly good JDK. The order now matches the one both generated launchers document. A bundled JDK below the floor is replaced, not worked around with JAVA_HOME — the launcher prefers <install>\jdk unconditionally, so leaving a stale one there would put "the installer worked" and "the REPL starts" back into disagreement. Reuse and bootstrap set identical state through one new Use-EmbeddedJdk helper.
• install.ps1: the existing bundled JDK is deleted before its replacement is known-good #234 — stage, verify, then swap.Install-EmbeddedJdk deleted the existing JDK before unpacking its replacement; a failed unpack (running out of disk is squarely in that window — 180 MB zip + ~300 MB expanded + ~309 MB jar in one tree) left a previously working install with no JVM at all. It now unpacks to staging, asserts bin\java.exe in the staged tree, and only then removes the old tree and moves the new one in.
• install.ps1: a failed install leaves ~300 MB of orphaned jdk/ in the target directory #236 — inputs are settled before anything large is downloaded. A typo in -Version, a missing artifact for the chosen -EsVersion/-ScalaVersion, or an unreachable repository was only discovered by Download-Jar, after ~300 MB of JDK had landed in $Target. New Test-RequestedVersion pre-flight runs before Resolve-Java; Get-AvailableVersions is memoised (successes only) so it costs no extra HTTP, and $script:LastListingError preserves the cause -Quiet swallows. For the residual paths the main flow is wrapped in try/finally — PowerShell runs finally on exit and preserves the exit code — which names the JDK left in $Target. The JDK is kept on purpose: with install.ps1: Resolve-Java never probes the JDK it bootstrapped, so every re-run re-downloads ~180 MB #233 the next attempt reuses it, and deleting could destroy a JDK a previous install depends on.

Generated launchers

• install.ps1: the generated .bat launcher prefers JAVA_HOME but never checks it against REQUIRED_JAVA #235 — the .bat now enforces the Java floor. It computed JAVA_MAJOR and spent it only on the --add-opens decision, so a stale %JAVA_HOME% (which outranks the PATH here, deliberately, because it is the JVM the installer probed) silently won and the REPL died with UnsupportedClassVersionError — an error naming a class-file version, which reads as a broken install. Guarded by if not "%JAVA_MAJOR%"=="0" for parity with the .ps1 launcher: refuse only a version positively read as too low, never one it failed to parse. Both launchers now name JAVA_HOME as the likely cause.

install.cmd

• install.cmd: the install.ps1 fallback is fetched unpinned from main, unverified, and left in %TEMP% #237 — the fallback is pinned, verified, and cleaned up. It fetched install.ps1 from refs/heads/main, unverified, into a fixed %TEMP% path it never removed, then ran it with -ExecutionPolicy Bypass. It now fetches a pinned release tag, verifies it against a pinned SHA-256 with certutilbeforepowershell.exe sees the file, and downloads into a fresh %RANDOM% directory removed at a single exit point. Overridable with SOFTCLIENT4ES_INSTALL_REF (+ SOFTCLIENT4ES_INSTALL_SHA256); setting the ref alone drops the check and says so. Still a wrapper — no installer logic was added.

⚠️ Two things to decide on before merging

1. New release ritual.install.cmd carries two constants that must be bumped together at every release:

   set"PS1_REF=v0.21.0"set"PS1_SHA256=e1275bd2…ae" # curl -fsSL .../<tag>/install.ps1 | shasum -a 256

   A mismatch is a hard failure, so a bumped tag with a stale hash breaks the fallback loudly for every install.cmd-only user. That is the intended failure mode (loud, never "runs something unverified"), but it is a new obligation for the release checklist.

2. Accepted trade-off: main's install.cmd now fetches the last release's installer. That is the point of pinning — a released .cmd must never silently pull main — but it means these very fixes reach the .cmd-only path at the next release, not at merge. Escape hatches: set SOFTCLIENT4ES_INSTALL_REF=main, or put install.ps1 next to the .cmd (a local copy still always wins). Say the word if you would rather default to main and have the packaging step substitute the tag instead.

Verification

No Windows host here, so, precisely:

• 37 checks driving the real function bodies out of install.ps1's AST (Parser::ParseFile → FindAll(FunctionDefinitionAst) → Invoke-Expression), so the shipped text is what runs, not a transcription: JDK reuse / stale-replace / fall-through / bootstrap ordering with fake java.exe version banners; Install-EmbeddedJdk with stubbed Invoke-WebRequest/Expand-Archive under a throwing unpack, a malformed unpack and a good one (asserting the pre-existing JDK survives the first two); the generated .bat/.ps1 text; and the top-level try/finally executed from its own AST extent with the step functions stubbed.
• 15 static checks on install.cmd: label/goto closure, subroutines after the final exit /b, single cleanup point, RC defaults to failure, the one-parse-pass rule (no %VAR% read after a set in the same parenthesised block), CRLF + ASCII, and refetching the pinned tag to confirm the pinned SHA-256 still matches byte for byte.
• Real runs against JFrog: -Help; -ListVersions; a bogus -Version (fails before Java resolution and writes nothing); a missing Scala variant (now reports the underlying 404); and an end-to-end install with a JDK pre-placed at <Target>\jdk → Java 17 found via bundled JDK … — nothing to download.
• Not covered:cmd.exe executing install.cmd or the generated .bat, certutil output parsing on real Windows, and Expand-Archive on a real Temurin zip.

🤖 Generated with Claude Code