') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(deps): refresh Node toolchain pin to v20.20.2 LTS by ihistand · Pull Request #2 · SQLAnvil/sqlanvil · GitHub
Skip to content

fix(deps): refresh Node toolchain pin to v20.20.2 LTS - #2

Closed
ihistand wants to merge 1 commit into
rename/dataform-to-sqlanvilfrom
fix/node-toolchain-pin
Closed

fix(deps): refresh Node toolchain pin to v20.20.2 LTS#2
ihistand wants to merge 1 commit into
rename/dataform-to-sqlanvilfrom
fix/node-toolchain-pin

Conversation

@ihistand

@ihistandihistand commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

The pinned Node v24.13.0 in WORKSPACE had stale SHA256 hashes that no longer matched the binaries served from nodejs.org. Bumped to Node v20.20.2 LTS (matches node:20-bookworm in Dockerfile.dev) with fresh SHA256 hashes from nodejs.org/dist/v20.20.2/SHASUMS256.txt for all 5 platforms.

This unblocks the proto-TS and core build/test targets that the rename PR #1 could not verify due to the broken Node pin.

Stale hash example

Expected: e798599612f4bb71333a3397ab0d095fd62214e115aea45aa858a145fc72d67e
Actual: aa881151bd0f9f154a0424dd60a72e9ce10672619121658c278a24327ef46831

Was a stale-pin issue, not a Node-24-specific problem — nodejs.org seems to have re-published the v24.13.0 archives at some point. Pinning to an LTS line is more stable.

Verification (in Docker)

./scripts/docker-bazel build //protos:ts # → success
./scripts/docker-bazel build //core/... # → success
./scripts/docker-bazel test //core/... # → 16/16 pass

Test plan

  • `./scripts/docker-bazel build //protos:ts`
  • `./scripts/docker-bazel build //core/...`
  • `./scripts/docker-bazel test //core/...` (16/16 pass)
  • `./scripts/docker-bazel build //...` — blocked separately by missing `@io_bazel_rules_docker` declaration in WORKSPACE (pre-existing upstream issue; `tools/postgres/BUILD` references it)

Stack

Stacked on top of PR #1 (`rename/dataform-to-sqlanvil`). Merge order: #1 first, then this.

🤖 Generated with Claude Code

@ihistand
fix(deps): refresh Node toolchain pin to v20.20.2 LTS
b45a19f
The pinned Node v24.13.0 in WORKSPACE had stale SHA256 hashes that no
longer matched nodejs.org's served binaries:
Expected: e798599612f4bb71333a3397ab0d095fd62214e115aea45aa858a145fc72d67e
Actual: aa881151bd0f9f154a0424dd60a72e9ce10672619121658c278a24327ef46831
Bumped to Node v20.20.2 LTS (matches the node:20-bookworm base in
Dockerfile.dev). Fresh SHA256 hashes pulled from
nodejs.org/dist/v20.20.2/SHASUMS256.txt for all 5 platforms.
This was a stale-pin issue (not a Node 24 problem) — nodejs.org appears
to have re-published the v24.13.0 archives at some point. Pinning to an
LTS line is more stable.
Verified in Docker:
./scripts/docker-bazel build //protos:ts → success
./scripts/docker-bazel build //core/... → success
./scripts/docker-bazel test //core/... → 16/16 pass
Full tree (//...) still blocked by a separate pre-existing upstream
issue: tools/postgres/BUILD references @io_bazel_rules_docker which is
not declared in WORKSPACE.
This was referenced May 27, 2026
Closed
Closed
Closed
Closed
Closed
Closed
ihistand added a commit that referenced this pull request Jun 4, 2026
@ihistand@claude
feat(core): settle warehouse config as flat + reject unknown warehouses
0092614
#2 decision: workflow_settings.yaml uses a flat `warehouse:` string
(bigquery/postgres/supabase) + flat defaults; the connection (with secrets)
stays in the gitignored .df-credentials.json. This overturns the design doc's
earlier "nested warehouse:{kind,connection}" call, which would have put secrets
in committed config — flat matches Dataform's settings/credentials split and is
already what the CLI, init, tests, example, and agent docs use.
Harden it: workflowSettingsAsProjectConfig now rejects an unknown `warehouse:`
value with a clear error instead of silently defaulting to BigQuery.
TDD: core/main_test.ts "warehouse config" suite (accepts the three, defaults to
bigquery when unset, RED→GREEN on rejecting "mysql"). CLAUDE.md item #2 marked
resolved.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ihistand

ihistand commented Jun 7, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Superseded: the Postgres reintegration + Dataform→SQLAnvil rename landed on main directly, and the docs moved to the SQLAnvil/docs repo. Closing as part of #12 (stale-branch prune). The one un-migrated draft, gcp_test_project_setup.md, was migrated to SQLAnvil/docs.

@ihistandihistand closed this Jun 7, 2026
@ihistand
ihistand deleted the fix/node-toolchain-pin branch June 7, 2026 01:45
@ihistandihistand mentioned this pull request Jun 15, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ihistand