') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); feat: MySQL/MariaDB adapter by ihistand · Pull Request #34 · SQLAnvil/sqlanvil · GitHub
Skip to content

feat: MySQL/MariaDB adapter - #34

Merged
ihistand merged 12 commits into
mainfrom
feat/mysql-adapter
Jun 17, 2026
Merged

feat: MySQL/MariaDB adapter#34
ihistand merged 12 commits into
mainfrom
feat/mysql-adapter

Conversation

@ihistand

@ihistandihistand commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Implements a single mysql warehouse adapter per planning/specs/2026-06-17-mysql-mariadb-adapter-design.md. One adapter generates portable MySQL-dialect SQL that runs against both MySQL and MariaDB — engine-specific features ride through operations, mirroring how the BigQuery/Postgres adapters lean on the engine for the heavy lifting.

What's included

  • Proto — MysqlConnection added to the WarehouseConfig union (protos/configs.proto).
  • Core — mysql accepted in supportedWarehouses; MySQL backtick quoting in CompilationSql (two-part `schema`.`name`, backtick-quoted assertion columns, backslash string escaping).
  • Adapter triad (mirrors Postgres):
  • CLI — credentials validation, init scaffolds a mysql .df-credentials.json, --warehouse mysql accepted, adapter wired into run/test.
  • Tests — unit coverage for quoting + DDL/DML generation; an integration spec that PASSES against both mysql:8 (3306) and mariadb:11 (3307) (full project run, incremental append + upsert idempotency, assertion pass/fail, EXPLAIN evaluate, fail-fast bad creds). Fixtures + tools/mysql/run-mysql-db.sh.

Verification

  • ./scripts/docker-bazel test //core/... //cli/... — all pass except the pre-existing, credentials-gated //cli:index_run_e2e_test (fails identically on main; unrelated to this change).
  • Integration spec green on both engines.
  • CLI smoke: init --warehouse mysql scaffolds correctly. (Full CLI compile/run end-to-end needs the 1.5.0 core on npm — the standalone compile installs @sqlanvil/core@<version>; the in-repo build is fully verified via the integration suite, which uses the local core tarball.)

Deferred (follow-up PRs)

Materialized views (error only), a mysql: {} options block (engine/indexes/partitioning), description/columns → COMMENT metadata, and introspect for MySQL sources.

Version bump to 1.5.0 + publish is a separate release step after merge.

🤖 Generated with Claude Code

ihistandand others added 12 commits June 17, 2026 08:26
@ihistand@claude
feat(proto): add MysqlConnection to WarehouseConfig union
90a1fc2
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand@claude
feat(core): accept mysql warehouse + MySQL backtick quoting
56bc0f1
- supportedWarehouses now includes mysql; main_test rejection case uses snowflake
- CompilationSql resolveTarget emits `schema`.`name` for mysql (no catalog level)
- indexAssertion backtick-quotes columns; sqlString uses backslash escaping for mysql
- unit tests for resolveTarget/sqlString/indexAssertion mysql branches
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand@claude
build(deps): add mysql2 for MySQL/MariaDB adapter
25c58a4
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand@claude
feat(mysql): MysqlExecutionSql DDL/DML generator
5d35cad
Table CTAS, CREATE OR REPLACE VIEW, incremental (CTAS + unique index then
ON DUPLICATE KEY UPDATE upsert), assertion via view + row count. Materialized
views error out (deferred). Wired into the ExecutionSql dispatcher.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand@claude
feat(mysql): MySqlPoolExecutor (release-once, fail-fast verify)
6a00950
mysql2-backed pool with withClientLock + single release path, verifyConnection
fail-fast, and a convertFieldType mapping MySQL DATA_TYPEs to field primitives.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand@claude
feat(mysql): MySqlDbAdapter (IDbAdapter via mysql2)
d3d9e3e
create() with fail-fast verify + optional TLS, withClientLock delegating to the
pool executor, EXPLAIN-based evaluate, information_schema introspection
(tables/table/search/schemas), CREATE DATABASE IF NOT EXISTS, deleteTable.
setMetadata is a deferred no-op for the MVP.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand@claude
feat(mysql): credentials validation + CLI wiring
b46c146
- credentials.read() validates MysqlConnection (host required)
- init scaffolds a mysql .df-credentials.json template
- warehouseOption accepts mysql; run/test commands create MySqlDbAdapter
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand@claude
test(mysql): docker fixtures for mysql:8 + mariadb:11
15eebf9
MysqlFixture (2-arg ctor, env-bypass for the docker-bazel path; same class
serves MySQL 3306 and MariaDB 3307) + run-mysql-db.sh launcher + BUILD.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand@claude
test(mysql): integration spec against mysql:8 and mariadb:11
864568f
Full-project run (table/view/incremental/merge/assertions), incremental append +
upsert idempotency, EXPLAIN-based evaluate, fail-fast bad creds — verified
PASSED on both mysql:8 (3306) and mariadb:11 (3307). Adds MYSQL_* env
forwarding to scripts/docker-bazel; upsertInto only emits ON DUPLICATE KEY
UPDATE when a uniqueKey exists (plain append otherwise).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand@claude
build(mysql): declare mysql2 as a bundle + package external
7666ca1
Adds mysql2 to the cli package.json deps and mysql2/promise to the rollup
externals (rollup matches the import specifier exactly), so the adapter's
mysql2/promise import is not bundled. Fixes the cli bundle build.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand@claude
docs: add MySQL/MariaDB to README warehouse list
a1d2696
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand@claude
refactor(mysql): address review — convertFieldType coverage + invaria…
12b3a00
…nt comments
- convertFieldType maps BIT->INTEGER, JSON/TIME->STRING; documents binary/blob/
geometry falling through to UNKNOWN (introspection-only metadata)
- comment the upsertInto no-metadata fallback invariant and the byteLimit/
client-side rowLimit divergence from the streaming Postgres path
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ihistand
ihistand merged commit cb579b7 into mainJun 17, 2026
This was referenced Jun 17, 2026
Closed
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ihistand