Skip to content

[Lab1] 312552050 - #31

Closed
tsaiet wants to merge 3 commits into
SQLab:312552050from
tsaiet:312552050
Closed

[Lab1] 312552050#31
tsaiet wants to merge 3 commits into
SQLab:312552050from
tsaiet:312552050

Conversation

@tsaiet

@tsaiettsaiet commented Feb 29, 2024•
edited
Loading

Copy link
Copy Markdown

Description

#2

  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

TaiYou-TWand others added 3 commits February 29, 2024 21:15
@TaiYou-TW@tsaiet
feat: lab1
ed91a19
doc: add title's description and branch warning in pr template
feat: remove badge requirement in lab1
doc: add sample's link in pr template
feat: add automatic PR labeler in github workflow
feat: update labeler's event and add github-token
fix: validate.sh will failed if there are spaces in node's path
doc: remove label instruction in pr template
@tsaiet
first commit
224abb4
@tsaiet
Merge branch '312552050' into 312552050
4d44359
@tsaiettsaiet closed this Feb 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tsaiet@TaiYou-TW