Skip to content

[LAB1] 312552050 - #35

Merged
TaiYou-TW merged 2 commits into
SQLab:312552050from
tsaiet:312552050
Mar 7, 2024
Merged

[LAB1] 312552050#35
TaiYou-TW merged 2 commits into
SQLab:312552050from
tsaiet:312552050

Conversation

@tsaiet

@tsaiettsaiet commented Feb 29, 2024•
edited
Loading

Copy link
Copy Markdown

Description

#2

  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

@TaiYou-TWTaiYou-TW reopened this Feb 29, 2024
@tsaiettsaiet changed the title [Lab1] 312552050[LAB1] 312552050Mar 7, 2024
@TaiYou-TW

TaiYou-TW commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

You should use more meaningful messages on your commits next time.

@TaiYou-TW
TaiYou-TW merged commit 6c3bef3 into SQLab:312552050Mar 7, 2024
@tsaiet

tsaiet commented Mar 8, 2024

Copy link
Copy Markdown
Author

You should use more meaningful messages on your commits next time.

okay!!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lab1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tsaiet@TaiYou-TW