:zap: tweaking PSFmachine to play with the K2 implementation by christinahedges · Pull Request #47 · SSDataLab/psfmachine

christinahedges · 2022-02-03T00:04:17Z

I'm taking a look at PSFmachine for ruprecht, and making a few tweaks. I'm opening this issue to discuss these tweaks.

Here's a rough log of changes:

Changed the _update_source_mask... function so that it more aggressively clips out the faint edges of the PSF
Messed a little with some of the sane defaults for the masking function
Added a slightly more robust error catch for the "breaks" in time binning,
Get centroid takes a frame index so it will only calculate the centroid of the current frame unless "mean" is passed...(this might not be advisable)
_get_source_mask now puts the centroid to the centroid of the frame_index, making sure that per cadence PSFs are always centered at zero.
build_frame_shape_model recalculates the source mask at every step

The last point makes sure that the PSF is always centered at 0,0 when we fit it. This is important, as our model is only valid if the PSF it's modeling is centered.

However, the way it is currently set up, this becomes quite intractable for large datasets...!

jorgemarpa · 2022-03-22T01:10:17Z

+ upper_radius_limit=36.0,
 lower_radius_limit=4.5,
 upper_flux_limit=2e5,
- lower_flux_limit=100,
+ lower_flux_limit=40,


this makes the rough mask more generous, good when scene motion is considerable, and allows for fainter pixels

jorgemarpa

I like the small tweaks you add to the API. Only a few of them change the default values, the rest only makes the API more robust. I don't think the first ones will make big changes for Kepler data.

We need to update the tutorials to reflect the new keyword arguments we are introducing here. I saw the tutorials in christinatweaks branch aren't updated to the last version in master.
Also, the change to superstamp.py will make the computing times in the SSMachine tutorials a bit longer.

I will run the Tutorials as a way to check things are consistent with the master branch, I'll report back when it's done.

jorgemarpa · 2022-03-22T01:16:24Z

 # mask out non finite values and background pixels
 k = (np.isfinite(wgts)) & (
- self.uncontaminated_source_mask.multiply(self.flux[t]).data > 100
+ self.uncontaminated_source_mask.multiply(self.flux[t]).data > 10


I agree this value should be more generous.
Let's add a comment that this value works well for Kepler/K2 background-subtracted pixels.

jorgemarpa · 2022-03-22T01:28:44Z

+ lower_flux_limit=40,
 correct_centroid_offset=True,
 plot=False,
+ frame_index="mean",


add docstring for this argument.
Using main keeps the original behavior, right?

jorgemarpa · 2022-03-22T01:40:51Z


 def build_shape_model(
- self, plot=False, flux_cut_off=1, frame_index="mean", **kwargs
+ self, plot=False, flux_atol=1, flux_rtol=0.001, frame_index="mean", **kwargs


I think these new arguments are better than the ones we had before.

christinahedges · 2022-02-03T00:04:17Z

I'm taking a look at PSFmachine for ruprecht, and making a few tweaks. I'm opening this issue to discuss these tweaks.

Here's a rough log of changes:

Changed the _update_source_mask... function so that it more aggressively clips out the faint edges of the PSF
Messed a little with some of the sane defaults for the masking function
Added a slightly more robust error catch for the "breaks" in time binning,
Get centroid takes a frame index so it will only calculate the centroid of the current frame unless "mean" is passed...(this might not be advisable)
_get_source_mask now puts the centroid to the centroid of the frame_index, making sure that per cadence PSFs are always centered at zero.
build_frame_shape_model recalculates the source mask at every step

The last point makes sure that the PSF is always centered at 0,0 when we fit it. This is important, as our model is only valid if the PSF it's modeling is centered.

However, the way it is currently set up, this becomes quite intractable for large datasets...!

jorgemarpa · 2022-03-22T01:10:17Z

+ upper_radius_limit=36.0,
 lower_radius_limit=4.5,
 upper_flux_limit=2e5,
- lower_flux_limit=100,
+ lower_flux_limit=40,


this makes the rough mask more generous, good when scene motion is considerable, and allows for fainter pixels

jorgemarpa

I like the small tweaks you add to the API. Only a few of them change the default values, the rest only makes the API more robust. I don't think the first ones will make big changes for Kepler data.

We need to update the tutorials to reflect the new keyword arguments we are introducing here. I saw the tutorials in christinatweaks branch aren't updated to the last version in master.
Also, the change to superstamp.py will make the computing times in the SSMachine tutorials a bit longer.

I will run the Tutorials as a way to check things are consistent with the master branch, I'll report back when it's done.

jorgemarpa · 2022-03-22T01:16:24Z

 # mask out non finite values and background pixels
 k = (np.isfinite(wgts)) & (
- self.uncontaminated_source_mask.multiply(self.flux[t]).data > 100
+ self.uncontaminated_source_mask.multiply(self.flux[t]).data > 10


I agree this value should be more generous.
Let's add a comment that this value works well for Kepler/K2 background-subtracted pixels.

jorgemarpa · 2022-03-22T01:28:44Z

+ lower_flux_limit=40,
 correct_centroid_offset=True,
 plot=False,
+ frame_index="mean",


add docstring for this argument.
Using main keeps the original behavior, right?

jorgemarpa · 2022-03-22T01:40:51Z


 def build_shape_model(
- self, plot=False, flux_cut_off=1, frame_index="mean", **kwargs
+ self, plot=False, flux_atol=1, flux_rtol=0.001, frame_index="mean", **kwargs


I think these new arguments are better than the ones we had before.

christinahedges · 2022-02-03T00:04:17Z

I'm taking a look at PSFmachine for ruprecht, and making a few tweaks. I'm opening this issue to discuss these tweaks.

Here's a rough log of changes:

Changed the _update_source_mask... function so that it more aggressively clips out the faint edges of the PSF
Messed a little with some of the sane defaults for the masking function
Added a slightly more robust error catch for the "breaks" in time binning,
Get centroid takes a frame index so it will only calculate the centroid of the current frame unless "mean" is passed...(this might not be advisable)
_get_source_mask now puts the centroid to the centroid of the frame_index, making sure that per cadence PSFs are always centered at zero.
build_frame_shape_model recalculates the source mask at every step

The last point makes sure that the PSF is always centered at 0,0 when we fit it. This is important, as our model is only valid if the PSF it's modeling is centered.

However, the way it is currently set up, this becomes quite intractable for large datasets...!

jorgemarpa · 2022-03-22T01:10:17Z

+ upper_radius_limit=36.0,
 lower_radius_limit=4.5,
 upper_flux_limit=2e5,
- lower_flux_limit=100,
+ lower_flux_limit=40,


this makes the rough mask more generous, good when scene motion is considerable, and allows for fainter pixels

jorgemarpa

I like the small tweaks you add to the API. Only a few of them change the default values, the rest only makes the API more robust. I don't think the first ones will make big changes for Kepler data.

We need to update the tutorials to reflect the new keyword arguments we are introducing here. I saw the tutorials in christinatweaks branch aren't updated to the last version in master.
Also, the change to superstamp.py will make the computing times in the SSMachine tutorials a bit longer.

I will run the Tutorials as a way to check things are consistent with the master branch, I'll report back when it's done.

jorgemarpa · 2022-03-22T01:16:24Z

 # mask out non finite values and background pixels
 k = (np.isfinite(wgts)) & (
- self.uncontaminated_source_mask.multiply(self.flux[t]).data > 100
+ self.uncontaminated_source_mask.multiply(self.flux[t]).data > 10


I agree this value should be more generous.
Let's add a comment that this value works well for Kepler/K2 background-subtracted pixels.

jorgemarpa · 2022-03-22T01:28:44Z

+ lower_flux_limit=40,
 correct_centroid_offset=True,
 plot=False,
+ frame_index="mean",


add docstring for this argument.
Using main keeps the original behavior, right?

jorgemarpa · 2022-03-22T01:40:51Z


 def build_shape_model(
- self, plot=False, flux_cut_off=1, frame_index="mean", **kwargs
+ self, plot=False, flux_atol=1, flux_rtol=0.001, frame_index="mean", **kwargs


I think these new arguments are better than the ones we had before.

christinahedges · 2022-02-03T00:04:17Z

I'm taking a look at PSFmachine for ruprecht, and making a few tweaks. I'm opening this issue to discuss these tweaks.

Here's a rough log of changes:

Changed the _update_source_mask... function so that it more aggressively clips out the faint edges of the PSF
Messed a little with some of the sane defaults for the masking function
Added a slightly more robust error catch for the "breaks" in time binning,
Get centroid takes a frame index so it will only calculate the centroid of the current frame unless "mean" is passed...(this might not be advisable)
_get_source_mask now puts the centroid to the centroid of the frame_index, making sure that per cadence PSFs are always centered at zero.
build_frame_shape_model recalculates the source mask at every step

The last point makes sure that the PSF is always centered at 0,0 when we fit it. This is important, as our model is only valid if the PSF it's modeling is centered.

However, the way it is currently set up, this becomes quite intractable for large datasets...!

jorgemarpa · 2022-03-22T01:10:17Z

+ upper_radius_limit=36.0,
 lower_radius_limit=4.5,
 upper_flux_limit=2e5,
- lower_flux_limit=100,
+ lower_flux_limit=40,


this makes the rough mask more generous, good when scene motion is considerable, and allows for fainter pixels

jorgemarpa

I like the small tweaks you add to the API. Only a few of them change the default values, the rest only makes the API more robust. I don't think the first ones will make big changes for Kepler data.

We need to update the tutorials to reflect the new keyword arguments we are introducing here. I saw the tutorials in christinatweaks branch aren't updated to the last version in master.
Also, the change to superstamp.py will make the computing times in the SSMachine tutorials a bit longer.

I will run the Tutorials as a way to check things are consistent with the master branch, I'll report back when it's done.

jorgemarpa · 2022-03-22T01:16:24Z

 # mask out non finite values and background pixels
 k = (np.isfinite(wgts)) & (
- self.uncontaminated_source_mask.multiply(self.flux[t]).data > 100
+ self.uncontaminated_source_mask.multiply(self.flux[t]).data > 10


I agree this value should be more generous.
Let's add a comment that this value works well for Kepler/K2 background-subtracted pixels.

jorgemarpa · 2022-03-22T01:28:44Z

+ lower_flux_limit=40,
 correct_centroid_offset=True,
 plot=False,
+ frame_index="mean",


add docstring for this argument.
Using main keeps the original behavior, right?

jorgemarpa · 2022-03-22T01:40:51Z


 def build_shape_model(
- self, plot=False, flux_cut_off=1, frame_index="mean", **kwargs
+ self, plot=False, flux_atol=1, flux_rtol=0.001, frame_index="mean", **kwargs


I think these new arguments are better than the ones we had before.

christinahedges · 2022-02-03T00:04:17Z

I'm taking a look at PSFmachine for ruprecht, and making a few tweaks. I'm opening this issue to discuss these tweaks.

Here's a rough log of changes:

Changed the _update_source_mask... function so that it more aggressively clips out the faint edges of the PSF
Messed a little with some of the sane defaults for the masking function
Added a slightly more robust error catch for the "breaks" in time binning,
Get centroid takes a frame index so it will only calculate the centroid of the current frame unless "mean" is passed...(this might not be advisable)
_get_source_mask now puts the centroid to the centroid of the frame_index, making sure that per cadence PSFs are always centered at zero.
build_frame_shape_model recalculates the source mask at every step

The last point makes sure that the PSF is always centered at 0,0 when we fit it. This is important, as our model is only valid if the PSF it's modeling is centered.

However, the way it is currently set up, this becomes quite intractable for large datasets...!

jorgemarpa · 2022-03-22T01:10:17Z

+ upper_radius_limit=36.0,
 lower_radius_limit=4.5,
 upper_flux_limit=2e5,
- lower_flux_limit=100,
+ lower_flux_limit=40,


this makes the rough mask more generous, good when scene motion is considerable, and allows for fainter pixels

jorgemarpa

I like the small tweaks you add to the API. Only a few of them change the default values, the rest only makes the API more robust. I don't think the first ones will make big changes for Kepler data.

We need to update the tutorials to reflect the new keyword arguments we are introducing here. I saw the tutorials in christinatweaks branch aren't updated to the last version in master.
Also, the change to superstamp.py will make the computing times in the SSMachine tutorials a bit longer.

I will run the Tutorials as a way to check things are consistent with the master branch, I'll report back when it's done.

jorgemarpa · 2022-03-22T01:16:24Z

 # mask out non finite values and background pixels
 k = (np.isfinite(wgts)) & (
- self.uncontaminated_source_mask.multiply(self.flux[t]).data > 100
+ self.uncontaminated_source_mask.multiply(self.flux[t]).data > 10


I agree this value should be more generous.
Let's add a comment that this value works well for Kepler/K2 background-subtracted pixels.

jorgemarpa · 2022-03-22T01:28:44Z

+ lower_flux_limit=40,
 correct_centroid_offset=True,
 plot=False,
+ frame_index="mean",


add docstring for this argument.
Using main keeps the original behavior, right?

jorgemarpa · 2022-03-22T01:40:51Z


 def build_shape_model(
- self, plot=False, flux_cut_off=1, frame_index="mean", **kwargs
+ self, plot=False, flux_atol=1, flux_rtol=0.001, frame_index="mean", **kwargs


I think these new arguments are better than the ones we had before.

christinahedges · 2022-02-03T00:04:17Z

I'm taking a look at PSFmachine for ruprecht, and making a few tweaks. I'm opening this issue to discuss these tweaks.

Here's a rough log of changes:

Changed the _update_source_mask... function so that it more aggressively clips out the faint edges of the PSF
Messed a little with some of the sane defaults for the masking function
Added a slightly more robust error catch for the "breaks" in time binning,
Get centroid takes a frame index so it will only calculate the centroid of the current frame unless "mean" is passed...(this might not be advisable)
_get_source_mask now puts the centroid to the centroid of the frame_index, making sure that per cadence PSFs are always centered at zero.
build_frame_shape_model recalculates the source mask at every step

The last point makes sure that the PSF is always centered at 0,0 when we fit it. This is important, as our model is only valid if the PSF it's modeling is centered.

However, the way it is currently set up, this becomes quite intractable for large datasets...!

jorgemarpa · 2022-03-22T01:10:17Z

+ upper_radius_limit=36.0,
 lower_radius_limit=4.5,
 upper_flux_limit=2e5,
- lower_flux_limit=100,
+ lower_flux_limit=40,


this makes the rough mask more generous, good when scene motion is considerable, and allows for fainter pixels

jorgemarpa

I like the small tweaks you add to the API. Only a few of them change the default values, the rest only makes the API more robust. I don't think the first ones will make big changes for Kepler data.

We need to update the tutorials to reflect the new keyword arguments we are introducing here. I saw the tutorials in christinatweaks branch aren't updated to the last version in master.
Also, the change to superstamp.py will make the computing times in the SSMachine tutorials a bit longer.

I will run the Tutorials as a way to check things are consistent with the master branch, I'll report back when it's done.

jorgemarpa · 2022-03-22T01:16:24Z

 # mask out non finite values and background pixels
 k = (np.isfinite(wgts)) & (
- self.uncontaminated_source_mask.multiply(self.flux[t]).data > 100
+ self.uncontaminated_source_mask.multiply(self.flux[t]).data > 10


I agree this value should be more generous.
Let's add a comment that this value works well for Kepler/K2 background-subtracted pixels.

jorgemarpa · 2022-03-22T01:28:44Z

+ lower_flux_limit=40,
 correct_centroid_offset=True,
 plot=False,
+ frame_index="mean",


add docstring for this argument.
Using main keeps the original behavior, right?

jorgemarpa · 2022-03-22T01:40:51Z


 def build_shape_model(
- self, plot=False, flux_cut_off=1, frame_index="mean", **kwargs
+ self, plot=False, flux_atol=1, flux_rtol=0.001, frame_index="mean", **kwargs


I think these new arguments are better than the ones we had before.

christinahedges · 2022-02-03T00:04:17Z

I'm taking a look at PSFmachine for ruprecht, and making a few tweaks. I'm opening this issue to discuss these tweaks.

Here's a rough log of changes:

Changed the _update_source_mask... function so that it more aggressively clips out the faint edges of the PSF
Messed a little with some of the sane defaults for the masking function
Added a slightly more robust error catch for the "breaks" in time binning,
Get centroid takes a frame index so it will only calculate the centroid of the current frame unless "mean" is passed...(this might not be advisable)
_get_source_mask now puts the centroid to the centroid of the frame_index, making sure that per cadence PSFs are always centered at zero.
build_frame_shape_model recalculates the source mask at every step

The last point makes sure that the PSF is always centered at 0,0 when we fit it. This is important, as our model is only valid if the PSF it's modeling is centered.

However, the way it is currently set up, this becomes quite intractable for large datasets...!

jorgemarpa · 2022-03-22T01:10:17Z

+ upper_radius_limit=36.0,
 lower_radius_limit=4.5,
 upper_flux_limit=2e5,
- lower_flux_limit=100,
+ lower_flux_limit=40,


this makes the rough mask more generous, good when scene motion is considerable, and allows for fainter pixels

jorgemarpa

I like the small tweaks you add to the API. Only a few of them change the default values, the rest only makes the API more robust. I don't think the first ones will make big changes for Kepler data.

We need to update the tutorials to reflect the new keyword arguments we are introducing here. I saw the tutorials in christinatweaks branch aren't updated to the last version in master.
Also, the change to superstamp.py will make the computing times in the SSMachine tutorials a bit longer.

I will run the Tutorials as a way to check things are consistent with the master branch, I'll report back when it's done.

jorgemarpa · 2022-03-22T01:16:24Z

 # mask out non finite values and background pixels
 k = (np.isfinite(wgts)) & (
- self.uncontaminated_source_mask.multiply(self.flux[t]).data > 100
+ self.uncontaminated_source_mask.multiply(self.flux[t]).data > 10


I agree this value should be more generous.
Let's add a comment that this value works well for Kepler/K2 background-subtracted pixels.

jorgemarpa · 2022-03-22T01:28:44Z

+ lower_flux_limit=40,
 correct_centroid_offset=True,
 plot=False,
+ frame_index="mean",


add docstring for this argument.
Using main keeps the original behavior, right?

jorgemarpa · 2022-03-22T01:40:51Z


 def build_shape_model(
- self, plot=False, flux_cut_off=1, frame_index="mean", **kwargs
+ self, plot=False, flux_atol=1, flux_rtol=0.001, frame_index="mean", **kwargs


I think these new arguments are better than the ones we had before.

christinahedges · 2022-02-03T00:04:17Z

I'm taking a look at PSFmachine for ruprecht, and making a few tweaks. I'm opening this issue to discuss these tweaks.

Here's a rough log of changes:

Changed the _update_source_mask... function so that it more aggressively clips out the faint edges of the PSF
Messed a little with some of the sane defaults for the masking function
Added a slightly more robust error catch for the "breaks" in time binning,
Get centroid takes a frame index so it will only calculate the centroid of the current frame unless "mean" is passed...(this might not be advisable)
_get_source_mask now puts the centroid to the centroid of the frame_index, making sure that per cadence PSFs are always centered at zero.
build_frame_shape_model recalculates the source mask at every step

The last point makes sure that the PSF is always centered at 0,0 when we fit it. This is important, as our model is only valid if the PSF it's modeling is centered.

However, the way it is currently set up, this becomes quite intractable for large datasets...!

jorgemarpa · 2022-03-22T01:10:17Z

+ upper_radius_limit=36.0,
 lower_radius_limit=4.5,
 upper_flux_limit=2e5,
- lower_flux_limit=100,
+ lower_flux_limit=40,


this makes the rough mask more generous, good when scene motion is considerable, and allows for fainter pixels

jorgemarpa

I like the small tweaks you add to the API. Only a few of them change the default values, the rest only makes the API more robust. I don't think the first ones will make big changes for Kepler data.

We need to update the tutorials to reflect the new keyword arguments we are introducing here. I saw the tutorials in christinatweaks branch aren't updated to the last version in master.
Also, the change to superstamp.py will make the computing times in the SSMachine tutorials a bit longer.

I will run the Tutorials as a way to check things are consistent with the master branch, I'll report back when it's done.

jorgemarpa · 2022-03-22T01:16:24Z

 # mask out non finite values and background pixels
 k = (np.isfinite(wgts)) & (
- self.uncontaminated_source_mask.multiply(self.flux[t]).data > 100
+ self.uncontaminated_source_mask.multiply(self.flux[t]).data > 10


I agree this value should be more generous.
Let's add a comment that this value works well for Kepler/K2 background-subtracted pixels.

jorgemarpa · 2022-03-22T01:28:44Z

+ lower_flux_limit=40,
 correct_centroid_offset=True,
 plot=False,
+ frame_index="mean",


add docstring for this argument.
Using main keeps the original behavior, right?

jorgemarpa · 2022-03-22T01:40:51Z


 def build_shape_model(
- self, plot=False, flux_cut_off=1, frame_index="mean", **kwargs
+ self, plot=False, flux_atol=1, flux_rtol=0.001, frame_index="mean", **kwargs


I think these new arguments are better than the ones we had before.

christinahedges added 2 commits February 2, 2022 16:03

⚡ tweaking
80d54a0

⚡ tweaking
9cfa03e

christinahedges requested a review from jorgemarpa March 18, 2022 18:12

christinahedges changed the title ~~[WIP] ⚡ tweaking PSFmachine to play with the K2 implementation~~⚡ tweaking PSFmachine to play with the K2 implementationMar 18, 2022

christinahedges mentioned this pull request Mar 18, 2022
Refactor API to remove in-place centroids, and update FFIMachine [do-NOT-merge] #54
Open
1 task

jorgemarpa reviewed Mar 22, 2022
View reviewed changes

christinahedges added 2 commits February 2, 2022 16:03

⚡ tweaking
80d54a0

⚡ tweaking
9cfa03e

christinahedges requested a review from jorgemarpa March 18, 2022 18:12

christinahedges changed the title ~~[WIP] ⚡ tweaking PSFmachine to play with the K2 implementation~~⚡ tweaking PSFmachine to play with the K2 implementationMar 18, 2022

christinahedges mentioned this pull request Mar 18, 2022
Refactor API to remove in-place centroids, and update FFIMachine [do-NOT-merge] #54
Open
1 task

jorgemarpa reviewed Mar 22, 2022
View reviewed changes

christinahedges added 2 commits February 2, 2022 16:03

⚡ tweaking
80d54a0

⚡ tweaking
9cfa03e

christinahedges requested a review from jorgemarpa March 18, 2022 18:12

christinahedges changed the title ~~[WIP] ⚡ tweaking PSFmachine to play with the K2 implementation~~⚡ tweaking PSFmachine to play with the K2 implementationMar 18, 2022

christinahedges mentioned this pull request Mar 18, 2022
Refactor API to remove in-place centroids, and update FFIMachine [do-NOT-merge] #54
Open
1 task

jorgemarpa reviewed Mar 22, 2022
View reviewed changes

christinahedges added 2 commits February 2, 2022 16:03

⚡ tweaking
80d54a0

⚡ tweaking
9cfa03e

christinahedges requested a review from jorgemarpa March 18, 2022 18:12

christinahedges changed the title ~~[WIP] ⚡ tweaking PSFmachine to play with the K2 implementation~~⚡ tweaking PSFmachine to play with the K2 implementationMar 18, 2022

christinahedges mentioned this pull request Mar 18, 2022
Refactor API to remove in-place centroids, and update FFIMachine [do-NOT-merge] #54
Open
1 task

jorgemarpa reviewed Mar 22, 2022
View reviewed changes

christinahedges added 2 commits February 2, 2022 16:03

⚡ tweaking
80d54a0

⚡ tweaking
9cfa03e

christinahedges requested a review from jorgemarpa March 18, 2022 18:12

christinahedges changed the title ~~[WIP] ⚡ tweaking PSFmachine to play with the K2 implementation~~⚡ tweaking PSFmachine to play with the K2 implementationMar 18, 2022

christinahedges mentioned this pull request Mar 18, 2022
Refactor API to remove in-place centroids, and update FFIMachine [do-NOT-merge] #54
Open
1 task

jorgemarpa reviewed Mar 22, 2022
View reviewed changes

christinahedges added 2 commits February 2, 2022 16:03

⚡ tweaking
80d54a0

⚡ tweaking
9cfa03e

christinahedges requested a review from jorgemarpa March 18, 2022 18:12

christinahedges changed the title ~~[WIP] ⚡ tweaking PSFmachine to play with the K2 implementation~~⚡ tweaking PSFmachine to play with the K2 implementationMar 18, 2022

christinahedges mentioned this pull request Mar 18, 2022
Refactor API to remove in-place centroids, and update FFIMachine [do-NOT-merge] #54
Open
1 task

jorgemarpa reviewed Mar 22, 2022
View reviewed changes

christinahedges added 2 commits February 2, 2022 16:03

⚡ tweaking
80d54a0

⚡ tweaking
9cfa03e

christinahedges requested a review from jorgemarpa March 18, 2022 18:12

christinahedges changed the title ~~[WIP] ⚡ tweaking PSFmachine to play with the K2 implementation~~⚡ tweaking PSFmachine to play with the K2 implementationMar 18, 2022

christinahedges mentioned this pull request Mar 18, 2022
Refactor API to remove in-place centroids, and update FFIMachine [do-NOT-merge] #54
Open
1 task

jorgemarpa reviewed Mar 22, 2022
View reviewed changes

christinahedges added 2 commits February 2, 2022 16:03

⚡ tweaking
80d54a0

⚡ tweaking
9cfa03e

christinahedges requested a review from jorgemarpa March 18, 2022 18:12

christinahedges changed the title ~~[WIP] ⚡ tweaking PSFmachine to play with the K2 implementation~~⚡ tweaking PSFmachine to play with the K2 implementationMar 18, 2022

christinahedges mentioned this pull request Mar 18, 2022
Refactor API to remove in-place centroids, and update FFIMachine [do-NOT-merge] #54
Open
1 task

jorgemarpa reviewed Mar 22, 2022
View reviewed changes

Uh oh!

Conversation

christinahedges commented Feb 3, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorgemarpa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

christinahedges commented Feb 3, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorgemarpa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

christinahedges commented Feb 3, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorgemarpa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

christinahedges commented Feb 3, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorgemarpa left a comment

christinahedges commented Feb 3, 2022•
edited
Loading

christinahedges commented Feb 3, 2022•
edited
Loading

christinahedges commented Feb 3, 2022•
edited
Loading

christinahedges commented Feb 3, 2022•
edited
Loading

christinahedges commented Feb 3, 2022•
edited
Loading