Skip to content

"Follows You" update to feature version 2 - #490

Open
Wilamaxin wants to merge 4 commits into
mainfrom
follows-you
Open

"Follows You" update to feature version 2#490
Wilamaxin wants to merge 4 commits into
mainfrom
follows-you

Conversation

@Wilamaxin

Copy link
Copy Markdown
Collaborator

This feature has some visibility issues when used along with Scratch Addons addon "Profile Banner". I couldn't fix that. Any ideas on how to fix that are welcome.

This feature has some visibility issues when used along with Scratch Addons addon "Profile Banner". I couldn't fix that. Any ideas on how to fix that are welcome.
Fixes visibility issue that occurred when used with Scratch Addons addon "Profile Banner" enabled.
@Wilamaxin

Copy link
Copy Markdown
CollaboratorAuthor

Issue fixed.

@rgantzosrgantzos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You updated multiple features in features.json.

@Wilamaxin

Copy link
Copy Markdown
CollaboratorAuthor

You updated multiple features in features.json.

That's the only way I can do it (please tell me if there is any other way that wouldn't cause file conflicts). Keep in mind that all PRs should be merged in the order I requested them.

@Wilamaxin

Copy link
Copy Markdown
CollaboratorAuthor

I can also not edit features.json. at all and keep it up to someone else to change when merging (then the order can be arbitrary)

@Wilamaxin
Wilamaxin requested a review from rgantzosMay 28, 2023 21:03
@Wilamaxin

Copy link
Copy Markdown
CollaboratorAuthor

File conflict example #489

@Wilamaxin

Copy link
Copy Markdown
CollaboratorAuthor

@rgantzos then what should I do?

@rgantzosrgantzos added priority: 3 Least important. status: needs review Waiting for further review. scope: feature type: enhancement Makes an existing feature better and removed priority: 3 Least important. labels Jun 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: featurestatus: needs reviewWaiting for further review.type: enhancementMakes an existing feature better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Wilamaxin@rgantzos