Skip to content

Improved overflow support - #20

Merged
DavyLandman merged 136 commits into
mainfrom
improved-overflow-support-main
Apr 7, 2025
Merged

Improved overflow support#20
DavyLandman merged 136 commits into
mainfrom
improved-overflow-support-main

Conversation

@sungshik

@sungshiksungshik commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Content

This is the main PR to address #12. It consists of the following auxiliary PRs:

Tasks

Features:

  • Test this situation (i.e., when watching a single file: overflow in parent directory triggers overflow for file)
  • Make it possible to distinguish original events from synthetic events (comment)? -- Not needed for now

Code quality:

Performance:

@codecov

codecovBot commented Feb 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.93842% with 65 lines in your changes missing coverage. Please review.

Project coverage is 80.7%. Comparing base (e23a194) to head (3afc76f).
Report is 138 commits behind head on main.

Files with missing linesPatch %Lines
...ineering/swat/watch/impl/jdk/JDKFileTreeWatch.java74.7%19 Missing and 10 partials ⚠️
...g/swat/watch/impl/overflows/IndexingRescanner.java79.5%12 Missing and 7 partials ⚠️
...ing/swat/watch/impl/overflows/BaseFileVisitor.java64.7%5 Missing and 1 partial ⚠️
src/main/java/engineering/swat/watch/Watcher.java84.6%2 Missing and 2 partials ⚠️
.../engineering/swat/watch/impl/jdk/JDKBaseWatch.java82.3%1 Missing and 2 partials ⚠️
.../engineering/swat/watch/impl/jdk/JDKFileWatch.java88.2%1 Missing and 1 partial ⚠️
...c/main/java/engineering/swat/watch/WatchEvent.java87.5%0 Missing and 1 partial ⚠️
...neering/swat/watch/impl/jdk/JDKDirectoryWatch.java91.6%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #20 +/- ##
=========================================
+ Coverage 80.0% 80.7% +0.7% - Complexity 88 131 +43 
=========================================
Files 11 16 +5 Lines 415 567 +152 Branches 41 64 +23 =========================================
+ Hits 332 458 +126 - Misses 57 69 +12 - Partials 26 40 +14 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sungshiksungshik changed the title Improved overflow support mainImproved overflow supportFeb 24, 2025
sungshikand others added 4 commits February 24, 2025 12:06
…roved-overflow-support/event-handlers-with-active-watch
…t/richer-active-watch
Improved overflow support: Internal `EventHandlingWatch` interface
sungshikand others added 3 commits February 24, 2025 14:10
sungshikand others added 3 commits March 26, 2025 16:57
…t/fix-delete-detection-in-indexing-rescanner
Improved overflow support: Fix detection of `DELETED` events in `IndexingRescanner`
…t/jdk-file-tree-watch
Improved overflow support: Recursive directory watches

@DavyLandmanDavyLandman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good, 2 small comments

Comment threadsrc/main/java/engineering/swat/watch/Watcher.java Outdated
sungshikand others added 19 commits March 28, 2025 13:40
…t-modified-times only when the files involved truly exist
…t/parameterized-torture-tests
Improved overflow support: Parameterized torture tests
…t/update-readme
Improved overflow support: Update README
@sungshik
sungshik marked this pull request as ready for review April 7, 2025 12:21
@DavyLandman
DavyLandman merged commit 111c161 into mainApr 7, 2025
@sungshik
sungshik deleted the improved-overflow-support-main branch April 11, 2025 08:38
@sungshiksungshik mentioned this pull request Apr 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sungshik@DavyLandman