Skip to content

Improved macOS support - #39

Merged
DavyLandman merged 57 commits into
mainfrom
improved-macos-support-main
May 12, 2025
Merged

Improved macOS support#39
DavyLandman merged 57 commits into
mainfrom
improved-macos-support-main

Conversation

@sungshik

@sungshiksungshik commented Apr 21, 2025

Copy link
Copy Markdown
Contributor

Overview

This is the main PR to address #4. Helper PRs:

Tasks

@codecov

codecovBot commented Apr 21, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 82.44275% with 46 lines in your changes missing coverage. Please review.

Project coverage is 81.6%. Comparing base (ec14259) to head (97dc29d).
Report is 58 commits behind head on main.

Files with missing linesPatch %Lines
...a/engineering/swat/watch/impl/mac/MacWatchKey.java80.6%4 Missing and 8 partials ⚠️
...neering/swat/watch/impl/mac/NativeEventStream.java87.2%4 Missing and 8 partials ⚠️
.../engineering/swat/watch/impl/mac/MacWatchable.java56.5%8 Missing and 2 partials ⚠️
...ava/engineering/swat/watch/impl/jdk/JDKPoller.java73.9%2 Missing and 4 partials ⚠️
...gineering/swat/watch/impl/mac/MacWatchService.java53.8%5 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #39 +/- ##
=========================================
+ Coverage 80.8% 81.6% +0.8% - Complexity 135 163 +28 
=========================================
Files 16 23 +7 Lines 568 827 +259 Branches 66 97 +31 =========================================
+ Hits 459 675 +216 - Misses 69 91 +22 - Partials 40 61 +21 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sungshikand others added 27 commits April 21, 2025 09:04
…n FS event stream using the native macOS APIs
…at fully implements the `java.nio.file.WatchService` interface
…io-file-watch-service
Improved macOS support: `java.nio.file` Watch Service
Comment thread.github/workflows/build.yaml
Comment threadREADME.md Outdated

@DavyLandmanDavyLandman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things I noticed.

Comment threadREADME.md Outdated
Comment threadpom.xml Outdated
Comment threadsrc/test/java/engineering/swat/watch/SmokeTests.java Outdated
@sungshik
sungshik marked this pull request as ready for review May 12, 2025 11:02
@DavyLandman
DavyLandman merged commit 042298e into mainMay 12, 2025
@DavyLandman
DavyLandman deleted the improved-macos-support-main branch May 12, 2025 13:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sungshik@DavyLandman