Uh oh!
There was an error while loading. Please reload this page.
fix(web): keep sidebar version and trash tab visible - #176
Conversation
📝 WalkthroughWalkthroughRemoves the sidebar ChangesSidebar Brand and Ghost Tab UI Update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
awsl233777
commented
May 28, 2026
Implemented the requested Web UI sidebar updates:
Validation actually run:
Remaining gate: GitHub review is still required; CodeRabbit is currently processing. @coderabbitai review |
(≡^ω^≡) ✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web-ui/partials/index/layout-header.html`:
- Line 121: The static brand container div with class "brand-block" currently
has tabindex="0" making it an unnecessary keyboard focus stop; remove the
tabindex attribute from the <div class="brand-block"> in layout-header.html so
it is no longer focusable, and if the brand must be interactive instead replace
the div with a semantic interactive element (e.g., <a> or <button>) and move any
event handlers/ARIA to that element.
In `@web-ui/res/web-ui-render.precompiled.js`:
- Line 170: The brand container div.brand-block currently has tabindex="0" which
creates an unnecessary keyboard focus stop even though it is non-interactive;
remove the tabindex attribute (or set it to -1 only if you need to preserve
programmatic focus) from the div.brand-block in the generated template/function
that emits the markup so the element is no longer keyboard-focusable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 32662854-327e-4c28-b39f-0a3ddc41e2d6
📒 Files selected for processing (7)
TODO.mdtests/unit/config-tabs-ui.test.mjstests/unit/web-ui-behavior-parity.test.mjsweb-ui/app.jsweb-ui/partials/index/layout-header.htmlweb-ui/res/web-ui-render.precompiled.jsweb-ui/styles/layout-shell.css
💤 Files with no reviewable changes (1)
- web-ui/app.js
📜 Review details
🔇 Additional comments (6)
web-ui/partials/index/layout-header.html (1)
125-125: LGTM!Also applies to: 131-134
web-ui/res/web-ui-render.precompiled.js (1)
2-2: LGTM!Also applies to: 181-186, 192-202
web-ui/styles/layout-shell.css (1)
418-424: LGTM!Also applies to: 495-495, 513-517
tests/unit/config-tabs-ui.test.mjs (1)
21-22: LGTM!Also applies to: 124-138
tests/unit/web-ui-behavior-parity.test.mjs (1)
411-412: LGTM!TODO.md (1)
1-5: LGTM!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
awsl233777
commented
May 28, 2026
Addressed CodeRabbit's actionable feedback:
Validation actually run after the fix:
@coderabbitai review |
(≡^‥^≡) ✅ Actions performedReview triggered.
|
awsl233777
commented
May 28, 2026
Updated the sidebar ghost tab placement. Changes:
Verification actually run:
@coderabbitai re-review |
(≡^‥^≡) ✅ Actions performedReview triggered.
|
awsl233777
commented
May 28, 2026
Follow-up docs cleanup per request. Changes:
Verification actually run:
@coderabbitai re-review |
(≡^‥^≡) ✅ Actions performedReview triggered.
|
awsl233777
commented
May 28, 2026
Version/tag follow-up. Changes:
Verification actually run:
@coderabbitai re-review |
(≡^‥^≡) ✅ Actions performedReview triggered.
|
Uh oh!
There was an error while loading. Please reload this page.
Summary
回收站tab can scroll fully above the fixed language controls.Codex Mateversion visible without hover state and slightly refine brand/version sizing.codexmate setupquick-start command from both README files.0.0.37and remove the temporary trackedTODO.mdfile.Fixes#175
Validation
npm run test:unit— all 530 unit tests passed.npm run lint— 300 files passed.git diff --check— passed.回收站is fully visible after scrolling the sidebar to the end.0.0.35/0.0.36no longer appear in the checked package metadata targets.