fix(security): decrypt gradebook-create + profile-settings responses (#126 #18, #19) by Jose-Gael-Cruz-Lopez · Pull Request #227 · SaplingLearn/Sapling

Jose-Gael-Cruz-Lopez · 2026-06-13T05:13:59Z

Part of #126 (findings #18 & #19, both LOW). Second of the two #126 PRs (the HIGH plaintext-write is #226).

Two response-boundary leaks (owner-only, not cross-user)

Bug: Classes add themselves as nodes in learn tab #18 — gradebook.create_assignment returned inserted[0], i.e. the stored ciphertext for points_possible/points_earned/notes, with no decrypt. (Masked today only because Course.tsx reloads and discards the response.)
Bug: "Upload Assignments" button on dashboard leads to syllabus upload popup #19 — profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — so bio/location came back as ciphertext.

Fixes

gradebook: decrypt the inserted row's points/notes before returning, mirroring get_course's read path (decrypt_numeric/decrypt_if_present, already imported).
profile: return through the decrypting _get_or_create_settings(user_id) helper instead of a raw select.

Tests

tests/test_response_decrypt_boundary.py: both assert the response carries plaintext, not the stored ciphertext. Both fail on pre-fix code (ciphertext returned). Full gradebook + profile route suites pass (51 tests).

⚠️ Encryption-boundary change — do not merge, opened for your review.

…126 #18, #19) Two response-boundary leaks where an encrypted column was returned to the authenticated owner as ciphertext: - gradebook create_assignment returned inserted[0] (the stored ciphertext for points_possible/points_earned/notes) with no decrypt. Decrypt the inserted row before returning, matching get_course's read path. - profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — bio/location came back as ciphertext. Return through the decrypting _get_or_create_settings helper. Both are owner-only correctness gaps (not cross-user). Tests assert the response carries decrypted plaintext; both fail pre-fix (ciphertext).

coderabbitai · 2026-06-13T05:14:06Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7136e3b-c0d2-473c-97da-b7ea8bd12130

📥 Commits

Reviewing files that changed from the base of the PR and between a27b688 and dae4179.

📒 Files selected for processing (3)

backend/routes/gradebook.py
backend/routes/profile.py
backend/tests/test_response_decrypt_boundary.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch security/126b-decrypt-responses

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2026-06-13T05:16:12Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend	`dae4179`	Commit Preview URL Branch Preview URL	Jun 13 2026, 05:16 AM

Jose-Gael-Cruz-Lopez · 2026-06-13T05:13:59Z

Part of #126 (findings #18 & #19, both LOW). Second of the two #126 PRs (the HIGH plaintext-write is #226).

Two response-boundary leaks (owner-only, not cross-user)

Bug: Classes add themselves as nodes in learn tab #18 — gradebook.create_assignment returned inserted[0], i.e. the stored ciphertext for points_possible/points_earned/notes, with no decrypt. (Masked today only because Course.tsx reloads and discards the response.)
Bug: "Upload Assignments" button on dashboard leads to syllabus upload popup #19 — profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — so bio/location came back as ciphertext.

Fixes

gradebook: decrypt the inserted row's points/notes before returning, mirroring get_course's read path (decrypt_numeric/decrypt_if_present, already imported).
profile: return through the decrypting _get_or_create_settings(user_id) helper instead of a raw select.

Tests

tests/test_response_decrypt_boundary.py: both assert the response carries plaintext, not the stored ciphertext. Both fail on pre-fix code (ciphertext returned). Full gradebook + profile route suites pass (51 tests).

⚠️ Encryption-boundary change — do not merge, opened for your review.

…126 #18, #19) Two response-boundary leaks where an encrypted column was returned to the authenticated owner as ciphertext: - gradebook create_assignment returned inserted[0] (the stored ciphertext for points_possible/points_earned/notes) with no decrypt. Decrypt the inserted row before returning, matching get_course's read path. - profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — bio/location came back as ciphertext. Return through the decrypting _get_or_create_settings helper. Both are owner-only correctness gaps (not cross-user). Tests assert the response carries decrypted plaintext; both fail pre-fix (ciphertext).

coderabbitai · 2026-06-13T05:14:06Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7136e3b-c0d2-473c-97da-b7ea8bd12130

📥 Commits

Reviewing files that changed from the base of the PR and between a27b688 and dae4179.

📒 Files selected for processing (3)

backend/routes/gradebook.py
backend/routes/profile.py
backend/tests/test_response_decrypt_boundary.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch security/126b-decrypt-responses

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2026-06-13T05:16:12Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend	`dae4179`	Commit Preview URL Branch Preview URL	Jun 13 2026, 05:16 AM

Jose-Gael-Cruz-Lopez · 2026-06-13T05:13:59Z

Part of #126 (findings #18 & #19, both LOW). Second of the two #126 PRs (the HIGH plaintext-write is #226).

Two response-boundary leaks (owner-only, not cross-user)

Bug: Classes add themselves as nodes in learn tab #18 — gradebook.create_assignment returned inserted[0], i.e. the stored ciphertext for points_possible/points_earned/notes, with no decrypt. (Masked today only because Course.tsx reloads and discards the response.)
Bug: "Upload Assignments" button on dashboard leads to syllabus upload popup #19 — profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — so bio/location came back as ciphertext.

Fixes

gradebook: decrypt the inserted row's points/notes before returning, mirroring get_course's read path (decrypt_numeric/decrypt_if_present, already imported).
profile: return through the decrypting _get_or_create_settings(user_id) helper instead of a raw select.

Tests

tests/test_response_decrypt_boundary.py: both assert the response carries plaintext, not the stored ciphertext. Both fail on pre-fix code (ciphertext returned). Full gradebook + profile route suites pass (51 tests).

⚠️ Encryption-boundary change — do not merge, opened for your review.

…126 #18, #19) Two response-boundary leaks where an encrypted column was returned to the authenticated owner as ciphertext: - gradebook create_assignment returned inserted[0] (the stored ciphertext for points_possible/points_earned/notes) with no decrypt. Decrypt the inserted row before returning, matching get_course's read path. - profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — bio/location came back as ciphertext. Return through the decrypting _get_or_create_settings helper. Both are owner-only correctness gaps (not cross-user). Tests assert the response carries decrypted plaintext; both fail pre-fix (ciphertext).

coderabbitai · 2026-06-13T05:14:06Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7136e3b-c0d2-473c-97da-b7ea8bd12130

📥 Commits

Reviewing files that changed from the base of the PR and between a27b688 and dae4179.

📒 Files selected for processing (3)

backend/routes/gradebook.py
backend/routes/profile.py
backend/tests/test_response_decrypt_boundary.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch security/126b-decrypt-responses

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2026-06-13T05:16:12Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend	`dae4179`	Commit Preview URL Branch Preview URL	Jun 13 2026, 05:16 AM

Jose-Gael-Cruz-Lopez · 2026-06-13T05:13:59Z

Part of #126 (findings #18 & #19, both LOW). Second of the two #126 PRs (the HIGH plaintext-write is #226).

Two response-boundary leaks (owner-only, not cross-user)

Bug: Classes add themselves as nodes in learn tab #18 — gradebook.create_assignment returned inserted[0], i.e. the stored ciphertext for points_possible/points_earned/notes, with no decrypt. (Masked today only because Course.tsx reloads and discards the response.)
Bug: "Upload Assignments" button on dashboard leads to syllabus upload popup #19 — profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — so bio/location came back as ciphertext.

Fixes

gradebook: decrypt the inserted row's points/notes before returning, mirroring get_course's read path (decrypt_numeric/decrypt_if_present, already imported).
profile: return through the decrypting _get_or_create_settings(user_id) helper instead of a raw select.

Tests

tests/test_response_decrypt_boundary.py: both assert the response carries plaintext, not the stored ciphertext. Both fail on pre-fix code (ciphertext returned). Full gradebook + profile route suites pass (51 tests).

⚠️ Encryption-boundary change — do not merge, opened for your review.

…126 #18, #19) Two response-boundary leaks where an encrypted column was returned to the authenticated owner as ciphertext: - gradebook create_assignment returned inserted[0] (the stored ciphertext for points_possible/points_earned/notes) with no decrypt. Decrypt the inserted row before returning, matching get_course's read path. - profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — bio/location came back as ciphertext. Return through the decrypting _get_or_create_settings helper. Both are owner-only correctness gaps (not cross-user). Tests assert the response carries decrypted plaintext; both fail pre-fix (ciphertext).

coderabbitai · 2026-06-13T05:14:06Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7136e3b-c0d2-473c-97da-b7ea8bd12130

📥 Commits

Reviewing files that changed from the base of the PR and between a27b688 and dae4179.

📒 Files selected for processing (3)

backend/routes/gradebook.py
backend/routes/profile.py
backend/tests/test_response_decrypt_boundary.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch security/126b-decrypt-responses

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2026-06-13T05:16:12Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend	`dae4179`	Commit Preview URL Branch Preview URL	Jun 13 2026, 05:16 AM

Jose-Gael-Cruz-Lopez · 2026-06-13T05:13:59Z

Part of #126 (findings #18 & #19, both LOW). Second of the two #126 PRs (the HIGH plaintext-write is #226).

Two response-boundary leaks (owner-only, not cross-user)

Bug: Classes add themselves as nodes in learn tab #18 — gradebook.create_assignment returned inserted[0], i.e. the stored ciphertext for points_possible/points_earned/notes, with no decrypt. (Masked today only because Course.tsx reloads and discards the response.)
Bug: "Upload Assignments" button on dashboard leads to syllabus upload popup #19 — profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — so bio/location came back as ciphertext.

Fixes

gradebook: decrypt the inserted row's points/notes before returning, mirroring get_course's read path (decrypt_numeric/decrypt_if_present, already imported).
profile: return through the decrypting _get_or_create_settings(user_id) helper instead of a raw select.

Tests

tests/test_response_decrypt_boundary.py: both assert the response carries plaintext, not the stored ciphertext. Both fail on pre-fix code (ciphertext returned). Full gradebook + profile route suites pass (51 tests).

⚠️ Encryption-boundary change — do not merge, opened for your review.

…126 #18, #19) Two response-boundary leaks where an encrypted column was returned to the authenticated owner as ciphertext: - gradebook create_assignment returned inserted[0] (the stored ciphertext for points_possible/points_earned/notes) with no decrypt. Decrypt the inserted row before returning, matching get_course's read path. - profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — bio/location came back as ciphertext. Return through the decrypting _get_or_create_settings helper. Both are owner-only correctness gaps (not cross-user). Tests assert the response carries decrypted plaintext; both fail pre-fix (ciphertext).

coderabbitai · 2026-06-13T05:14:06Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7136e3b-c0d2-473c-97da-b7ea8bd12130

📥 Commits

Reviewing files that changed from the base of the PR and between a27b688 and dae4179.

📒 Files selected for processing (3)

backend/routes/gradebook.py
backend/routes/profile.py
backend/tests/test_response_decrypt_boundary.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch security/126b-decrypt-responses

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2026-06-13T05:16:12Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend	`dae4179`	Commit Preview URL Branch Preview URL	Jun 13 2026, 05:16 AM

Jose-Gael-Cruz-Lopez · 2026-06-13T05:13:59Z

Part of #126 (findings #18 & #19, both LOW). Second of the two #126 PRs (the HIGH plaintext-write is #226).

Two response-boundary leaks (owner-only, not cross-user)

Bug: Classes add themselves as nodes in learn tab #18 — gradebook.create_assignment returned inserted[0], i.e. the stored ciphertext for points_possible/points_earned/notes, with no decrypt. (Masked today only because Course.tsx reloads and discards the response.)
Bug: "Upload Assignments" button on dashboard leads to syllabus upload popup #19 — profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — so bio/location came back as ciphertext.

Fixes

gradebook: decrypt the inserted row's points/notes before returning, mirroring get_course's read path (decrypt_numeric/decrypt_if_present, already imported).
profile: return through the decrypting _get_or_create_settings(user_id) helper instead of a raw select.

Tests

tests/test_response_decrypt_boundary.py: both assert the response carries plaintext, not the stored ciphertext. Both fail on pre-fix code (ciphertext returned). Full gradebook + profile route suites pass (51 tests).

⚠️ Encryption-boundary change — do not merge, opened for your review.

…126 #18, #19) Two response-boundary leaks where an encrypted column was returned to the authenticated owner as ciphertext: - gradebook create_assignment returned inserted[0] (the stored ciphertext for points_possible/points_earned/notes) with no decrypt. Decrypt the inserted row before returning, matching get_course's read path. - profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — bio/location came back as ciphertext. Return through the decrypting _get_or_create_settings helper. Both are owner-only correctness gaps (not cross-user). Tests assert the response carries decrypted plaintext; both fail pre-fix (ciphertext).

coderabbitai · 2026-06-13T05:14:06Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7136e3b-c0d2-473c-97da-b7ea8bd12130

📥 Commits

Reviewing files that changed from the base of the PR and between a27b688 and dae4179.

📒 Files selected for processing (3)

backend/routes/gradebook.py
backend/routes/profile.py
backend/tests/test_response_decrypt_boundary.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch security/126b-decrypt-responses

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2026-06-13T05:16:12Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend	`dae4179`	Commit Preview URL Branch Preview URL	Jun 13 2026, 05:16 AM

Jose-Gael-Cruz-Lopez · 2026-06-13T05:13:59Z

Part of #126 (findings #18 & #19, both LOW). Second of the two #126 PRs (the HIGH plaintext-write is #226).

Two response-boundary leaks (owner-only, not cross-user)

Bug: Classes add themselves as nodes in learn tab #18 — gradebook.create_assignment returned inserted[0], i.e. the stored ciphertext for points_possible/points_earned/notes, with no decrypt. (Masked today only because Course.tsx reloads and discards the response.)
Bug: "Upload Assignments" button on dashboard leads to syllabus upload popup #19 — profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — so bio/location came back as ciphertext.

Fixes

gradebook: decrypt the inserted row's points/notes before returning, mirroring get_course's read path (decrypt_numeric/decrypt_if_present, already imported).
profile: return through the decrypting _get_or_create_settings(user_id) helper instead of a raw select.

Tests

tests/test_response_decrypt_boundary.py: both assert the response carries plaintext, not the stored ciphertext. Both fail on pre-fix code (ciphertext returned). Full gradebook + profile route suites pass (51 tests).

⚠️ Encryption-boundary change — do not merge, opened for your review.

…126 #18, #19) Two response-boundary leaks where an encrypted column was returned to the authenticated owner as ciphertext: - gradebook create_assignment returned inserted[0] (the stored ciphertext for points_possible/points_earned/notes) with no decrypt. Decrypt the inserted row before returning, matching get_course's read path. - profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — bio/location came back as ciphertext. Return through the decrypting _get_or_create_settings helper. Both are owner-only correctness gaps (not cross-user). Tests assert the response carries decrypted plaintext; both fail pre-fix (ciphertext).

coderabbitai · 2026-06-13T05:14:06Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7136e3b-c0d2-473c-97da-b7ea8bd12130

📥 Commits

Reviewing files that changed from the base of the PR and between a27b688 and dae4179.

📒 Files selected for processing (3)

backend/routes/gradebook.py
backend/routes/profile.py
backend/tests/test_response_decrypt_boundary.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch security/126b-decrypt-responses

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2026-06-13T05:16:12Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend	`dae4179`	Commit Preview URL Branch Preview URL	Jun 13 2026, 05:16 AM

Jose-Gael-Cruz-Lopez · 2026-06-13T05:13:59Z

Part of #126 (findings #18 & #19, both LOW). Second of the two #126 PRs (the HIGH plaintext-write is #226).

Two response-boundary leaks (owner-only, not cross-user)

Bug: Classes add themselves as nodes in learn tab #18 — gradebook.create_assignment returned inserted[0], i.e. the stored ciphertext for points_possible/points_earned/notes, with no decrypt. (Masked today only because Course.tsx reloads and discards the response.)
Bug: "Upload Assignments" button on dashboard leads to syllabus upload popup #19 — profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — so bio/location came back as ciphertext.

Fixes

gradebook: decrypt the inserted row's points/notes before returning, mirroring get_course's read path (decrypt_numeric/decrypt_if_present, already imported).
profile: return through the decrypting _get_or_create_settings(user_id) helper instead of a raw select.

Tests

tests/test_response_decrypt_boundary.py: both assert the response carries plaintext, not the stored ciphertext. Both fail on pre-fix code (ciphertext returned). Full gradebook + profile route suites pass (51 tests).

⚠️ Encryption-boundary change — do not merge, opened for your review.

…126 #18, #19) Two response-boundary leaks where an encrypted column was returned to the authenticated owner as ciphertext: - gradebook create_assignment returned inserted[0] (the stored ciphertext for points_possible/points_earned/notes) with no decrypt. Decrypt the inserted row before returning, matching get_course's read path. - profile PATCH /settings returned a raw _SETTINGS_COLS select with no decrypt, unlike GET — bio/location came back as ciphertext. Return through the decrypting _get_or_create_settings helper. Both are owner-only correctness gaps (not cross-user). Tests assert the response carries decrypted plaintext; both fail pre-fix (ciphertext).

coderabbitai · 2026-06-13T05:14:06Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7136e3b-c0d2-473c-97da-b7ea8bd12130

📥 Commits

Reviewing files that changed from the base of the PR and between a27b688 and dae4179.

📒 Files selected for processing (3)

backend/routes/gradebook.py
backend/routes/profile.py
backend/tests/test_response_decrypt_boundary.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch security/126b-decrypt-responses

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2026-06-13T05:16:12Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend	`dae4179`	Commit Preview URL Branch Preview URL	Jun 13 2026, 05:16 AM

Jose-Gael-Cruz-Lopez merged commit 926d0fd into mainJun 14, 2026
6 checks passed

Jose-Gael-Cruz-Lopez deleted the security/126b-decrypt-responses branch June 14, 2026 02:17