chore(db): re-runnable cosmetics migration + ordered migration runner (#196, #197) by Jose-Gael-Cruz-Lopez · Pull Request #251 · SaplingLearn/Sapling

Jose-Gael-Cruz-Lopez · 2026-06-22T04:08:59Z

Two migration-hygiene fixes from the backend audit.

#196 — `migration_cosmetics.sql` is now idempotent

The five ALTER TABLE user_settings ADD CONSTRAINT fk_… statements were bare; Postgres has no ADD CONSTRAINT IF NOT EXISTS, so a second run aborted with "constraint already exists" (and, un-transactioned, left ambiguous partial state). Each is now wrapped in the DO $$ … IF NOT EXISTS (SELECT 1 FROM pg_constraint …) guard already used in migration_gradebook.sql, so the migration is safely re-runnable.

#197 — deterministic ordering + applied-migration ledger

Ordering lived only in prose headers, the root drift hazard behind the schema↔migration discrepancies elsewhere in the audit. This introduces:

schema_migrations(version, applied_at) ledger — new migration_schema_migrations.sql + mirrored into supabase_schema.sql.
db/migrate.py — an explicit ordered MANIFEST and a runner that applies each pending migration exactly once, in order, recording it. --status inspects without writing; --apply runs pending ones (needs a direct DATABASE_URL + psycopg, lazily imported — the PostgREST client can't run DDL).
db/MIGRATIONS.md — documents the baseline/ledger/runner model and the "add a migration" checklist.

supabase_schema.sql remains the canonical baseline for fresh databases; the runner governs the incremental files going forward.

Tests

test_migration_runner.py — manifest covers everymigration_*.sql (no orphan/phantom/dupe), the known drop-legacy → gradebook order holds, pending() excludes applied + preserves order, and all five cosmetics FKs are guarded.

Verification

ruff check . clean; gated suite green (+7 new); python -m db.migrate --status runs with no DB.

Closes#196, #197.

…s migration (#196)

…ation (#196)

…migration (#196)

…tion (#196)

…cs migration (#196)

…fest (#197)

…idempotency (#196, #197)

coderabbitai · 2026-06-22T04:09:08Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e54a88c-3818-46e8-a8e9-03d56b037a7c

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and dd97fac.

📒 Files selected for processing (3)

backend/db/MIGRATIONS.md
backend/db/migration_schema_migrations.sql
backend/db/migrations/0001_baseline_schema.sql

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/migration-hygiene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cloudflare-workers-and-pages · 2026-06-22T04:11:15Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
❌ Deployment failed View logs	frontend	`d225b53`	Jun 22 2026, 04:11 AM

Previously --status ran the ledger CREATE TABLE IF NOT EXISTS inside the psycopg connection context, which commits on a clean exit and created the schema_migrations table as a side effect — contradicting the documented "no DB writes" contract. Check information_schema for the ledger instead and treat a missing table as zero applied migrations.

Without DATABASE_URL, --apply passed an empty connection string to psycopg.connect(""), which silently falls back to libpq env defaults (PGHOST, local socket) and yields a confusing connection error or an unintended connection. Fail fast with a clear message instead.

cloudflare-workers-and-pages · 2026-06-24T04:51:51Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	`dd97fac`	Commit Preview URL Branch Preview URL	Jun 24 2026, 02:46 PM

# Conflicts: # backend/db/migrate.py # backend/db/migrations/0009_cosmetics.sql

…main

AndresL230 · 2026-06-25T02:53:17Z

Largely superseded. The ordered migration runner (#197) already landed as #252 (it's what the redesign uses), and the cosmetics re-runnability concern (#196) is mooted by the runner's applied-migration ledger (each file applies once). Closing — reopen if the cosmetics idempotency fix is still needed standalone.

Jose-Gael-Cruz-Lopez · 2026-06-22T04:08:59Z

Two migration-hygiene fixes from the backend audit.

#196 — `migration_cosmetics.sql` is now idempotent

The five ALTER TABLE user_settings ADD CONSTRAINT fk_… statements were bare; Postgres has no ADD CONSTRAINT IF NOT EXISTS, so a second run aborted with "constraint already exists" (and, un-transactioned, left ambiguous partial state). Each is now wrapped in the DO $$ … IF NOT EXISTS (SELECT 1 FROM pg_constraint …) guard already used in migration_gradebook.sql, so the migration is safely re-runnable.

#197 — deterministic ordering + applied-migration ledger

Ordering lived only in prose headers, the root drift hazard behind the schema↔migration discrepancies elsewhere in the audit. This introduces:

schema_migrations(version, applied_at) ledger — new migration_schema_migrations.sql + mirrored into supabase_schema.sql.
db/migrate.py — an explicit ordered MANIFEST and a runner that applies each pending migration exactly once, in order, recording it. --status inspects without writing; --apply runs pending ones (needs a direct DATABASE_URL + psycopg, lazily imported — the PostgREST client can't run DDL).
db/MIGRATIONS.md — documents the baseline/ledger/runner model and the "add a migration" checklist.

supabase_schema.sql remains the canonical baseline for fresh databases; the runner governs the incremental files going forward.

Tests

test_migration_runner.py — manifest covers everymigration_*.sql (no orphan/phantom/dupe), the known drop-legacy → gradebook order holds, pending() excludes applied + preserves order, and all five cosmetics FKs are guarded.

Verification

ruff check . clean; gated suite green (+7 new); python -m db.migrate --status runs with no DB.

Closes#196, #197.

…s migration (#196)

…ation (#196)

…migration (#196)

…tion (#196)

…cs migration (#196)

…fest (#197)

…idempotency (#196, #197)

coderabbitai · 2026-06-22T04:09:08Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e54a88c-3818-46e8-a8e9-03d56b037a7c

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and dd97fac.

📒 Files selected for processing (3)

backend/db/MIGRATIONS.md
backend/db/migration_schema_migrations.sql
backend/db/migrations/0001_baseline_schema.sql

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/migration-hygiene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cloudflare-workers-and-pages · 2026-06-22T04:11:15Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
❌ Deployment failed View logs	frontend	`d225b53`	Jun 22 2026, 04:11 AM

Previously --status ran the ledger CREATE TABLE IF NOT EXISTS inside the psycopg connection context, which commits on a clean exit and created the schema_migrations table as a side effect — contradicting the documented "no DB writes" contract. Check information_schema for the ledger instead and treat a missing table as zero applied migrations.

Without DATABASE_URL, --apply passed an empty connection string to psycopg.connect(""), which silently falls back to libpq env defaults (PGHOST, local socket) and yields a confusing connection error or an unintended connection. Fail fast with a clear message instead.

cloudflare-workers-and-pages · 2026-06-24T04:51:51Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	`dd97fac`	Commit Preview URL Branch Preview URL	Jun 24 2026, 02:46 PM

# Conflicts: # backend/db/migrate.py # backend/db/migrations/0009_cosmetics.sql

…main

AndresL230 · 2026-06-25T02:53:17Z

Largely superseded. The ordered migration runner (#197) already landed as #252 (it's what the redesign uses), and the cosmetics re-runnability concern (#196) is mooted by the runner's applied-migration ledger (each file applies once). Closing — reopen if the cosmetics idempotency fix is still needed standalone.

Jose-Gael-Cruz-Lopez · 2026-06-22T04:08:59Z

Two migration-hygiene fixes from the backend audit.

#196 — `migration_cosmetics.sql` is now idempotent

The five ALTER TABLE user_settings ADD CONSTRAINT fk_… statements were bare; Postgres has no ADD CONSTRAINT IF NOT EXISTS, so a second run aborted with "constraint already exists" (and, un-transactioned, left ambiguous partial state). Each is now wrapped in the DO $$ … IF NOT EXISTS (SELECT 1 FROM pg_constraint …) guard already used in migration_gradebook.sql, so the migration is safely re-runnable.

#197 — deterministic ordering + applied-migration ledger

Ordering lived only in prose headers, the root drift hazard behind the schema↔migration discrepancies elsewhere in the audit. This introduces:

schema_migrations(version, applied_at) ledger — new migration_schema_migrations.sql + mirrored into supabase_schema.sql.
db/migrate.py — an explicit ordered MANIFEST and a runner that applies each pending migration exactly once, in order, recording it. --status inspects without writing; --apply runs pending ones (needs a direct DATABASE_URL + psycopg, lazily imported — the PostgREST client can't run DDL).
db/MIGRATIONS.md — documents the baseline/ledger/runner model and the "add a migration" checklist.

supabase_schema.sql remains the canonical baseline for fresh databases; the runner governs the incremental files going forward.

Tests

test_migration_runner.py — manifest covers everymigration_*.sql (no orphan/phantom/dupe), the known drop-legacy → gradebook order holds, pending() excludes applied + preserves order, and all five cosmetics FKs are guarded.

Verification

ruff check . clean; gated suite green (+7 new); python -m db.migrate --status runs with no DB.

Closes#196, #197.

…s migration (#196)

…ation (#196)

…migration (#196)

…tion (#196)

…cs migration (#196)

…fest (#197)

…idempotency (#196, #197)

coderabbitai · 2026-06-22T04:09:08Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e54a88c-3818-46e8-a8e9-03d56b037a7c

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and dd97fac.

📒 Files selected for processing (3)

backend/db/MIGRATIONS.md
backend/db/migration_schema_migrations.sql
backend/db/migrations/0001_baseline_schema.sql

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/migration-hygiene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cloudflare-workers-and-pages · 2026-06-22T04:11:15Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
❌ Deployment failed View logs	frontend	`d225b53`	Jun 22 2026, 04:11 AM

Previously --status ran the ledger CREATE TABLE IF NOT EXISTS inside the psycopg connection context, which commits on a clean exit and created the schema_migrations table as a side effect — contradicting the documented "no DB writes" contract. Check information_schema for the ledger instead and treat a missing table as zero applied migrations.

Without DATABASE_URL, --apply passed an empty connection string to psycopg.connect(""), which silently falls back to libpq env defaults (PGHOST, local socket) and yields a confusing connection error or an unintended connection. Fail fast with a clear message instead.

cloudflare-workers-and-pages · 2026-06-24T04:51:51Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	`dd97fac`	Commit Preview URL Branch Preview URL	Jun 24 2026, 02:46 PM

# Conflicts: # backend/db/migrate.py # backend/db/migrations/0009_cosmetics.sql

…main

AndresL230 · 2026-06-25T02:53:17Z

Largely superseded. The ordered migration runner (#197) already landed as #252 (it's what the redesign uses), and the cosmetics re-runnability concern (#196) is mooted by the runner's applied-migration ledger (each file applies once). Closing — reopen if the cosmetics idempotency fix is still needed standalone.

Jose-Gael-Cruz-Lopez · 2026-06-22T04:08:59Z

Two migration-hygiene fixes from the backend audit.

#196 — `migration_cosmetics.sql` is now idempotent

The five ALTER TABLE user_settings ADD CONSTRAINT fk_… statements were bare; Postgres has no ADD CONSTRAINT IF NOT EXISTS, so a second run aborted with "constraint already exists" (and, un-transactioned, left ambiguous partial state). Each is now wrapped in the DO $$ … IF NOT EXISTS (SELECT 1 FROM pg_constraint …) guard already used in migration_gradebook.sql, so the migration is safely re-runnable.

#197 — deterministic ordering + applied-migration ledger

Ordering lived only in prose headers, the root drift hazard behind the schema↔migration discrepancies elsewhere in the audit. This introduces:

schema_migrations(version, applied_at) ledger — new migration_schema_migrations.sql + mirrored into supabase_schema.sql.
db/migrate.py — an explicit ordered MANIFEST and a runner that applies each pending migration exactly once, in order, recording it. --status inspects without writing; --apply runs pending ones (needs a direct DATABASE_URL + psycopg, lazily imported — the PostgREST client can't run DDL).
db/MIGRATIONS.md — documents the baseline/ledger/runner model and the "add a migration" checklist.

supabase_schema.sql remains the canonical baseline for fresh databases; the runner governs the incremental files going forward.

Tests

test_migration_runner.py — manifest covers everymigration_*.sql (no orphan/phantom/dupe), the known drop-legacy → gradebook order holds, pending() excludes applied + preserves order, and all five cosmetics FKs are guarded.

Verification

ruff check . clean; gated suite green (+7 new); python -m db.migrate --status runs with no DB.

Closes#196, #197.

…s migration (#196)

…ation (#196)

…migration (#196)

…tion (#196)

…cs migration (#196)

…fest (#197)

…idempotency (#196, #197)

coderabbitai · 2026-06-22T04:09:08Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e54a88c-3818-46e8-a8e9-03d56b037a7c

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and dd97fac.

📒 Files selected for processing (3)

backend/db/MIGRATIONS.md
backend/db/migration_schema_migrations.sql
backend/db/migrations/0001_baseline_schema.sql

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/migration-hygiene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cloudflare-workers-and-pages · 2026-06-22T04:11:15Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
❌ Deployment failed View logs	frontend	`d225b53`	Jun 22 2026, 04:11 AM

Previously --status ran the ledger CREATE TABLE IF NOT EXISTS inside the psycopg connection context, which commits on a clean exit and created the schema_migrations table as a side effect — contradicting the documented "no DB writes" contract. Check information_schema for the ledger instead and treat a missing table as zero applied migrations.

Without DATABASE_URL, --apply passed an empty connection string to psycopg.connect(""), which silently falls back to libpq env defaults (PGHOST, local socket) and yields a confusing connection error or an unintended connection. Fail fast with a clear message instead.

cloudflare-workers-and-pages · 2026-06-24T04:51:51Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	`dd97fac`	Commit Preview URL Branch Preview URL	Jun 24 2026, 02:46 PM

# Conflicts: # backend/db/migrate.py # backend/db/migrations/0009_cosmetics.sql

…main

AndresL230 · 2026-06-25T02:53:17Z

Largely superseded. The ordered migration runner (#197) already landed as #252 (it's what the redesign uses), and the cosmetics re-runnability concern (#196) is mooted by the runner's applied-migration ledger (each file applies once). Closing — reopen if the cosmetics idempotency fix is still needed standalone.

Jose-Gael-Cruz-Lopez · 2026-06-22T04:08:59Z

Two migration-hygiene fixes from the backend audit.

#196 — `migration_cosmetics.sql` is now idempotent

The five ALTER TABLE user_settings ADD CONSTRAINT fk_… statements were bare; Postgres has no ADD CONSTRAINT IF NOT EXISTS, so a second run aborted with "constraint already exists" (and, un-transactioned, left ambiguous partial state). Each is now wrapped in the DO $$ … IF NOT EXISTS (SELECT 1 FROM pg_constraint …) guard already used in migration_gradebook.sql, so the migration is safely re-runnable.

#197 — deterministic ordering + applied-migration ledger

Ordering lived only in prose headers, the root drift hazard behind the schema↔migration discrepancies elsewhere in the audit. This introduces:

schema_migrations(version, applied_at) ledger — new migration_schema_migrations.sql + mirrored into supabase_schema.sql.
db/migrate.py — an explicit ordered MANIFEST and a runner that applies each pending migration exactly once, in order, recording it. --status inspects without writing; --apply runs pending ones (needs a direct DATABASE_URL + psycopg, lazily imported — the PostgREST client can't run DDL).
db/MIGRATIONS.md — documents the baseline/ledger/runner model and the "add a migration" checklist.

supabase_schema.sql remains the canonical baseline for fresh databases; the runner governs the incremental files going forward.

Tests

test_migration_runner.py — manifest covers everymigration_*.sql (no orphan/phantom/dupe), the known drop-legacy → gradebook order holds, pending() excludes applied + preserves order, and all five cosmetics FKs are guarded.

Verification

ruff check . clean; gated suite green (+7 new); python -m db.migrate --status runs with no DB.

Closes#196, #197.

…s migration (#196)

…ation (#196)

…migration (#196)

…tion (#196)

…cs migration (#196)

…fest (#197)

…idempotency (#196, #197)

coderabbitai · 2026-06-22T04:09:08Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e54a88c-3818-46e8-a8e9-03d56b037a7c

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and dd97fac.

📒 Files selected for processing (3)

backend/db/MIGRATIONS.md
backend/db/migration_schema_migrations.sql
backend/db/migrations/0001_baseline_schema.sql

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/migration-hygiene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cloudflare-workers-and-pages · 2026-06-22T04:11:15Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
❌ Deployment failed View logs	frontend	`d225b53`	Jun 22 2026, 04:11 AM

Previously --status ran the ledger CREATE TABLE IF NOT EXISTS inside the psycopg connection context, which commits on a clean exit and created the schema_migrations table as a side effect — contradicting the documented "no DB writes" contract. Check information_schema for the ledger instead and treat a missing table as zero applied migrations.

Without DATABASE_URL, --apply passed an empty connection string to psycopg.connect(""), which silently falls back to libpq env defaults (PGHOST, local socket) and yields a confusing connection error or an unintended connection. Fail fast with a clear message instead.

cloudflare-workers-and-pages · 2026-06-24T04:51:51Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	`dd97fac`	Commit Preview URL Branch Preview URL	Jun 24 2026, 02:46 PM

# Conflicts: # backend/db/migrate.py # backend/db/migrations/0009_cosmetics.sql

…main

AndresL230 · 2026-06-25T02:53:17Z

Largely superseded. The ordered migration runner (#197) already landed as #252 (it's what the redesign uses), and the cosmetics re-runnability concern (#196) is mooted by the runner's applied-migration ledger (each file applies once). Closing — reopen if the cosmetics idempotency fix is still needed standalone.

Jose-Gael-Cruz-Lopez · 2026-06-22T04:08:59Z

Two migration-hygiene fixes from the backend audit.

#196 — `migration_cosmetics.sql` is now idempotent

The five ALTER TABLE user_settings ADD CONSTRAINT fk_… statements were bare; Postgres has no ADD CONSTRAINT IF NOT EXISTS, so a second run aborted with "constraint already exists" (and, un-transactioned, left ambiguous partial state). Each is now wrapped in the DO $$ … IF NOT EXISTS (SELECT 1 FROM pg_constraint …) guard already used in migration_gradebook.sql, so the migration is safely re-runnable.

#197 — deterministic ordering + applied-migration ledger

Ordering lived only in prose headers, the root drift hazard behind the schema↔migration discrepancies elsewhere in the audit. This introduces:

schema_migrations(version, applied_at) ledger — new migration_schema_migrations.sql + mirrored into supabase_schema.sql.
db/migrate.py — an explicit ordered MANIFEST and a runner that applies each pending migration exactly once, in order, recording it. --status inspects without writing; --apply runs pending ones (needs a direct DATABASE_URL + psycopg, lazily imported — the PostgREST client can't run DDL).
db/MIGRATIONS.md — documents the baseline/ledger/runner model and the "add a migration" checklist.

supabase_schema.sql remains the canonical baseline for fresh databases; the runner governs the incremental files going forward.

Tests

test_migration_runner.py — manifest covers everymigration_*.sql (no orphan/phantom/dupe), the known drop-legacy → gradebook order holds, pending() excludes applied + preserves order, and all five cosmetics FKs are guarded.

Verification

ruff check . clean; gated suite green (+7 new); python -m db.migrate --status runs with no DB.

Closes#196, #197.

…s migration (#196)

…ation (#196)

…migration (#196)

…tion (#196)

…cs migration (#196)

…fest (#197)

…idempotency (#196, #197)

coderabbitai · 2026-06-22T04:09:08Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e54a88c-3818-46e8-a8e9-03d56b037a7c

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and dd97fac.

📒 Files selected for processing (3)

backend/db/MIGRATIONS.md
backend/db/migration_schema_migrations.sql
backend/db/migrations/0001_baseline_schema.sql

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/migration-hygiene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cloudflare-workers-and-pages · 2026-06-22T04:11:15Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
❌ Deployment failed View logs	frontend	`d225b53`	Jun 22 2026, 04:11 AM

Previously --status ran the ledger CREATE TABLE IF NOT EXISTS inside the psycopg connection context, which commits on a clean exit and created the schema_migrations table as a side effect — contradicting the documented "no DB writes" contract. Check information_schema for the ledger instead and treat a missing table as zero applied migrations.

Without DATABASE_URL, --apply passed an empty connection string to psycopg.connect(""), which silently falls back to libpq env defaults (PGHOST, local socket) and yields a confusing connection error or an unintended connection. Fail fast with a clear message instead.

cloudflare-workers-and-pages · 2026-06-24T04:51:51Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	`dd97fac`	Commit Preview URL Branch Preview URL	Jun 24 2026, 02:46 PM

# Conflicts: # backend/db/migrate.py # backend/db/migrations/0009_cosmetics.sql

…main

AndresL230 · 2026-06-25T02:53:17Z

Largely superseded. The ordered migration runner (#197) already landed as #252 (it's what the redesign uses), and the cosmetics re-runnability concern (#196) is mooted by the runner's applied-migration ledger (each file applies once). Closing — reopen if the cosmetics idempotency fix is still needed standalone.

Jose-Gael-Cruz-Lopez · 2026-06-22T04:08:59Z

Two migration-hygiene fixes from the backend audit.

#196 — `migration_cosmetics.sql` is now idempotent

The five ALTER TABLE user_settings ADD CONSTRAINT fk_… statements were bare; Postgres has no ADD CONSTRAINT IF NOT EXISTS, so a second run aborted with "constraint already exists" (and, un-transactioned, left ambiguous partial state). Each is now wrapped in the DO $$ … IF NOT EXISTS (SELECT 1 FROM pg_constraint …) guard already used in migration_gradebook.sql, so the migration is safely re-runnable.

#197 — deterministic ordering + applied-migration ledger

Ordering lived only in prose headers, the root drift hazard behind the schema↔migration discrepancies elsewhere in the audit. This introduces:

schema_migrations(version, applied_at) ledger — new migration_schema_migrations.sql + mirrored into supabase_schema.sql.
db/migrate.py — an explicit ordered MANIFEST and a runner that applies each pending migration exactly once, in order, recording it. --status inspects without writing; --apply runs pending ones (needs a direct DATABASE_URL + psycopg, lazily imported — the PostgREST client can't run DDL).
db/MIGRATIONS.md — documents the baseline/ledger/runner model and the "add a migration" checklist.

supabase_schema.sql remains the canonical baseline for fresh databases; the runner governs the incremental files going forward.

Tests

test_migration_runner.py — manifest covers everymigration_*.sql (no orphan/phantom/dupe), the known drop-legacy → gradebook order holds, pending() excludes applied + preserves order, and all five cosmetics FKs are guarded.

Verification

ruff check . clean; gated suite green (+7 new); python -m db.migrate --status runs with no DB.

Closes#196, #197.

…s migration (#196)

…ation (#196)

…migration (#196)

…tion (#196)

…cs migration (#196)

…fest (#197)

…idempotency (#196, #197)

coderabbitai · 2026-06-22T04:09:08Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e54a88c-3818-46e8-a8e9-03d56b037a7c

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and dd97fac.

📒 Files selected for processing (3)

backend/db/MIGRATIONS.md
backend/db/migration_schema_migrations.sql
backend/db/migrations/0001_baseline_schema.sql

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/migration-hygiene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cloudflare-workers-and-pages · 2026-06-22T04:11:15Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
❌ Deployment failed View logs	frontend	`d225b53`	Jun 22 2026, 04:11 AM

Previously --status ran the ledger CREATE TABLE IF NOT EXISTS inside the psycopg connection context, which commits on a clean exit and created the schema_migrations table as a side effect — contradicting the documented "no DB writes" contract. Check information_schema for the ledger instead and treat a missing table as zero applied migrations.

Without DATABASE_URL, --apply passed an empty connection string to psycopg.connect(""), which silently falls back to libpq env defaults (PGHOST, local socket) and yields a confusing connection error or an unintended connection. Fail fast with a clear message instead.

cloudflare-workers-and-pages · 2026-06-24T04:51:51Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	`dd97fac`	Commit Preview URL Branch Preview URL	Jun 24 2026, 02:46 PM

# Conflicts: # backend/db/migrate.py # backend/db/migrations/0009_cosmetics.sql

…main

AndresL230 · 2026-06-25T02:53:17Z

Largely superseded. The ordered migration runner (#197) already landed as #252 (it's what the redesign uses), and the cosmetics re-runnability concern (#196) is mooted by the runner's applied-migration ledger (each file applies once). Closing — reopen if the cosmetics idempotency fix is still needed standalone.

Jose-Gael-Cruz-Lopez · 2026-06-22T04:08:59Z

Two migration-hygiene fixes from the backend audit.

#196 — `migration_cosmetics.sql` is now idempotent

The five ALTER TABLE user_settings ADD CONSTRAINT fk_… statements were bare; Postgres has no ADD CONSTRAINT IF NOT EXISTS, so a second run aborted with "constraint already exists" (and, un-transactioned, left ambiguous partial state). Each is now wrapped in the DO $$ … IF NOT EXISTS (SELECT 1 FROM pg_constraint …) guard already used in migration_gradebook.sql, so the migration is safely re-runnable.

#197 — deterministic ordering + applied-migration ledger

Ordering lived only in prose headers, the root drift hazard behind the schema↔migration discrepancies elsewhere in the audit. This introduces:

schema_migrations(version, applied_at) ledger — new migration_schema_migrations.sql + mirrored into supabase_schema.sql.
db/migrate.py — an explicit ordered MANIFEST and a runner that applies each pending migration exactly once, in order, recording it. --status inspects without writing; --apply runs pending ones (needs a direct DATABASE_URL + psycopg, lazily imported — the PostgREST client can't run DDL).
db/MIGRATIONS.md — documents the baseline/ledger/runner model and the "add a migration" checklist.

supabase_schema.sql remains the canonical baseline for fresh databases; the runner governs the incremental files going forward.

Tests

test_migration_runner.py — manifest covers everymigration_*.sql (no orphan/phantom/dupe), the known drop-legacy → gradebook order holds, pending() excludes applied + preserves order, and all five cosmetics FKs are guarded.

Verification

ruff check . clean; gated suite green (+7 new); python -m db.migrate --status runs with no DB.

Closes#196, #197.

…s migration (#196)

…ation (#196)

…migration (#196)

…tion (#196)

…cs migration (#196)

…fest (#197)

…idempotency (#196, #197)

coderabbitai · 2026-06-22T04:09:08Z

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e54a88c-3818-46e8-a8e9-03d56b037a7c

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and dd97fac.

📒 Files selected for processing (3)

backend/db/MIGRATIONS.md
backend/db/migration_schema_migrations.sql
backend/db/migrations/0001_baseline_schema.sql

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/migration-hygiene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cloudflare-workers-and-pages · 2026-06-22T04:11:15Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
❌ Deployment failed View logs	frontend	`d225b53`	Jun 22 2026, 04:11 AM

Previously --status ran the ledger CREATE TABLE IF NOT EXISTS inside the psycopg connection context, which commits on a clean exit and created the schema_migrations table as a side effect — contradicting the documented "no DB writes" contract. Check information_schema for the ledger instead and treat a missing table as zero applied migrations.

Without DATABASE_URL, --apply passed an empty connection string to psycopg.connect(""), which silently falls back to libpq env defaults (PGHOST, local socket) and yields a confusing connection error or an unintended connection. Fail fast with a clear message instead.

cloudflare-workers-and-pages · 2026-06-24T04:51:51Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	`dd97fac`	Commit Preview URL Branch Preview URL	Jun 24 2026, 02:46 PM

# Conflicts: # backend/db/migrate.py # backend/db/migrations/0009_cosmetics.sql

…main

AndresL230 · 2026-06-25T02:53:17Z

Largely superseded. The ordered migration runner (#197) already landed as #252 (it's what the redesign uses), and the cosmetics re-runnability concern (#196) is mooted by the runner's applied-migration ledger (each file applies once). Closing — reopen if the cosmetics idempotency fix is still needed standalone.

Jose-Gael-Cruz-Lopez added 10 commits June 22, 2026 00:04

fix(db): guard fk_user_settings_avatar_frame for re-runnable cosmetic…
ef1093b
…s migration (#196)

fix(db): guard fk_user_settings_banner for re-runnable cosmetics migr…
ace4f2a
…ation (#196)

fix(db): guard fk_user_settings_name_color for re-runnable cosmetics …
41ef569
…migration (#196)

fix(db): guard fk_user_settings_title for re-runnable cosmetics migra…
23309f1
…tion (#196)

fix(db): guard fk_user_settings_featured_role for re-runnable cosmeti…
e6e9fe1
…cs migration (#196)

feat(db): add schema_migrations ledger table migration (#197)
f2cc860

feat(db): mirror schema_migrations ledger into canonical schema (#197)
0317da3

feat(db): add ordered, idempotent migration runner with explicit mani…
12c6e61
…fest (#197)

docs(db): document migration ordering, ledger, and runner usage (#197)
4098396

test(db): cover migration manifest ordering/completeness + cosmetics …
d225b53
…idempotency (#196, #197)

Jose-Gael-Cruz-Lopez added 2 commits June 24, 2026 00:51

Jose-Gael-Cruz-Lopez added 2 commits June 24, 2026 10:27

Merge remote-tracking branch 'origin/main' into chore/migration-hygiene
0c82456
# Conflicts: # backend/db/migrate.py # backend/db/migrations/0009_cosmetics.sql

test(db): drop obsolete runner test superseded by test_migrate.py on …
dd97fac
…main

AndresL230 closed this Jun 25, 2026

AndresL230 deleted the chore/migration-hygiene branch June 27, 2026 04:21