Uh oh!
There was an error while loading. Please reload this page.
fix(ci): unbreak the Frontend check (eslint flag + prune stale suppressions) - #262
Merged
Merged
Conversation
The lint step ran `npx eslint . --max-warnings -1`. With a space, the bare `-1`
is parsed as a CLI option ("No -NUM option defined") and eslint exits 2 — so the
Frontend (lint + tsc + vitest) job has been failing at lint on every push to main
and every PR, before tsc/vitest ever run.
Use `--max-warnings=-1` (with '='), which is the intended "no warning limit"
(warnings don't fail CI). This unblocks the Frontend check repo-wide and lets the
typecheck + vitest steps actually execute.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe CI workflow ESLint command is updated to use ChangesESLint CI Fix and Suppression Reduction
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with |
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs | frontend-staging | 2369d8a | Commit Preview URL Branch Preview URL | Jun 23 2026, 10:04 PM |
Correcting the --max-warnings flag let eslint actually run, which exposed the
real blocker: eslint-suppressions.json listed suppressions that no longer occur
(mostly react-hooks/set-state-in-effect, which the eslint-config-next bump stopped
reporting). ESLint exits 2 on leftover suppressions ("suppressions left that do not
occur anymore"), independent of --max-warnings.
Prune the dead entries (`eslint . --prune-suppressions`, -139 lines). Verified
locally against the synced lockfile (CI-matching deps): eslint, tsc --noEmit, and
vitest (68 tests) all pass. This + the flag fix green the Frontend check repo-wide.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the chronically-red Frontend (lint + tsc + vitest) check (red on
mainand every PR). Two stacked causes, two commits:1. Malformed eslint flag
The lint step ran
npx eslint . --max-warnings -1. With a space, the bare-1is parsed as an option →No -NUM option defined, exit 2 — eslint died before linting anything. Fixed to--max-warnings=-1(no warning limit; warnings don't fail CI).2. Stale bulk-suppressions baseline
Fixing the flag let eslint run, which exposed the real blocker:
frontend/eslint-suppressions.jsonlisted suppressions that no longer occur (mostlyreact-hooks/set-state-in-effect, which theeslint-config-nextbump stopped reporting). ESLint exits 2 on leftover suppressions regardless of--max-warnings. Pruned the dead entries (eslint . --prune-suppressions, −139 lines).Verified locally (CI-matching deps via fresh
npm ciagainst the synced lockfile)npx eslint . --max-warnings=-1→ exit 0 (35 warnings, 0 errors)npx tsc --noEmit→ exit 0npm test→ exit 0 (10 files, 68 tests passed)Once this lands on
main, the Frontend check goes green repo-wide — including #261, which inherits the fix via its merge ref.🤖 Generated with Claude Code
Summary by CodeRabbit