Skip to content

chore(lint): fix ruff violations in RAG scripts unblocking main CI - #324

Merged
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts
Jul 8, 2026
Merged

chore(lint): fix ruff violations in RAG scripts unblocking main CI#324
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

main’s CI Backend (pytest) job has been red since the RAG pipeline scripts landed (~Jul 3): 8 un-baselined ruff errors made ruff check . exit 1, which skips pytest entirely. Because main isn’t a protected branch, merges kept going through the red and it went unnoticed — and every open PR inherits the failure via the pull_request merge check.

Violations fixed (all pre-existing on main, behavior-preserving)

FileRuleFix
scripts/benchmark_rag.pyF401drop unused import os
E402 ×2# noqa: E402 on the two intentional post-sys.path imports
F841drop unused chunk_results binding (keeps the side-effecting run_chunk_tests(cases) call)
scripts/ingest_catalog.pyE402# noqa: E402 on the post-sys.path import
F541drop stray f prefix on a placeholder-less string
scripts/scrape_bu_catalog.pyF401drop unused import sys
F841drop unused school_courses binding (keeps the side-effecting scrape_school(...) call)

No behavior change — only unused bindings/imports removed and intentional bootstrap imports annotated.

Verification

ruff 0.15.20 check . (same version + ruff.toml as CI) → All checks passed. This PR’s own CI should now run pytest (previously skipped) and go green, un-reding the whole PR backlog’s Backend job.

@Darkest-Teddy heads-up — these are your RAG scripts; open PRs (#318/#323) may need a trivial rebase after this lands.

🤖 Generated with Claude Code

main's CI (Backend job) has been red since the RAG pipeline scripts
landed (~Jul 3): 8 un-baselined ruff errors caused ruff check . to
exit 1, skipping pytest. Because main isn't a protected branch, merges
proceeded through the red and it went unnoticed — and every open PR's
Backend job inherited the failure via the pull_request merge check.
Fixes (behavior-preserving):
- benchmark_rag.py: drop unused import os; noqa: E402 on the two
intentional post-sys.path imports; drop unused chunk_results binding
(keeps the side-effecting run_chunk_tests call).
- ingest_catalog.py: noqa: E402 on the post-sys.path import; drop stray
f-prefix on a placeholder-less string.
- scrape_bu_catalog.py: drop unused import sys; drop unused
school_courses binding (keeps the side-effecting scrape_school call).
Verified locally: ruff 0.15.20 check . -> All checks passed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a0f890d-41c6-4b2c-8d76-75d59fd0654a

📥 Commits

Reviewing files that changed from the base of the PR and between 6424005 and 9fcfb9e.

📒 Files selected for processing (3)
  • backend/scripts/benchmark_rag.py
  • backend/scripts/ingest_catalog.py
  • backend/scripts/scrape_bu_catalog.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-ruff-lint-rag-scripts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging9fcfb9eCommit Preview URL

Branch Preview URL
Jul 08 2026, 06:28 AM

@AndresL230
AndresL230 merged commit 6243563 into mainJul 8, 2026
6 checks passed
@AndresL230
AndresL230 deleted the chore/fix-ruff-lint-rag-scripts branch August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore(lint): fix ruff violations in RAG scripts unblocking main CI by AndresL230 · Pull Request #324 · SaplingLearn/Sapling · GitHub
Skip to content

chore(lint): fix ruff violations in RAG scripts unblocking main CI - #324

Merged
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts
Jul 8, 2026
Merged

chore(lint): fix ruff violations in RAG scripts unblocking main CI#324
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

main’s CI Backend (pytest) job has been red since the RAG pipeline scripts landed (~Jul 3): 8 un-baselined ruff errors made ruff check . exit 1, which skips pytest entirely. Because main isn’t a protected branch, merges kept going through the red and it went unnoticed — and every open PR inherits the failure via the pull_request merge check.

Violations fixed (all pre-existing on main, behavior-preserving)

FileRuleFix
scripts/benchmark_rag.pyF401drop unused import os
E402 ×2# noqa: E402 on the two intentional post-sys.path imports
F841drop unused chunk_results binding (keeps the side-effecting run_chunk_tests(cases) call)
scripts/ingest_catalog.pyE402# noqa: E402 on the post-sys.path import
F541drop stray f prefix on a placeholder-less string
scripts/scrape_bu_catalog.pyF401drop unused import sys
F841drop unused school_courses binding (keeps the side-effecting scrape_school(...) call)

No behavior change — only unused bindings/imports removed and intentional bootstrap imports annotated.

Verification

ruff 0.15.20 check . (same version + ruff.toml as CI) → All checks passed. This PR’s own CI should now run pytest (previously skipped) and go green, un-reding the whole PR backlog’s Backend job.

@Darkest-Teddy heads-up — these are your RAG scripts; open PRs (#318/#323) may need a trivial rebase after this lands.

🤖 Generated with Claude Code

main's CI (Backend job) has been red since the RAG pipeline scripts
landed (~Jul 3): 8 un-baselined ruff errors caused ruff check . to
exit 1, skipping pytest. Because main isn't a protected branch, merges
proceeded through the red and it went unnoticed — and every open PR's
Backend job inherited the failure via the pull_request merge check.
Fixes (behavior-preserving):
- benchmark_rag.py: drop unused import os; noqa: E402 on the two
intentional post-sys.path imports; drop unused chunk_results binding
(keeps the side-effecting run_chunk_tests call).
- ingest_catalog.py: noqa: E402 on the post-sys.path import; drop stray
f-prefix on a placeholder-less string.
- scrape_bu_catalog.py: drop unused import sys; drop unused
school_courses binding (keeps the side-effecting scrape_school call).
Verified locally: ruff 0.15.20 check . -> All checks passed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a0f890d-41c6-4b2c-8d76-75d59fd0654a

📥 Commits

Reviewing files that changed from the base of the PR and between 6424005 and 9fcfb9e.

📒 Files selected for processing (3)
  • backend/scripts/benchmark_rag.py
  • backend/scripts/ingest_catalog.py
  • backend/scripts/scrape_bu_catalog.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-ruff-lint-rag-scripts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging9fcfb9eCommit Preview URL

Branch Preview URL
Jul 08 2026, 06:28 AM

@AndresL230
AndresL230 merged commit 6243563 into mainJul 8, 2026
6 checks passed
@AndresL230
AndresL230 deleted the chore/fix-ruff-lint-rag-scripts branch August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(lint): fix ruff violations in RAG scripts unblocking main CI by AndresL230 · Pull Request #324 · SaplingLearn/Sapling · GitHub
Skip to content

chore(lint): fix ruff violations in RAG scripts unblocking main CI - #324

Merged
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts
Jul 8, 2026
Merged

chore(lint): fix ruff violations in RAG scripts unblocking main CI#324
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

main’s CI Backend (pytest) job has been red since the RAG pipeline scripts landed (~Jul 3): 8 un-baselined ruff errors made ruff check . exit 1, which skips pytest entirely. Because main isn’t a protected branch, merges kept going through the red and it went unnoticed — and every open PR inherits the failure via the pull_request merge check.

Violations fixed (all pre-existing on main, behavior-preserving)

FileRuleFix
scripts/benchmark_rag.pyF401drop unused import os
E402 ×2# noqa: E402 on the two intentional post-sys.path imports
F841drop unused chunk_results binding (keeps the side-effecting run_chunk_tests(cases) call)
scripts/ingest_catalog.pyE402# noqa: E402 on the post-sys.path import
F541drop stray f prefix on a placeholder-less string
scripts/scrape_bu_catalog.pyF401drop unused import sys
F841drop unused school_courses binding (keeps the side-effecting scrape_school(...) call)

No behavior change — only unused bindings/imports removed and intentional bootstrap imports annotated.

Verification

ruff 0.15.20 check . (same version + ruff.toml as CI) → All checks passed. This PR’s own CI should now run pytest (previously skipped) and go green, un-reding the whole PR backlog’s Backend job.

@Darkest-Teddy heads-up — these are your RAG scripts; open PRs (#318/#323) may need a trivial rebase after this lands.

🤖 Generated with Claude Code

main's CI (Backend job) has been red since the RAG pipeline scripts
landed (~Jul 3): 8 un-baselined ruff errors caused ruff check . to
exit 1, skipping pytest. Because main isn't a protected branch, merges
proceeded through the red and it went unnoticed — and every open PR's
Backend job inherited the failure via the pull_request merge check.
Fixes (behavior-preserving):
- benchmark_rag.py: drop unused import os; noqa: E402 on the two
intentional post-sys.path imports; drop unused chunk_results binding
(keeps the side-effecting run_chunk_tests call).
- ingest_catalog.py: noqa: E402 on the post-sys.path import; drop stray
f-prefix on a placeholder-less string.
- scrape_bu_catalog.py: drop unused import sys; drop unused
school_courses binding (keeps the side-effecting scrape_school call).
Verified locally: ruff 0.15.20 check . -> All checks passed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a0f890d-41c6-4b2c-8d76-75d59fd0654a

📥 Commits

Reviewing files that changed from the base of the PR and between 6424005 and 9fcfb9e.

📒 Files selected for processing (3)
  • backend/scripts/benchmark_rag.py
  • backend/scripts/ingest_catalog.py
  • backend/scripts/scrape_bu_catalog.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-ruff-lint-rag-scripts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging9fcfb9eCommit Preview URL

Branch Preview URL
Jul 08 2026, 06:28 AM

@AndresL230
AndresL230 merged commit 6243563 into mainJul 8, 2026
6 checks passed
@AndresL230
AndresL230 deleted the chore/fix-ruff-lint-rag-scripts branch August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(lint): fix ruff violations in RAG scripts unblocking main CI by AndresL230 · Pull Request #324 · SaplingLearn/Sapling · GitHub
Skip to content

chore(lint): fix ruff violations in RAG scripts unblocking main CI - #324

Merged
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts
Jul 8, 2026
Merged

chore(lint): fix ruff violations in RAG scripts unblocking main CI#324
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

main’s CI Backend (pytest) job has been red since the RAG pipeline scripts landed (~Jul 3): 8 un-baselined ruff errors made ruff check . exit 1, which skips pytest entirely. Because main isn’t a protected branch, merges kept going through the red and it went unnoticed — and every open PR inherits the failure via the pull_request merge check.

Violations fixed (all pre-existing on main, behavior-preserving)

FileRuleFix
scripts/benchmark_rag.pyF401drop unused import os
E402 ×2# noqa: E402 on the two intentional post-sys.path imports
F841drop unused chunk_results binding (keeps the side-effecting run_chunk_tests(cases) call)
scripts/ingest_catalog.pyE402# noqa: E402 on the post-sys.path import
F541drop stray f prefix on a placeholder-less string
scripts/scrape_bu_catalog.pyF401drop unused import sys
F841drop unused school_courses binding (keeps the side-effecting scrape_school(...) call)

No behavior change — only unused bindings/imports removed and intentional bootstrap imports annotated.

Verification

ruff 0.15.20 check . (same version + ruff.toml as CI) → All checks passed. This PR’s own CI should now run pytest (previously skipped) and go green, un-reding the whole PR backlog’s Backend job.

@Darkest-Teddy heads-up — these are your RAG scripts; open PRs (#318/#323) may need a trivial rebase after this lands.

🤖 Generated with Claude Code

main's CI (Backend job) has been red since the RAG pipeline scripts
landed (~Jul 3): 8 un-baselined ruff errors caused ruff check . to
exit 1, skipping pytest. Because main isn't a protected branch, merges
proceeded through the red and it went unnoticed — and every open PR's
Backend job inherited the failure via the pull_request merge check.
Fixes (behavior-preserving):
- benchmark_rag.py: drop unused import os; noqa: E402 on the two
intentional post-sys.path imports; drop unused chunk_results binding
(keeps the side-effecting run_chunk_tests call).
- ingest_catalog.py: noqa: E402 on the post-sys.path import; drop stray
f-prefix on a placeholder-less string.
- scrape_bu_catalog.py: drop unused import sys; drop unused
school_courses binding (keeps the side-effecting scrape_school call).
Verified locally: ruff 0.15.20 check . -> All checks passed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a0f890d-41c6-4b2c-8d76-75d59fd0654a

📥 Commits

Reviewing files that changed from the base of the PR and between 6424005 and 9fcfb9e.

📒 Files selected for processing (3)
  • backend/scripts/benchmark_rag.py
  • backend/scripts/ingest_catalog.py
  • backend/scripts/scrape_bu_catalog.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-ruff-lint-rag-scripts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging9fcfb9eCommit Preview URL

Branch Preview URL
Jul 08 2026, 06:28 AM

@AndresL230
AndresL230 merged commit 6243563 into mainJul 8, 2026
6 checks passed
@AndresL230
AndresL230 deleted the chore/fix-ruff-lint-rag-scripts branch August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' chore(lint): fix ruff violations in RAG scripts unblocking main CI by AndresL230 · Pull Request #324 · SaplingLearn/Sapling · GitHub
Skip to content

chore(lint): fix ruff violations in RAG scripts unblocking main CI - #324

Merged
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts
Jul 8, 2026
Merged

chore(lint): fix ruff violations in RAG scripts unblocking main CI#324
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

main’s CI Backend (pytest) job has been red since the RAG pipeline scripts landed (~Jul 3): 8 un-baselined ruff errors made ruff check . exit 1, which skips pytest entirely. Because main isn’t a protected branch, merges kept going through the red and it went unnoticed — and every open PR inherits the failure via the pull_request merge check.

Violations fixed (all pre-existing on main, behavior-preserving)

FileRuleFix
scripts/benchmark_rag.pyF401drop unused import os
E402 ×2# noqa: E402 on the two intentional post-sys.path imports
F841drop unused chunk_results binding (keeps the side-effecting run_chunk_tests(cases) call)
scripts/ingest_catalog.pyE402# noqa: E402 on the post-sys.path import
F541drop stray f prefix on a placeholder-less string
scripts/scrape_bu_catalog.pyF401drop unused import sys
F841drop unused school_courses binding (keeps the side-effecting scrape_school(...) call)

No behavior change — only unused bindings/imports removed and intentional bootstrap imports annotated.

Verification

ruff 0.15.20 check . (same version + ruff.toml as CI) → All checks passed. This PR’s own CI should now run pytest (previously skipped) and go green, un-reding the whole PR backlog’s Backend job.

@Darkest-Teddy heads-up — these are your RAG scripts; open PRs (#318/#323) may need a trivial rebase after this lands.

🤖 Generated with Claude Code

main's CI (Backend job) has been red since the RAG pipeline scripts
landed (~Jul 3): 8 un-baselined ruff errors caused ruff check . to
exit 1, skipping pytest. Because main isn't a protected branch, merges
proceeded through the red and it went unnoticed — and every open PR's
Backend job inherited the failure via the pull_request merge check.
Fixes (behavior-preserving):
- benchmark_rag.py: drop unused import os; noqa: E402 on the two
intentional post-sys.path imports; drop unused chunk_results binding
(keeps the side-effecting run_chunk_tests call).
- ingest_catalog.py: noqa: E402 on the post-sys.path import; drop stray
f-prefix on a placeholder-less string.
- scrape_bu_catalog.py: drop unused import sys; drop unused
school_courses binding (keeps the side-effecting scrape_school call).
Verified locally: ruff 0.15.20 check . -> All checks passed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a0f890d-41c6-4b2c-8d76-75d59fd0654a

📥 Commits

Reviewing files that changed from the base of the PR and between 6424005 and 9fcfb9e.

📒 Files selected for processing (3)
  • backend/scripts/benchmark_rag.py
  • backend/scripts/ingest_catalog.py
  • backend/scripts/scrape_bu_catalog.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-ruff-lint-rag-scripts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging9fcfb9eCommit Preview URL

Branch Preview URL
Jul 08 2026, 06:28 AM

@AndresL230
AndresL230 merged commit 6243563 into mainJul 8, 2026
6 checks passed
@AndresL230
AndresL230 deleted the chore/fix-ruff-lint-rag-scripts branch August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(lint): fix ruff violations in RAG scripts unblocking main CI by AndresL230 · Pull Request #324 · SaplingLearn/Sapling · GitHub
Skip to content

chore(lint): fix ruff violations in RAG scripts unblocking main CI - #324

Merged
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts
Jul 8, 2026
Merged

chore(lint): fix ruff violations in RAG scripts unblocking main CI#324
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

main’s CI Backend (pytest) job has been red since the RAG pipeline scripts landed (~Jul 3): 8 un-baselined ruff errors made ruff check . exit 1, which skips pytest entirely. Because main isn’t a protected branch, merges kept going through the red and it went unnoticed — and every open PR inherits the failure via the pull_request merge check.

Violations fixed (all pre-existing on main, behavior-preserving)

FileRuleFix
scripts/benchmark_rag.pyF401drop unused import os
E402 ×2# noqa: E402 on the two intentional post-sys.path imports
F841drop unused chunk_results binding (keeps the side-effecting run_chunk_tests(cases) call)
scripts/ingest_catalog.pyE402# noqa: E402 on the post-sys.path import
F541drop stray f prefix on a placeholder-less string
scripts/scrape_bu_catalog.pyF401drop unused import sys
F841drop unused school_courses binding (keeps the side-effecting scrape_school(...) call)

No behavior change — only unused bindings/imports removed and intentional bootstrap imports annotated.

Verification

ruff 0.15.20 check . (same version + ruff.toml as CI) → All checks passed. This PR’s own CI should now run pytest (previously skipped) and go green, un-reding the whole PR backlog’s Backend job.

@Darkest-Teddy heads-up — these are your RAG scripts; open PRs (#318/#323) may need a trivial rebase after this lands.

🤖 Generated with Claude Code

main's CI (Backend job) has been red since the RAG pipeline scripts
landed (~Jul 3): 8 un-baselined ruff errors caused ruff check . to
exit 1, skipping pytest. Because main isn't a protected branch, merges
proceeded through the red and it went unnoticed — and every open PR's
Backend job inherited the failure via the pull_request merge check.
Fixes (behavior-preserving):
- benchmark_rag.py: drop unused import os; noqa: E402 on the two
intentional post-sys.path imports; drop unused chunk_results binding
(keeps the side-effecting run_chunk_tests call).
- ingest_catalog.py: noqa: E402 on the post-sys.path import; drop stray
f-prefix on a placeholder-less string.
- scrape_bu_catalog.py: drop unused import sys; drop unused
school_courses binding (keeps the side-effecting scrape_school call).
Verified locally: ruff 0.15.20 check . -> All checks passed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a0f890d-41c6-4b2c-8d76-75d59fd0654a

📥 Commits

Reviewing files that changed from the base of the PR and between 6424005 and 9fcfb9e.

📒 Files selected for processing (3)
  • backend/scripts/benchmark_rag.py
  • backend/scripts/ingest_catalog.py
  • backend/scripts/scrape_bu_catalog.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-ruff-lint-rag-scripts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging9fcfb9eCommit Preview URL

Branch Preview URL
Jul 08 2026, 06:28 AM

@AndresL230
AndresL230 merged commit 6243563 into mainJul 8, 2026
6 checks passed
@AndresL230
AndresL230 deleted the chore/fix-ruff-lint-rag-scripts branch August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(lint): fix ruff violations in RAG scripts unblocking main CI by AndresL230 · Pull Request #324 · SaplingLearn/Sapling · GitHub
Skip to content

chore(lint): fix ruff violations in RAG scripts unblocking main CI - #324

Merged
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts
Jul 8, 2026
Merged

chore(lint): fix ruff violations in RAG scripts unblocking main CI#324
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

main’s CI Backend (pytest) job has been red since the RAG pipeline scripts landed (~Jul 3): 8 un-baselined ruff errors made ruff check . exit 1, which skips pytest entirely. Because main isn’t a protected branch, merges kept going through the red and it went unnoticed — and every open PR inherits the failure via the pull_request merge check.

Violations fixed (all pre-existing on main, behavior-preserving)

FileRuleFix
scripts/benchmark_rag.pyF401drop unused import os
E402 ×2# noqa: E402 on the two intentional post-sys.path imports
F841drop unused chunk_results binding (keeps the side-effecting run_chunk_tests(cases) call)
scripts/ingest_catalog.pyE402# noqa: E402 on the post-sys.path import
F541drop stray f prefix on a placeholder-less string
scripts/scrape_bu_catalog.pyF401drop unused import sys
F841drop unused school_courses binding (keeps the side-effecting scrape_school(...) call)

No behavior change — only unused bindings/imports removed and intentional bootstrap imports annotated.

Verification

ruff 0.15.20 check . (same version + ruff.toml as CI) → All checks passed. This PR’s own CI should now run pytest (previously skipped) and go green, un-reding the whole PR backlog’s Backend job.

@Darkest-Teddy heads-up — these are your RAG scripts; open PRs (#318/#323) may need a trivial rebase after this lands.

🤖 Generated with Claude Code

main's CI (Backend job) has been red since the RAG pipeline scripts
landed (~Jul 3): 8 un-baselined ruff errors caused ruff check . to
exit 1, skipping pytest. Because main isn't a protected branch, merges
proceeded through the red and it went unnoticed — and every open PR's
Backend job inherited the failure via the pull_request merge check.
Fixes (behavior-preserving):
- benchmark_rag.py: drop unused import os; noqa: E402 on the two
intentional post-sys.path imports; drop unused chunk_results binding
(keeps the side-effecting run_chunk_tests call).
- ingest_catalog.py: noqa: E402 on the post-sys.path import; drop stray
f-prefix on a placeholder-less string.
- scrape_bu_catalog.py: drop unused import sys; drop unused
school_courses binding (keeps the side-effecting scrape_school call).
Verified locally: ruff 0.15.20 check . -> All checks passed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a0f890d-41c6-4b2c-8d76-75d59fd0654a

📥 Commits

Reviewing files that changed from the base of the PR and between 6424005 and 9fcfb9e.

📒 Files selected for processing (3)
  • backend/scripts/benchmark_rag.py
  • backend/scripts/ingest_catalog.py
  • backend/scripts/scrape_bu_catalog.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-ruff-lint-rag-scripts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging9fcfb9eCommit Preview URL

Branch Preview URL
Jul 08 2026, 06:28 AM

@AndresL230
AndresL230 merged commit 6243563 into mainJul 8, 2026
6 checks passed
@AndresL230
AndresL230 deleted the chore/fix-ruff-lint-rag-scripts branch August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); chore(lint): fix ruff violations in RAG scripts unblocking main CI by AndresL230 · Pull Request #324 · SaplingLearn/Sapling · GitHub
Skip to content

chore(lint): fix ruff violations in RAG scripts unblocking main CI - #324

Merged
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts
Jul 8, 2026
Merged

chore(lint): fix ruff violations in RAG scripts unblocking main CI#324
AndresL230 merged 1 commit into
mainfrom
chore/fix-ruff-lint-rag-scripts

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

main’s CI Backend (pytest) job has been red since the RAG pipeline scripts landed (~Jul 3): 8 un-baselined ruff errors made ruff check . exit 1, which skips pytest entirely. Because main isn’t a protected branch, merges kept going through the red and it went unnoticed — and every open PR inherits the failure via the pull_request merge check.

Violations fixed (all pre-existing on main, behavior-preserving)

FileRuleFix
scripts/benchmark_rag.pyF401drop unused import os
E402 ×2# noqa: E402 on the two intentional post-sys.path imports
F841drop unused chunk_results binding (keeps the side-effecting run_chunk_tests(cases) call)
scripts/ingest_catalog.pyE402# noqa: E402 on the post-sys.path import
F541drop stray f prefix on a placeholder-less string
scripts/scrape_bu_catalog.pyF401drop unused import sys
F841drop unused school_courses binding (keeps the side-effecting scrape_school(...) call)

No behavior change — only unused bindings/imports removed and intentional bootstrap imports annotated.

Verification

ruff 0.15.20 check . (same version + ruff.toml as CI) → All checks passed. This PR’s own CI should now run pytest (previously skipped) and go green, un-reding the whole PR backlog’s Backend job.

@Darkest-Teddy heads-up — these are your RAG scripts; open PRs (#318/#323) may need a trivial rebase after this lands.

🤖 Generated with Claude Code

main's CI (Backend job) has been red since the RAG pipeline scripts
landed (~Jul 3): 8 un-baselined ruff errors caused ruff check . to
exit 1, skipping pytest. Because main isn't a protected branch, merges
proceeded through the red and it went unnoticed — and every open PR's
Backend job inherited the failure via the pull_request merge check.
Fixes (behavior-preserving):
- benchmark_rag.py: drop unused import os; noqa: E402 on the two
intentional post-sys.path imports; drop unused chunk_results binding
(keeps the side-effecting run_chunk_tests call).
- ingest_catalog.py: noqa: E402 on the post-sys.path import; drop stray
f-prefix on a placeholder-less string.
- scrape_bu_catalog.py: drop unused import sys; drop unused
school_courses binding (keeps the side-effecting scrape_school call).
Verified locally: ruff 0.15.20 check . -> All checks passed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a0f890d-41c6-4b2c-8d76-75d59fd0654a

📥 Commits

Reviewing files that changed from the base of the PR and between 6424005 and 9fcfb9e.

📒 Files selected for processing (3)
  • backend/scripts/benchmark_rag.py
  • backend/scripts/ingest_catalog.py
  • backend/scripts/scrape_bu_catalog.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-ruff-lint-rag-scripts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging9fcfb9eCommit Preview URL

Branch Preview URL
Jul 08 2026, 06:28 AM

@AndresL230
AndresL230 merged commit 6243563 into mainJul 8, 2026
6 checks passed
@AndresL230
AndresL230 deleted the chore/fix-ruff-lint-rag-scripts branch August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230