feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191) - #466

Merged
AndresL230 merged 2 commits into
mainfrom
b8-beta-polish
Jul 30, 2026
Merged

feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191)#466
AndresL230 merged 2 commits into
mainfrom
b8-beta-polish

Conversation

@AndresL230

@AndresL230AndresL230 commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Bundle B8 — public-beta polish

Closes#169, closes#170, closes#171, closes#187, closes#172, closes#188, closes#191.

SEO (#169#170#171#187)

  • Root metadata (app/layout.tsx): metadataBase derived from DEPLOY_ENV via a new deployGuard.resolveSiteUrl (ADR-0022 single-knob; NEXT_PUBLIC_SITE_URL overrides for local/preview), title template, OpenGraph + Twitter cards backed by a generated public/og.png (1200×630), canonical.
  • robots.ts: allows the public surface, disallows the entire private app shell (mirrors middleware.ts PROTECTED) — and disallows everything on staging so staging twins never compete with canonical pages.
  • sitemap.ts: public marketing/legal routes + per-job careers slugs. manifest.ts: brand name/colors/icon.
  • Per-page metadata: about/privacy/terms export metadata; careers split into a server wrapper (page.tsx, holds metadata) + CareersList.tsx client child (UI unchanged, moved verbatim); careers/[slug] gets per-job generateMetadata.
  • Careers [slug] page returns 200 + fallback UI for invalid slugs (soft 404) #187: unknown careers slug now calls notFound() → real HTTP 404 instead of a 200 soft-404.

Shell (#172#188)

  • Real app/global-error.tsx rendering its own <html>/<body> + branded ErrorFallback (imports globals.css since it replaces the root layout); the misnamed segment boundary error.tsx renamed GlobalError → RootError.
  • (shell)/loading.tsx: instant neutral skeleton on shell route transitions.

Auth state honesty (#191)

  • setActiveUser gains a { persist } option: localStorage identity is written only after GET /api/auth/me confirms the session (gated in the OAuth callback, and through the popup broadcast via a new profileConfirmed payload field consumed by SignInModal). On a failed /me, the tab still signs in (context hydrates) but nothing persists — the provider's cookie fallback reconciles on the next full load.
  • UserContext.fetchProfileData (already fired on every authed mount) now clears the stale identity on a definitive 401/404; 5xx/network failures keep the session (a server blip must not sign anyone out).

Tests

  • 25 new vitest cases: seo.test.ts (metadata/robots/sitemap/manifest/notFound + resolveSiteUrl), globalError.test.tsx, shellLoading.test.tsx, UserContext.reconcile.test.tsx (401/404 clear, 5xx/network keep), callback.test.tsx (persist gate + clean failure).
  • Promoted journey e2e/public-seo.spec.ts: robots/sitemap/manifest resolve, careers hard-404, OG tags on the landing HTML.
  • Full suite: 41 files / 308 tests green (now 313); tsc --noEmit clean; eslint . 0 errors with no suppressions-baseline changes (the one new exhaustive-deps hit was fixed properly via useCallback).

Notes for review

  • next build cannot run inside the worktree (Turbopack rejects the symlinked node_modules); the build is exercised by the pre-merge e2e cycle from the primary checkout (stack build) before merge.
  • No docs/frontend-testids.md / eslint.config.mjs changes needed: no new interactive elements on testid'd surfaces (the journey is pure HTTP).

🤖 Generated with Claude Code

@coderabbitai

coderabbitaiBot commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:21 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c96c88e-0548-4c51-902d-f0d1b8965a58

📥 Commits

Reviewing files that changed from the base of the PR and between 1102093 and f118d9f.

⛔ Files ignored due to path filters (1)
  • frontend/public/og.png is excluded by !**/*.png
📒 Files selected for processing (23)
  • frontend/e2e/public-seo.spec.ts
  • frontend/src/app/(public)/about/page.tsx
  • frontend/src/app/(public)/careers/CareersList.tsx
  • frontend/src/app/(public)/careers/[slug]/page.tsx
  • frontend/src/app/(public)/careers/page.tsx
  • frontend/src/app/(public)/privacy/page.tsx
  • frontend/src/app/(public)/terms/page.tsx
  • frontend/src/app/(shell)/loading.tsx
  • frontend/src/app/auth/callback/callback.test.tsx
  • frontend/src/app/auth/callback/page.tsx
  • frontend/src/app/error.tsx
  • frontend/src/app/global-error.tsx
  • frontend/src/app/globalError.test.tsx
  • frontend/src/app/layout.tsx
  • frontend/src/app/manifest.ts
  • frontend/src/app/robots.ts
  • frontend/src/app/seo.test.ts
  • frontend/src/app/shellLoading.test.tsx
  • frontend/src/app/sitemap.ts
  • frontend/src/components/SignInModal.tsx
  • frontend/src/context/UserContext.reconcile.test.tsx
  • frontend/src/context/UserContext.tsx
  • frontend/src/lib/deployGuard.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs		frontend-stagingf118d9fCommit Preview URL

Branch Preview URL		Jul 30 2026, 07:26 AM

@AndresL230

AndresL230 commented Jul 30, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Code review

Found 1 issue:

  1. The new (shell)/loading.tssx fallback fabricates its own topbar skeleton (avatar circle + text bar + pill), but the shell's real TopNav/SideNav are persistent chrome rendered by ShellFrameoutside the {children} slot — Next mounts loading.tsx inside <main>, so every shell route transition flashes a second, skeleton-shaped topbar stacked directly under the real one (bug due to ShellFrame.tsx rendering <TopNav/>/<SideNav/> around <main>, not inside it)

Sapling/frontend/src/app/(shell)/loading.tsx

Lines 13 to 20 in 818840d

>
<divstyle={{display: "flex",alignItems: "center",gap: 12,marginBottom: 28}}>
<Skeletonwidth={26}height={26}circle/>
<Skeletonwidth={140}height={16}/>
<divstyle={{flex: 1}}/>
<Skeletonwidth={90}height={28}radius="var(--r-full)"/>
</div>
<divstyle={{maxWidth: 1080,margin: "0 auto",display: "flex",flexDirection: "column",gap: 14}}>

Sub-threshold notes (verified, being fixed in a follow-up commit on this PR, scores <80): resolveSiteUrl checks NEXT_PUBLIC_SITE_URL before DEPLOY_ENV, inverting the ADR-0022 precedence its own doc comment claims (75); the new 401/404 auto-clear in fetchProfileData can strand a just-signed-in tab on a shell route with cleared state (65); the persist gate is only covered via mocks, never the real provider (30).

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

AndresL230 added a commit that referenced this pull request Jul 30, 2026
@AndresL230@claude
fix(review): address all four#466review findings
64861e1
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AndresL230and others added 2 commits July 30, 2026 00:13
@AndresL230@claude
feat(frontend): public-beta SEO + shell polish (#169#170#171#187#172
17e796b
#188#191)
- #169: full root metadata — metadataBase (DEPLOY_ENV-derived via new
deployGuard.resolveSiteUrl), title template, OG/Twitter cards with a
generated public/og.png, canonical.
- #170: robots.ts (staging fully disallowed; private app surface blocked),
sitemap.ts (public routes + job slugs), manifest.ts (brand identity).
- #171: per-page metadata on about/privacy/terms/careers; careers page split
into a server wrapper + CareersList client child; per-job generateMetadata.
- #187: unknown careers slug now hard-404s via notFound().
- #172: real app/global-error.tsx (own <html>/<body>, branded ErrorFallback);
the misnamed root segment boundary renamed GlobalError → RootError.
- #188: (shell)/loading.tsx paints an instant skeleton on route transitions.
- #191: localStorage identity persists only after a confirmed /me
(setActiveUser persist gate through callback + SignInModal broadcast);
UserContext clears stale identity on definitive 401/404 from the existing
profile fetch — 5xx/network keep the session.
- e2e: public-seo.spec.ts pins robots/sitemap/manifest/careers-404/og tags.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230@claude
fix(review): address all four#466review findings
f118d9f
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230
AndresL230 merged commit b9b0b89 into mainJul 30, 2026
7 checks passed
@AndresL230AndresL230 mentioned this pull request Jul 30, 2026
Merged
@AndresL230
AndresL230 deleted the b8-beta-polish branch August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191) - #466
Merged
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Jul 30, 2026
Merged
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191)#466
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Conversation
@AndresL230
@AndresL230AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

Collaborator
Bundle B8 — public-beta polish
Closes#169, closes#170, closes#171, closes#187, closes#172, closes#188, closes#191.
SEO (#169#170#171#187)
  • Root metadata (app/layout.tsx): metadataBase derived from DEPLOY_ENV via a new deployGuard.resolveSiteUrl (ADR-0022 single-knob; NEXT_PUBLIC_SITE_URL overrides for local/preview), title template, OpenGraph + Twitter cards backed by a generated public/og.png (1200×630), canonical.
  • robots.ts: allows the public surface, disallows the entire private app shell (mirrors middleware.ts PROTECTED) — and disallows everything on staging so staging twins never compete with canonical pages.
  • sitemap.ts: public marketing/legal routes + per-job careers slugs. manifest.ts: brand name/colors/icon.
  • Per-page metadata: about/privacy/terms export metadata; careers split into a server wrapper (page.tsx, holds metadata) + CareersList.tsx client child (UI unchanged, moved verbatim); careers/[slug] gets per-job generateMetadata.
  • Careers [slug] page returns 200 + fallback UI for invalid slugs (soft 404) #187: unknown careers slug now calls notFound() → real HTTP 404 instead of a 200 soft-404.
Shell (#172#188)
  • Real app/global-error.tsx rendering its own <html>/<body> + branded ErrorFallback (imports globals.css since it replaces the root layout); the misnamed segment boundary error.tsx renamed GlobalError → RootError.
  • (shell)/loading.tsx: instant neutral skeleton on shell route transitions.
Auth state honesty (#191)
  • setActiveUser gains a { persist } option: localStorage identity is written only after GET /api/auth/me confirms the session (gated in the OAuth callback, and through the popup broadcast via a new profileConfirmed payload field consumed by SignInModal). On a failed /me, the tab still signs in (context hydrates) but nothing persists — the provider's cookie fallback reconciles on the next full load.
  • UserContext.fetchProfileData (already fired on every authed mount) now clears the stale identity on a definitive 401/404; 5xx/network failures keep the session (a server blip must not sign anyone out).
Tests
  • 25 new vitest cases: seo.test.ts (metadata/robots/sitemap/manifest/notFound + resolveSiteUrl), globalError.test.tsx, shellLoading.test.tsx, UserContext.reconcile.test.tsx (401/404 clear, 5xx/network keep), callback.test.tsx (persist gate + clean failure).
  • Promoted journey e2e/public-seo.spec.ts: robots/sitemap/manifest resolve, careers hard-404, OG tags on the landing HTML.
  • Full suite: 41 files / 308 tests green (now 313); tsc --noEmit clean; eslint . 0 errors with no suppressions-baseline changes (the one new exhaustive-deps hit was fixed properly via useCallback).
Notes for review
  • next build cannot run inside the worktree (Turbopack rejects the symlinked node_modules); the build is exercised by the pre-merge e2e cycle from the primary checkout (stack build) before merge.
  • No docs/frontend-testids.md / eslint.config.mjs changes needed: no new interactive elements on testid'd surfaces (the journey is pure HTTP).
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@AndresL230, you've reached your PR review limit, so we couldn't start this review.
Next review available in:21 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2c96c88e-0548-4c51-902d-f0d1b8965a58
📥 Commits
Reviewing files that changed from the base of the PR and between 1102093 and f118d9f.
⛔ Files ignored due to path filters (1)
  • frontend/public/og.png is excluded by !**/*.png
📒 Files selected for processing (23)
  • frontend/e2e/public-seo.spec.ts
  • frontend/src/app/(public)/about/page.tsx
  • frontend/src/app/(public)/careers/CareersList.tsx
  • frontend/src/app/(public)/careers/[slug]/page.tsx
  • frontend/src/app/(public)/careers/page.tsx
  • frontend/src/app/(public)/privacy/page.tsx
  • frontend/src/app/(public)/terms/page.tsx
  • frontend/src/app/(shell)/loading.tsx
  • frontend/src/app/auth/callback/callback.test.tsx
  • frontend/src/app/auth/callback/page.tsx
  • frontend/src/app/error.tsx
  • frontend/src/app/global-error.tsx
  • frontend/src/app/globalError.test.tsx
  • frontend/src/app/layout.tsx
  • frontend/src/app/manifest.ts
  • frontend/src/app/robots.ts
  • frontend/src/app/seo.test.ts
  • frontend/src/app/shellLoading.test.tsx
  • frontend/src/app/sitemap.ts
  • frontend/src/components/SignInModal.tsx
  • frontend/src/context/UserContext.reconcile.test.tsx
  • frontend/src/context/UserContext.tsx
  • frontend/src/lib/deployGuard.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers
The latest updates on your project. Learn more about integrating Git with Workers.
StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful! 
View logs		frontend-stagingf118d9fCommit Preview URL

Branch Preview URL		Jul 30 2026, 07:26 AM
@AndresL230
AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Code review
Found 1 issue:
  1. The new (shell)/loading.tssx fallback fabricates its own topbar skeleton (avatar circle + text bar + pill), but the shell's real TopNav/SideNav are persistent chrome rendered by ShellFrameoutside the {children} slot — Next mounts loading.tsx inside <main>, so every shell route transition flashes a second, skeleton-shaped topbar stacked directly under the real one (bug due to ShellFrame.tsx rendering <TopNav/>/<SideNav/> around <main>, not inside it)
Sapling/frontend/src/app/(shell)/loading.tsx

Lines 13 to 20
in
818840d
>
<divstyle={{display: "flex",alignItems: "center",gap: 12,marginBottom: 28}}>
<Skeletonwidth={26}height={26}circle/>
<Skeletonwidth={140}height={16}/>
<divstyle={{flex: 1}}/>
<Skeletonwidth={90}height={28}radius="var(--r-full)"/>
</div>
<divstyle={{maxWidth: 1080,margin: "0 auto",display: "flex",flexDirection: "column",gap: 14}}>
Sub-threshold notes (verified, being fixed in a follow-up commit on this PR, scores <80): resolveSiteUrl checks NEXT_PUBLIC_SITE_URL before DEPLOY_ENV, inverting the ADR-0022 precedence its own doc comment claims (75); the new 401/404 auto-clear in fetchProfileData can strand a just-signed-in tab on a shell route with cleared state (65); the persist gate is only covered via mocks, never the real provider (30).
🤖 Generated with Claude Code
- If this code review was useful, please react with 👍. Otherwise, react with 👎.
AndresL230 added a commit
that referenced
this pull request
Jul 30, 2026
@AndresL230@claude
fix(review): address all four#466review findings
64861e1
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AndresL230and others
added 2 commits
July 30, 2026 00:13
@AndresL230@claude
feat(frontend): public-beta SEO + shell polish (#169#170#171#187#172
17e796b
#188#191)
- #169: full root metadata — metadataBase (DEPLOY_ENV-derived via new
deployGuard.resolveSiteUrl), title template, OG/Twitter cards with a
generated public/og.png, canonical.
- #170: robots.ts (staging fully disallowed; private app surface blocked),
sitemap.ts (public routes + job slugs), manifest.ts (brand identity).
- #171: per-page metadata on about/privacy/terms/careers; careers page split
into a server wrapper + CareersList client child; per-job generateMetadata.
- #187: unknown careers slug now hard-404s via notFound().
- #172: real app/global-error.tsx (own <html>/<body>, branded ErrorFallback);
the misnamed root segment boundary renamed GlobalError → RootError.
- #188: (shell)/loading.tsx paints an instant skeleton on route transitions.
- #191: localStorage identity persists only after a confirmed /me
(setActiveUser persist gate through callback + SignInModal broadcast);
UserContext clears stale identity on definitive 401/404 from the existing
profile fetch — 5xx/network keep the session.
- e2e: public-seo.spec.ts pins robots/sitemap/manifest/careers-404/og tags.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230@claude
fix(review): address all four#466review findings
f118d9f
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230
AndresL230
merged commit b9b0b89
into
mainJul 30, 2026

7 checks passed

@AndresL230AndresL230
mentioned this pull request
Jul 30, 2026
 Merged

@AndresL230
AndresL230
deleted the

b8-beta-polish

branch
August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191) - #466
Merged
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Jul 30, 2026
Merged
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191)#466
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Conversation
@AndresL230
@AndresL230AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

Collaborator
Bundle B8 — public-beta polish
Closes#169, closes#170, closes#171, closes#187, closes#172, closes#188, closes#191.
SEO (#169#170#171#187)
  • Root metadata (app/layout.tsx): metadataBase derived from DEPLOY_ENV via a new deployGuard.resolveSiteUrl (ADR-0022 single-knob; NEXT_PUBLIC_SITE_URL overrides for local/preview), title template, OpenGraph + Twitter cards backed by a generated public/og.png (1200×630), canonical.
  • robots.ts: allows the public surface, disallows the entire private app shell (mirrors middleware.ts PROTECTED) — and disallows everything on staging so staging twins never compete with canonical pages.
  • sitemap.ts: public marketing/legal routes + per-job careers slugs. manifest.ts: brand name/colors/icon.
  • Per-page metadata: about/privacy/terms export metadata; careers split into a server wrapper (page.tsx, holds metadata) + CareersList.tsx client child (UI unchanged, moved verbatim); careers/[slug] gets per-job generateMetadata.
  • Careers [slug] page returns 200 + fallback UI for invalid slugs (soft 404) #187: unknown careers slug now calls notFound() → real HTTP 404 instead of a 200 soft-404.
Shell (#172#188)
  • Real app/global-error.tsx rendering its own <html>/<body> + branded ErrorFallback (imports globals.css since it replaces the root layout); the misnamed segment boundary error.tsx renamed GlobalError → RootError.
  • (shell)/loading.tsx: instant neutral skeleton on shell route transitions.
Auth state honesty (#191)
  • setActiveUser gains a { persist } option: localStorage identity is written only after GET /api/auth/me confirms the session (gated in the OAuth callback, and through the popup broadcast via a new profileConfirmed payload field consumed by SignInModal). On a failed /me, the tab still signs in (context hydrates) but nothing persists — the provider's cookie fallback reconciles on the next full load.
  • UserContext.fetchProfileData (already fired on every authed mount) now clears the stale identity on a definitive 401/404; 5xx/network failures keep the session (a server blip must not sign anyone out).
Tests
  • 25 new vitest cases: seo.test.ts (metadata/robots/sitemap/manifest/notFound + resolveSiteUrl), globalError.test.tsx, shellLoading.test.tsx, UserContext.reconcile.test.tsx (401/404 clear, 5xx/network keep), callback.test.tsx (persist gate + clean failure).
  • Promoted journey e2e/public-seo.spec.ts: robots/sitemap/manifest resolve, careers hard-404, OG tags on the landing HTML.
  • Full suite: 41 files / 308 tests green (now 313); tsc --noEmit clean; eslint . 0 errors with no suppressions-baseline changes (the one new exhaustive-deps hit was fixed properly via useCallback).
Notes for review
  • next build cannot run inside the worktree (Turbopack rejects the symlinked node_modules); the build is exercised by the pre-merge e2e cycle from the primary checkout (stack build) before merge.
  • No docs/frontend-testids.md / eslint.config.mjs changes needed: no new interactive elements on testid'd surfaces (the journey is pure HTTP).
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@AndresL230, you've reached your PR review limit, so we couldn't start this review.
Next review available in:21 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2c96c88e-0548-4c51-902d-f0d1b8965a58
📥 Commits
Reviewing files that changed from the base of the PR and between 1102093 and f118d9f.
⛔ Files ignored due to path filters (1)
  • frontend/public/og.png is excluded by !**/*.png
📒 Files selected for processing (23)
  • frontend/e2e/public-seo.spec.ts
  • frontend/src/app/(public)/about/page.tsx
  • frontend/src/app/(public)/careers/CareersList.tsx
  • frontend/src/app/(public)/careers/[slug]/page.tsx
  • frontend/src/app/(public)/careers/page.tsx
  • frontend/src/app/(public)/privacy/page.tsx
  • frontend/src/app/(public)/terms/page.tsx
  • frontend/src/app/(shell)/loading.tsx
  • frontend/src/app/auth/callback/callback.test.tsx
  • frontend/src/app/auth/callback/page.tsx
  • frontend/src/app/error.tsx
  • frontend/src/app/global-error.tsx
  • frontend/src/app/globalError.test.tsx
  • frontend/src/app/layout.tsx
  • frontend/src/app/manifest.ts
  • frontend/src/app/robots.ts
  • frontend/src/app/seo.test.ts
  • frontend/src/app/shellLoading.test.tsx
  • frontend/src/app/sitemap.ts
  • frontend/src/components/SignInModal.tsx
  • frontend/src/context/UserContext.reconcile.test.tsx
  • frontend/src/context/UserContext.tsx
  • frontend/src/lib/deployGuard.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers
The latest updates on your project. Learn more about integrating Git with Workers.
StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful! 
View logs		frontend-stagingf118d9fCommit Preview URL

Branch Preview URL		Jul 30 2026, 07:26 AM
@AndresL230
AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Code review
Found 1 issue:
  1. The new (shell)/loading.tssx fallback fabricates its own topbar skeleton (avatar circle + text bar + pill), but the shell's real TopNav/SideNav are persistent chrome rendered by ShellFrameoutside the {children} slot — Next mounts loading.tsx inside <main>, so every shell route transition flashes a second, skeleton-shaped topbar stacked directly under the real one (bug due to ShellFrame.tsx rendering <TopNav/>/<SideNav/> around <main>, not inside it)
Sapling/frontend/src/app/(shell)/loading.tsx

Lines 13 to 20
in
818840d
>
<divstyle={{display: "flex",alignItems: "center",gap: 12,marginBottom: 28}}>
<Skeletonwidth={26}height={26}circle/>
<Skeletonwidth={140}height={16}/>
<divstyle={{flex: 1}}/>
<Skeletonwidth={90}height={28}radius="var(--r-full)"/>
</div>
<divstyle={{maxWidth: 1080,margin: "0 auto",display: "flex",flexDirection: "column",gap: 14}}>
Sub-threshold notes (verified, being fixed in a follow-up commit on this PR, scores <80): resolveSiteUrl checks NEXT_PUBLIC_SITE_URL before DEPLOY_ENV, inverting the ADR-0022 precedence its own doc comment claims (75); the new 401/404 auto-clear in fetchProfileData can strand a just-signed-in tab on a shell route with cleared state (65); the persist gate is only covered via mocks, never the real provider (30).
🤖 Generated with Claude Code
- If this code review was useful, please react with 👍. Otherwise, react with 👎.
AndresL230 added a commit
that referenced
this pull request
Jul 30, 2026
@AndresL230@claude
fix(review): address all four#466review findings
64861e1
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AndresL230and others
added 2 commits
July 30, 2026 00:13
@AndresL230@claude
feat(frontend): public-beta SEO + shell polish (#169#170#171#187#172
17e796b
#188#191)
- #169: full root metadata — metadataBase (DEPLOY_ENV-derived via new
deployGuard.resolveSiteUrl), title template, OG/Twitter cards with a
generated public/og.png, canonical.
- #170: robots.ts (staging fully disallowed; private app surface blocked),
sitemap.ts (public routes + job slugs), manifest.ts (brand identity).
- #171: per-page metadata on about/privacy/terms/careers; careers page split
into a server wrapper + CareersList client child; per-job generateMetadata.
- #187: unknown careers slug now hard-404s via notFound().
- #172: real app/global-error.tsx (own <html>/<body>, branded ErrorFallback);
the misnamed root segment boundary renamed GlobalError → RootError.
- #188: (shell)/loading.tsx paints an instant skeleton on route transitions.
- #191: localStorage identity persists only after a confirmed /me
(setActiveUser persist gate through callback + SignInModal broadcast);
UserContext clears stale identity on definitive 401/404 from the existing
profile fetch — 5xx/network keep the session.
- e2e: public-seo.spec.ts pins robots/sitemap/manifest/careers-404/og tags.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230@claude
fix(review): address all four#466review findings
f118d9f
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230
AndresL230
merged commit b9b0b89
into
mainJul 30, 2026

7 checks passed

@AndresL230AndresL230
mentioned this pull request
Jul 30, 2026
 Merged

@AndresL230
AndresL230
deleted the

b8-beta-polish

branch
August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191) - #466
Merged
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Jul 30, 2026
Merged
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191)#466
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Conversation
@AndresL230
@AndresL230AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

Collaborator
Bundle B8 — public-beta polish
Closes#169, closes#170, closes#171, closes#187, closes#172, closes#188, closes#191.
SEO (#169#170#171#187)
  • Root metadata (app/layout.tsx): metadataBase derived from DEPLOY_ENV via a new deployGuard.resolveSiteUrl (ADR-0022 single-knob; NEXT_PUBLIC_SITE_URL overrides for local/preview), title template, OpenGraph + Twitter cards backed by a generated public/og.png (1200×630), canonical.
  • robots.ts: allows the public surface, disallows the entire private app shell (mirrors middleware.ts PROTECTED) — and disallows everything on staging so staging twins never compete with canonical pages.
  • sitemap.ts: public marketing/legal routes + per-job careers slugs. manifest.ts: brand name/colors/icon.
  • Per-page metadata: about/privacy/terms export metadata; careers split into a server wrapper (page.tsx, holds metadata) + CareersList.tsx client child (UI unchanged, moved verbatim); careers/[slug] gets per-job generateMetadata.
  • Careers [slug] page returns 200 + fallback UI for invalid slugs (soft 404) #187: unknown careers slug now calls notFound() → real HTTP 404 instead of a 200 soft-404.
Shell (#172#188)
  • Real app/global-error.tsx rendering its own <html>/<body> + branded ErrorFallback (imports globals.css since it replaces the root layout); the misnamed segment boundary error.tsx renamed GlobalError → RootError.
  • (shell)/loading.tsx: instant neutral skeleton on shell route transitions.
Auth state honesty (#191)
  • setActiveUser gains a { persist } option: localStorage identity is written only after GET /api/auth/me confirms the session (gated in the OAuth callback, and through the popup broadcast via a new profileConfirmed payload field consumed by SignInModal). On a failed /me, the tab still signs in (context hydrates) but nothing persists — the provider's cookie fallback reconciles on the next full load.
  • UserContext.fetchProfileData (already fired on every authed mount) now clears the stale identity on a definitive 401/404; 5xx/network failures keep the session (a server blip must not sign anyone out).
Tests
  • 25 new vitest cases: seo.test.ts (metadata/robots/sitemap/manifest/notFound + resolveSiteUrl), globalError.test.tsx, shellLoading.test.tsx, UserContext.reconcile.test.tsx (401/404 clear, 5xx/network keep), callback.test.tsx (persist gate + clean failure).
  • Promoted journey e2e/public-seo.spec.ts: robots/sitemap/manifest resolve, careers hard-404, OG tags on the landing HTML.
  • Full suite: 41 files / 308 tests green (now 313); tsc --noEmit clean; eslint . 0 errors with no suppressions-baseline changes (the one new exhaustive-deps hit was fixed properly via useCallback).
Notes for review
  • next build cannot run inside the worktree (Turbopack rejects the symlinked node_modules); the build is exercised by the pre-merge e2e cycle from the primary checkout (stack build) before merge.
  • No docs/frontend-testids.md / eslint.config.mjs changes needed: no new interactive elements on testid'd surfaces (the journey is pure HTTP).
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@AndresL230, you've reached your PR review limit, so we couldn't start this review.
Next review available in:21 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2c96c88e-0548-4c51-902d-f0d1b8965a58
📥 Commits
Reviewing files that changed from the base of the PR and between 1102093 and f118d9f.
⛔ Files ignored due to path filters (1)
  • frontend/public/og.png is excluded by !**/*.png
📒 Files selected for processing (23)
  • frontend/e2e/public-seo.spec.ts
  • frontend/src/app/(public)/about/page.tsx
  • frontend/src/app/(public)/careers/CareersList.tsx
  • frontend/src/app/(public)/careers/[slug]/page.tsx
  • frontend/src/app/(public)/careers/page.tsx
  • frontend/src/app/(public)/privacy/page.tsx
  • frontend/src/app/(public)/terms/page.tsx
  • frontend/src/app/(shell)/loading.tsx
  • frontend/src/app/auth/callback/callback.test.tsx
  • frontend/src/app/auth/callback/page.tsx
  • frontend/src/app/error.tsx
  • frontend/src/app/global-error.tsx
  • frontend/src/app/globalError.test.tsx
  • frontend/src/app/layout.tsx
  • frontend/src/app/manifest.ts
  • frontend/src/app/robots.ts
  • frontend/src/app/seo.test.ts
  • frontend/src/app/shellLoading.test.tsx
  • frontend/src/app/sitemap.ts
  • frontend/src/components/SignInModal.tsx
  • frontend/src/context/UserContext.reconcile.test.tsx
  • frontend/src/context/UserContext.tsx
  • frontend/src/lib/deployGuard.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers
The latest updates on your project. Learn more about integrating Git with Workers.
StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful! 
View logs		frontend-stagingf118d9fCommit Preview URL

Branch Preview URL		Jul 30 2026, 07:26 AM
@AndresL230
AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Code review
Found 1 issue:
  1. The new (shell)/loading.tssx fallback fabricates its own topbar skeleton (avatar circle + text bar + pill), but the shell's real TopNav/SideNav are persistent chrome rendered by ShellFrameoutside the {children} slot — Next mounts loading.tsx inside <main>, so every shell route transition flashes a second, skeleton-shaped topbar stacked directly under the real one (bug due to ShellFrame.tsx rendering <TopNav/>/<SideNav/> around <main>, not inside it)
Sapling/frontend/src/app/(shell)/loading.tsx

Lines 13 to 20
in
818840d
>
<divstyle={{display: "flex",alignItems: "center",gap: 12,marginBottom: 28}}>
<Skeletonwidth={26}height={26}circle/>
<Skeletonwidth={140}height={16}/>
<divstyle={{flex: 1}}/>
<Skeletonwidth={90}height={28}radius="var(--r-full)"/>
</div>
<divstyle={{maxWidth: 1080,margin: "0 auto",display: "flex",flexDirection: "column",gap: 14}}>
Sub-threshold notes (verified, being fixed in a follow-up commit on this PR, scores <80): resolveSiteUrl checks NEXT_PUBLIC_SITE_URL before DEPLOY_ENV, inverting the ADR-0022 precedence its own doc comment claims (75); the new 401/404 auto-clear in fetchProfileData can strand a just-signed-in tab on a shell route with cleared state (65); the persist gate is only covered via mocks, never the real provider (30).
🤖 Generated with Claude Code
- If this code review was useful, please react with 👍. Otherwise, react with 👎.
AndresL230 added a commit
that referenced
this pull request
Jul 30, 2026
@AndresL230@claude
fix(review): address all four#466review findings
64861e1
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AndresL230and others
added 2 commits
July 30, 2026 00:13
@AndresL230@claude
feat(frontend): public-beta SEO + shell polish (#169#170#171#187#172
17e796b
#188#191)
- #169: full root metadata — metadataBase (DEPLOY_ENV-derived via new
deployGuard.resolveSiteUrl), title template, OG/Twitter cards with a
generated public/og.png, canonical.
- #170: robots.ts (staging fully disallowed; private app surface blocked),
sitemap.ts (public routes + job slugs), manifest.ts (brand identity).
- #171: per-page metadata on about/privacy/terms/careers; careers page split
into a server wrapper + CareersList client child; per-job generateMetadata.
- #187: unknown careers slug now hard-404s via notFound().
- #172: real app/global-error.tsx (own <html>/<body>, branded ErrorFallback);
the misnamed root segment boundary renamed GlobalError → RootError.
- #188: (shell)/loading.tsx paints an instant skeleton on route transitions.
- #191: localStorage identity persists only after a confirmed /me
(setActiveUser persist gate through callback + SignInModal broadcast);
UserContext clears stale identity on definitive 401/404 from the existing
profile fetch — 5xx/network keep the session.
- e2e: public-seo.spec.ts pins robots/sitemap/manifest/careers-404/og tags.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230@claude
fix(review): address all four#466review findings
f118d9f
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230
AndresL230
merged commit b9b0b89
into
mainJul 30, 2026

7 checks passed

@AndresL230AndresL230
mentioned this pull request
Jul 30, 2026
 Merged

@AndresL230
AndresL230
deleted the

b8-beta-polish

branch
August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191) - #466
Merged
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Jul 30, 2026
Merged
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191)#466
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Conversation
@AndresL230
@AndresL230AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

Collaborator
Bundle B8 — public-beta polish
Closes#169, closes#170, closes#171, closes#187, closes#172, closes#188, closes#191.
SEO (#169#170#171#187)
  • Root metadata (app/layout.tsx): metadataBase derived from DEPLOY_ENV via a new deployGuard.resolveSiteUrl (ADR-0022 single-knob; NEXT_PUBLIC_SITE_URL overrides for local/preview), title template, OpenGraph + Twitter cards backed by a generated public/og.png (1200×630), canonical.
  • robots.ts: allows the public surface, disallows the entire private app shell (mirrors middleware.ts PROTECTED) — and disallows everything on staging so staging twins never compete with canonical pages.
  • sitemap.ts: public marketing/legal routes + per-job careers slugs. manifest.ts: brand name/colors/icon.
  • Per-page metadata: about/privacy/terms export metadata; careers split into a server wrapper (page.tsx, holds metadata) + CareersList.tsx client child (UI unchanged, moved verbatim); careers/[slug] gets per-job generateMetadata.
  • Careers [slug] page returns 200 + fallback UI for invalid slugs (soft 404) #187: unknown careers slug now calls notFound() → real HTTP 404 instead of a 200 soft-404.
Shell (#172#188)
  • Real app/global-error.tsx rendering its own <html>/<body> + branded ErrorFallback (imports globals.css since it replaces the root layout); the misnamed segment boundary error.tsx renamed GlobalError → RootError.
  • (shell)/loading.tsx: instant neutral skeleton on shell route transitions.
Auth state honesty (#191)
  • setActiveUser gains a { persist } option: localStorage identity is written only after GET /api/auth/me confirms the session (gated in the OAuth callback, and through the popup broadcast via a new profileConfirmed payload field consumed by SignInModal). On a failed /me, the tab still signs in (context hydrates) but nothing persists — the provider's cookie fallback reconciles on the next full load.
  • UserContext.fetchProfileData (already fired on every authed mount) now clears the stale identity on a definitive 401/404; 5xx/network failures keep the session (a server blip must not sign anyone out).
Tests
  • 25 new vitest cases: seo.test.ts (metadata/robots/sitemap/manifest/notFound + resolveSiteUrl), globalError.test.tsx, shellLoading.test.tsx, UserContext.reconcile.test.tsx (401/404 clear, 5xx/network keep), callback.test.tsx (persist gate + clean failure).
  • Promoted journey e2e/public-seo.spec.ts: robots/sitemap/manifest resolve, careers hard-404, OG tags on the landing HTML.
  • Full suite: 41 files / 308 tests green (now 313); tsc --noEmit clean; eslint . 0 errors with no suppressions-baseline changes (the one new exhaustive-deps hit was fixed properly via useCallback).
Notes for review
  • next build cannot run inside the worktree (Turbopack rejects the symlinked node_modules); the build is exercised by the pre-merge e2e cycle from the primary checkout (stack build) before merge.
  • No docs/frontend-testids.md / eslint.config.mjs changes needed: no new interactive elements on testid'd surfaces (the journey is pure HTTP).
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@AndresL230, you've reached your PR review limit, so we couldn't start this review.
Next review available in:21 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2c96c88e-0548-4c51-902d-f0d1b8965a58
📥 Commits
Reviewing files that changed from the base of the PR and between 1102093 and f118d9f.
⛔ Files ignored due to path filters (1)
  • frontend/public/og.png is excluded by !**/*.png
📒 Files selected for processing (23)
  • frontend/e2e/public-seo.spec.ts
  • frontend/src/app/(public)/about/page.tsx
  • frontend/src/app/(public)/careers/CareersList.tsx
  • frontend/src/app/(public)/careers/[slug]/page.tsx
  • frontend/src/app/(public)/careers/page.tsx
  • frontend/src/app/(public)/privacy/page.tsx
  • frontend/src/app/(public)/terms/page.tsx
  • frontend/src/app/(shell)/loading.tsx
  • frontend/src/app/auth/callback/callback.test.tsx
  • frontend/src/app/auth/callback/page.tsx
  • frontend/src/app/error.tsx
  • frontend/src/app/global-error.tsx
  • frontend/src/app/globalError.test.tsx
  • frontend/src/app/layout.tsx
  • frontend/src/app/manifest.ts
  • frontend/src/app/robots.ts
  • frontend/src/app/seo.test.ts
  • frontend/src/app/shellLoading.test.tsx
  • frontend/src/app/sitemap.ts
  • frontend/src/components/SignInModal.tsx
  • frontend/src/context/UserContext.reconcile.test.tsx
  • frontend/src/context/UserContext.tsx
  • frontend/src/lib/deployGuard.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers
The latest updates on your project. Learn more about integrating Git with Workers.
StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful! 
View logs		frontend-stagingf118d9fCommit Preview URL

Branch Preview URL		Jul 30 2026, 07:26 AM
@AndresL230
AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Code review
Found 1 issue:
  1. The new (shell)/loading.tssx fallback fabricates its own topbar skeleton (avatar circle + text bar + pill), but the shell's real TopNav/SideNav are persistent chrome rendered by ShellFrameoutside the {children} slot — Next mounts loading.tsx inside <main>, so every shell route transition flashes a second, skeleton-shaped topbar stacked directly under the real one (bug due to ShellFrame.tsx rendering <TopNav/>/<SideNav/> around <main>, not inside it)
Sapling/frontend/src/app/(shell)/loading.tsx

Lines 13 to 20
in
818840d
>
<divstyle={{display: "flex",alignItems: "center",gap: 12,marginBottom: 28}}>
<Skeletonwidth={26}height={26}circle/>
<Skeletonwidth={140}height={16}/>
<divstyle={{flex: 1}}/>
<Skeletonwidth={90}height={28}radius="var(--r-full)"/>
</div>
<divstyle={{maxWidth: 1080,margin: "0 auto",display: "flex",flexDirection: "column",gap: 14}}>
Sub-threshold notes (verified, being fixed in a follow-up commit on this PR, scores <80): resolveSiteUrl checks NEXT_PUBLIC_SITE_URL before DEPLOY_ENV, inverting the ADR-0022 precedence its own doc comment claims (75); the new 401/404 auto-clear in fetchProfileData can strand a just-signed-in tab on a shell route with cleared state (65); the persist gate is only covered via mocks, never the real provider (30).
🤖 Generated with Claude Code
- If this code review was useful, please react with 👍. Otherwise, react with 👎.
AndresL230 added a commit
that referenced
this pull request
Jul 30, 2026
@AndresL230@claude
fix(review): address all four#466review findings
64861e1
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AndresL230and others
added 2 commits
July 30, 2026 00:13
@AndresL230@claude
feat(frontend): public-beta SEO + shell polish (#169#170#171#187#172
17e796b
#188#191)
- #169: full root metadata — metadataBase (DEPLOY_ENV-derived via new
deployGuard.resolveSiteUrl), title template, OG/Twitter cards with a
generated public/og.png, canonical.
- #170: robots.ts (staging fully disallowed; private app surface blocked),
sitemap.ts (public routes + job slugs), manifest.ts (brand identity).
- #171: per-page metadata on about/privacy/terms/careers; careers page split
into a server wrapper + CareersList client child; per-job generateMetadata.
- #187: unknown careers slug now hard-404s via notFound().
- #172: real app/global-error.tsx (own <html>/<body>, branded ErrorFallback);
the misnamed root segment boundary renamed GlobalError → RootError.
- #188: (shell)/loading.tsx paints an instant skeleton on route transitions.
- #191: localStorage identity persists only after a confirmed /me
(setActiveUser persist gate through callback + SignInModal broadcast);
UserContext clears stale identity on definitive 401/404 from the existing
profile fetch — 5xx/network keep the session.
- e2e: public-seo.spec.ts pins robots/sitemap/manifest/careers-404/og tags.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230@claude
fix(review): address all four#466review findings
f118d9f
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230
AndresL230
merged commit b9b0b89
into
mainJul 30, 2026

7 checks passed

@AndresL230AndresL230
mentioned this pull request
Jul 30, 2026
 Merged

@AndresL230
AndresL230
deleted the

b8-beta-polish

branch
August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191) - #466
Merged
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Jul 30, 2026
Merged
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191)#466
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Conversation
@AndresL230
@AndresL230AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

Collaborator
Bundle B8 — public-beta polish
Closes#169, closes#170, closes#171, closes#187, closes#172, closes#188, closes#191.
SEO (#169#170#171#187)
  • Root metadata (app/layout.tsx): metadataBase derived from DEPLOY_ENV via a new deployGuard.resolveSiteUrl (ADR-0022 single-knob; NEXT_PUBLIC_SITE_URL overrides for local/preview), title template, OpenGraph + Twitter cards backed by a generated public/og.png (1200×630), canonical.
  • robots.ts: allows the public surface, disallows the entire private app shell (mirrors middleware.ts PROTECTED) — and disallows everything on staging so staging twins never compete with canonical pages.
  • sitemap.ts: public marketing/legal routes + per-job careers slugs. manifest.ts: brand name/colors/icon.
  • Per-page metadata: about/privacy/terms export metadata; careers split into a server wrapper (page.tsx, holds metadata) + CareersList.tsx client child (UI unchanged, moved verbatim); careers/[slug] gets per-job generateMetadata.
  • Careers [slug] page returns 200 + fallback UI for invalid slugs (soft 404) #187: unknown careers slug now calls notFound() → real HTTP 404 instead of a 200 soft-404.
Shell (#172#188)
  • Real app/global-error.tsx rendering its own <html>/<body> + branded ErrorFallback (imports globals.css since it replaces the root layout); the misnamed segment boundary error.tsx renamed GlobalError → RootError.
  • (shell)/loading.tsx: instant neutral skeleton on shell route transitions.
Auth state honesty (#191)
  • setActiveUser gains a { persist } option: localStorage identity is written only after GET /api/auth/me confirms the session (gated in the OAuth callback, and through the popup broadcast via a new profileConfirmed payload field consumed by SignInModal). On a failed /me, the tab still signs in (context hydrates) but nothing persists — the provider's cookie fallback reconciles on the next full load.
  • UserContext.fetchProfileData (already fired on every authed mount) now clears the stale identity on a definitive 401/404; 5xx/network failures keep the session (a server blip must not sign anyone out).
Tests
  • 25 new vitest cases: seo.test.ts (metadata/robots/sitemap/manifest/notFound + resolveSiteUrl), globalError.test.tsx, shellLoading.test.tsx, UserContext.reconcile.test.tsx (401/404 clear, 5xx/network keep), callback.test.tsx (persist gate + clean failure).
  • Promoted journey e2e/public-seo.spec.ts: robots/sitemap/manifest resolve, careers hard-404, OG tags on the landing HTML.
  • Full suite: 41 files / 308 tests green (now 313); tsc --noEmit clean; eslint . 0 errors with no suppressions-baseline changes (the one new exhaustive-deps hit was fixed properly via useCallback).
Notes for review
  • next build cannot run inside the worktree (Turbopack rejects the symlinked node_modules); the build is exercised by the pre-merge e2e cycle from the primary checkout (stack build) before merge.
  • No docs/frontend-testids.md / eslint.config.mjs changes needed: no new interactive elements on testid'd surfaces (the journey is pure HTTP).
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@AndresL230, you've reached your PR review limit, so we couldn't start this review.
Next review available in:21 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2c96c88e-0548-4c51-902d-f0d1b8965a58
📥 Commits
Reviewing files that changed from the base of the PR and between 1102093 and f118d9f.
⛔ Files ignored due to path filters (1)
  • frontend/public/og.png is excluded by !**/*.png
📒 Files selected for processing (23)
  • frontend/e2e/public-seo.spec.ts
  • frontend/src/app/(public)/about/page.tsx
  • frontend/src/app/(public)/careers/CareersList.tsx
  • frontend/src/app/(public)/careers/[slug]/page.tsx
  • frontend/src/app/(public)/careers/page.tsx
  • frontend/src/app/(public)/privacy/page.tsx
  • frontend/src/app/(public)/terms/page.tsx
  • frontend/src/app/(shell)/loading.tsx
  • frontend/src/app/auth/callback/callback.test.tsx
  • frontend/src/app/auth/callback/page.tsx
  • frontend/src/app/error.tsx
  • frontend/src/app/global-error.tsx
  • frontend/src/app/globalError.test.tsx
  • frontend/src/app/layout.tsx
  • frontend/src/app/manifest.ts
  • frontend/src/app/robots.ts
  • frontend/src/app/seo.test.ts
  • frontend/src/app/shellLoading.test.tsx
  • frontend/src/app/sitemap.ts
  • frontend/src/components/SignInModal.tsx
  • frontend/src/context/UserContext.reconcile.test.tsx
  • frontend/src/context/UserContext.tsx
  • frontend/src/lib/deployGuard.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers
The latest updates on your project. Learn more about integrating Git with Workers.
StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful! 
View logs		frontend-stagingf118d9fCommit Preview URL

Branch Preview URL		Jul 30 2026, 07:26 AM
@AndresL230
AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Code review
Found 1 issue:
  1. The new (shell)/loading.tssx fallback fabricates its own topbar skeleton (avatar circle + text bar + pill), but the shell's real TopNav/SideNav are persistent chrome rendered by ShellFrameoutside the {children} slot — Next mounts loading.tsx inside <main>, so every shell route transition flashes a second, skeleton-shaped topbar stacked directly under the real one (bug due to ShellFrame.tsx rendering <TopNav/>/<SideNav/> around <main>, not inside it)
Sapling/frontend/src/app/(shell)/loading.tsx

Lines 13 to 20
in
818840d
>
<divstyle={{display: "flex",alignItems: "center",gap: 12,marginBottom: 28}}>
<Skeletonwidth={26}height={26}circle/>
<Skeletonwidth={140}height={16}/>
<divstyle={{flex: 1}}/>
<Skeletonwidth={90}height={28}radius="var(--r-full)"/>
</div>
<divstyle={{maxWidth: 1080,margin: "0 auto",display: "flex",flexDirection: "column",gap: 14}}>
Sub-threshold notes (verified, being fixed in a follow-up commit on this PR, scores <80): resolveSiteUrl checks NEXT_PUBLIC_SITE_URL before DEPLOY_ENV, inverting the ADR-0022 precedence its own doc comment claims (75); the new 401/404 auto-clear in fetchProfileData can strand a just-signed-in tab on a shell route with cleared state (65); the persist gate is only covered via mocks, never the real provider (30).
🤖 Generated with Claude Code
- If this code review was useful, please react with 👍. Otherwise, react with 👎.
AndresL230 added a commit
that referenced
this pull request
Jul 30, 2026
@AndresL230@claude
fix(review): address all four#466review findings
64861e1
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AndresL230and others
added 2 commits
July 30, 2026 00:13
@AndresL230@claude
feat(frontend): public-beta SEO + shell polish (#169#170#171#187#172
17e796b
#188#191)
- #169: full root metadata — metadataBase (DEPLOY_ENV-derived via new
deployGuard.resolveSiteUrl), title template, OG/Twitter cards with a
generated public/og.png, canonical.
- #170: robots.ts (staging fully disallowed; private app surface blocked),
sitemap.ts (public routes + job slugs), manifest.ts (brand identity).
- #171: per-page metadata on about/privacy/terms/careers; careers page split
into a server wrapper + CareersList client child; per-job generateMetadata.
- #187: unknown careers slug now hard-404s via notFound().
- #172: real app/global-error.tsx (own <html>/<body>, branded ErrorFallback);
the misnamed root segment boundary renamed GlobalError → RootError.
- #188: (shell)/loading.tsx paints an instant skeleton on route transitions.
- #191: localStorage identity persists only after a confirmed /me
(setActiveUser persist gate through callback + SignInModal broadcast);
UserContext clears stale identity on definitive 401/404 from the existing
profile fetch — 5xx/network keep the session.
- e2e: public-seo.spec.ts pins robots/sitemap/manifest/careers-404/og tags.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230@claude
fix(review): address all four#466review findings
f118d9f
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230
AndresL230
merged commit b9b0b89
into
mainJul 30, 2026

7 checks passed

@AndresL230AndresL230
mentioned this pull request
Jul 30, 2026
 Merged

@AndresL230
AndresL230
deleted the

b8-beta-polish

branch
August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191) - #466
Merged
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Jul 30, 2026
Merged
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191)#466
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Conversation
@AndresL230
@AndresL230AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

Collaborator
Bundle B8 — public-beta polish
Closes#169, closes#170, closes#171, closes#187, closes#172, closes#188, closes#191.
SEO (#169#170#171#187)
  • Root metadata (app/layout.tsx): metadataBase derived from DEPLOY_ENV via a new deployGuard.resolveSiteUrl (ADR-0022 single-knob; NEXT_PUBLIC_SITE_URL overrides for local/preview), title template, OpenGraph + Twitter cards backed by a generated public/og.png (1200×630), canonical.
  • robots.ts: allows the public surface, disallows the entire private app shell (mirrors middleware.ts PROTECTED) — and disallows everything on staging so staging twins never compete with canonical pages.
  • sitemap.ts: public marketing/legal routes + per-job careers slugs. manifest.ts: brand name/colors/icon.
  • Per-page metadata: about/privacy/terms export metadata; careers split into a server wrapper (page.tsx, holds metadata) + CareersList.tsx client child (UI unchanged, moved verbatim); careers/[slug] gets per-job generateMetadata.
  • Careers [slug] page returns 200 + fallback UI for invalid slugs (soft 404) #187: unknown careers slug now calls notFound() → real HTTP 404 instead of a 200 soft-404.
Shell (#172#188)
  • Real app/global-error.tsx rendering its own <html>/<body> + branded ErrorFallback (imports globals.css since it replaces the root layout); the misnamed segment boundary error.tsx renamed GlobalError → RootError.
  • (shell)/loading.tsx: instant neutral skeleton on shell route transitions.
Auth state honesty (#191)
  • setActiveUser gains a { persist } option: localStorage identity is written only after GET /api/auth/me confirms the session (gated in the OAuth callback, and through the popup broadcast via a new profileConfirmed payload field consumed by SignInModal). On a failed /me, the tab still signs in (context hydrates) but nothing persists — the provider's cookie fallback reconciles on the next full load.
  • UserContext.fetchProfileData (already fired on every authed mount) now clears the stale identity on a definitive 401/404; 5xx/network failures keep the session (a server blip must not sign anyone out).
Tests
  • 25 new vitest cases: seo.test.ts (metadata/robots/sitemap/manifest/notFound + resolveSiteUrl), globalError.test.tsx, shellLoading.test.tsx, UserContext.reconcile.test.tsx (401/404 clear, 5xx/network keep), callback.test.tsx (persist gate + clean failure).
  • Promoted journey e2e/public-seo.spec.ts: robots/sitemap/manifest resolve, careers hard-404, OG tags on the landing HTML.
  • Full suite: 41 files / 308 tests green (now 313); tsc --noEmit clean; eslint . 0 errors with no suppressions-baseline changes (the one new exhaustive-deps hit was fixed properly via useCallback).
Notes for review
  • next build cannot run inside the worktree (Turbopack rejects the symlinked node_modules); the build is exercised by the pre-merge e2e cycle from the primary checkout (stack build) before merge.
  • No docs/frontend-testids.md / eslint.config.mjs changes needed: no new interactive elements on testid'd surfaces (the journey is pure HTTP).
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@AndresL230, you've reached your PR review limit, so we couldn't start this review.
Next review available in:21 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2c96c88e-0548-4c51-902d-f0d1b8965a58
📥 Commits
Reviewing files that changed from the base of the PR and between 1102093 and f118d9f.
⛔ Files ignored due to path filters (1)
  • frontend/public/og.png is excluded by !**/*.png
📒 Files selected for processing (23)
  • frontend/e2e/public-seo.spec.ts
  • frontend/src/app/(public)/about/page.tsx
  • frontend/src/app/(public)/careers/CareersList.tsx
  • frontend/src/app/(public)/careers/[slug]/page.tsx
  • frontend/src/app/(public)/careers/page.tsx
  • frontend/src/app/(public)/privacy/page.tsx
  • frontend/src/app/(public)/terms/page.tsx
  • frontend/src/app/(shell)/loading.tsx
  • frontend/src/app/auth/callback/callback.test.tsx
  • frontend/src/app/auth/callback/page.tsx
  • frontend/src/app/error.tsx
  • frontend/src/app/global-error.tsx
  • frontend/src/app/globalError.test.tsx
  • frontend/src/app/layout.tsx
  • frontend/src/app/manifest.ts
  • frontend/src/app/robots.ts
  • frontend/src/app/seo.test.ts
  • frontend/src/app/shellLoading.test.tsx
  • frontend/src/app/sitemap.ts
  • frontend/src/components/SignInModal.tsx
  • frontend/src/context/UserContext.reconcile.test.tsx
  • frontend/src/context/UserContext.tsx
  • frontend/src/lib/deployGuard.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers
The latest updates on your project. Learn more about integrating Git with Workers.
StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful! 
View logs		frontend-stagingf118d9fCommit Preview URL

Branch Preview URL		Jul 30 2026, 07:26 AM
@AndresL230
AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Code review
Found 1 issue:
  1. The new (shell)/loading.tssx fallback fabricates its own topbar skeleton (avatar circle + text bar + pill), but the shell's real TopNav/SideNav are persistent chrome rendered by ShellFrameoutside the {children} slot — Next mounts loading.tsx inside <main>, so every shell route transition flashes a second, skeleton-shaped topbar stacked directly under the real one (bug due to ShellFrame.tsx rendering <TopNav/>/<SideNav/> around <main>, not inside it)
Sapling/frontend/src/app/(shell)/loading.tsx

Lines 13 to 20
in
818840d
>
<divstyle={{display: "flex",alignItems: "center",gap: 12,marginBottom: 28}}>
<Skeletonwidth={26}height={26}circle/>
<Skeletonwidth={140}height={16}/>
<divstyle={{flex: 1}}/>
<Skeletonwidth={90}height={28}radius="var(--r-full)"/>
</div>
<divstyle={{maxWidth: 1080,margin: "0 auto",display: "flex",flexDirection: "column",gap: 14}}>
Sub-threshold notes (verified, being fixed in a follow-up commit on this PR, scores <80): resolveSiteUrl checks NEXT_PUBLIC_SITE_URL before DEPLOY_ENV, inverting the ADR-0022 precedence its own doc comment claims (75); the new 401/404 auto-clear in fetchProfileData can strand a just-signed-in tab on a shell route with cleared state (65); the persist gate is only covered via mocks, never the real provider (30).
🤖 Generated with Claude Code
- If this code review was useful, please react with 👍. Otherwise, react with 👎.
AndresL230 added a commit
that referenced
this pull request
Jul 30, 2026
@AndresL230@claude
fix(review): address all four#466review findings
64861e1
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AndresL230and others
added 2 commits
July 30, 2026 00:13
@AndresL230@claude
feat(frontend): public-beta SEO + shell polish (#169#170#171#187#172
17e796b
#188#191)
- #169: full root metadata — metadataBase (DEPLOY_ENV-derived via new
deployGuard.resolveSiteUrl), title template, OG/Twitter cards with a
generated public/og.png, canonical.
- #170: robots.ts (staging fully disallowed; private app surface blocked),
sitemap.ts (public routes + job slugs), manifest.ts (brand identity).
- #171: per-page metadata on about/privacy/terms/careers; careers page split
into a server wrapper + CareersList client child; per-job generateMetadata.
- #187: unknown careers slug now hard-404s via notFound().
- #172: real app/global-error.tsx (own <html>/<body>, branded ErrorFallback);
the misnamed root segment boundary renamed GlobalError → RootError.
- #188: (shell)/loading.tsx paints an instant skeleton on route transitions.
- #191: localStorage identity persists only after a confirmed /me
(setActiveUser persist gate through callback + SignInModal broadcast);
UserContext clears stale identity on definitive 401/404 from the existing
profile fetch — 5xx/network keep the session.
- e2e: public-seo.spec.ts pins robots/sitemap/manifest/careers-404/og tags.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230@claude
fix(review): address all four#466review findings
f118d9f
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230
AndresL230
merged commit b9b0b89
into
mainJul 30, 2026

7 checks passed

@AndresL230AndresL230
mentioned this pull request
Jul 30, 2026
 Merged

@AndresL230
AndresL230
deleted the

b8-beta-polish

branch
August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191) - #466
Merged
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Jul 30, 2026
Merged
feat(frontend): public-beta SEO + shell polish (B8: #169 #170 #171 #187 #172 #188 #191)#466
AndresL230 merged 2 commits into
mainfrom 
b8-beta-polish
Conversation
@AndresL230
@AndresL230AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

Collaborator
Bundle B8 — public-beta polish
Closes#169, closes#170, closes#171, closes#187, closes#172, closes#188, closes#191.
SEO (#169#170#171#187)
  • Root metadata (app/layout.tsx): metadataBase derived from DEPLOY_ENV via a new deployGuard.resolveSiteUrl (ADR-0022 single-knob; NEXT_PUBLIC_SITE_URL overrides for local/preview), title template, OpenGraph + Twitter cards backed by a generated public/og.png (1200×630), canonical.
  • robots.ts: allows the public surface, disallows the entire private app shell (mirrors middleware.ts PROTECTED) — and disallows everything on staging so staging twins never compete with canonical pages.
  • sitemap.ts: public marketing/legal routes + per-job careers slugs. manifest.ts: brand name/colors/icon.
  • Per-page metadata: about/privacy/terms export metadata; careers split into a server wrapper (page.tsx, holds metadata) + CareersList.tsx client child (UI unchanged, moved verbatim); careers/[slug] gets per-job generateMetadata.
  • Careers [slug] page returns 200 + fallback UI for invalid slugs (soft 404) #187: unknown careers slug now calls notFound() → real HTTP 404 instead of a 200 soft-404.
Shell (#172#188)
  • Real app/global-error.tsx rendering its own <html>/<body> + branded ErrorFallback (imports globals.css since it replaces the root layout); the misnamed segment boundary error.tsx renamed GlobalError → RootError.
  • (shell)/loading.tsx: instant neutral skeleton on shell route transitions.
Auth state honesty (#191)
  • setActiveUser gains a { persist } option: localStorage identity is written only after GET /api/auth/me confirms the session (gated in the OAuth callback, and through the popup broadcast via a new profileConfirmed payload field consumed by SignInModal). On a failed /me, the tab still signs in (context hydrates) but nothing persists — the provider's cookie fallback reconciles on the next full load.
  • UserContext.fetchProfileData (already fired on every authed mount) now clears the stale identity on a definitive 401/404; 5xx/network failures keep the session (a server blip must not sign anyone out).
Tests
  • 25 new vitest cases: seo.test.ts (metadata/robots/sitemap/manifest/notFound + resolveSiteUrl), globalError.test.tsx, shellLoading.test.tsx, UserContext.reconcile.test.tsx (401/404 clear, 5xx/network keep), callback.test.tsx (persist gate + clean failure).
  • Promoted journey e2e/public-seo.spec.ts: robots/sitemap/manifest resolve, careers hard-404, OG tags on the landing HTML.
  • Full suite: 41 files / 308 tests green (now 313); tsc --noEmit clean; eslint . 0 errors with no suppressions-baseline changes (the one new exhaustive-deps hit was fixed properly via useCallback).
Notes for review
  • next build cannot run inside the worktree (Turbopack rejects the symlinked node_modules); the build is exercised by the pre-merge e2e cycle from the primary checkout (stack build) before merge.
  • No docs/frontend-testids.md / eslint.config.mjs changes needed: no new interactive elements on testid'd surfaces (the journey is pure HTTP).
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Review limit reached
@AndresL230, you've reached your PR review limit, so we couldn't start this review.
Next review available in:21 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2c96c88e-0548-4c51-902d-f0d1b8965a58
📥 Commits
Reviewing files that changed from the base of the PR and between 1102093 and f118d9f.
⛔ Files ignored due to path filters (1)
  • frontend/public/og.png is excluded by !**/*.png
📒 Files selected for processing (23)
  • frontend/e2e/public-seo.spec.ts
  • frontend/src/app/(public)/about/page.tsx
  • frontend/src/app/(public)/careers/CareersList.tsx
  • frontend/src/app/(public)/careers/[slug]/page.tsx
  • frontend/src/app/(public)/careers/page.tsx
  • frontend/src/app/(public)/privacy/page.tsx
  • frontend/src/app/(public)/terms/page.tsx
  • frontend/src/app/(shell)/loading.tsx
  • frontend/src/app/auth/callback/callback.test.tsx
  • frontend/src/app/auth/callback/page.tsx
  • frontend/src/app/error.tsx
  • frontend/src/app/global-error.tsx
  • frontend/src/app/globalError.test.tsx
  • frontend/src/app/layout.tsx
  • frontend/src/app/manifest.ts
  • frontend/src/app/robots.ts
  • frontend/src/app/seo.test.ts
  • frontend/src/app/shellLoading.test.tsx
  • frontend/src/app/sitemap.ts
  • frontend/src/components/SignInModal.tsx
  • frontend/src/context/UserContext.reconcile.test.tsx
  • frontend/src/context/UserContext.tsx
  • frontend/src/lib/deployGuard.ts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@cloudflare-workers-and-pages
cloudflare-workers-and-pagesBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers
The latest updates on your project. Learn more about integrating Git with Workers.
StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful! 
View logs		frontend-stagingf118d9fCommit Preview URL

Branch Preview URL		Jul 30 2026, 07:26 AM
@AndresL230
AndresL230
commented
Jul 30, 2026

Copy link


Copy Markdown

CollaboratorAuthor
Code review
Found 1 issue:
  1. The new (shell)/loading.tssx fallback fabricates its own topbar skeleton (avatar circle + text bar + pill), but the shell's real TopNav/SideNav are persistent chrome rendered by ShellFrameoutside the {children} slot — Next mounts loading.tsx inside <main>, so every shell route transition flashes a second, skeleton-shaped topbar stacked directly under the real one (bug due to ShellFrame.tsx rendering <TopNav/>/<SideNav/> around <main>, not inside it)
Sapling/frontend/src/app/(shell)/loading.tsx

Lines 13 to 20
in
818840d
>
<divstyle={{display: "flex",alignItems: "center",gap: 12,marginBottom: 28}}>
<Skeletonwidth={26}height={26}circle/>
<Skeletonwidth={140}height={16}/>
<divstyle={{flex: 1}}/>
<Skeletonwidth={90}height={28}radius="var(--r-full)"/>
</div>
<divstyle={{maxWidth: 1080,margin: "0 auto",display: "flex",flexDirection: "column",gap: 14}}>
Sub-threshold notes (verified, being fixed in a follow-up commit on this PR, scores <80): resolveSiteUrl checks NEXT_PUBLIC_SITE_URL before DEPLOY_ENV, inverting the ADR-0022 precedence its own doc comment claims (75); the new 401/404 auto-clear in fetchProfileData can strand a just-signed-in tab on a shell route with cleared state (65); the persist gate is only covered via mocks, never the real provider (30).
🤖 Generated with Claude Code
- If this code review was useful, please react with 👍. Otherwise, react with 👎.
AndresL230 added a commit
that referenced
this pull request
Jul 30, 2026
@AndresL230@claude
fix(review): address all four#466review findings
64861e1
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AndresL230and others
added 2 commits
July 30, 2026 00:13
@AndresL230@claude
feat(frontend): public-beta SEO + shell polish (#169#170#171#187#172
17e796b
#188#191)
- #169: full root metadata — metadataBase (DEPLOY_ENV-derived via new
deployGuard.resolveSiteUrl), title template, OG/Twitter cards with a
generated public/og.png, canonical.
- #170: robots.ts (staging fully disallowed; private app surface blocked),
sitemap.ts (public routes + job slugs), manifest.ts (brand identity).
- #171: per-page metadata on about/privacy/terms/careers; careers page split
into a server wrapper + CareersList client child; per-job generateMetadata.
- #187: unknown careers slug now hard-404s via notFound().
- #172: real app/global-error.tsx (own <html>/<body>, branded ErrorFallback);
the misnamed root segment boundary renamed GlobalError → RootError.
- #188: (shell)/loading.tsx paints an instant skeleton on route transitions.
- #191: localStorage identity persists only after a confirmed /me
(setActiveUser persist gate through callback + SignInModal broadcast);
UserContext clears stale identity on definitive 401/404 from the existing
profile fetch — 5xx/network keep the session.
- e2e: public-seo.spec.ts pins robots/sitemap/manifest/careers-404/og tags.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230@claude
fix(review): address all four#466review findings
f118d9f
- (shell)/loading.tsx: drop the fabricated topbar row — the fallback mounts
inside ShellFrame's <main>, under the real persistent TopNav/SideNav, so it
must be content-only (double-topbar flash, score 100).
- deployGuard.resolveSiteUrl: DEPLOY_ENV now wins unconditionally (ADR-0022
precedence, matching resolveFrontendEnv); NEXT_PUBLIC_SITE_URL is the
local/preview fallback only, and the build-time explicit lock in
checkFrontendDeployEnv now classifies it too (score 75).
- UserContext: a definitive 401/404 clear on a shell route now hard-bounces
to /?error=session_expired (same greppable code as the middleware) instead
of stranding a gated screen with no identity; pure shouldBounceToSignin
predicate exported and pinned by tests (score 65).
- Persist gate now exercised against the REAL provider: persist:false writes
nothing, default persists (score 30).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AndresL230
AndresL230
merged commit b9b0b89
into
mainJul 30, 2026

7 checks passed

@AndresL230AndresL230
mentioned this pull request
Jul 30, 2026
 Merged

@AndresL230
AndresL230
deleted the

b8-beta-polish

branch
August 2, 2026 18:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment