Skip to content

ci: give the integration lane the function-mode env it demands - #583

Merged
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode
Aug 23, 2026
Merged

ci: give the integration lane the function-mode env it demands#583
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

Fixes the integration (local supabase) lane, red on every push to main since 2026-08-22.

What was wrong

b14fc3ba (#574) added backend/tests/integration/test_quiz_subcutaneous_db.py. Its autouse _requires_function_mode fixture raises unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS=agents.function_handlers_e2e are set. Nothing that runs the lane set them, so every push produced 57 passed, 14 errors.

The raise is correct and stays: those tests drive generate/answer/submit through real HTTP, so without the seam they would call live Gemini, and a silent skip would let the gate report green having run nothing. The runner was what was wrong.

RunCommitResult
32565044570#573last green
32566643897#574first red
32567613715#575red
32622375267#566red

Changes

  1. Set the pair on the test step, mirroring e2e.yml L81-82. Applied at the step rather than inside the fixture so the whole lane sees one mode.
  2. Fixed the same gap in docs/local-supabase.md — anyone following the documented invocation hit the identical RuntimeError.
  3. Added a pull_request trigger. The lane previously ran only on push to main, so test(quiz): the loop through HTTP against real Postgres (#545) #574 could not have failed pre-merge no matter who reviewed it.

Why lane-wide function mode is safe

  • No other test under backend/tests/integration/ constructs an agent (they are GETs and gradescope CRUD), so nothing can trip UnregisteredHandlerError.
  • backend/.env.local.example — copied to .env in the Migrate + seed step — defines neither variable, so the integration conftest's load_dotenv(..., override=True) cannot clobber the workflow env.

Note on the trigger

The pull_request trigger is unfiltered, so it costs ~5 min of Supabase boot on every PR including frontend-only ones. A paths: filter would buy that back at the cost of a narrower version of the blind spot that caused this bug. Easy to add later if the minutes matter more than the coverage — say the word.

Verification

This PR is its own test: the pull_request trigger means the lane runs here, on this branch, with the fix applied. It must go green — and the fact that it runs at all is change 3 working.

🤖 Generated with Claude Code

The lane has been red on every push to main since #574, which added
tests/integration/test_quiz_subcutaneous_db.py. Its autouse fixture raises
unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS are set —
deliberately, since a skip would let the gate report green having run nothing
— but nothing that runs the lane sets them. 57 passed, 14 errored.
Set the pair on the test step, mirroring e2e.yml, and fix the same gap in the
documented invocation in docs/local-supabase.md.
Also add a pull_request trigger. This lane ran only on push to main, so #574
could not have failed pre-merge no matter who reviewed it; the one gate built
to catch route/schema drift was structurally blind to a PR introducing it.
Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:59 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2eec1afa-f9bc-4aec-8528-87a6912ad919

📥 Commits

Reviewing files that changed from the base of the PR and between 752a82c and fd5fb61.

📒 Files selected for processing (2)
  • .github/workflows/integration.yml
  • docs/local-supabase.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Aug 23, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-stagingfd5fb61Commit Preview URL

Branch Preview URL
Aug 23 2026, 06:35 AM

@supabase

supabaseBot commented Aug 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project ybgqdonkoqftwrmweuyv because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@AndresL230
AndresL230 merged commit 5b1a240 into mainAug 23, 2026
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
ci: give the integration lane the function-mode env it demands by AndresL230 · Pull Request #583 · SaplingLearn/Sapling · GitHub
Skip to content

ci: give the integration lane the function-mode env it demands - #583

Merged
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode
Aug 23, 2026
Merged

ci: give the integration lane the function-mode env it demands#583
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

Fixes the integration (local supabase) lane, red on every push to main since 2026-08-22.

What was wrong

b14fc3ba (#574) added backend/tests/integration/test_quiz_subcutaneous_db.py. Its autouse _requires_function_mode fixture raises unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS=agents.function_handlers_e2e are set. Nothing that runs the lane set them, so every push produced 57 passed, 14 errors.

The raise is correct and stays: those tests drive generate/answer/submit through real HTTP, so without the seam they would call live Gemini, and a silent skip would let the gate report green having run nothing. The runner was what was wrong.

RunCommitResult
32565044570#573last green
32566643897#574first red
32567613715#575red
32622375267#566red

Changes

  1. Set the pair on the test step, mirroring e2e.yml L81-82. Applied at the step rather than inside the fixture so the whole lane sees one mode.
  2. Fixed the same gap in docs/local-supabase.md — anyone following the documented invocation hit the identical RuntimeError.
  3. Added a pull_request trigger. The lane previously ran only on push to main, so test(quiz): the loop through HTTP against real Postgres (#545) #574 could not have failed pre-merge no matter who reviewed it.

Why lane-wide function mode is safe

  • No other test under backend/tests/integration/ constructs an agent (they are GETs and gradescope CRUD), so nothing can trip UnregisteredHandlerError.
  • backend/.env.local.example — copied to .env in the Migrate + seed step — defines neither variable, so the integration conftest's load_dotenv(..., override=True) cannot clobber the workflow env.

Note on the trigger

The pull_request trigger is unfiltered, so it costs ~5 min of Supabase boot on every PR including frontend-only ones. A paths: filter would buy that back at the cost of a narrower version of the blind spot that caused this bug. Easy to add later if the minutes matter more than the coverage — say the word.

Verification

This PR is its own test: the pull_request trigger means the lane runs here, on this branch, with the fix applied. It must go green — and the fact that it runs at all is change 3 working.

🤖 Generated with Claude Code

The lane has been red on every push to main since #574, which added
tests/integration/test_quiz_subcutaneous_db.py. Its autouse fixture raises
unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS are set —
deliberately, since a skip would let the gate report green having run nothing
— but nothing that runs the lane sets them. 57 passed, 14 errored.
Set the pair on the test step, mirroring e2e.yml, and fix the same gap in the
documented invocation in docs/local-supabase.md.
Also add a pull_request trigger. This lane ran only on push to main, so #574
could not have failed pre-merge no matter who reviewed it; the one gate built
to catch route/schema drift was structurally blind to a PR introducing it.
Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:59 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2eec1afa-f9bc-4aec-8528-87a6912ad919

📥 Commits

Reviewing files that changed from the base of the PR and between 752a82c and fd5fb61.

📒 Files selected for processing (2)
  • .github/workflows/integration.yml
  • docs/local-supabase.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Aug 23, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-stagingfd5fb61Commit Preview URL

Branch Preview URL
Aug 23 2026, 06:35 AM

@supabase

supabaseBot commented Aug 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project ybgqdonkoqftwrmweuyv because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@AndresL230
AndresL230 merged commit 5b1a240 into mainAug 23, 2026
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' ci: give the integration lane the function-mode env it demands by AndresL230 · Pull Request #583 · SaplingLearn/Sapling · GitHub
Skip to content

ci: give the integration lane the function-mode env it demands - #583

Merged
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode
Aug 23, 2026
Merged

ci: give the integration lane the function-mode env it demands#583
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

Fixes the integration (local supabase) lane, red on every push to main since 2026-08-22.

What was wrong

b14fc3ba (#574) added backend/tests/integration/test_quiz_subcutaneous_db.py. Its autouse _requires_function_mode fixture raises unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS=agents.function_handlers_e2e are set. Nothing that runs the lane set them, so every push produced 57 passed, 14 errors.

The raise is correct and stays: those tests drive generate/answer/submit through real HTTP, so without the seam they would call live Gemini, and a silent skip would let the gate report green having run nothing. The runner was what was wrong.

RunCommitResult
32565044570#573last green
32566643897#574first red
32567613715#575red
32622375267#566red

Changes

  1. Set the pair on the test step, mirroring e2e.yml L81-82. Applied at the step rather than inside the fixture so the whole lane sees one mode.
  2. Fixed the same gap in docs/local-supabase.md — anyone following the documented invocation hit the identical RuntimeError.
  3. Added a pull_request trigger. The lane previously ran only on push to main, so test(quiz): the loop through HTTP against real Postgres (#545) #574 could not have failed pre-merge no matter who reviewed it.

Why lane-wide function mode is safe

  • No other test under backend/tests/integration/ constructs an agent (they are GETs and gradescope CRUD), so nothing can trip UnregisteredHandlerError.
  • backend/.env.local.example — copied to .env in the Migrate + seed step — defines neither variable, so the integration conftest's load_dotenv(..., override=True) cannot clobber the workflow env.

Note on the trigger

The pull_request trigger is unfiltered, so it costs ~5 min of Supabase boot on every PR including frontend-only ones. A paths: filter would buy that back at the cost of a narrower version of the blind spot that caused this bug. Easy to add later if the minutes matter more than the coverage — say the word.

Verification

This PR is its own test: the pull_request trigger means the lane runs here, on this branch, with the fix applied. It must go green — and the fact that it runs at all is change 3 working.

🤖 Generated with Claude Code

The lane has been red on every push to main since #574, which added
tests/integration/test_quiz_subcutaneous_db.py. Its autouse fixture raises
unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS are set —
deliberately, since a skip would let the gate report green having run nothing
— but nothing that runs the lane sets them. 57 passed, 14 errored.
Set the pair on the test step, mirroring e2e.yml, and fix the same gap in the
documented invocation in docs/local-supabase.md.
Also add a pull_request trigger. This lane ran only on push to main, so #574
could not have failed pre-merge no matter who reviewed it; the one gate built
to catch route/schema drift was structurally blind to a PR introducing it.
Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:59 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2eec1afa-f9bc-4aec-8528-87a6912ad919

📥 Commits

Reviewing files that changed from the base of the PR and between 752a82c and fd5fb61.

📒 Files selected for processing (2)
  • .github/workflows/integration.yml
  • docs/local-supabase.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Aug 23, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-stagingfd5fb61Commit Preview URL

Branch Preview URL
Aug 23 2026, 06:35 AM

@supabase

supabaseBot commented Aug 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project ybgqdonkoqftwrmweuyv because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@AndresL230
AndresL230 merged commit 5b1a240 into mainAug 23, 2026
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' ci: give the integration lane the function-mode env it demands by AndresL230 · Pull Request #583 · SaplingLearn/Sapling · GitHub
Skip to content

ci: give the integration lane the function-mode env it demands - #583

Merged
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode
Aug 23, 2026
Merged

ci: give the integration lane the function-mode env it demands#583
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

Fixes the integration (local supabase) lane, red on every push to main since 2026-08-22.

What was wrong

b14fc3ba (#574) added backend/tests/integration/test_quiz_subcutaneous_db.py. Its autouse _requires_function_mode fixture raises unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS=agents.function_handlers_e2e are set. Nothing that runs the lane set them, so every push produced 57 passed, 14 errors.

The raise is correct and stays: those tests drive generate/answer/submit through real HTTP, so without the seam they would call live Gemini, and a silent skip would let the gate report green having run nothing. The runner was what was wrong.

RunCommitResult
32565044570#573last green
32566643897#574first red
32567613715#575red
32622375267#566red

Changes

  1. Set the pair on the test step, mirroring e2e.yml L81-82. Applied at the step rather than inside the fixture so the whole lane sees one mode.
  2. Fixed the same gap in docs/local-supabase.md — anyone following the documented invocation hit the identical RuntimeError.
  3. Added a pull_request trigger. The lane previously ran only on push to main, so test(quiz): the loop through HTTP against real Postgres (#545) #574 could not have failed pre-merge no matter who reviewed it.

Why lane-wide function mode is safe

  • No other test under backend/tests/integration/ constructs an agent (they are GETs and gradescope CRUD), so nothing can trip UnregisteredHandlerError.
  • backend/.env.local.example — copied to .env in the Migrate + seed step — defines neither variable, so the integration conftest's load_dotenv(..., override=True) cannot clobber the workflow env.

Note on the trigger

The pull_request trigger is unfiltered, so it costs ~5 min of Supabase boot on every PR including frontend-only ones. A paths: filter would buy that back at the cost of a narrower version of the blind spot that caused this bug. Easy to add later if the minutes matter more than the coverage — say the word.

Verification

This PR is its own test: the pull_request trigger means the lane runs here, on this branch, with the fix applied. It must go green — and the fact that it runs at all is change 3 working.

🤖 Generated with Claude Code

The lane has been red on every push to main since #574, which added
tests/integration/test_quiz_subcutaneous_db.py. Its autouse fixture raises
unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS are set —
deliberately, since a skip would let the gate report green having run nothing
— but nothing that runs the lane sets them. 57 passed, 14 errored.
Set the pair on the test step, mirroring e2e.yml, and fix the same gap in the
documented invocation in docs/local-supabase.md.
Also add a pull_request trigger. This lane ran only on push to main, so #574
could not have failed pre-merge no matter who reviewed it; the one gate built
to catch route/schema drift was structurally blind to a PR introducing it.
Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:59 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2eec1afa-f9bc-4aec-8528-87a6912ad919

📥 Commits

Reviewing files that changed from the base of the PR and between 752a82c and fd5fb61.

📒 Files selected for processing (2)
  • .github/workflows/integration.yml
  • docs/local-supabase.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Aug 23, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-stagingfd5fb61Commit Preview URL

Branch Preview URL
Aug 23 2026, 06:35 AM

@supabase

supabaseBot commented Aug 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project ybgqdonkoqftwrmweuyv because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@AndresL230
AndresL230 merged commit 5b1a240 into mainAug 23, 2026
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' ci: give the integration lane the function-mode env it demands by AndresL230 · Pull Request #583 · SaplingLearn/Sapling · GitHub
Skip to content

ci: give the integration lane the function-mode env it demands - #583

Merged
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode
Aug 23, 2026
Merged

ci: give the integration lane the function-mode env it demands#583
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

Fixes the integration (local supabase) lane, red on every push to main since 2026-08-22.

What was wrong

b14fc3ba (#574) added backend/tests/integration/test_quiz_subcutaneous_db.py. Its autouse _requires_function_mode fixture raises unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS=agents.function_handlers_e2e are set. Nothing that runs the lane set them, so every push produced 57 passed, 14 errors.

The raise is correct and stays: those tests drive generate/answer/submit through real HTTP, so without the seam they would call live Gemini, and a silent skip would let the gate report green having run nothing. The runner was what was wrong.

RunCommitResult
32565044570#573last green
32566643897#574first red
32567613715#575red
32622375267#566red

Changes

  1. Set the pair on the test step, mirroring e2e.yml L81-82. Applied at the step rather than inside the fixture so the whole lane sees one mode.
  2. Fixed the same gap in docs/local-supabase.md — anyone following the documented invocation hit the identical RuntimeError.
  3. Added a pull_request trigger. The lane previously ran only on push to main, so test(quiz): the loop through HTTP against real Postgres (#545) #574 could not have failed pre-merge no matter who reviewed it.

Why lane-wide function mode is safe

  • No other test under backend/tests/integration/ constructs an agent (they are GETs and gradescope CRUD), so nothing can trip UnregisteredHandlerError.
  • backend/.env.local.example — copied to .env in the Migrate + seed step — defines neither variable, so the integration conftest's load_dotenv(..., override=True) cannot clobber the workflow env.

Note on the trigger

The pull_request trigger is unfiltered, so it costs ~5 min of Supabase boot on every PR including frontend-only ones. A paths: filter would buy that back at the cost of a narrower version of the blind spot that caused this bug. Easy to add later if the minutes matter more than the coverage — say the word.

Verification

This PR is its own test: the pull_request trigger means the lane runs here, on this branch, with the fix applied. It must go green — and the fact that it runs at all is change 3 working.

🤖 Generated with Claude Code

The lane has been red on every push to main since #574, which added
tests/integration/test_quiz_subcutaneous_db.py. Its autouse fixture raises
unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS are set —
deliberately, since a skip would let the gate report green having run nothing
— but nothing that runs the lane sets them. 57 passed, 14 errored.
Set the pair on the test step, mirroring e2e.yml, and fix the same gap in the
documented invocation in docs/local-supabase.md.
Also add a pull_request trigger. This lane ran only on push to main, so #574
could not have failed pre-merge no matter who reviewed it; the one gate built
to catch route/schema drift was structurally blind to a PR introducing it.
Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:59 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2eec1afa-f9bc-4aec-8528-87a6912ad919

📥 Commits

Reviewing files that changed from the base of the PR and between 752a82c and fd5fb61.

📒 Files selected for processing (2)
  • .github/workflows/integration.yml
  • docs/local-supabase.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Aug 23, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-stagingfd5fb61Commit Preview URL

Branch Preview URL
Aug 23 2026, 06:35 AM

@supabase

supabaseBot commented Aug 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project ybgqdonkoqftwrmweuyv because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@AndresL230
AndresL230 merged commit 5b1a240 into mainAug 23, 2026
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' ci: give the integration lane the function-mode env it demands by AndresL230 · Pull Request #583 · SaplingLearn/Sapling · GitHub
Skip to content

ci: give the integration lane the function-mode env it demands - #583

Merged
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode
Aug 23, 2026
Merged

ci: give the integration lane the function-mode env it demands#583
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

Fixes the integration (local supabase) lane, red on every push to main since 2026-08-22.

What was wrong

b14fc3ba (#574) added backend/tests/integration/test_quiz_subcutaneous_db.py. Its autouse _requires_function_mode fixture raises unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS=agents.function_handlers_e2e are set. Nothing that runs the lane set them, so every push produced 57 passed, 14 errors.

The raise is correct and stays: those tests drive generate/answer/submit through real HTTP, so without the seam they would call live Gemini, and a silent skip would let the gate report green having run nothing. The runner was what was wrong.

RunCommitResult
32565044570#573last green
32566643897#574first red
32567613715#575red
32622375267#566red

Changes

  1. Set the pair on the test step, mirroring e2e.yml L81-82. Applied at the step rather than inside the fixture so the whole lane sees one mode.
  2. Fixed the same gap in docs/local-supabase.md — anyone following the documented invocation hit the identical RuntimeError.
  3. Added a pull_request trigger. The lane previously ran only on push to main, so test(quiz): the loop through HTTP against real Postgres (#545) #574 could not have failed pre-merge no matter who reviewed it.

Why lane-wide function mode is safe

  • No other test under backend/tests/integration/ constructs an agent (they are GETs and gradescope CRUD), so nothing can trip UnregisteredHandlerError.
  • backend/.env.local.example — copied to .env in the Migrate + seed step — defines neither variable, so the integration conftest's load_dotenv(..., override=True) cannot clobber the workflow env.

Note on the trigger

The pull_request trigger is unfiltered, so it costs ~5 min of Supabase boot on every PR including frontend-only ones. A paths: filter would buy that back at the cost of a narrower version of the blind spot that caused this bug. Easy to add later if the minutes matter more than the coverage — say the word.

Verification

This PR is its own test: the pull_request trigger means the lane runs here, on this branch, with the fix applied. It must go green — and the fact that it runs at all is change 3 working.

🤖 Generated with Claude Code

The lane has been red on every push to main since #574, which added
tests/integration/test_quiz_subcutaneous_db.py. Its autouse fixture raises
unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS are set —
deliberately, since a skip would let the gate report green having run nothing
— but nothing that runs the lane sets them. 57 passed, 14 errored.
Set the pair on the test step, mirroring e2e.yml, and fix the same gap in the
documented invocation in docs/local-supabase.md.
Also add a pull_request trigger. This lane ran only on push to main, so #574
could not have failed pre-merge no matter who reviewed it; the one gate built
to catch route/schema drift was structurally blind to a PR introducing it.
Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:59 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2eec1afa-f9bc-4aec-8528-87a6912ad919

📥 Commits

Reviewing files that changed from the base of the PR and between 752a82c and fd5fb61.

📒 Files selected for processing (2)
  • .github/workflows/integration.yml
  • docs/local-supabase.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Aug 23, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-stagingfd5fb61Commit Preview URL

Branch Preview URL
Aug 23 2026, 06:35 AM

@supabase

supabaseBot commented Aug 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project ybgqdonkoqftwrmweuyv because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@AndresL230
AndresL230 merged commit 5b1a240 into mainAug 23, 2026
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' ci: give the integration lane the function-mode env it demands by AndresL230 · Pull Request #583 · SaplingLearn/Sapling · GitHub
Skip to content

ci: give the integration lane the function-mode env it demands - #583

Merged
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode
Aug 23, 2026
Merged

ci: give the integration lane the function-mode env it demands#583
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

Fixes the integration (local supabase) lane, red on every push to main since 2026-08-22.

What was wrong

b14fc3ba (#574) added backend/tests/integration/test_quiz_subcutaneous_db.py. Its autouse _requires_function_mode fixture raises unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS=agents.function_handlers_e2e are set. Nothing that runs the lane set them, so every push produced 57 passed, 14 errors.

The raise is correct and stays: those tests drive generate/answer/submit through real HTTP, so without the seam they would call live Gemini, and a silent skip would let the gate report green having run nothing. The runner was what was wrong.

RunCommitResult
32565044570#573last green
32566643897#574first red
32567613715#575red
32622375267#566red

Changes

  1. Set the pair on the test step, mirroring e2e.yml L81-82. Applied at the step rather than inside the fixture so the whole lane sees one mode.
  2. Fixed the same gap in docs/local-supabase.md — anyone following the documented invocation hit the identical RuntimeError.
  3. Added a pull_request trigger. The lane previously ran only on push to main, so test(quiz): the loop through HTTP against real Postgres (#545) #574 could not have failed pre-merge no matter who reviewed it.

Why lane-wide function mode is safe

  • No other test under backend/tests/integration/ constructs an agent (they are GETs and gradescope CRUD), so nothing can trip UnregisteredHandlerError.
  • backend/.env.local.example — copied to .env in the Migrate + seed step — defines neither variable, so the integration conftest's load_dotenv(..., override=True) cannot clobber the workflow env.

Note on the trigger

The pull_request trigger is unfiltered, so it costs ~5 min of Supabase boot on every PR including frontend-only ones. A paths: filter would buy that back at the cost of a narrower version of the blind spot that caused this bug. Easy to add later if the minutes matter more than the coverage — say the word.

Verification

This PR is its own test: the pull_request trigger means the lane runs here, on this branch, with the fix applied. It must go green — and the fact that it runs at all is change 3 working.

🤖 Generated with Claude Code

The lane has been red on every push to main since #574, which added
tests/integration/test_quiz_subcutaneous_db.py. Its autouse fixture raises
unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS are set —
deliberately, since a skip would let the gate report green having run nothing
— but nothing that runs the lane sets them. 57 passed, 14 errored.
Set the pair on the test step, mirroring e2e.yml, and fix the same gap in the
documented invocation in docs/local-supabase.md.
Also add a pull_request trigger. This lane ran only on push to main, so #574
could not have failed pre-merge no matter who reviewed it; the one gate built
to catch route/schema drift was structurally blind to a PR introducing it.
Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:59 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2eec1afa-f9bc-4aec-8528-87a6912ad919

📥 Commits

Reviewing files that changed from the base of the PR and between 752a82c and fd5fb61.

📒 Files selected for processing (2)
  • .github/workflows/integration.yml
  • docs/local-supabase.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Aug 23, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-stagingfd5fb61Commit Preview URL

Branch Preview URL
Aug 23 2026, 06:35 AM

@supabase

supabaseBot commented Aug 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project ybgqdonkoqftwrmweuyv because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@AndresL230
AndresL230 merged commit 5b1a240 into mainAug 23, 2026
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); ci: give the integration lane the function-mode env it demands by AndresL230 · Pull Request #583 · SaplingLearn/Sapling · GitHub
Skip to content

ci: give the integration lane the function-mode env it demands - #583

Merged
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode
Aug 23, 2026
Merged

ci: give the integration lane the function-mode env it demands#583
AndresL230 merged 1 commit into
mainfrom
fix/integration-lane-function-mode

Conversation

@AndresL230

Copy link
Copy Markdown
Collaborator

Fixes the integration (local supabase) lane, red on every push to main since 2026-08-22.

What was wrong

b14fc3ba (#574) added backend/tests/integration/test_quiz_subcutaneous_db.py. Its autouse _requires_function_mode fixture raises unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS=agents.function_handlers_e2e are set. Nothing that runs the lane set them, so every push produced 57 passed, 14 errors.

The raise is correct and stays: those tests drive generate/answer/submit through real HTTP, so without the seam they would call live Gemini, and a silent skip would let the gate report green having run nothing. The runner was what was wrong.

RunCommitResult
32565044570#573last green
32566643897#574first red
32567613715#575red
32622375267#566red

Changes

  1. Set the pair on the test step, mirroring e2e.yml L81-82. Applied at the step rather than inside the fixture so the whole lane sees one mode.
  2. Fixed the same gap in docs/local-supabase.md — anyone following the documented invocation hit the identical RuntimeError.
  3. Added a pull_request trigger. The lane previously ran only on push to main, so test(quiz): the loop through HTTP against real Postgres (#545) #574 could not have failed pre-merge no matter who reviewed it.

Why lane-wide function mode is safe

  • No other test under backend/tests/integration/ constructs an agent (they are GETs and gradescope CRUD), so nothing can trip UnregisteredHandlerError.
  • backend/.env.local.example — copied to .env in the Migrate + seed step — defines neither variable, so the integration conftest's load_dotenv(..., override=True) cannot clobber the workflow env.

Note on the trigger

The pull_request trigger is unfiltered, so it costs ~5 min of Supabase boot on every PR including frontend-only ones. A paths: filter would buy that back at the cost of a narrower version of the blind spot that caused this bug. Easy to add later if the minutes matter more than the coverage — say the word.

Verification

This PR is its own test: the pull_request trigger means the lane runs here, on this branch, with the fix applied. It must go green — and the fact that it runs at all is change 3 working.

🤖 Generated with Claude Code

The lane has been red on every push to main since #574, which added
tests/integration/test_quiz_subcutaneous_db.py. Its autouse fixture raises
unless SAPLING_MODEL_MODE=function and SAPLING_FUNCTION_HANDLERS are set —
deliberately, since a skip would let the gate report green having run nothing
— but nothing that runs the lane sets them. 57 passed, 14 errored.
Set the pair on the test step, mirroring e2e.yml, and fix the same gap in the
documented invocation in docs/local-supabase.md.
Also add a pull_request trigger. This lane ran only on push to main, so #574
could not have failed pre-merge no matter who reviewed it; the one gate built
to catch route/schema drift was structurally blind to a PR introducing it.
Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:59 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2eec1afa-f9bc-4aec-8528-87a6912ad919

📥 Commits

Reviewing files that changed from the base of the PR and between 752a82c and fd5fb61.

📒 Files selected for processing (2)
  • .github/workflows/integration.yml
  • docs/local-supabase.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Aug 23, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-stagingfd5fb61Commit Preview URL

Branch Preview URL
Aug 23 2026, 06:35 AM

@supabase

supabaseBot commented Aug 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project ybgqdonkoqftwrmweuyv because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@AndresL230
AndresL230 merged commit 5b1a240 into mainAug 23, 2026
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AndresL230