Uh oh!
There was an error while loading. Please reload this page.
Adds Modal run and check and server - #36
Closed
tcapelle wants to merge 17 commits into
Closed
Conversation
willhu-jpg
commented
May 9, 2025
Collaborator
Hi Thomas, thank you for the contribution! We're taking a look at your pull request. |
tcapelle
commented
May 19, 2025
Author
I can split the PR, let's book some time and chat about how can I help you guys. For the time being I moved to work on TritonBench instead. |
Collaborator
Thank you so much for your suggestions and the attempt @tcapelle! Thank you for the other stylistic suggestions. We will keep that in mind for future enhancements. Closing this PR for now! Again really appreciate your suggestion and contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great repo.
I added a simple run_and_check modal so we can run this on any hardware, also added a server in modal so we can serve the run_and_check and use it on a GRPO pipeline.
uvas dependency manager and move to a more modernprproject.toml