Uh oh!
There was an error while loading. Please reload this page.
Dummy PR: demonstrate unit test failures - #3923
Closed
rcomer wants to merge 1 commit into
Closed
Conversation
rcomer
marked this pull request as draft
November 19, 2020 16:45
rcomer
commented
Nov 19, 2020
MemberAuthor
I tried pinning |
MemberAuthor
It seems that, at cftime 1.3 you can still specify a zero datetime without a calendar using e.g. |
rcomer
commented
Nov 19, 2020
MemberAuthor
Really not obvious how a flipped pressure coordinate would be caused by https://travis-ci.org/github/SciTools/iris/jobs/744701405#L26923-L26931 |
Merged
bjlittle
commented
Nov 25, 2020
Member
@rcomer We've already pin back Do you still need this PR? Or happy to close? 🛩️ |
rcomer
commented
Nov 25, 2020
MemberAuthor
Happy to close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
As raised on the Google Group, cftime v1.3 was released this week and is unforgiving about what kind of datetimes you can have. Iris tests now produce a raft of errors of the form
While demonstrating this locally, I saw a bunch of other failures that aren't obviously about cftime. So I figured the easiest way to raise this was to create a PR and let Travis show them!
Consult Iris pull request check list