Uh oh!
There was an error while loading. Please reload this page.
Migrate synthetic data generation from iris-ugrid - #4076
Merged
Conversation
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
pp-mo
requested changes
Mar 26, 2021
pp-mo
left a comment
Member
There was a problem hiding this comment.
Comparing to the content in ris-ugrid, I see you subtly refactored the scope of this with a view to future generalisation, e.g. beyond netcdf. Which I think is all good, and nicely done!
I thought of some tiny tweaks, but otherwise looks fine.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
trexfeathers
commented
Mar 26, 2021
ContributorAuthor
Thanks @pp-mo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
For original review, see SciTools-incubator/iris-ugrid#38.
I'm keen in future to extend this beyond UGRID-NetCDF files, as the pattern is very useful for good benchmark coverage.
Consult Iris pull request check list