adopt setuptools-scm for auto versioning - #4841
Conversation
commented
Jun 30, 2022
|
Nice @bjlittle |
|
@pp-mo No, this won't affect our release version numbering scheme. Business as usual. For example,
When we tag the release in GH, the tag name will automatically become the I'll confirm that by tagging a release in my own If you require further confidence, then currently |
commented
Jul 5, 2022
|
@trexfeathers I'm just wondering whether there is any |
I'm fairly certain that ASV only does tag parsing, and that's obviously all via Git. I can always try running some stuff once I've finished reviewing the changes. Also of note is that ASV always installs the project (via |
left a comment
There was a problem hiding this comment.
Thanks @bjlittle, a few questions/requests for you...
| release = iris.__version__ | ||
| # |version|, also used in various other places throughout the built documents. | ||
|
|
||
| version = iris.__version__ |
There was a problem hiding this comment.
This doesn't align with setuptools_scm recommendations.
There was a problem hiding this comment.
How come we no longer have a release variable?
There was a problem hiding this comment.
I figure it's just not used anymore. I can't see anywhere in the docs that references it.
Perhaps @tkknight might know this one 🤔
There was a problem hiding this comment.
The docs build without any warnings and they render fine, so that's good enough for me
There was a problem hiding this comment.
Version displayed in latest docs is now "v0.1.dev72+dirty". Was that expected?
There was a problem hiding this comment.
I got 3.3.0 when I tested it. @bjlittle any ideas?
commented
Jul 5, 2022
|
I've done some local benchmarking experiments and there are no signs of trouble there 🙂 |
🚀 Pull Request
Description
This PR adopts
setuptools-scmto automate the versioning ofiris.This means that we no longer need to care about bumping the
iris.__version__manually for a release, or post-release to a dev version.Requires #4840 to be merged first, in order to include the relevant updates to the requirements
ymlandlockfiles.Also, once this is merged, we're then in a position to automate the routine creation, testing and publishing of
irissource and binary PyPI wheels, as a GHA. See #4849.Reference: See setuptools-scm.
TODO:
conda-lockfilespy310requirements (Support python 3.10 #4840)@bjlittle/irisforked repo)Consult Iris pull request check list