Uh oh!
There was an error while loading. Please reload this page.
Added mechanism to designate arbitrary exceptions as recoverable - #56
Open
Bilge wants to merge 1 commit into
Open
Added mechanism to designate arbitrary exceptions as recoverable#56Bilge wants to merge 1 commit into
Bilge wants to merge 1 commit into
Conversation
Bilgeforce-pushed
the
exception-descriptor
branch
from
April 23, 2018 13:10
808a432 to
38afba3CompareThis important feature is needed because, although we have a mechanism for marking exceptions that extend RecoverableConnectorException as recoverable at the connector level, exception may need to be treated as recoverable at the resource level too. Resource implementations may not always have the luxury of creating their own exception types when relying on third party libraries.
Bilgeforce-pushed
the
exception-descriptor
branch
from
April 23, 2018 13:26
38afba3 to
33b0f84CompareCodecov Report
@@ Coverage Diff @@## 5.0 #56 +/- ##
============================================
+ Coverage 91.68% 92.48% +0.79% + Complexity 220 209 -11
============================================
Files 37 32 -5 Lines 457 439 -18 ============================================
- Hits 419 406 -13 + Misses 38 33 -5
Continue to review full report at Codecov.
|
Bilgeforce-pushed
the
5.0
branch
2 times, most recently
from
October 31, 2019 08:48
ad1512c to
56b9d03CompareBilgeforce-pushed
the
master
branch
2 times, most recently
from
December 1, 2019 20:42
2308bb2 to
37b143dCompareBilgeforce-pushed
the
master
branch
16 times, most recently
from
December 15, 2020 23:58
a592815 to
db12909CompareBilgeforce-pushed
the
master
branch
27 times, most recently
from
December 2, 2022 13:05
8df01f3 to
4cd4dbdCompareBilgeforce-pushed
the
master
branch
3 times, most recently
from
December 8, 2022 13:58
773cde2 to
93ce095Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This important feature is needed because, although we have a mechanism for marking exceptions that extend
RecoverableConnectorExceptionas recoverable at the connector level, exception may need to be treated as recoverable at the resource level too. Resource implementations may not always have the luxury of creating their own exception types when relying on third party libraries.On second thoughts, changing the
RecoverableConnectorExceptionbase class to aRecoverableExceptioninterface would probably be a better solution since it would permit implementations to write whatever code they need to trap the specific exception they want to promote to recoverable without any maintenance burden within Porter herself.