[java] specify nullability in packages org.openqa.selenium.chrom* - #17152

Merged
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom
asolntsev:nullability
Mar 2, 2026
Merged

[java] specify nullability in packages org.openqa.selenium.chrom*#17152
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom
asolntsev:nullability

Conversation

@asolntsev

@asolntsevasolntsev commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

🔗 Related Issues

Partially implements #14291

💥 What does this PR do?

Added JSpecify nullability annotations to packages:

  • org.openqa.selenium.chrome
  • org.openqa.selenium.chromium
  • (and a little bit to org.openqa.selenium.remote, as much as needed for previous two)

🔄 Types of changes

  • Cleanup (formatting, renaming)

@asolntsevasolntsev self-assigned this Mar 1, 2026
@asolntsevasolntsev added this to the 4.42.0 milestone Mar 1, 2026
@selenium-ciselenium-ci added the C-java Java Bindings label Mar 1, 2026
@qodo-code-review

qodo-code-reviewBot commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Add JSpecify nullability annotations to chrome and chromium packages

✨ Enhancement🧪 Tests

Grey Divider

Walkthroughs

Description
• Add JSpecify nullability annotations to chrome and chromium packages
• Introduce helper methods for safe capability retrieval and execution
• Refactor code to eliminate unsafe casts and improve type safety
• Clean up unused imports and simplify implementation patterns

Grey Divider

File Changes

1. java/src/org/openqa/selenium/Capabilities.java ✨ Enhancement +12/-0

Add generic helper methods for capability access

java/src/org/openqa/selenium/Capabilities.java

2. java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java Cleanup +0/-3

Remove unused logger import

java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java

3. java/src/org/openqa/selenium/chrome/package-info.java ✨ Enhancement +21/-0

Add NullMarked annotation to chrome package

java/src/org/openqa/selenium/chrome/package-info.java

View more (12)
4. java/src/org/openqa/selenium/chromium/AddHasCasting.java ✨ Enhancement +5/-3

Replace unsafe casts with safe null handling

java/src/org/openqa/selenium/chromium/AddHasCasting.java

5. java/src/org/openqa/selenium/chromium/AddHasCdp.java ✨ Enhancement +2/-5

Use executeRequired for non-null result handling

java/src/org/openqa/selenium/chromium/AddHasCdp.java

6. java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java ✨ Enhancement +1/-4

Replace requireNonNull with executeRequired method

java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java

7. java/src/org/openqa/selenium/chromium/ChromiumDriver.java ✨ Enhancement +4/-9

Add nullability annotations and remove redundant code

java/src/org/openqa/selenium/chromium/ChromiumDriver.java

8. java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java ✨ Enhancement +1/-1

Add nullable annotation to fromString parameter

java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java

9. java/src/org/openqa/selenium/chromium/ChromiumOptions.java ✨ Enhancement +39/-43

Refactor to use self() method and improve type safety

java/src/org/openqa/selenium/chromium/ChromiumOptions.java

10. java/src/org/openqa/selenium/chromium/HasCasting.java 📝 Documentation +1/-1

Update javadoc from array to list terminology

java/src/org/openqa/selenium/chromium/HasCasting.java

11. java/src/org/openqa/selenium/remote/ExecuteMethod.java ✨ Enhancement +7/-1

Add generic type parameter and executeRequired method

java/src/org/openqa/selenium/remote/ExecuteMethod.java

12. java/src/org/openqa/selenium/remote/FedCmDialogImpl.java ✨ Enhancement +18/-16

Add nullability annotations and simplify casting

java/src/org/openqa/selenium/remote/FedCmDialogImpl.java

13. java/src/org/openqa/selenium/remote/LocalExecuteMethod.java ✨ Enhancement +3/-1

Add NullMarked annotation and generic type parameter

java/src/org/openqa/selenium/remote/LocalExecuteMethod.java

14. java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java ✨ Enhancement +3/-2

Add generic type parameter with cast suppression

java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java

15. java/src/org/openqa/selenium/remote/RemoteWebDriver.java ✨ Enhancement +2/-1

Add nullability annotations to executeScript method

java/src/org/openqa/selenium/remote/RemoteWebDriver.java

Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-reviewBot commented Mar 1, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1)📘 Rule violations (1)📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. ExecuteMethod.execute() made generic 📘 Rule violation✓ Correctness
Description
The public ExecuteMethod.execute signature was changed to a generic method, which can be
source-incompatible for downstream implementations that previously implemented `Object
execute(...)`. This risks breaking user upgrades without a compatibility strategy.
Code

java/src/org/openqa/selenium/remote/ExecuteMethod.java[R40-44]

+ @Nullable <T> T execute(String commandName, @Nullable Map<String, ?> parameters);++ default <T> T executeRequired(String commandName, @Nullable Map<String, ?> parameters) {+ return requireNonNull(execute(commandName, parameters));+ }
Evidence
Compliance requires public interfaces to remain backward compatible; changing
ExecuteMethod.execute from a concrete Object return to a generic <T> T changes the method’s
source-level contract for implementers and callers. The diff shows the updated generic signature on
a public interface method.

AGENTS.md
java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
A public interface method (`ExecuteMethod.execute`) was changed to a generic method. This can break downstream implementations that previously implemented `Object execute(String, Map)` and violates the project’s API/ABI compatibility expectations.
## Issue Context
`ExecuteMethod` is a public extension point in `org.openqa.selenium.remote`. To keep upgrades safe, avoid source-incompatible signature changes; prefer adding a new helper method (with a new name) that performs the generic cast and/or required-null enforcement.
## Fix Focus Areas
- java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Mutable extensions capability list 🐞 Bug⛯ Reliability
Description
ChromiumOptions now stores a mutable List for the "extensions" capability inside an otherwise
unmodifiable options map, creating an immutability inconsistency (and allowing unexpected post-hoc
mutation by callers). This can lead to subtle bugs where capability maps appear immutable but
contain mutable nested state.
Code

java/src/org/openqa/selenium/chromium/ChromiumOptions.java[R251-261]

+ options.put("args", List.copyOf(args));+ options.put("extensions", extensionsArgument());
options.putAll(androidOptions);
return unmodifiableMap(options);
}
+ private List<String> extensionsArgument() {+ return Stream.concat(extensionFiles.stream().map(this::fileContentBase64), extensions.stream())+ .collect(toList());+ }
Evidence
getExtraCapability returns unmodifiableMap(options) but inserts extensionsArgument() directly;
extensionsArgument() uses Collectors.toList() which produces a mutable list. In the same method,
args is explicitly made immutable via List.copyOf(args), suggesting the intent is to return
immutable collections for list-valued capabilities.

java/src/org/openqa/selenium/chromium/ChromiumOptions.java[245-256]
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`ChromiumOptions#getExtraCapability` returns an unmodifiable map, but the `&quot;extensions&quot;` value is currently a mutable `List` (built via `Collectors.toList()`), which breaks the implicit immutability expectation established by `&quot;args&quot;` using `List.copyOf(args)`.
### Issue Context
Callers may treat capability maps as effectively immutable; mutating nested collections can produce surprising behavior and makes debugging harder.
### Fix Focus Areas
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[251-256]
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@asolntsev
asolntsev merged commit cae8d22 into SeleniumHQ:trunkMar 2, 2026
73 of 77 checks passed
@asolntsev
asolntsev deleted the nullability branch March 2, 2026 21:16
@asolntsevasolntsev added the I-enhancement Something could be better label Mar 3, 2026
asolntsev added a commit to asolntsev/selenium that referenced this pull request Mar 6, 2026
@asolntsev
make the signature change in ExecuteMethod backward compatible
5e8e34c
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
@asolntsevasolntsev mentioned this pull request Mar 6, 2026
Merged
asolntsev added a commit that referenced this pull request Mar 6, 2026
@asolntsev
[java] make the signature change in ExecuteMethod backward compatib…
bd280c7
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
AutomatedTester pushed a commit that referenced this pull request Mar 11, 2026
@asolntsev@AutomatedTester
[java] specify nullability in packagesorg.openqa.selenium.chrom*(#…
14642bd
…17152)
AutomatedTester pushed a commit that referenced this pull request Mar 11, 2026
@asolntsev@AutomatedTester
[java] make the signature change in ExecuteMethod backward compatib…
ada4964
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
krishnamohan-kothapalli pushed a commit to krishnamohan-kothapalli/selenium that referenced this pull request Mar 18, 2026
@asolntsev@krishnamohan-kothapalli
[java] make the signature change in ExecuteMethod backward compatib…
f571079
…le (SeleniumHQ#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
This was referenced Apr 9, 2026
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
This was referenced Apr 17, 2026
Closed
Closed
Merged
Closed
Closed
Closed
This was referenced May 1, 2026
Closed
Closed
This was referenced May 11, 2026
Merged
Closed
Closed
Closed
Closed
@dependabotdependabotBot mentioned this pull request May 18, 2026
Closed
This was referenced Jun 16, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 13, 2026
Open
Closed
Closed
This was referenced Aug 1, 2026
Closed
Closed
Closed
Closed
This was referenced Aug 17, 2026
Closed
Open
This was referenced Aug 31, 2026
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iampopovichiampopovichAwaiting requested review from iampopovich

Assignees

@asolntsevasolntsev

Labels

C-javaJava BindingsI-enhancementSomething could be better

Projects

None yet

Milestone

4.42.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asolntsev@selenium-ci
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[java] specify nullability in packages org.openqa.selenium.chrom* - #17152
Merged
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Mar 2, 2026
Merged
[java] specify nullability in packages org.openqa.selenium.chrom*#17152
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Conversation
@asolntsev
@asolntsevasolntsev
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
🔗 Related Issues
Partially implements #14291
💥 What does this PR do?
Added JSpecify nullability annotations to packages:
  • org.openqa.selenium.chrome
  • org.openqa.selenium.chromium
  • (and a little bit to org.openqa.selenium.remote, as much as needed for previous two)
🔄 Types of changes
  • Cleanup (formatting, renaming)
@asolntsevasolntsev
self-assigned this
Mar 1, 2026
@asolntsevasolntsev
added this to the 4.42.0 milestone
Mar 1, 2026
@selenium-ciselenium-ci
added
the 
C-java
Java Bindings
label
Mar 1, 2026
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Review Summary by Qodo
Add JSpecify nullability annotations to chrome and chromium packages
✨ Enhancement🧪 Tests
Grey Divider
Walkthroughs
Description
• Add JSpecify nullability annotations to chrome and chromium packages
• Introduce helper methods for safe capability retrieval and execution
• Refactor code to eliminate unsafe casts and improve type safety
• Clean up unused imports and simplify implementation patterns

Grey Divider
File Changes
1. java/src/org/openqa/selenium/Capabilities.java
✨ Enhancement +12/-0 
Add generic helper methods for capability access
 java/src/org/openqa/selenium/Capabilities.java
2. java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
 Cleanup  +0/-3 
Remove unused logger import
 java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
3. java/src/org/openqa/selenium/chrome/package-info.java
✨ Enhancement +21/-0 
Add NullMarked annotation to chrome package
 java/src/org/openqa/selenium/chrome/package-info.java
View more (12)
4. java/src/org/openqa/selenium/chromium/AddHasCasting.java
✨ Enhancement +5/-3 
Replace unsafe casts with safe null handling
 java/src/org/openqa/selenium/chromium/AddHasCasting.java
5. java/src/org/openqa/selenium/chromium/AddHasCdp.java
✨ Enhancement +2/-5 
Use executeRequired for non-null result handling
 java/src/org/openqa/selenium/chromium/AddHasCdp.java
6. java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
✨ Enhancement +1/-4 
Replace requireNonNull with executeRequired method
 java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
7. java/src/org/openqa/selenium/chromium/ChromiumDriver.java
✨ Enhancement +4/-9 
Add nullability annotations and remove redundant code
 java/src/org/openqa/selenium/chromium/ChromiumDriver.java
8. java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
✨ Enhancement +1/-1 
Add nullable annotation to fromString parameter
 java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
9. java/src/org/openqa/selenium/chromium/ChromiumOptions.java
✨ Enhancement +39/-43 
Refactor to use self() method and improve type safety
 java/src/org/openqa/selenium/chromium/ChromiumOptions.java
10. java/src/org/openqa/selenium/chromium/HasCasting.java
📝 Documentation +1/-1 
Update javadoc from array to list terminology
 java/src/org/openqa/selenium/chromium/HasCasting.java
11. java/src/org/openqa/selenium/remote/ExecuteMethod.java
✨ Enhancement +7/-1 
Add generic type parameter and executeRequired method
 java/src/org/openqa/selenium/remote/ExecuteMethod.java
12. java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
✨ Enhancement +18/-16 
Add nullability annotations and simplify casting
 java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
13. java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
✨ Enhancement +3/-1 
Add NullMarked annotation and generic type parameter
 java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
14. java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
✨ Enhancement +3/-2 
Add generic type parameter with cast suppression
 java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
15. java/src/org/openqa/selenium/remote/RemoteWebDriver.java
✨ Enhancement +2/-1 
Add nullability annotations to executeScript method
 java/src/org/openqa/selenium/remote/RemoteWebDriver.java
Grey Divider
Qodo Logo
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Code Review by Qodo
🐞 Bugs (1)📘 Rule violations (1)📎 Requirement gaps (0)
Grey Divider

Remediation recommended
 1. ExecuteMethod.execute() made generic 📘 Rule violation✓ Correctness
Description
The public ExecuteMethod.execute signature was changed to a generic method, which can be
source-incompatible for downstream implementations that previously implemented `Object
execute(...)`. This risks breaking user upgrades without a compatibility strategy.

Code
java/src/org/openqa/selenium/remote/ExecuteMethod.java[R40-44]
+ @Nullable <T> T execute(String commandName, @Nullable Map<String, ?> parameters);++ default <T> T executeRequired(String commandName, @Nullable Map<String, ?> parameters) {+ return requireNonNull(execute(commandName, parameters));+ }
Evidence
Compliance requires public interfaces to remain backward compatible; changing
ExecuteMethod.execute from a concrete Object return to a generic <T> T changes the method’s
source-level contract for implementers and callers. The diff shows the updated generic signature on
a public interface method.

AGENTS.md
java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
A public interface method (`ExecuteMethod.execute`) was changed to a generic method. This can break downstream implementations that previously implemented `Object execute(String, Map)` and violates the project’s API/ABI compatibility expectations.
## Issue Context
`ExecuteMethod` is a public extension point in `org.openqa.selenium.remote`. To keep upgrades safe, avoid source-incompatible signature changes; prefer adding a new helper method (with a new name) that performs the generic cast and/or required-null enforcement.
## Fix Focus Areas
- java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
 2. Mutable extensions capability list 🐞 Bug⛯ Reliability
Description
ChromiumOptions now stores a mutable List for the "extensions" capability inside an otherwise
unmodifiable options map, creating an immutability inconsistency (and allowing unexpected post-hoc
mutation by callers). This can lead to subtle bugs where capability maps appear immutable but
contain mutable nested state.

Code
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[R251-261]
+ options.put("args", List.copyOf(args));+ options.put("extensions", extensionsArgument());
options.putAll(androidOptions);
return unmodifiableMap(options);
}
+ private List<String> extensionsArgument() {+ return Stream.concat(extensionFiles.stream().map(this::fileContentBase64), extensions.stream())+ .collect(toList());+ }
Evidence
getExtraCapability returns unmodifiableMap(options) but inserts extensionsArgument() directly;
extensionsArgument() uses Collectors.toList() which produces a mutable list. In the same method,
args is explicitly made immutable via List.copyOf(args), suggesting the intent is to return
immutable collections for list-valued capabilities.

java/src/org/openqa/selenium/chromium/ChromiumOptions.java[245-256]
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`ChromiumOptions#getExtraCapability` returns an unmodifiable map, but the `&quot;extensions&quot;` value is currently a mutable `List` (built via `Collectors.toList()`), which breaks the implicit immutability expectation established by `&quot;args&quot;` using `List.copyOf(args)`.
### Issue Context
Callers may treat capability maps as effectively immutable; mutating nested collections can produce surprising behavior and makes debugging harder.
### Fix Focus Areas
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[251-256]
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Grey Divider
ⓘ The new review experience is currently in Beta. Learn more
Grey Divider
Qodo Logo
@asolntsev
asolntsev
merged commit cae8d22
into
SeleniumHQ:trunkMar 2, 2026

73 of 77 checks passed

@asolntsev
asolntsev
deleted the

nullability

branch
March 2, 2026 21:16
@asolntsevasolntsev
added
the 
I-enhancement
Something could be better
label
Mar 3, 2026
asolntsev added a commit
to asolntsev/selenium
that referenced
this pull request
Mar 6, 2026
@asolntsev
make the signature change in ExecuteMethod backward compatible
5e8e34c
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
@asolntsevasolntsev
mentioned this pull request
Mar 6, 2026
 Merged

asolntsev added a commit
that referenced
this pull request
Mar 6, 2026
@asolntsev
[java] make the signature change in ExecuteMethod backward compatib…
bd280c7
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] specify nullability in packagesorg.openqa.selenium.chrom*(#…
14642bd
…17152)
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] make the signature change in ExecuteMethod backward compatib…
ada4964
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
krishnamohan-kothapalli pushed a commit
to krishnamohan-kothapalli/selenium
that referenced
this pull request
Mar 18, 2026
@asolntsev@krishnamohan-kothapalli
[java] make the signature change in ExecuteMethod backward compatib…
f571079
…le (SeleniumHQ#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`

This was referenced Apr 9, 2026
 Merged

 Closed

 Closed

 Merged

 Merged

 Merged

 Closed

 Closed

 Closed

 Merged

 Merged

 Closed

 Closed


This was referenced Apr 17, 2026
 Closed

 Closed

 Merged

 Closed

 Closed

 Closed


This was referenced May 1, 2026
 Closed

 Closed


This was referenced May 11, 2026
 Merged

 Closed

 Closed

 Closed

 Closed

@dependabotdependabotBot
mentioned this pull request
May 18, 2026
 Closed


This was referenced Jun 16, 2026
 Closed

 Closed

 Closed

 Closed

 Closed


This was referenced Jul 13, 2026
 Open

 Closed

 Closed


This was referenced Aug 1, 2026
 Closed

 Closed

 Closed

 Closed


This was referenced Aug 17, 2026
 Closed

 Open


This was referenced Aug 31, 2026
 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@iampopovichiampopovichAwaiting requested review from iampopovich

Assignees

@asolntsevasolntsev

Labels

C-javaJava BindingsI-enhancementSomething could be better

Projects


None yet


Milestone

4.42.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asolntsev@selenium-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[java] specify nullability in packages org.openqa.selenium.chrom* - #17152
Merged
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Mar 2, 2026
Merged
[java] specify nullability in packages org.openqa.selenium.chrom*#17152
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Conversation
@asolntsev
@asolntsevasolntsev
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
🔗 Related Issues
Partially implements #14291
💥 What does this PR do?
Added JSpecify nullability annotations to packages:
  • org.openqa.selenium.chrome
  • org.openqa.selenium.chromium
  • (and a little bit to org.openqa.selenium.remote, as much as needed for previous two)
🔄 Types of changes
  • Cleanup (formatting, renaming)
@asolntsevasolntsev
self-assigned this
Mar 1, 2026
@asolntsevasolntsev
added this to the 4.42.0 milestone
Mar 1, 2026
@selenium-ciselenium-ci
added
the 
C-java
Java Bindings
label
Mar 1, 2026
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Review Summary by Qodo
Add JSpecify nullability annotations to chrome and chromium packages
✨ Enhancement🧪 Tests
Grey Divider
Walkthroughs
Description
• Add JSpecify nullability annotations to chrome and chromium packages
• Introduce helper methods for safe capability retrieval and execution
• Refactor code to eliminate unsafe casts and improve type safety
• Clean up unused imports and simplify implementation patterns

Grey Divider
File Changes
1. java/src/org/openqa/selenium/Capabilities.java
✨ Enhancement +12/-0 
Add generic helper methods for capability access
 java/src/org/openqa/selenium/Capabilities.java
2. java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
 Cleanup  +0/-3 
Remove unused logger import
 java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
3. java/src/org/openqa/selenium/chrome/package-info.java
✨ Enhancement +21/-0 
Add NullMarked annotation to chrome package
 java/src/org/openqa/selenium/chrome/package-info.java
View more (12)
4. java/src/org/openqa/selenium/chromium/AddHasCasting.java
✨ Enhancement +5/-3 
Replace unsafe casts with safe null handling
 java/src/org/openqa/selenium/chromium/AddHasCasting.java
5. java/src/org/openqa/selenium/chromium/AddHasCdp.java
✨ Enhancement +2/-5 
Use executeRequired for non-null result handling
 java/src/org/openqa/selenium/chromium/AddHasCdp.java
6. java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
✨ Enhancement +1/-4 
Replace requireNonNull with executeRequired method
 java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
7. java/src/org/openqa/selenium/chromium/ChromiumDriver.java
✨ Enhancement +4/-9 
Add nullability annotations and remove redundant code
 java/src/org/openqa/selenium/chromium/ChromiumDriver.java
8. java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
✨ Enhancement +1/-1 
Add nullable annotation to fromString parameter
 java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
9. java/src/org/openqa/selenium/chromium/ChromiumOptions.java
✨ Enhancement +39/-43 
Refactor to use self() method and improve type safety
 java/src/org/openqa/selenium/chromium/ChromiumOptions.java
10. java/src/org/openqa/selenium/chromium/HasCasting.java
📝 Documentation +1/-1 
Update javadoc from array to list terminology
 java/src/org/openqa/selenium/chromium/HasCasting.java
11. java/src/org/openqa/selenium/remote/ExecuteMethod.java
✨ Enhancement +7/-1 
Add generic type parameter and executeRequired method
 java/src/org/openqa/selenium/remote/ExecuteMethod.java
12. java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
✨ Enhancement +18/-16 
Add nullability annotations and simplify casting
 java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
13. java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
✨ Enhancement +3/-1 
Add NullMarked annotation and generic type parameter
 java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
14. java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
✨ Enhancement +3/-2 
Add generic type parameter with cast suppression
 java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
15. java/src/org/openqa/selenium/remote/RemoteWebDriver.java
✨ Enhancement +2/-1 
Add nullability annotations to executeScript method
 java/src/org/openqa/selenium/remote/RemoteWebDriver.java
Grey Divider
Qodo Logo
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Code Review by Qodo
🐞 Bugs (1)📘 Rule violations (1)📎 Requirement gaps (0)
Grey Divider

Remediation recommended
 1. ExecuteMethod.execute() made generic 📘 Rule violation✓ Correctness
Description
The public ExecuteMethod.execute signature was changed to a generic method, which can be
source-incompatible for downstream implementations that previously implemented `Object
execute(...)`. This risks breaking user upgrades without a compatibility strategy.

Code
java/src/org/openqa/selenium/remote/ExecuteMethod.java[R40-44]
+ @Nullable <T> T execute(String commandName, @Nullable Map<String, ?> parameters);++ default <T> T executeRequired(String commandName, @Nullable Map<String, ?> parameters) {+ return requireNonNull(execute(commandName, parameters));+ }
Evidence
Compliance requires public interfaces to remain backward compatible; changing
ExecuteMethod.execute from a concrete Object return to a generic <T> T changes the method’s
source-level contract for implementers and callers. The diff shows the updated generic signature on
a public interface method.

AGENTS.md
java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
A public interface method (`ExecuteMethod.execute`) was changed to a generic method. This can break downstream implementations that previously implemented `Object execute(String, Map)` and violates the project’s API/ABI compatibility expectations.
## Issue Context
`ExecuteMethod` is a public extension point in `org.openqa.selenium.remote`. To keep upgrades safe, avoid source-incompatible signature changes; prefer adding a new helper method (with a new name) that performs the generic cast and/or required-null enforcement.
## Fix Focus Areas
- java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
 2. Mutable extensions capability list 🐞 Bug⛯ Reliability
Description
ChromiumOptions now stores a mutable List for the "extensions" capability inside an otherwise
unmodifiable options map, creating an immutability inconsistency (and allowing unexpected post-hoc
mutation by callers). This can lead to subtle bugs where capability maps appear immutable but
contain mutable nested state.

Code
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[R251-261]
+ options.put("args", List.copyOf(args));+ options.put("extensions", extensionsArgument());
options.putAll(androidOptions);
return unmodifiableMap(options);
}
+ private List<String> extensionsArgument() {+ return Stream.concat(extensionFiles.stream().map(this::fileContentBase64), extensions.stream())+ .collect(toList());+ }
Evidence
getExtraCapability returns unmodifiableMap(options) but inserts extensionsArgument() directly;
extensionsArgument() uses Collectors.toList() which produces a mutable list. In the same method,
args is explicitly made immutable via List.copyOf(args), suggesting the intent is to return
immutable collections for list-valued capabilities.

java/src/org/openqa/selenium/chromium/ChromiumOptions.java[245-256]
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`ChromiumOptions#getExtraCapability` returns an unmodifiable map, but the `&quot;extensions&quot;` value is currently a mutable `List` (built via `Collectors.toList()`), which breaks the implicit immutability expectation established by `&quot;args&quot;` using `List.copyOf(args)`.
### Issue Context
Callers may treat capability maps as effectively immutable; mutating nested collections can produce surprising behavior and makes debugging harder.
### Fix Focus Areas
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[251-256]
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Grey Divider
ⓘ The new review experience is currently in Beta. Learn more
Grey Divider
Qodo Logo
@asolntsev
asolntsev
merged commit cae8d22
into
SeleniumHQ:trunkMar 2, 2026

73 of 77 checks passed

@asolntsev
asolntsev
deleted the

nullability

branch
March 2, 2026 21:16
@asolntsevasolntsev
added
the 
I-enhancement
Something could be better
label
Mar 3, 2026
asolntsev added a commit
to asolntsev/selenium
that referenced
this pull request
Mar 6, 2026
@asolntsev
make the signature change in ExecuteMethod backward compatible
5e8e34c
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
@asolntsevasolntsev
mentioned this pull request
Mar 6, 2026
 Merged

asolntsev added a commit
that referenced
this pull request
Mar 6, 2026
@asolntsev
[java] make the signature change in ExecuteMethod backward compatib…
bd280c7
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] specify nullability in packagesorg.openqa.selenium.chrom*(#…
14642bd
…17152)
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] make the signature change in ExecuteMethod backward compatib…
ada4964
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
krishnamohan-kothapalli pushed a commit
to krishnamohan-kothapalli/selenium
that referenced
this pull request
Mar 18, 2026
@asolntsev@krishnamohan-kothapalli
[java] make the signature change in ExecuteMethod backward compatib…
f571079
…le (SeleniumHQ#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`

This was referenced Apr 9, 2026
 Merged

 Closed

 Closed

 Merged

 Merged

 Merged

 Closed

 Closed

 Closed

 Merged

 Merged

 Closed

 Closed


This was referenced Apr 17, 2026
 Closed

 Closed

 Merged

 Closed

 Closed

 Closed


This was referenced May 1, 2026
 Closed

 Closed


This was referenced May 11, 2026
 Merged

 Closed

 Closed

 Closed

 Closed

@dependabotdependabotBot
mentioned this pull request
May 18, 2026
 Closed


This was referenced Jun 16, 2026
 Closed

 Closed

 Closed

 Closed

 Closed


This was referenced Jul 13, 2026
 Open

 Closed

 Closed


This was referenced Aug 1, 2026
 Closed

 Closed

 Closed

 Closed


This was referenced Aug 17, 2026
 Closed

 Open


This was referenced Aug 31, 2026
 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@iampopovichiampopovichAwaiting requested review from iampopovich

Assignees

@asolntsevasolntsev

Labels

C-javaJava BindingsI-enhancementSomething could be better

Projects


None yet


Milestone

4.42.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asolntsev@selenium-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[java] specify nullability in packages org.openqa.selenium.chrom* - #17152
Merged
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Mar 2, 2026
Merged
[java] specify nullability in packages org.openqa.selenium.chrom*#17152
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Conversation
@asolntsev
@asolntsevasolntsev
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
🔗 Related Issues
Partially implements #14291
💥 What does this PR do?
Added JSpecify nullability annotations to packages:
  • org.openqa.selenium.chrome
  • org.openqa.selenium.chromium
  • (and a little bit to org.openqa.selenium.remote, as much as needed for previous two)
🔄 Types of changes
  • Cleanup (formatting, renaming)
@asolntsevasolntsev
self-assigned this
Mar 1, 2026
@asolntsevasolntsev
added this to the 4.42.0 milestone
Mar 1, 2026
@selenium-ciselenium-ci
added
the 
C-java
Java Bindings
label
Mar 1, 2026
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Review Summary by Qodo
Add JSpecify nullability annotations to chrome and chromium packages
✨ Enhancement🧪 Tests
Grey Divider
Walkthroughs
Description
• Add JSpecify nullability annotations to chrome and chromium packages
• Introduce helper methods for safe capability retrieval and execution
• Refactor code to eliminate unsafe casts and improve type safety
• Clean up unused imports and simplify implementation patterns

Grey Divider
File Changes
1. java/src/org/openqa/selenium/Capabilities.java
✨ Enhancement +12/-0 
Add generic helper methods for capability access
 java/src/org/openqa/selenium/Capabilities.java
2. java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
 Cleanup  +0/-3 
Remove unused logger import
 java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
3. java/src/org/openqa/selenium/chrome/package-info.java
✨ Enhancement +21/-0 
Add NullMarked annotation to chrome package
 java/src/org/openqa/selenium/chrome/package-info.java
View more (12)
4. java/src/org/openqa/selenium/chromium/AddHasCasting.java
✨ Enhancement +5/-3 
Replace unsafe casts with safe null handling
 java/src/org/openqa/selenium/chromium/AddHasCasting.java
5. java/src/org/openqa/selenium/chromium/AddHasCdp.java
✨ Enhancement +2/-5 
Use executeRequired for non-null result handling
 java/src/org/openqa/selenium/chromium/AddHasCdp.java
6. java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
✨ Enhancement +1/-4 
Replace requireNonNull with executeRequired method
 java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
7. java/src/org/openqa/selenium/chromium/ChromiumDriver.java
✨ Enhancement +4/-9 
Add nullability annotations and remove redundant code
 java/src/org/openqa/selenium/chromium/ChromiumDriver.java
8. java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
✨ Enhancement +1/-1 
Add nullable annotation to fromString parameter
 java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
9. java/src/org/openqa/selenium/chromium/ChromiumOptions.java
✨ Enhancement +39/-43 
Refactor to use self() method and improve type safety
 java/src/org/openqa/selenium/chromium/ChromiumOptions.java
10. java/src/org/openqa/selenium/chromium/HasCasting.java
📝 Documentation +1/-1 
Update javadoc from array to list terminology
 java/src/org/openqa/selenium/chromium/HasCasting.java
11. java/src/org/openqa/selenium/remote/ExecuteMethod.java
✨ Enhancement +7/-1 
Add generic type parameter and executeRequired method
 java/src/org/openqa/selenium/remote/ExecuteMethod.java
12. java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
✨ Enhancement +18/-16 
Add nullability annotations and simplify casting
 java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
13. java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
✨ Enhancement +3/-1 
Add NullMarked annotation and generic type parameter
 java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
14. java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
✨ Enhancement +3/-2 
Add generic type parameter with cast suppression
 java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
15. java/src/org/openqa/selenium/remote/RemoteWebDriver.java
✨ Enhancement +2/-1 
Add nullability annotations to executeScript method
 java/src/org/openqa/selenium/remote/RemoteWebDriver.java
Grey Divider
Qodo Logo
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Code Review by Qodo
🐞 Bugs (1)📘 Rule violations (1)📎 Requirement gaps (0)
Grey Divider

Remediation recommended
 1. ExecuteMethod.execute() made generic 📘 Rule violation✓ Correctness
Description
The public ExecuteMethod.execute signature was changed to a generic method, which can be
source-incompatible for downstream implementations that previously implemented `Object
execute(...)`. This risks breaking user upgrades without a compatibility strategy.

Code
java/src/org/openqa/selenium/remote/ExecuteMethod.java[R40-44]
+ @Nullable <T> T execute(String commandName, @Nullable Map<String, ?> parameters);++ default <T> T executeRequired(String commandName, @Nullable Map<String, ?> parameters) {+ return requireNonNull(execute(commandName, parameters));+ }
Evidence
Compliance requires public interfaces to remain backward compatible; changing
ExecuteMethod.execute from a concrete Object return to a generic <T> T changes the method’s
source-level contract for implementers and callers. The diff shows the updated generic signature on
a public interface method.

AGENTS.md
java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
A public interface method (`ExecuteMethod.execute`) was changed to a generic method. This can break downstream implementations that previously implemented `Object execute(String, Map)` and violates the project’s API/ABI compatibility expectations.
## Issue Context
`ExecuteMethod` is a public extension point in `org.openqa.selenium.remote`. To keep upgrades safe, avoid source-incompatible signature changes; prefer adding a new helper method (with a new name) that performs the generic cast and/or required-null enforcement.
## Fix Focus Areas
- java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
 2. Mutable extensions capability list 🐞 Bug⛯ Reliability
Description
ChromiumOptions now stores a mutable List for the "extensions" capability inside an otherwise
unmodifiable options map, creating an immutability inconsistency (and allowing unexpected post-hoc
mutation by callers). This can lead to subtle bugs where capability maps appear immutable but
contain mutable nested state.

Code
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[R251-261]
+ options.put("args", List.copyOf(args));+ options.put("extensions", extensionsArgument());
options.putAll(androidOptions);
return unmodifiableMap(options);
}
+ private List<String> extensionsArgument() {+ return Stream.concat(extensionFiles.stream().map(this::fileContentBase64), extensions.stream())+ .collect(toList());+ }
Evidence
getExtraCapability returns unmodifiableMap(options) but inserts extensionsArgument() directly;
extensionsArgument() uses Collectors.toList() which produces a mutable list. In the same method,
args is explicitly made immutable via List.copyOf(args), suggesting the intent is to return
immutable collections for list-valued capabilities.

java/src/org/openqa/selenium/chromium/ChromiumOptions.java[245-256]
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`ChromiumOptions#getExtraCapability` returns an unmodifiable map, but the `&quot;extensions&quot;` value is currently a mutable `List` (built via `Collectors.toList()`), which breaks the implicit immutability expectation established by `&quot;args&quot;` using `List.copyOf(args)`.
### Issue Context
Callers may treat capability maps as effectively immutable; mutating nested collections can produce surprising behavior and makes debugging harder.
### Fix Focus Areas
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[251-256]
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Grey Divider
ⓘ The new review experience is currently in Beta. Learn more
Grey Divider
Qodo Logo
@asolntsev
asolntsev
merged commit cae8d22
into
SeleniumHQ:trunkMar 2, 2026

73 of 77 checks passed

@asolntsev
asolntsev
deleted the

nullability

branch
March 2, 2026 21:16
@asolntsevasolntsev
added
the 
I-enhancement
Something could be better
label
Mar 3, 2026
asolntsev added a commit
to asolntsev/selenium
that referenced
this pull request
Mar 6, 2026
@asolntsev
make the signature change in ExecuteMethod backward compatible
5e8e34c
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
@asolntsevasolntsev
mentioned this pull request
Mar 6, 2026
 Merged

asolntsev added a commit
that referenced
this pull request
Mar 6, 2026
@asolntsev
[java] make the signature change in ExecuteMethod backward compatib…
bd280c7
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] specify nullability in packagesorg.openqa.selenium.chrom*(#…
14642bd
…17152)
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] make the signature change in ExecuteMethod backward compatib…
ada4964
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
krishnamohan-kothapalli pushed a commit
to krishnamohan-kothapalli/selenium
that referenced
this pull request
Mar 18, 2026
@asolntsev@krishnamohan-kothapalli
[java] make the signature change in ExecuteMethod backward compatib…
f571079
…le (SeleniumHQ#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`

This was referenced Apr 9, 2026
 Merged

 Closed

 Closed

 Merged

 Merged

 Merged

 Closed

 Closed

 Closed

 Merged

 Merged

 Closed

 Closed


This was referenced Apr 17, 2026
 Closed

 Closed

 Merged

 Closed

 Closed

 Closed


This was referenced May 1, 2026
 Closed

 Closed


This was referenced May 11, 2026
 Merged

 Closed

 Closed

 Closed

 Closed

@dependabotdependabotBot
mentioned this pull request
May 18, 2026
 Closed


This was referenced Jun 16, 2026
 Closed

 Closed

 Closed

 Closed

 Closed


This was referenced Jul 13, 2026
 Open

 Closed

 Closed


This was referenced Aug 1, 2026
 Closed

 Closed

 Closed

 Closed


This was referenced Aug 17, 2026
 Closed

 Open


This was referenced Aug 31, 2026
 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@iampopovichiampopovichAwaiting requested review from iampopovich

Assignees

@asolntsevasolntsev

Labels

C-javaJava BindingsI-enhancementSomething could be better

Projects


None yet


Milestone

4.42.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asolntsev@selenium-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[java] specify nullability in packages org.openqa.selenium.chrom* - #17152
Merged
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Mar 2, 2026
Merged
[java] specify nullability in packages org.openqa.selenium.chrom*#17152
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Conversation
@asolntsev
@asolntsevasolntsev
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
🔗 Related Issues
Partially implements #14291
💥 What does this PR do?
Added JSpecify nullability annotations to packages:
  • org.openqa.selenium.chrome
  • org.openqa.selenium.chromium
  • (and a little bit to org.openqa.selenium.remote, as much as needed for previous two)
🔄 Types of changes
  • Cleanup (formatting, renaming)
@asolntsevasolntsev
self-assigned this
Mar 1, 2026
@asolntsevasolntsev
added this to the 4.42.0 milestone
Mar 1, 2026
@selenium-ciselenium-ci
added
the 
C-java
Java Bindings
label
Mar 1, 2026
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Review Summary by Qodo
Add JSpecify nullability annotations to chrome and chromium packages
✨ Enhancement🧪 Tests
Grey Divider
Walkthroughs
Description
• Add JSpecify nullability annotations to chrome and chromium packages
• Introduce helper methods for safe capability retrieval and execution
• Refactor code to eliminate unsafe casts and improve type safety
• Clean up unused imports and simplify implementation patterns

Grey Divider
File Changes
1. java/src/org/openqa/selenium/Capabilities.java
✨ Enhancement +12/-0 
Add generic helper methods for capability access
 java/src/org/openqa/selenium/Capabilities.java
2. java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
 Cleanup  +0/-3 
Remove unused logger import
 java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
3. java/src/org/openqa/selenium/chrome/package-info.java
✨ Enhancement +21/-0 
Add NullMarked annotation to chrome package
 java/src/org/openqa/selenium/chrome/package-info.java
View more (12)
4. java/src/org/openqa/selenium/chromium/AddHasCasting.java
✨ Enhancement +5/-3 
Replace unsafe casts with safe null handling
 java/src/org/openqa/selenium/chromium/AddHasCasting.java
5. java/src/org/openqa/selenium/chromium/AddHasCdp.java
✨ Enhancement +2/-5 
Use executeRequired for non-null result handling
 java/src/org/openqa/selenium/chromium/AddHasCdp.java
6. java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
✨ Enhancement +1/-4 
Replace requireNonNull with executeRequired method
 java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
7. java/src/org/openqa/selenium/chromium/ChromiumDriver.java
✨ Enhancement +4/-9 
Add nullability annotations and remove redundant code
 java/src/org/openqa/selenium/chromium/ChromiumDriver.java
8. java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
✨ Enhancement +1/-1 
Add nullable annotation to fromString parameter
 java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
9. java/src/org/openqa/selenium/chromium/ChromiumOptions.java
✨ Enhancement +39/-43 
Refactor to use self() method and improve type safety
 java/src/org/openqa/selenium/chromium/ChromiumOptions.java
10. java/src/org/openqa/selenium/chromium/HasCasting.java
📝 Documentation +1/-1 
Update javadoc from array to list terminology
 java/src/org/openqa/selenium/chromium/HasCasting.java
11. java/src/org/openqa/selenium/remote/ExecuteMethod.java
✨ Enhancement +7/-1 
Add generic type parameter and executeRequired method
 java/src/org/openqa/selenium/remote/ExecuteMethod.java
12. java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
✨ Enhancement +18/-16 
Add nullability annotations and simplify casting
 java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
13. java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
✨ Enhancement +3/-1 
Add NullMarked annotation and generic type parameter
 java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
14. java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
✨ Enhancement +3/-2 
Add generic type parameter with cast suppression
 java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
15. java/src/org/openqa/selenium/remote/RemoteWebDriver.java
✨ Enhancement +2/-1 
Add nullability annotations to executeScript method
 java/src/org/openqa/selenium/remote/RemoteWebDriver.java
Grey Divider
Qodo Logo
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Code Review by Qodo
🐞 Bugs (1)📘 Rule violations (1)📎 Requirement gaps (0)
Grey Divider

Remediation recommended
 1. ExecuteMethod.execute() made generic 📘 Rule violation✓ Correctness
Description
The public ExecuteMethod.execute signature was changed to a generic method, which can be
source-incompatible for downstream implementations that previously implemented `Object
execute(...)`. This risks breaking user upgrades without a compatibility strategy.

Code
java/src/org/openqa/selenium/remote/ExecuteMethod.java[R40-44]
+ @Nullable <T> T execute(String commandName, @Nullable Map<String, ?> parameters);++ default <T> T executeRequired(String commandName, @Nullable Map<String, ?> parameters) {+ return requireNonNull(execute(commandName, parameters));+ }
Evidence
Compliance requires public interfaces to remain backward compatible; changing
ExecuteMethod.execute from a concrete Object return to a generic <T> T changes the method’s
source-level contract for implementers and callers. The diff shows the updated generic signature on
a public interface method.

AGENTS.md
java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
A public interface method (`ExecuteMethod.execute`) was changed to a generic method. This can break downstream implementations that previously implemented `Object execute(String, Map)` and violates the project’s API/ABI compatibility expectations.
## Issue Context
`ExecuteMethod` is a public extension point in `org.openqa.selenium.remote`. To keep upgrades safe, avoid source-incompatible signature changes; prefer adding a new helper method (with a new name) that performs the generic cast and/or required-null enforcement.
## Fix Focus Areas
- java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
 2. Mutable extensions capability list 🐞 Bug⛯ Reliability
Description
ChromiumOptions now stores a mutable List for the "extensions" capability inside an otherwise
unmodifiable options map, creating an immutability inconsistency (and allowing unexpected post-hoc
mutation by callers). This can lead to subtle bugs where capability maps appear immutable but
contain mutable nested state.

Code
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[R251-261]
+ options.put("args", List.copyOf(args));+ options.put("extensions", extensionsArgument());
options.putAll(androidOptions);
return unmodifiableMap(options);
}
+ private List<String> extensionsArgument() {+ return Stream.concat(extensionFiles.stream().map(this::fileContentBase64), extensions.stream())+ .collect(toList());+ }
Evidence
getExtraCapability returns unmodifiableMap(options) but inserts extensionsArgument() directly;
extensionsArgument() uses Collectors.toList() which produces a mutable list. In the same method,
args is explicitly made immutable via List.copyOf(args), suggesting the intent is to return
immutable collections for list-valued capabilities.

java/src/org/openqa/selenium/chromium/ChromiumOptions.java[245-256]
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`ChromiumOptions#getExtraCapability` returns an unmodifiable map, but the `&quot;extensions&quot;` value is currently a mutable `List` (built via `Collectors.toList()`), which breaks the implicit immutability expectation established by `&quot;args&quot;` using `List.copyOf(args)`.
### Issue Context
Callers may treat capability maps as effectively immutable; mutating nested collections can produce surprising behavior and makes debugging harder.
### Fix Focus Areas
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[251-256]
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Grey Divider
ⓘ The new review experience is currently in Beta. Learn more
Grey Divider
Qodo Logo
@asolntsev
asolntsev
merged commit cae8d22
into
SeleniumHQ:trunkMar 2, 2026

73 of 77 checks passed

@asolntsev
asolntsev
deleted the

nullability

branch
March 2, 2026 21:16
@asolntsevasolntsev
added
the 
I-enhancement
Something could be better
label
Mar 3, 2026
asolntsev added a commit
to asolntsev/selenium
that referenced
this pull request
Mar 6, 2026
@asolntsev
make the signature change in ExecuteMethod backward compatible
5e8e34c
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
@asolntsevasolntsev
mentioned this pull request
Mar 6, 2026
 Merged

asolntsev added a commit
that referenced
this pull request
Mar 6, 2026
@asolntsev
[java] make the signature change in ExecuteMethod backward compatib…
bd280c7
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] specify nullability in packagesorg.openqa.selenium.chrom*(#…
14642bd
…17152)
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] make the signature change in ExecuteMethod backward compatib…
ada4964
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
krishnamohan-kothapalli pushed a commit
to krishnamohan-kothapalli/selenium
that referenced
this pull request
Mar 18, 2026
@asolntsev@krishnamohan-kothapalli
[java] make the signature change in ExecuteMethod backward compatib…
f571079
…le (SeleniumHQ#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`

This was referenced Apr 9, 2026
 Merged

 Closed

 Closed

 Merged

 Merged

 Merged

 Closed

 Closed

 Closed

 Merged

 Merged

 Closed

 Closed


This was referenced Apr 17, 2026
 Closed

 Closed

 Merged

 Closed

 Closed

 Closed


This was referenced May 1, 2026
 Closed

 Closed


This was referenced May 11, 2026
 Merged

 Closed

 Closed

 Closed

 Closed

@dependabotdependabotBot
mentioned this pull request
May 18, 2026
 Closed


This was referenced Jun 16, 2026
 Closed

 Closed

 Closed

 Closed

 Closed


This was referenced Jul 13, 2026
 Open

 Closed

 Closed


This was referenced Aug 1, 2026
 Closed

 Closed

 Closed

 Closed


This was referenced Aug 17, 2026
 Closed

 Open


This was referenced Aug 31, 2026
 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@iampopovichiampopovichAwaiting requested review from iampopovich

Assignees

@asolntsevasolntsev

Labels

C-javaJava BindingsI-enhancementSomething could be better

Projects


None yet


Milestone

4.42.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asolntsev@selenium-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[java] specify nullability in packages org.openqa.selenium.chrom* - #17152
Merged
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Mar 2, 2026
Merged
[java] specify nullability in packages org.openqa.selenium.chrom*#17152
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Conversation
@asolntsev
@asolntsevasolntsev
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
🔗 Related Issues
Partially implements #14291
💥 What does this PR do?
Added JSpecify nullability annotations to packages:
  • org.openqa.selenium.chrome
  • org.openqa.selenium.chromium
  • (and a little bit to org.openqa.selenium.remote, as much as needed for previous two)
🔄 Types of changes
  • Cleanup (formatting, renaming)
@asolntsevasolntsev
self-assigned this
Mar 1, 2026
@asolntsevasolntsev
added this to the 4.42.0 milestone
Mar 1, 2026
@selenium-ciselenium-ci
added
the 
C-java
Java Bindings
label
Mar 1, 2026
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Review Summary by Qodo
Add JSpecify nullability annotations to chrome and chromium packages
✨ Enhancement🧪 Tests
Grey Divider
Walkthroughs
Description
• Add JSpecify nullability annotations to chrome and chromium packages
• Introduce helper methods for safe capability retrieval and execution
• Refactor code to eliminate unsafe casts and improve type safety
• Clean up unused imports and simplify implementation patterns

Grey Divider
File Changes
1. java/src/org/openqa/selenium/Capabilities.java
✨ Enhancement +12/-0 
Add generic helper methods for capability access
 java/src/org/openqa/selenium/Capabilities.java
2. java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
 Cleanup  +0/-3 
Remove unused logger import
 java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
3. java/src/org/openqa/selenium/chrome/package-info.java
✨ Enhancement +21/-0 
Add NullMarked annotation to chrome package
 java/src/org/openqa/selenium/chrome/package-info.java
View more (12)
4. java/src/org/openqa/selenium/chromium/AddHasCasting.java
✨ Enhancement +5/-3 
Replace unsafe casts with safe null handling
 java/src/org/openqa/selenium/chromium/AddHasCasting.java
5. java/src/org/openqa/selenium/chromium/AddHasCdp.java
✨ Enhancement +2/-5 
Use executeRequired for non-null result handling
 java/src/org/openqa/selenium/chromium/AddHasCdp.java
6. java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
✨ Enhancement +1/-4 
Replace requireNonNull with executeRequired method
 java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
7. java/src/org/openqa/selenium/chromium/ChromiumDriver.java
✨ Enhancement +4/-9 
Add nullability annotations and remove redundant code
 java/src/org/openqa/selenium/chromium/ChromiumDriver.java
8. java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
✨ Enhancement +1/-1 
Add nullable annotation to fromString parameter
 java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
9. java/src/org/openqa/selenium/chromium/ChromiumOptions.java
✨ Enhancement +39/-43 
Refactor to use self() method and improve type safety
 java/src/org/openqa/selenium/chromium/ChromiumOptions.java
10. java/src/org/openqa/selenium/chromium/HasCasting.java
📝 Documentation +1/-1 
Update javadoc from array to list terminology
 java/src/org/openqa/selenium/chromium/HasCasting.java
11. java/src/org/openqa/selenium/remote/ExecuteMethod.java
✨ Enhancement +7/-1 
Add generic type parameter and executeRequired method
 java/src/org/openqa/selenium/remote/ExecuteMethod.java
12. java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
✨ Enhancement +18/-16 
Add nullability annotations and simplify casting
 java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
13. java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
✨ Enhancement +3/-1 
Add NullMarked annotation and generic type parameter
 java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
14. java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
✨ Enhancement +3/-2 
Add generic type parameter with cast suppression
 java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
15. java/src/org/openqa/selenium/remote/RemoteWebDriver.java
✨ Enhancement +2/-1 
Add nullability annotations to executeScript method
 java/src/org/openqa/selenium/remote/RemoteWebDriver.java
Grey Divider
Qodo Logo
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Code Review by Qodo
🐞 Bugs (1)📘 Rule violations (1)📎 Requirement gaps (0)
Grey Divider

Remediation recommended
 1. ExecuteMethod.execute() made generic 📘 Rule violation✓ Correctness
Description
The public ExecuteMethod.execute signature was changed to a generic method, which can be
source-incompatible for downstream implementations that previously implemented `Object
execute(...)`. This risks breaking user upgrades without a compatibility strategy.

Code
java/src/org/openqa/selenium/remote/ExecuteMethod.java[R40-44]
+ @Nullable <T> T execute(String commandName, @Nullable Map<String, ?> parameters);++ default <T> T executeRequired(String commandName, @Nullable Map<String, ?> parameters) {+ return requireNonNull(execute(commandName, parameters));+ }
Evidence
Compliance requires public interfaces to remain backward compatible; changing
ExecuteMethod.execute from a concrete Object return to a generic <T> T changes the method’s
source-level contract for implementers and callers. The diff shows the updated generic signature on
a public interface method.

AGENTS.md
java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
A public interface method (`ExecuteMethod.execute`) was changed to a generic method. This can break downstream implementations that previously implemented `Object execute(String, Map)` and violates the project’s API/ABI compatibility expectations.
## Issue Context
`ExecuteMethod` is a public extension point in `org.openqa.selenium.remote`. To keep upgrades safe, avoid source-incompatible signature changes; prefer adding a new helper method (with a new name) that performs the generic cast and/or required-null enforcement.
## Fix Focus Areas
- java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
 2. Mutable extensions capability list 🐞 Bug⛯ Reliability
Description
ChromiumOptions now stores a mutable List for the "extensions" capability inside an otherwise
unmodifiable options map, creating an immutability inconsistency (and allowing unexpected post-hoc
mutation by callers). This can lead to subtle bugs where capability maps appear immutable but
contain mutable nested state.

Code
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[R251-261]
+ options.put("args", List.copyOf(args));+ options.put("extensions", extensionsArgument());
options.putAll(androidOptions);
return unmodifiableMap(options);
}
+ private List<String> extensionsArgument() {+ return Stream.concat(extensionFiles.stream().map(this::fileContentBase64), extensions.stream())+ .collect(toList());+ }
Evidence
getExtraCapability returns unmodifiableMap(options) but inserts extensionsArgument() directly;
extensionsArgument() uses Collectors.toList() which produces a mutable list. In the same method,
args is explicitly made immutable via List.copyOf(args), suggesting the intent is to return
immutable collections for list-valued capabilities.

java/src/org/openqa/selenium/chromium/ChromiumOptions.java[245-256]
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`ChromiumOptions#getExtraCapability` returns an unmodifiable map, but the `&quot;extensions&quot;` value is currently a mutable `List` (built via `Collectors.toList()`), which breaks the implicit immutability expectation established by `&quot;args&quot;` using `List.copyOf(args)`.
### Issue Context
Callers may treat capability maps as effectively immutable; mutating nested collections can produce surprising behavior and makes debugging harder.
### Fix Focus Areas
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[251-256]
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Grey Divider
ⓘ The new review experience is currently in Beta. Learn more
Grey Divider
Qodo Logo
@asolntsev
asolntsev
merged commit cae8d22
into
SeleniumHQ:trunkMar 2, 2026

73 of 77 checks passed

@asolntsev
asolntsev
deleted the

nullability

branch
March 2, 2026 21:16
@asolntsevasolntsev
added
the 
I-enhancement
Something could be better
label
Mar 3, 2026
asolntsev added a commit
to asolntsev/selenium
that referenced
this pull request
Mar 6, 2026
@asolntsev
make the signature change in ExecuteMethod backward compatible
5e8e34c
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
@asolntsevasolntsev
mentioned this pull request
Mar 6, 2026
 Merged

asolntsev added a commit
that referenced
this pull request
Mar 6, 2026
@asolntsev
[java] make the signature change in ExecuteMethod backward compatib…
bd280c7
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] specify nullability in packagesorg.openqa.selenium.chrom*(#…
14642bd
…17152)
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] make the signature change in ExecuteMethod backward compatib…
ada4964
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
krishnamohan-kothapalli pushed a commit
to krishnamohan-kothapalli/selenium
that referenced
this pull request
Mar 18, 2026
@asolntsev@krishnamohan-kothapalli
[java] make the signature change in ExecuteMethod backward compatib…
f571079
…le (SeleniumHQ#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`

This was referenced Apr 9, 2026
 Merged

 Closed

 Closed

 Merged

 Merged

 Merged

 Closed

 Closed

 Closed

 Merged

 Merged

 Closed

 Closed


This was referenced Apr 17, 2026
 Closed

 Closed

 Merged

 Closed

 Closed

 Closed


This was referenced May 1, 2026
 Closed

 Closed


This was referenced May 11, 2026
 Merged

 Closed

 Closed

 Closed

 Closed

@dependabotdependabotBot
mentioned this pull request
May 18, 2026
 Closed


This was referenced Jun 16, 2026
 Closed

 Closed

 Closed

 Closed

 Closed


This was referenced Jul 13, 2026
 Open

 Closed

 Closed


This was referenced Aug 1, 2026
 Closed

 Closed

 Closed

 Closed


This was referenced Aug 17, 2026
 Closed

 Open


This was referenced Aug 31, 2026
 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@iampopovichiampopovichAwaiting requested review from iampopovich

Assignees

@asolntsevasolntsev

Labels

C-javaJava BindingsI-enhancementSomething could be better

Projects


None yet


Milestone

4.42.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asolntsev@selenium-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[java] specify nullability in packages org.openqa.selenium.chrom* - #17152
Merged
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Mar 2, 2026
Merged
[java] specify nullability in packages org.openqa.selenium.chrom*#17152
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Conversation
@asolntsev
@asolntsevasolntsev
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
🔗 Related Issues
Partially implements #14291
💥 What does this PR do?
Added JSpecify nullability annotations to packages:
  • org.openqa.selenium.chrome
  • org.openqa.selenium.chromium
  • (and a little bit to org.openqa.selenium.remote, as much as needed for previous two)
🔄 Types of changes
  • Cleanup (formatting, renaming)
@asolntsevasolntsev
self-assigned this
Mar 1, 2026
@asolntsevasolntsev
added this to the 4.42.0 milestone
Mar 1, 2026
@selenium-ciselenium-ci
added
the 
C-java
Java Bindings
label
Mar 1, 2026
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Review Summary by Qodo
Add JSpecify nullability annotations to chrome and chromium packages
✨ Enhancement🧪 Tests
Grey Divider
Walkthroughs
Description
• Add JSpecify nullability annotations to chrome and chromium packages
• Introduce helper methods for safe capability retrieval and execution
• Refactor code to eliminate unsafe casts and improve type safety
• Clean up unused imports and simplify implementation patterns

Grey Divider
File Changes
1. java/src/org/openqa/selenium/Capabilities.java
✨ Enhancement +12/-0 
Add generic helper methods for capability access
 java/src/org/openqa/selenium/Capabilities.java
2. java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
 Cleanup  +0/-3 
Remove unused logger import
 java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
3. java/src/org/openqa/selenium/chrome/package-info.java
✨ Enhancement +21/-0 
Add NullMarked annotation to chrome package
 java/src/org/openqa/selenium/chrome/package-info.java
View more (12)
4. java/src/org/openqa/selenium/chromium/AddHasCasting.java
✨ Enhancement +5/-3 
Replace unsafe casts with safe null handling
 java/src/org/openqa/selenium/chromium/AddHasCasting.java
5. java/src/org/openqa/selenium/chromium/AddHasCdp.java
✨ Enhancement +2/-5 
Use executeRequired for non-null result handling
 java/src/org/openqa/selenium/chromium/AddHasCdp.java
6. java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
✨ Enhancement +1/-4 
Replace requireNonNull with executeRequired method
 java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
7. java/src/org/openqa/selenium/chromium/ChromiumDriver.java
✨ Enhancement +4/-9 
Add nullability annotations and remove redundant code
 java/src/org/openqa/selenium/chromium/ChromiumDriver.java
8. java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
✨ Enhancement +1/-1 
Add nullable annotation to fromString parameter
 java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
9. java/src/org/openqa/selenium/chromium/ChromiumOptions.java
✨ Enhancement +39/-43 
Refactor to use self() method and improve type safety
 java/src/org/openqa/selenium/chromium/ChromiumOptions.java
10. java/src/org/openqa/selenium/chromium/HasCasting.java
📝 Documentation +1/-1 
Update javadoc from array to list terminology
 java/src/org/openqa/selenium/chromium/HasCasting.java
11. java/src/org/openqa/selenium/remote/ExecuteMethod.java
✨ Enhancement +7/-1 
Add generic type parameter and executeRequired method
 java/src/org/openqa/selenium/remote/ExecuteMethod.java
12. java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
✨ Enhancement +18/-16 
Add nullability annotations and simplify casting
 java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
13. java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
✨ Enhancement +3/-1 
Add NullMarked annotation and generic type parameter
 java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
14. java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
✨ Enhancement +3/-2 
Add generic type parameter with cast suppression
 java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
15. java/src/org/openqa/selenium/remote/RemoteWebDriver.java
✨ Enhancement +2/-1 
Add nullability annotations to executeScript method
 java/src/org/openqa/selenium/remote/RemoteWebDriver.java
Grey Divider
Qodo Logo
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Code Review by Qodo
🐞 Bugs (1)📘 Rule violations (1)📎 Requirement gaps (0)
Grey Divider

Remediation recommended
 1. ExecuteMethod.execute() made generic 📘 Rule violation✓ Correctness
Description
The public ExecuteMethod.execute signature was changed to a generic method, which can be
source-incompatible for downstream implementations that previously implemented `Object
execute(...)`. This risks breaking user upgrades without a compatibility strategy.

Code
java/src/org/openqa/selenium/remote/ExecuteMethod.java[R40-44]
+ @Nullable <T> T execute(String commandName, @Nullable Map<String, ?> parameters);++ default <T> T executeRequired(String commandName, @Nullable Map<String, ?> parameters) {+ return requireNonNull(execute(commandName, parameters));+ }
Evidence
Compliance requires public interfaces to remain backward compatible; changing
ExecuteMethod.execute from a concrete Object return to a generic <T> T changes the method’s
source-level contract for implementers and callers. The diff shows the updated generic signature on
a public interface method.

AGENTS.md
java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
A public interface method (`ExecuteMethod.execute`) was changed to a generic method. This can break downstream implementations that previously implemented `Object execute(String, Map)` and violates the project’s API/ABI compatibility expectations.
## Issue Context
`ExecuteMethod` is a public extension point in `org.openqa.selenium.remote`. To keep upgrades safe, avoid source-incompatible signature changes; prefer adding a new helper method (with a new name) that performs the generic cast and/or required-null enforcement.
## Fix Focus Areas
- java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
 2. Mutable extensions capability list 🐞 Bug⛯ Reliability
Description
ChromiumOptions now stores a mutable List for the "extensions" capability inside an otherwise
unmodifiable options map, creating an immutability inconsistency (and allowing unexpected post-hoc
mutation by callers). This can lead to subtle bugs where capability maps appear immutable but
contain mutable nested state.

Code
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[R251-261]
+ options.put("args", List.copyOf(args));+ options.put("extensions", extensionsArgument());
options.putAll(androidOptions);
return unmodifiableMap(options);
}
+ private List<String> extensionsArgument() {+ return Stream.concat(extensionFiles.stream().map(this::fileContentBase64), extensions.stream())+ .collect(toList());+ }
Evidence
getExtraCapability returns unmodifiableMap(options) but inserts extensionsArgument() directly;
extensionsArgument() uses Collectors.toList() which produces a mutable list. In the same method,
args is explicitly made immutable via List.copyOf(args), suggesting the intent is to return
immutable collections for list-valued capabilities.

java/src/org/openqa/selenium/chromium/ChromiumOptions.java[245-256]
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`ChromiumOptions#getExtraCapability` returns an unmodifiable map, but the `&quot;extensions&quot;` value is currently a mutable `List` (built via `Collectors.toList()`), which breaks the implicit immutability expectation established by `&quot;args&quot;` using `List.copyOf(args)`.
### Issue Context
Callers may treat capability maps as effectively immutable; mutating nested collections can produce surprising behavior and makes debugging harder.
### Fix Focus Areas
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[251-256]
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Grey Divider
ⓘ The new review experience is currently in Beta. Learn more
Grey Divider
Qodo Logo
@asolntsev
asolntsev
merged commit cae8d22
into
SeleniumHQ:trunkMar 2, 2026

73 of 77 checks passed

@asolntsev
asolntsev
deleted the

nullability

branch
March 2, 2026 21:16
@asolntsevasolntsev
added
the 
I-enhancement
Something could be better
label
Mar 3, 2026
asolntsev added a commit
to asolntsev/selenium
that referenced
this pull request
Mar 6, 2026
@asolntsev
make the signature change in ExecuteMethod backward compatible
5e8e34c
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
@asolntsevasolntsev
mentioned this pull request
Mar 6, 2026
 Merged

asolntsev added a commit
that referenced
this pull request
Mar 6, 2026
@asolntsev
[java] make the signature change in ExecuteMethod backward compatib…
bd280c7
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] specify nullability in packagesorg.openqa.selenium.chrom*(#…
14642bd
…17152)
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] make the signature change in ExecuteMethod backward compatib…
ada4964
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
krishnamohan-kothapalli pushed a commit
to krishnamohan-kothapalli/selenium
that referenced
this pull request
Mar 18, 2026
@asolntsev@krishnamohan-kothapalli
[java] make the signature change in ExecuteMethod backward compatib…
f571079
…le (SeleniumHQ#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`

This was referenced Apr 9, 2026
 Merged

 Closed

 Closed

 Merged

 Merged

 Merged

 Closed

 Closed

 Closed

 Merged

 Merged

 Closed

 Closed


This was referenced Apr 17, 2026
 Closed

 Closed

 Merged

 Closed

 Closed

 Closed


This was referenced May 1, 2026
 Closed

 Closed


This was referenced May 11, 2026
 Merged

 Closed

 Closed

 Closed

 Closed

@dependabotdependabotBot
mentioned this pull request
May 18, 2026
 Closed


This was referenced Jun 16, 2026
 Closed

 Closed

 Closed

 Closed

 Closed


This was referenced Jul 13, 2026
 Open

 Closed

 Closed


This was referenced Aug 1, 2026
 Closed

 Closed

 Closed

 Closed


This was referenced Aug 17, 2026
 Closed

 Open


This was referenced Aug 31, 2026
 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@iampopovichiampopovichAwaiting requested review from iampopovich

Assignees

@asolntsevasolntsev

Labels

C-javaJava BindingsI-enhancementSomething could be better

Projects


None yet


Milestone

4.42.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asolntsev@selenium-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[java] specify nullability in packages org.openqa.selenium.chrom* - #17152
Merged
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Mar 2, 2026
Merged
[java] specify nullability in packages org.openqa.selenium.chrom*#17152
asolntsev merged 1 commit into
SeleniumHQ:trunkfrom 
asolntsev:nullability
Conversation
@asolntsev
@asolntsevasolntsev
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
🔗 Related Issues
Partially implements #14291
💥 What does this PR do?
Added JSpecify nullability annotations to packages:
  • org.openqa.selenium.chrome
  • org.openqa.selenium.chromium
  • (and a little bit to org.openqa.selenium.remote, as much as needed for previous two)
🔄 Types of changes
  • Cleanup (formatting, renaming)
@asolntsevasolntsev
self-assigned this
Mar 1, 2026
@asolntsevasolntsev
added this to the 4.42.0 milestone
Mar 1, 2026
@selenium-ciselenium-ci
added
the 
C-java
Java Bindings
label
Mar 1, 2026
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Review Summary by Qodo
Add JSpecify nullability annotations to chrome and chromium packages
✨ Enhancement🧪 Tests
Grey Divider
Walkthroughs
Description
• Add JSpecify nullability annotations to chrome and chromium packages
• Introduce helper methods for safe capability retrieval and execution
• Refactor code to eliminate unsafe casts and improve type safety
• Clean up unused imports and simplify implementation patterns

Grey Divider
File Changes
1. java/src/org/openqa/selenium/Capabilities.java
✨ Enhancement +12/-0 
Add generic helper methods for capability access
 java/src/org/openqa/selenium/Capabilities.java
2. java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
 Cleanup  +0/-3 
Remove unused logger import
 java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
3. java/src/org/openqa/selenium/chrome/package-info.java
✨ Enhancement +21/-0 
Add NullMarked annotation to chrome package
 java/src/org/openqa/selenium/chrome/package-info.java
View more (12)
4. java/src/org/openqa/selenium/chromium/AddHasCasting.java
✨ Enhancement +5/-3 
Replace unsafe casts with safe null handling
 java/src/org/openqa/selenium/chromium/AddHasCasting.java
5. java/src/org/openqa/selenium/chromium/AddHasCdp.java
✨ Enhancement +2/-5 
Use executeRequired for non-null result handling
 java/src/org/openqa/selenium/chromium/AddHasCdp.java
6. java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
✨ Enhancement +1/-4 
Replace requireNonNull with executeRequired method
 java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
7. java/src/org/openqa/selenium/chromium/ChromiumDriver.java
✨ Enhancement +4/-9 
Add nullability annotations and remove redundant code
 java/src/org/openqa/selenium/chromium/ChromiumDriver.java
8. java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
✨ Enhancement +1/-1 
Add nullable annotation to fromString parameter
 java/src/org/openqa/selenium/chromium/ChromiumDriverLogLevel.java
9. java/src/org/openqa/selenium/chromium/ChromiumOptions.java
✨ Enhancement +39/-43 
Refactor to use self() method and improve type safety
 java/src/org/openqa/selenium/chromium/ChromiumOptions.java
10. java/src/org/openqa/selenium/chromium/HasCasting.java
📝 Documentation +1/-1 
Update javadoc from array to list terminology
 java/src/org/openqa/selenium/chromium/HasCasting.java
11. java/src/org/openqa/selenium/remote/ExecuteMethod.java
✨ Enhancement +7/-1 
Add generic type parameter and executeRequired method
 java/src/org/openqa/selenium/remote/ExecuteMethod.java
12. java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
✨ Enhancement +18/-16 
Add nullability annotations and simplify casting
 java/src/org/openqa/selenium/remote/FedCmDialogImpl.java
13. java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
✨ Enhancement +3/-1 
Add NullMarked annotation and generic type parameter
 java/src/org/openqa/selenium/remote/LocalExecuteMethod.java
14. java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
✨ Enhancement +3/-2 
Add generic type parameter with cast suppression
 java/src/org/openqa/selenium/remote/RemoteExecuteMethod.java
15. java/src/org/openqa/selenium/remote/RemoteWebDriver.java
✨ Enhancement +2/-1 
Add nullability annotations to executeScript method
 java/src/org/openqa/selenium/remote/RemoteWebDriver.java
Grey Divider
Qodo Logo
@qodo-code-review
qodo-code-reviewBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Code Review by Qodo
🐞 Bugs (1)📘 Rule violations (1)📎 Requirement gaps (0)
Grey Divider

Remediation recommended
 1. ExecuteMethod.execute() made generic 📘 Rule violation✓ Correctness
Description
The public ExecuteMethod.execute signature was changed to a generic method, which can be
source-incompatible for downstream implementations that previously implemented `Object
execute(...)`. This risks breaking user upgrades without a compatibility strategy.

Code
java/src/org/openqa/selenium/remote/ExecuteMethod.java[R40-44]
+ @Nullable <T> T execute(String commandName, @Nullable Map<String, ?> parameters);++ default <T> T executeRequired(String commandName, @Nullable Map<String, ?> parameters) {+ return requireNonNull(execute(commandName, parameters));+ }
Evidence
Compliance requires public interfaces to remain backward compatible; changing
ExecuteMethod.execute from a concrete Object return to a generic <T> T changes the method’s
source-level contract for implementers and callers. The diff shows the updated generic signature on
a public interface method.

AGENTS.md
java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
A public interface method (`ExecuteMethod.execute`) was changed to a generic method. This can break downstream implementations that previously implemented `Object execute(String, Map)` and violates the project’s API/ABI compatibility expectations.
## Issue Context
`ExecuteMethod` is a public extension point in `org.openqa.selenium.remote`. To keep upgrades safe, avoid source-incompatible signature changes; prefer adding a new helper method (with a new name) that performs the generic cast and/or required-null enforcement.
## Fix Focus Areas
- java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
 2. Mutable extensions capability list 🐞 Bug⛯ Reliability
Description
ChromiumOptions now stores a mutable List for the "extensions" capability inside an otherwise
unmodifiable options map, creating an immutability inconsistency (and allowing unexpected post-hoc
mutation by callers). This can lead to subtle bugs where capability maps appear immutable but
contain mutable nested state.

Code
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[R251-261]
+ options.put("args", List.copyOf(args));+ options.put("extensions", extensionsArgument());
options.putAll(androidOptions);
return unmodifiableMap(options);
}
+ private List<String> extensionsArgument() {+ return Stream.concat(extensionFiles.stream().map(this::fileContentBase64), extensions.stream())+ .collect(toList());+ }
Evidence
getExtraCapability returns unmodifiableMap(options) but inserts extensionsArgument() directly;
extensionsArgument() uses Collectors.toList() which produces a mutable list. In the same method,
args is explicitly made immutable via List.copyOf(args), suggesting the intent is to return
immutable collections for list-valued capabilities.

java/src/org/openqa/selenium/chromium/ChromiumOptions.java[245-256]
java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]
Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`ChromiumOptions#getExtraCapability` returns an unmodifiable map, but the `&quot;extensions&quot;` value is currently a mutable `List` (built via `Collectors.toList()`), which breaks the implicit immutability expectation established by `&quot;args&quot;` using `List.copyOf(args)`.
### Issue Context
Callers may treat capability maps as effectively immutable; mutating nested collections can produce surprising behavior and makes debugging harder.
### Fix Focus Areas
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[251-256]
- java/src/org/openqa/selenium/chromium/ChromiumOptions.java[258-261]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Grey Divider
ⓘ The new review experience is currently in Beta. Learn more
Grey Divider
Qodo Logo
@asolntsev
asolntsev
merged commit cae8d22
into
SeleniumHQ:trunkMar 2, 2026

73 of 77 checks passed

@asolntsev
asolntsev
deleted the

nullability

branch
March 2, 2026 21:16
@asolntsevasolntsev
added
the 
I-enhancement
Something could be better
label
Mar 3, 2026
asolntsev added a commit
to asolntsev/selenium
that referenced
this pull request
Mar 6, 2026
@asolntsev
make the signature change in ExecuteMethod backward compatible
5e8e34c
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
@asolntsevasolntsev
mentioned this pull request
Mar 6, 2026
 Merged

asolntsev added a commit
that referenced
this pull request
Mar 6, 2026
@asolntsev
[java] make the signature change in ExecuteMethod backward compatib…
bd280c7
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] specify nullability in packagesorg.openqa.selenium.chrom*(#…
14642bd
…17152)
AutomatedTester pushed a commit
that referenced
this pull request
Mar 11, 2026
@asolntsev@AutomatedTester
[java] make the signature change in ExecuteMethod backward compatib…
ada4964
…le (#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR #17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`
krishnamohan-kothapalli pushed a commit
to krishnamohan-kothapalli/selenium
that referenced
this pull request
Mar 18, 2026
@asolntsev@krishnamohan-kothapalli
[java] make the signature change in ExecuteMethod backward compatib…
f571079
…le (SeleniumHQ#17183)
* make the signature change in `ExecuteMethod` backward compatible
... to avoid too many changes e.g. in Appium project (its has own implementation `AppiumExecutionMethod`).
In PR SeleniumHQ#17152, I changed signature of `ExecuteMethod.execute()` - and later realized that it breaks backward compatibility in Appium.
* rename the additional helper methods `ExecuteMethod`
* rename the additional helper methods `ExecuteMethod`

This was referenced Apr 9, 2026
 Merged

 Closed

 Closed

 Merged

 Merged

 Merged

 Closed

 Closed

 Closed

 Merged

 Merged

 Closed

 Closed


This was referenced Apr 17, 2026
 Closed

 Closed

 Merged

 Closed

 Closed

 Closed


This was referenced May 1, 2026
 Closed

 Closed


This was referenced May 11, 2026
 Merged

 Closed

 Closed

 Closed

 Closed

@dependabotdependabotBot
mentioned this pull request
May 18, 2026
 Closed


This was referenced Jun 16, 2026
 Closed

 Closed

 Closed

 Closed

 Closed


This was referenced Jul 13, 2026
 Open

 Closed

 Closed


This was referenced Aug 1, 2026
 Closed

 Closed

 Closed

 Closed


This was referenced Aug 17, 2026
 Closed

 Open


This was referenced Aug 31, 2026
 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@iampopovichiampopovichAwaiting requested review from iampopovich

Assignees

@asolntsevasolntsev

Labels

C-javaJava BindingsI-enhancementSomething could be better

Projects


None yet


Milestone

4.42.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asolntsev@selenium-ci