Uh oh!
There was an error while loading. Please reload this page.
[OB-8109]: time format validation and fallback for demo logs - #43
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements validation and fallback handling for time format strings in the demo_logs source's SampleFile format. The changes ensure robust timestamp formatting by validating the time format at configuration time and providing graceful degradation at runtime.
Key changes:
- Adds validation for
time_formatfield to detect empty or invalid format strings during configuration - Implements a fallback mechanism that uses RFC3339 format when timestamp formatting fails
- Adds comprehensive test coverage for both validation and fallback behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aayushoj
left a comment
There was a problem hiding this comment.
Please address the copilot's comment on UT test case. LGTM.
Uh oh!
There was an error while loading. Please reload this page.
No description provided.