Skip to content

Instead of erroring with WrongRegion when the S3 bucket region differs - #69

Merged
jsbalis1 merged 3 commits into
masterfrom
fix_region_mismatch
Mar 3, 2026
Merged

Instead of erroring with WrongRegion when the S3 bucket region differs#69
jsbalis1 merged 3 commits into
masterfrom
fix_region_mismatch

Conversation

@jsbali

Copy link
Copy Markdown
Contributor

from the SQS queue region, dynamically create and cache S3 clients
for the bucket's region

 from the SQS queue region, dynamically create and cache S3 clients
for the bucket's region
@afxa

afxa commented Jan 29, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

StatusScanner Critical High Medium LowTotal (0)
Open Source Security0000 0 issues
Licenses0000 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@jsbali
jsbali requested a review from janmejayJanuary 29, 2026 19:15

@janmejayjanmejay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test with sqs messages that use two different regions?

Comment threadsrc/sources/aws_s3/sqs.rs Outdated
@jsbali

Copy link
Copy Markdown
ContributorAuthor

Will add integration tests JJ, later in a diff PR with LocalStack

@jsbali

Copy link
Copy Markdown
ContributorAuthor

Current test run

test sources::aws_s3::integration_tests::handles_errored_status ... ignored
test sinks::aws_s3::integration_tests::s3_healthchecks_invalid_bucket ... ok
test sinks::aws_s3::integration_tests::s3_healthchecks ... ok
test sinks::aws_s3::integration_tests::acknowledges_failures ... ok
test sinks::aws_s3::integration_tests::s3_insert_message_into_with_flat_key_prefix ... ok
test sinks::aws_s3::integration_tests::s3_insert_message_into_with_folder_key_prefix ... ok
test sinks::aws_s3::integration_tests::s3_insert_message_into_with_ssekms_key_id ... ok
test sinks::aws_s3::integration_tests::s3_flush_on_exhaustion ... ok
test sinks::aws_s3::integration_tests::s3_insert_message_into_object_lock ... ok
test sinks::aws_s3::integration_tests::s3_gzip ... ok
test sinks::aws_s3::integration_tests::s3_zstd ... ok
test sinks::aws_s3::integration_tests::s3_rotate_files_after_the_buffer_size_is_reached ... ok
test sources::aws_s3::integration_tests::s3_process_message ... ok
test sources::aws_s3::integration_tests::handles_failed_status_without_deletion ... ok
test sources::aws_s3::integration_tests::handles_failed_status ... ok
test sources::aws_s3::integration_tests::s3_process_json_message ... ok
test sources::aws_s3::integration_tests::s3_process_message_gzip ... ok
test sources::aws_s3::integration_tests::s3_process_message_multiline ... ok
test sources::aws_s3::integration_tests::s3_process_message_multipart_gzip ... ok
test sources::aws_s3::integration_tests::s3_process_message_multipart_zstd ... ok
test sources::aws_s3::integration_tests::s3_process_message_spaces ... ok
test sources::aws_s3::integration_tests::s3_process_message_special_characters ... ok
test sources::aws_s3::integration_tests::s3_process_message_with_log_namespace ... ok
test result: ok. 22 passed; 0 failed; 1 ignored; 0 measured; 1641 filtered out; finished in 20.43s

@akshayakumar-t
akshayakumar-t self-requested a review March 3, 2026 05:29
@jsbalis1
jsbalis1 merged commit 573dbe9 into masterMar 3, 2026
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jsbali@afxa@janmejay@akshayakumar-t@jsbalis1