Uh oh!
There was an error while loading. Please reload this page.
Instead of erroring with WrongRegion when the S3 bucket region differs - #69
Merged
Conversation
from the SQS queue region, dynamically create and cache S3 clients for the bucket's region
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
janmejay
approved these changes
Feb 2, 2026
janmejay
left a comment
Contributor
There was a problem hiding this comment.
Should we add a test with sqs messages that use two different regions?
Uh oh!
There was an error while loading. Please reload this page.
jsbali
commented
Feb 3, 2026
ContributorAuthor
Will add integration tests JJ, later in a diff PR with LocalStack |
jsbali
commented
Feb 3, 2026
ContributorAuthor
Current test run |
akshayakumar-t
self-requested a review
March 3, 2026 05:29
akshayakumar-t
approved these changes
Mar 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from the SQS queue region, dynamically create and cache S3 clients
for the bucket's region