Uh oh!
There was an error while loading. Please reload this page.
build(deps): bump share_plus from 10.1.4 to 13.1.0 - #21
Conversation
📝 WalkthroughWalkthroughThe pull request updates the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pubspec.yaml`:
- Line 19: Update the pubspec.yaml environment constraint to match the resolved
minimum SDKs from the lockfile: change the sdk constraint to ">=3.7.0 <4.0.0"
and add/update the flutter constraint to ">=3.29.0" inside the environment block
in pubspec.yaml so the declared minimums align with the share_plus 13.1.0
transitive requirements found in pubspec.lock.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 205b75fe-b41f-4b34-addc-337c62041336
⛔ Files ignored due to path filters (1)
pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pubspec.yaml
satyakwok
commented
May 14, 2026
@dependabot rebase |
Bumps [share_plus](https://github.com/fluttercommunity/plus_plugins/tree/main/packages/share_plus) from 10.1.4 to 13.1.0. - [Release notes](https://github.com/fluttercommunity/plus_plugins/releases) - [Commits](https://github.com/fluttercommunity/plus_plugins/commits/share_plus-v13.1.0/packages/share_plus) --- updated-dependencies: - dependency-name: share_plus dependency-version: 13.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
80e1c27 to
cb59ec5CompareThere was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
pubspec.yaml (1)
7-8:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUpdate environment constraints to match
share_plus13.1.0 requirements.The current SDK constraint
>=3.0.0 <4.0.0is too permissive. As noted in the previous review,share_plus13.1.0 and its transitive dependencies require Dart>=3.7.0and Flutter>=3.29.0. Thepubspec.yamlshould declare these actual minimums to prevent dependency resolution failures or runtime issues on unsupported toolchains.🔧 Suggested fix
environment: - sdk: '>=3.0.0 <4.0.0'+ sdk: '>=3.7.0 <4.0.0'+ flutter: '>=3.29.0'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pubspec.yaml` around lines 7 - 8, Update the environment SDK constraint to match share_plus 13.1.0 requirements by changing the sdk lower bound from '>=3.0.0' to '>=3.7.0' and add a Flutter minimum constraint; modify the environment block in pubspec.yaml (the environment: sdk line) to use sdk: '>=3.7.0 <4.0.0' and add flutter: '>=3.29.0' so dependency resolution will require Dart >=3.7.0 and Flutter >=3.29.0.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pubspec.yaml`:
- Line 19: Replace the deprecated Share.share call with the v13 API: import
SharePlus and ShareParams from share_plus, then replace the Share.share('My SRX
address: $address') invocation (in the receive screen handler around the
existing call site) with SharePlus.instance.share(ShareParams(text: 'My SRX
address: $address')); ensure the new import(s) are added and remove or stop
using the old Share symbol so the code compiles against share_plus v13.
---
Duplicate comments:
In `@pubspec.yaml`:
- Around line 7-8: Update the environment SDK constraint to match share_plus
13.1.0 requirements by changing the sdk lower bound from '>=3.0.0' to '>=3.7.0'
and add a Flutter minimum constraint; modify the environment block in
pubspec.yaml (the environment: sdk line) to use sdk: '>=3.7.0 <4.0.0' and add
flutter: '>=3.29.0' so dependency resolution will require Dart >=3.7.0 and
Flutter >=3.29.0.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e1233269-649c-4a6e-9496-deb728a64e0f
⛔ Files ignored due to path filters (1)
pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pubspec.yaml
| qr_flutter: ^4.1.0 | ||
| intl: ^0.20.2 | ||
| share_plus: ^10.0.0 | ||
| share_plus: ^13.1.0 |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash# Description: Find all share_plus imports and method calls to verify API compatibilityecho"=== Searching for share_plus imports ==="
rg -n "import.*share_plus" --type=dart
echo -e "\n=== Searching for Share class usage ==="
rg -n -C3 "Share\." --type=dart
echo -e "\n=== Searching for share method calls ==="
ast-grep --lang dart --pattern 'Share.share($$$)'
ast-grep --lang dart --pattern 'Share.shareFiles($$$)'
ast-grep --lang dart --pattern 'Share.shareXFiles($$$)'Repository: Sentriscloud/solux
Length of output: 874
🌐 Web query:
share_plus v13 migration guide breaking changes Share.share() API compatibility
💡 Result:
share_plus v13 migration / breaking changes relevant to Share.share compatibility 1) What changed (API migration) - The plugin’s old static API methods Share.share(), Share.shareUri(), and Share.shareXFiles() are deprecated in favor of SharePlus.instance.share(params) [1][2]. - The migration guidance is: wrap your old arguments in a ShareParams(...) object, then call SharePlus.instance.share(...) instead of the static Share.* methods [1][2]. 2) Compatibility details for Share.share usage - Share.share() (and the other static methods) still exist but are marked deprecated, meaning they remain usable for now but you should migrate to avoid deprecation and eventual removal [1][2][3]. - The new approach uses a single instance (SharePlus.instance) plus ShareParams, rather than multiple static convenience methods [1][2]. 3) Concrete migration example Old: - Share.share("Shared text"); - Share.shareUri("http://example.com"); - Share.shareXFiles(files); [1] New: - SharePlus.instance.share(ShareParams(text: "Shared text")); - SharePlus.instance.share(ShareParams(uri: "http://example.com")); - SharePlus.instance.share(ShareParams(files: files)); [1] 4) “Breaking changes” in share_plus v13 itself (non-API) - The published changelog for share_plus version 13.0.0 explicitly warns that it contains breaking changes, but those breaking changes listed there are dependency/requirement related (e.g., win32 dependency bump changing requirements such as minimum Flutter/Dart versions and iOS/macOS minima) rather than the Share.share() deprecation/migration itself [4][5]. If you share your exact current code (the specific Share.share* call sites and which Share.* parameters you use, plus whether you pass title/subject/sharePositionOrigin), I can map each call to the equivalent ShareParams usage.
Citations:
- 1: https://pub.dev/packages/share_plus/versions/13.0.0
- 2: https://pub.dev/documentation/share_plus/latest
- 3: https://pub.dev/documentation/share_plus/latest/share_plus/Share-class.html
- 4: https://pub.dev/packages/share_plus/versions/13.0.0/changelog
- 5: https://github.com/fluttercommunity/plus_plugins/blob/main/packages/share_plus/share_plus/CHANGELOG.md
The old Share.share() API is deprecated in v13 but still functional—update when convenient.
The Share.share() method used in lib/screens/receive/receive_screen.dart:164 is deprecated in share_plus v13 but remains usable. While your code will continue to work, migrate to the new API pattern to future-proof against eventual removal:
- Old:
Share.share('My SRX address: $address') - New:
SharePlus.instance.share(ShareParams(text: 'My SRX address: $address'))
Update the import and method call at the location above to use SharePlus and ShareParams for consistency with v13 best practices.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pubspec.yaml` at line 19, Replace the deprecated Share.share call with the
v13 API: import SharePlus and ShareParams from share_plus, then replace the
Share.share('My SRX address: $address') invocation (in the receive screen
handler around the existing call site) with
SharePlus.instance.share(ShareParams(text: 'My SRX address: $address')); ensure
the new import(s) are added and remove or stop using the old Share symbol so the
code compiles against share_plus v13.
There was a problem hiding this comment.
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @pubspec.yaml at line 19, Replace the deprecated Share.share call with the
v13 API: import SharePlus and ShareParams from share_plus, then replace the
Share.share('My SRX address: $address') invocation (in the receive screen
handler around the existing call site) with
SharePlus.instance.share(ShareParams(text: 'My SRX address: $address')); ensure
the new import(s) are added and remove or stop using the old Share symbol so the
code compiles against share_plus v13.
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
echo "=== receive_screen.dart share_plus import ==="
rg -n "share_plus\|import.*share\|Share\." --type=dart lib/screens/receive/receive_screen.dart
echo -e "\n=== Full context around share usage ==="
rg -n -C5 "Share\." --type=dart lib/screens/receive/receive_screen.dart
echo -e "\n=== All share_plus usages across project ==="
rg -n "Share\.\|share_plus\|SharePlus\|ShareParams" --type=dart
Length of output: 618
🏁 Script executed:
#!/bin/bash
echo "=== Top 20 lines of receive_screen.dart ==="
head -20 lib/screens/receive/receive_screen.dart
echo -e "\n=== All imports in receive_screen.dart ==="
rg -n "^import" lib/screens/receive/receive_screen.dart
Length of output: 1284
@satyakwok, the finding is confirmed and still valid. Here's the minimal fix:
lib/screens/receive/receive_screen.dart
The import on line 6 is already correct — SharePlus and ShareParams are both exported from package:share_plus/share_plus.dart, so no import changes are needed. Only line 164 needs updating:
- onTap: () => Share.share('My SRX address: $address'),+ onTap: () => SharePlus.instance.share(ShareParams(text: 'My SRX address: $address')),That's the only change required. The rest of the file is unaffected.
- Update the deprecated
Share.share()call site inlib/screens/receive/receive_screen.dartline 164
- 📌 Commit the changes to this branch
Superseded by #29. |
Bumps share_plus from 10.1.4 to 13.1.0.
Commits
6427bc6chore(release): prepare for release (#3805)d965e00feat(share_plus): Lower requirements to Dart 3.10 and Flutter 3.38.1 (#3801)6982a68chore(release): prepare for release (#3793)0e3eb91feat(share_plus)!: Bump win32 from 5.15.0 to 6.0.0 (#3762)c46ab89chore(release): prepare for release (#3785)ae6330bfix(share_plus): Avoid crash on iOS during file and text sharing in add-to-ap...b64f663chore(release): prepare for release (#3701)42b079bfix(share_plus): Avoid crash on iOS 26 on iPhones with no sharePositionOrigin...1d29902chore(release): prepare for release (#3675)3bd253bfix(share_plus): unable to get the correct result on iOS (#3660)Summary by CodeRabbit