Uh oh!
There was an error while loading. Please reload this page.
Update v3.5.0 - #263
Conversation
ButterscotchV
commented
Apr 5, 2023
A little update on this PR, I haven't merged it because there is a bug with closing the server. I'm not sure if kill detection needs to be removed or reworked or what, but I don't have the time to invest into debugging it, so it will remain unmerged and unreleased for now. If anyone wants to tackle this issue, I welcome you. The bug with closing the server is related to accepting input and kill detection, something locks it up and prevents it from fully closing, meaning stuff like Pterodactyl panel and such get permanently stuck unless you force kill it. |
dhkatz
commented
Apr 5, 2023
Do you know if this happens more on Windows or Linux? I could maybe give it a shot to fix it |
ButterscotchV
commented
Apr 5, 2023
The issue happens on Linux mainly, but I'm sure that Windows isn't free from issues. The input system attempts to not block by checking for input before attempting to read (and potentially block), so I'm not sure why it would be getting caught there, but it very well could be... It might be worth making an input option to check for available input before reading the line? I don't really remember what the code looks like in there. |
dhkatz
commented
Apr 5, 2023
I think I experienced the issue on Linux when I tested out the 3.5.0 build earlier. On Windows I tried to get it to lock up but couldn't seem to. But this was only after like 5 minutes of messing around. I will dig through the code a bit |
Uh oh!
There was an error while loading. Please reload this page.