Skip to content

Merge bug/1 createentityfunction fails - #4

Merged
tmclaugh merged 2 commits into
mainfrom
bug/1-createentityfunction-fails
Jun 28, 2026
Merged

Merge bug/1 createentityfunction fails#4
tmclaugh merged 2 commits into
mainfrom
bug/1-createentityfunction-fails

Conversation

@tmclaugh

Copy link
Copy Markdown
Member

No description provided.

Since this commit was deployed functions have been failing. No clue why since this should be the default value used when not set. Let's see if this fixes it.
Revert "remove unnecessary config for functions"
This reverts commit 4e04adf.
@tmclaughtmclaugh self-assigned this Jun 28, 2026
CopilotAI review requested due to automatic review settings June 28, 2026 19:15
@tmclaughtmclaugh added the bug Something isn't working label Jun 28, 2026

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the AWS SAM esbuild build configuration to address the CreateEntity Lambda build/runtime failure related to ESM dependency resolution, and enables source maps via deployment parameters for easier debugging.

Changes:

  • Disable minification for CreateEntityFunction and add MainFields to esbuild BuildProperties across functions to prefer ESM entry points.
  • Enable source maps through a new EnableSourceMaps value in cfn-parameters.json.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

FileDescription
template.yamlUpdates esbuild BuildProperties (minification and MainFields) for Lambda functions to improve ESM module resolution and debugging behavior.
cfn-parameters.jsonAdds EnableSourceMaps parameter value to turn on source maps during deployment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadtemplate.yaml
Comment threadtemplate.yaml
Comment threadtemplate.yaml
Comment threadtemplate.yaml
Comment threadtemplate.yaml
Comment threadcfn-parameters.json
@datadog-serverlessopsio

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 1 Pipeline job failed

Main | deploy View in DatadogGitHub Actions

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: de56717 | Docs | Give us feedback!

@tmclaugh
tmclaugh merged commit 69bc520 into mainJun 28, 2026
4 of 5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tmclaugh