Skip to content

[Agents] expand git, commit authorship, and PR conventions - #2045

Merged
mergify[bot] merged 1 commit into
Shamrock-code:mainfrom
tdavidcl:cursor/agent-git-conventions-173d
Aug 14, 2026
Merged

mergify[bot] merged 1 commit into
Shamrock-code:mainfrom
tdavidcl:cursor/agent-git-conventions-173d

Conversation

@tdavidcl

Copy link
Copy Markdown
Member

Document that the initiating user must be the first commit author, clarify Assisted-by vs Co-Authored-by (including hook cleanup), and add upstream PR targeting with fork compare-link fallback.

Assisted-by: Composer

Document that the initiating user must be the first commit author,
clarify Assisted-by vs Co-Authored-by (including hook cleanup), and
add upstream PR targeting with fork compare-link fallback.

Assisted-by: Composer
@github-actions

Copy link
Copy Markdown
Contributor

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label light-ci to only trigger a reduced & faster version of the CI (need the full one before merge).
5 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Caution

CodeRabbit couldn't post its review summary.

Error details
postComment timed out

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 09e20b4a-f2b6-4bed-9ddf-b308cd8aee05

📥 Commits

Reviewing files that changed from the base of the PR and between 3eea1bc and b90c52c.

📒 Files selected for processing (1)
  • AGENTS.md

📝 Walkthrough

Walkthrough

AGENTS.md expands Git, commit, and pull request guidance. It defines upstream targets, authorship requirements, Assisted-by attribution, hook-injected co-author handling, fork comparison links, and upstream pull request lookup commands.

Changes

Git and pull request guidance

Layer / File(s) Summary
Commit and pull request instructions
AGENTS.md
The guidance now specifies commit authorship, agent attribution, pull-request targets, fork comparison URLs, and upstream pull request lookup commands.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to b90c5

This documentation-only change clarifies commit authorship and pull-request targeting guidance; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the documented changes to Git, commit authorship, and pull request conventions.
Description check ✅ Passed The description directly explains the documented authorship, attribution, and upstream pull request conventions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit b90c52c
Commiter email is timothee.davidcleris@proton.me

Light CI is enabled. This will only run the basic tests and not the full tests.
Merging a PR require the job "on PR / all" to pass which is disabled in this case.

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
cmake-format.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 8171 → 8171 (0.0%)

Detailed changes :

@mergify

mergify Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 2 hours 2 minutes 46 seconds in the queue, including 1 hour 51 minutes 10 seconds running CI.

Required conditions to merge
  • check-success = all

@mergify mergify Bot added the queued label Aug 14, 2026
@mergify
mergify Bot merged commit 50904f5 into Shamrock-code:main Aug 14, 2026
40 checks passed
@mergify mergify Bot removed the queued label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants