Replace string concatenation with StringBuilder and invariant interpolation - #696

Open
kamilla11 wants to merge 1 commit into
Shane32:masterfrom
kamilla11:refactor/string_concatenation_replacement
Open

Replace string concatenation with StringBuilder and invariant interpolation#696
kamilla11 wants to merge 1 commit into
Shane32:masterfrom
kamilla11:refactor/string_concatenation_replacement

Conversation

@kamilla11

@kamilla11kamilla11 commented May 26, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Summary

Closes issue #648.

  • Replace string concatenation with StringBuilder or string interpolation.
  • Introduce StringExtensions.AppendInvariant(StringBuilder, …) as a single cross-TFM API.
  • Add polyfill attributes (InterpolatedStringHandlerAttribute, etc.) for targets below .NET 6 so the compiler can emit correct interpolation code.

Extension method sb.AppendInvariant("...") on .NET 6+ is not possible (CS8944), so a static call is used StringExtensions.AppendInvariant(sb, "...")

Summary by CodeRabbit

  • Refactor

    • Optimized string building operations across payload generators for improved memory efficiency
    • Enhanced invariant culture string handling in payment and QR code formats
    • Streamlined PDF generation string construction logic

  • Chores

    • Added internal compiler attribute support for .NET 6+ compatibility

Review Change Stack

@coderabbitai

coderabbitaiBot commented May 26, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aaa1ad1f-5a33-4e9d-8c85-1adec053cf97

📥 Commits

Reviewing files that changed from the base of the PR and between 4b97eb1 and f39e154.

📒 Files selected for processing (15)
  • QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs
  • QRCoder/Extensions/StringExtensions.cs
  • QRCoder/PayloadGenerator.cs
  • QRCoder/PayloadGenerator/BezahlCode.cs
  • QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs
  • QRCoder/PayloadGenerator/ContactData.cs
  • QRCoder/PayloadGenerator/Girocode.cs
  • QRCoder/PayloadGenerator/Mail.cs
  • QRCoder/PayloadGenerator/OneTimePassword.cs
  • QRCoder/PayloadGenerator/RussiaPaymentOrder.cs
  • QRCoder/PayloadGenerator/SwissQrCode.cs
  • QRCoder/PayloadGenerator/Url.cs
  • QRCoder/PayloadGenerator/WiFi.cs
  • QRCoder/PdfByteQRCode.cs
  • QRCoder/QRCodeGenerator/Polynom.cs
📝 Walkthrough

Walkthrough

This PR systematically refactors QRCoder's payload generators to use invariant-culture interpolated strings instead of string concatenation. It adds compiler attributes for pre-.NET 6 compatibility, introduces an AppendInvariant extension helper, and applies the pattern across payment, contact, authentication, and PDF generation classes.

Changes

Interpolated String Handler Refactoring

Layer / File(s)Summary
Compiler Attributes & StringExtensions Infrastructure
QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs, QRCoder/Extensions/StringExtensions.cs		Adds InterpolatedStringHandlerAttribute, InterpolatedStringHandlerArgumentAttribute, and CompilerFeatureRequiredAttribute (conditional for !NET6_0_OR_GREATER). Introduces AppendInvariant helper that accepts interpolated-string handler refs for invariant-culture appends, with existing numeric overloads refactored to delegate through it.
Core PayloadGenerator Updates
QRCoder/PayloadGenerator.cs		IsValidIban checksum computation replaces LINQ Aggregate with StringBuilder loop; EscapeInput switches per-character replacement to interpolation; NET5+ conditional code uses interpolated substring construction.
Simple String Format Changes
QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs, QRCoder/PayloadGenerator/Mail.cs, QRCoder/PayloadGenerator/Url.cs, QRCoder/PayloadGenerator/WiFi.cs		Straightforward conversions from string concatenation to string interpolation for URL prefixes, query parameters, and HEX-string wrapping—no behavioral changes.
OneTimePassword OTP Query Building
QRCoder/PayloadGenerator/OneTimePassword.cs		HOTP counter, TOTP period, issuer:label combination, and common query fields refactored from sb.Append concatenation to StringExtensions.AppendInvariant with interpolation.
Payment & Financial Payload Builders
QRCoder/PayloadGenerator/BezahlCode.cs, QRCoder/PayloadGenerator/Girocode.cs, QRCoder/PayloadGenerator/RussiaPaymentOrder.cs		BezahlCode non-contact/contact query construction, Girocode BCD payload assembly, and RussiaPaymentOrder mandatory fields refactored to use StringBuilder + AppendInvariant, preserving conditional field inclusion and encoding normalization.
Contact & Address Data Builders
QRCoder/PayloadGenerator/ContactData.cs, QRCoder/PayloadGenerator/SwissQrCode.cs		ContactData (MeCard and vCard output) and SwissQrCode (contact block and full payload) refactored from concatenation to StringBuilder + AppendInvariant, maintaining address ordering rules and conditional formatting by output type/version. Formatting comments updated.
PDF Byte Generation
QRCoder/PdfByteQRCode.cs		PDF object construction (catalog, pages, content stream, xref table, trailer) switched from concatenation to StringBuilder + AppendInvariant; path rectangle commands and color RGB strings use interpolation. xref offset tracking and stream length computation preserved.
Polynomial String Representation
QRCoder/QRCodeGenerator/Polynom.cs		Polynomial term formatting updated to use AppendInvariant with interpolated algebraic notation instead of direct Append concatenation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • Shane32/QRCoder#635: Modifies the same PDF generation code paths in PdfByteQRCode.cs (GetGraphic, CreatePathFromModules, ColorToPdfRgb).

Suggested labels

refactoring, performance

Suggested reviewers

  • gfoidl
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: replacing string concatenation with StringBuilder and invariant interpolation throughout the codebase.
Docstring Coverage✅ PassedDocstring coverage is 93.10% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kamilla11

kamilla11 commented May 26, 2026

Copy link
Copy Markdown
Author

I also want to warn you that IDE0055 errors occurred during the build, which are not present in <NoWarn>$(NoWarn);IDE0005;CA1510;</NoWarn>, which triggers configuration errors <TreatWarningsAsErrors>. These errors are not related to the code I changed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kamilla11
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Replace string concatenation with StringBuilder and invariant interpolation - #696
Open
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Open
Replace string concatenation with StringBuilder and invariant interpolation#696
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Conversation
@kamilla11
@kamilla11kamilla11
commented
May 26, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary
Closes issue #648.
  • Replace string concatenation with StringBuilder or string interpolation.
  • Introduce StringExtensions.AppendInvariant(StringBuilder, …) as a single cross-TFM API.
  • Add polyfill attributes (InterpolatedStringHandlerAttribute, etc.) for targets below .NET 6 so the compiler can emit correct interpolation code.
Extension method sb.AppendInvariant("...") on .NET 6+ is not possible (CS8944), so a static call is used StringExtensions.AppendInvariant(sb, "...")
Summary by CodeRabbit
  • Refactor
    • Optimized string building operations across payload generators for improved memory efficiency
    • Enhanced invariant culture string handling in payment and QR code formats
    • Streamlined PDF generation string construction logic
  • Chores
    • Added internal compiler attribute support for .NET 6+ compatibility
Review Change Stack
@coderabbitai
coderabbitaiBot
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aaa1ad1f-5a33-4e9d-8c85-1adec053cf97
📥 Commits
Reviewing files that changed from the base of the PR and between 4b97eb1 and f39e154.
📒 Files selected for processing (15)
  • QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs
  • QRCoder/Extensions/StringExtensions.cs
  • QRCoder/PayloadGenerator.cs
  • QRCoder/PayloadGenerator/BezahlCode.cs
  • QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs
  • QRCoder/PayloadGenerator/ContactData.cs
  • QRCoder/PayloadGenerator/Girocode.cs
  • QRCoder/PayloadGenerator/Mail.cs
  • QRCoder/PayloadGenerator/OneTimePassword.cs
  • QRCoder/PayloadGenerator/RussiaPaymentOrder.cs
  • QRCoder/PayloadGenerator/SwissQrCode.cs
  • QRCoder/PayloadGenerator/Url.cs
  • QRCoder/PayloadGenerator/WiFi.cs
  • QRCoder/PdfByteQRCode.cs
  • QRCoder/QRCodeGenerator/Polynom.cs
📝 Walkthrough
Walkthrough
This PR systematically refactors QRCoder's payload generators to use invariant-culture interpolated strings instead of string concatenation. It adds compiler attributes for pre-.NET 6 compatibility, introduces an AppendInvariant extension helper, and applies the pattern across payment, contact, authentication, and PDF generation classes.
Changes
Interpolated String Handler Refactoring
Layer / File(s)Summary
Compiler Attributes & StringExtensions Infrastructure
QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs, QRCoder/Extensions/StringExtensions.cs		Adds InterpolatedStringHandlerAttribute, InterpolatedStringHandlerArgumentAttribute, and CompilerFeatureRequiredAttribute (conditional for !NET6_0_OR_GREATER). Introduces AppendInvariant helper that accepts interpolated-string handler refs for invariant-culture appends, with existing numeric overloads refactored to delegate through it.
Core PayloadGenerator Updates
QRCoder/PayloadGenerator.cs		IsValidIban checksum computation replaces LINQ Aggregate with StringBuilder loop; EscapeInput switches per-character replacement to interpolation; NET5+ conditional code uses interpolated substring construction.
Simple String Format Changes
QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs, QRCoder/PayloadGenerator/Mail.cs, QRCoder/PayloadGenerator/Url.cs, QRCoder/PayloadGenerator/WiFi.cs		Straightforward conversions from string concatenation to string interpolation for URL prefixes, query parameters, and HEX-string wrapping—no behavioral changes.
OneTimePassword OTP Query Building
QRCoder/PayloadGenerator/OneTimePassword.cs		HOTP counter, TOTP period, issuer:label combination, and common query fields refactored from sb.Append concatenation to StringExtensions.AppendInvariant with interpolation.
Payment & Financial Payload Builders
QRCoder/PayloadGenerator/BezahlCode.cs, QRCoder/PayloadGenerator/Girocode.cs, QRCoder/PayloadGenerator/RussiaPaymentOrder.cs		BezahlCode non-contact/contact query construction, Girocode BCD payload assembly, and RussiaPaymentOrder mandatory fields refactored to use StringBuilder + AppendInvariant, preserving conditional field inclusion and encoding normalization.
Contact & Address Data Builders
QRCoder/PayloadGenerator/ContactData.cs, QRCoder/PayloadGenerator/SwissQrCode.cs		ContactData (MeCard and vCard output) and SwissQrCode (contact block and full payload) refactored from concatenation to StringBuilder + AppendInvariant, maintaining address ordering rules and conditional formatting by output type/version. Formatting comments updated.
PDF Byte Generation
QRCoder/PdfByteQRCode.cs		PDF object construction (catalog, pages, content stream, xref table, trailer) switched from concatenation to StringBuilder + AppendInvariant; path rectangle commands and color RGB strings use interpolation. xref offset tracking and stream length computation preserved.
Polynomial String Representation
QRCoder/QRCodeGenerator/Polynom.cs		Polynomial term formatting updated to use AppendInvariant with interpolated algebraic notation instead of direct Append concatenation.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
  • Shane32/QRCoder#635: Modifies the same PDF generation code paths in PdfByteQRCode.cs (GetGraphic, CreatePathFromModules, ColorToPdfRgb).
Suggested labels
refactoring, performance
Suggested reviewers
  • gfoidl
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: replacing string concatenation with StringBuilder and invariant interpolation throughout the codebase.
Docstring Coverage✅ PassedDocstring coverage is 93.10% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@kamilla11
kamilla11
commented
May 26, 2026

Copy link


Copy Markdown

Author
I also want to warn you that IDE0055 errors occurred during the build, which are not present in <NoWarn>$(NoWarn);IDE0005;CA1510;</NoWarn>, which triggers configuration errors <TreatWarningsAsErrors>. These errors are not related to the code I changed.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kamilla11

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Replace string concatenation with StringBuilder and invariant interpolation - #696
Open
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Open
Replace string concatenation with StringBuilder and invariant interpolation#696
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Conversation
@kamilla11
@kamilla11kamilla11
commented
May 26, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary
Closes issue #648.
  • Replace string concatenation with StringBuilder or string interpolation.
  • Introduce StringExtensions.AppendInvariant(StringBuilder, …) as a single cross-TFM API.
  • Add polyfill attributes (InterpolatedStringHandlerAttribute, etc.) for targets below .NET 6 so the compiler can emit correct interpolation code.
Extension method sb.AppendInvariant("...") on .NET 6+ is not possible (CS8944), so a static call is used StringExtensions.AppendInvariant(sb, "...")
Summary by CodeRabbit
  • Refactor
    • Optimized string building operations across payload generators for improved memory efficiency
    • Enhanced invariant culture string handling in payment and QR code formats
    • Streamlined PDF generation string construction logic
  • Chores
    • Added internal compiler attribute support for .NET 6+ compatibility
Review Change Stack
@coderabbitai
coderabbitaiBot
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aaa1ad1f-5a33-4e9d-8c85-1adec053cf97
📥 Commits
Reviewing files that changed from the base of the PR and between 4b97eb1 and f39e154.
📒 Files selected for processing (15)
  • QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs
  • QRCoder/Extensions/StringExtensions.cs
  • QRCoder/PayloadGenerator.cs
  • QRCoder/PayloadGenerator/BezahlCode.cs
  • QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs
  • QRCoder/PayloadGenerator/ContactData.cs
  • QRCoder/PayloadGenerator/Girocode.cs
  • QRCoder/PayloadGenerator/Mail.cs
  • QRCoder/PayloadGenerator/OneTimePassword.cs
  • QRCoder/PayloadGenerator/RussiaPaymentOrder.cs
  • QRCoder/PayloadGenerator/SwissQrCode.cs
  • QRCoder/PayloadGenerator/Url.cs
  • QRCoder/PayloadGenerator/WiFi.cs
  • QRCoder/PdfByteQRCode.cs
  • QRCoder/QRCodeGenerator/Polynom.cs
📝 Walkthrough
Walkthrough
This PR systematically refactors QRCoder's payload generators to use invariant-culture interpolated strings instead of string concatenation. It adds compiler attributes for pre-.NET 6 compatibility, introduces an AppendInvariant extension helper, and applies the pattern across payment, contact, authentication, and PDF generation classes.
Changes
Interpolated String Handler Refactoring
Layer / File(s)Summary
Compiler Attributes & StringExtensions Infrastructure
QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs, QRCoder/Extensions/StringExtensions.cs		Adds InterpolatedStringHandlerAttribute, InterpolatedStringHandlerArgumentAttribute, and CompilerFeatureRequiredAttribute (conditional for !NET6_0_OR_GREATER). Introduces AppendInvariant helper that accepts interpolated-string handler refs for invariant-culture appends, with existing numeric overloads refactored to delegate through it.
Core PayloadGenerator Updates
QRCoder/PayloadGenerator.cs		IsValidIban checksum computation replaces LINQ Aggregate with StringBuilder loop; EscapeInput switches per-character replacement to interpolation; NET5+ conditional code uses interpolated substring construction.
Simple String Format Changes
QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs, QRCoder/PayloadGenerator/Mail.cs, QRCoder/PayloadGenerator/Url.cs, QRCoder/PayloadGenerator/WiFi.cs		Straightforward conversions from string concatenation to string interpolation for URL prefixes, query parameters, and HEX-string wrapping—no behavioral changes.
OneTimePassword OTP Query Building
QRCoder/PayloadGenerator/OneTimePassword.cs		HOTP counter, TOTP period, issuer:label combination, and common query fields refactored from sb.Append concatenation to StringExtensions.AppendInvariant with interpolation.
Payment & Financial Payload Builders
QRCoder/PayloadGenerator/BezahlCode.cs, QRCoder/PayloadGenerator/Girocode.cs, QRCoder/PayloadGenerator/RussiaPaymentOrder.cs		BezahlCode non-contact/contact query construction, Girocode BCD payload assembly, and RussiaPaymentOrder mandatory fields refactored to use StringBuilder + AppendInvariant, preserving conditional field inclusion and encoding normalization.
Contact & Address Data Builders
QRCoder/PayloadGenerator/ContactData.cs, QRCoder/PayloadGenerator/SwissQrCode.cs		ContactData (MeCard and vCard output) and SwissQrCode (contact block and full payload) refactored from concatenation to StringBuilder + AppendInvariant, maintaining address ordering rules and conditional formatting by output type/version. Formatting comments updated.
PDF Byte Generation
QRCoder/PdfByteQRCode.cs		PDF object construction (catalog, pages, content stream, xref table, trailer) switched from concatenation to StringBuilder + AppendInvariant; path rectangle commands and color RGB strings use interpolation. xref offset tracking and stream length computation preserved.
Polynomial String Representation
QRCoder/QRCodeGenerator/Polynom.cs		Polynomial term formatting updated to use AppendInvariant with interpolated algebraic notation instead of direct Append concatenation.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
  • Shane32/QRCoder#635: Modifies the same PDF generation code paths in PdfByteQRCode.cs (GetGraphic, CreatePathFromModules, ColorToPdfRgb).
Suggested labels
refactoring, performance
Suggested reviewers
  • gfoidl
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: replacing string concatenation with StringBuilder and invariant interpolation throughout the codebase.
Docstring Coverage✅ PassedDocstring coverage is 93.10% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@kamilla11
kamilla11
commented
May 26, 2026

Copy link


Copy Markdown

Author
I also want to warn you that IDE0055 errors occurred during the build, which are not present in <NoWarn>$(NoWarn);IDE0005;CA1510;</NoWarn>, which triggers configuration errors <TreatWarningsAsErrors>. These errors are not related to the code I changed.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kamilla11

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Replace string concatenation with StringBuilder and invariant interpolation - #696
Open
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Open
Replace string concatenation with StringBuilder and invariant interpolation#696
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Conversation
@kamilla11
@kamilla11kamilla11
commented
May 26, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary
Closes issue #648.
  • Replace string concatenation with StringBuilder or string interpolation.
  • Introduce StringExtensions.AppendInvariant(StringBuilder, …) as a single cross-TFM API.
  • Add polyfill attributes (InterpolatedStringHandlerAttribute, etc.) for targets below .NET 6 so the compiler can emit correct interpolation code.
Extension method sb.AppendInvariant("...") on .NET 6+ is not possible (CS8944), so a static call is used StringExtensions.AppendInvariant(sb, "...")
Summary by CodeRabbit
  • Refactor
    • Optimized string building operations across payload generators for improved memory efficiency
    • Enhanced invariant culture string handling in payment and QR code formats
    • Streamlined PDF generation string construction logic
  • Chores
    • Added internal compiler attribute support for .NET 6+ compatibility
Review Change Stack
@coderabbitai
coderabbitaiBot
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aaa1ad1f-5a33-4e9d-8c85-1adec053cf97
📥 Commits
Reviewing files that changed from the base of the PR and between 4b97eb1 and f39e154.
📒 Files selected for processing (15)
  • QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs
  • QRCoder/Extensions/StringExtensions.cs
  • QRCoder/PayloadGenerator.cs
  • QRCoder/PayloadGenerator/BezahlCode.cs
  • QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs
  • QRCoder/PayloadGenerator/ContactData.cs
  • QRCoder/PayloadGenerator/Girocode.cs
  • QRCoder/PayloadGenerator/Mail.cs
  • QRCoder/PayloadGenerator/OneTimePassword.cs
  • QRCoder/PayloadGenerator/RussiaPaymentOrder.cs
  • QRCoder/PayloadGenerator/SwissQrCode.cs
  • QRCoder/PayloadGenerator/Url.cs
  • QRCoder/PayloadGenerator/WiFi.cs
  • QRCoder/PdfByteQRCode.cs
  • QRCoder/QRCodeGenerator/Polynom.cs
📝 Walkthrough
Walkthrough
This PR systematically refactors QRCoder's payload generators to use invariant-culture interpolated strings instead of string concatenation. It adds compiler attributes for pre-.NET 6 compatibility, introduces an AppendInvariant extension helper, and applies the pattern across payment, contact, authentication, and PDF generation classes.
Changes
Interpolated String Handler Refactoring
Layer / File(s)Summary
Compiler Attributes & StringExtensions Infrastructure
QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs, QRCoder/Extensions/StringExtensions.cs		Adds InterpolatedStringHandlerAttribute, InterpolatedStringHandlerArgumentAttribute, and CompilerFeatureRequiredAttribute (conditional for !NET6_0_OR_GREATER). Introduces AppendInvariant helper that accepts interpolated-string handler refs for invariant-culture appends, with existing numeric overloads refactored to delegate through it.
Core PayloadGenerator Updates
QRCoder/PayloadGenerator.cs		IsValidIban checksum computation replaces LINQ Aggregate with StringBuilder loop; EscapeInput switches per-character replacement to interpolation; NET5+ conditional code uses interpolated substring construction.
Simple String Format Changes
QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs, QRCoder/PayloadGenerator/Mail.cs, QRCoder/PayloadGenerator/Url.cs, QRCoder/PayloadGenerator/WiFi.cs		Straightforward conversions from string concatenation to string interpolation for URL prefixes, query parameters, and HEX-string wrapping—no behavioral changes.
OneTimePassword OTP Query Building
QRCoder/PayloadGenerator/OneTimePassword.cs		HOTP counter, TOTP period, issuer:label combination, and common query fields refactored from sb.Append concatenation to StringExtensions.AppendInvariant with interpolation.
Payment & Financial Payload Builders
QRCoder/PayloadGenerator/BezahlCode.cs, QRCoder/PayloadGenerator/Girocode.cs, QRCoder/PayloadGenerator/RussiaPaymentOrder.cs		BezahlCode non-contact/contact query construction, Girocode BCD payload assembly, and RussiaPaymentOrder mandatory fields refactored to use StringBuilder + AppendInvariant, preserving conditional field inclusion and encoding normalization.
Contact & Address Data Builders
QRCoder/PayloadGenerator/ContactData.cs, QRCoder/PayloadGenerator/SwissQrCode.cs		ContactData (MeCard and vCard output) and SwissQrCode (contact block and full payload) refactored from concatenation to StringBuilder + AppendInvariant, maintaining address ordering rules and conditional formatting by output type/version. Formatting comments updated.
PDF Byte Generation
QRCoder/PdfByteQRCode.cs		PDF object construction (catalog, pages, content stream, xref table, trailer) switched from concatenation to StringBuilder + AppendInvariant; path rectangle commands and color RGB strings use interpolation. xref offset tracking and stream length computation preserved.
Polynomial String Representation
QRCoder/QRCodeGenerator/Polynom.cs		Polynomial term formatting updated to use AppendInvariant with interpolated algebraic notation instead of direct Append concatenation.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
  • Shane32/QRCoder#635: Modifies the same PDF generation code paths in PdfByteQRCode.cs (GetGraphic, CreatePathFromModules, ColorToPdfRgb).
Suggested labels
refactoring, performance
Suggested reviewers
  • gfoidl
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: replacing string concatenation with StringBuilder and invariant interpolation throughout the codebase.
Docstring Coverage✅ PassedDocstring coverage is 93.10% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@kamilla11
kamilla11
commented
May 26, 2026

Copy link


Copy Markdown

Author
I also want to warn you that IDE0055 errors occurred during the build, which are not present in <NoWarn>$(NoWarn);IDE0005;CA1510;</NoWarn>, which triggers configuration errors <TreatWarningsAsErrors>. These errors are not related to the code I changed.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kamilla11

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Replace string concatenation with StringBuilder and invariant interpolation - #696
Open
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Open
Replace string concatenation with StringBuilder and invariant interpolation#696
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Conversation
@kamilla11
@kamilla11kamilla11
commented
May 26, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary
Closes issue #648.
  • Replace string concatenation with StringBuilder or string interpolation.
  • Introduce StringExtensions.AppendInvariant(StringBuilder, …) as a single cross-TFM API.
  • Add polyfill attributes (InterpolatedStringHandlerAttribute, etc.) for targets below .NET 6 so the compiler can emit correct interpolation code.
Extension method sb.AppendInvariant("...") on .NET 6+ is not possible (CS8944), so a static call is used StringExtensions.AppendInvariant(sb, "...")
Summary by CodeRabbit
  • Refactor
    • Optimized string building operations across payload generators for improved memory efficiency
    • Enhanced invariant culture string handling in payment and QR code formats
    • Streamlined PDF generation string construction logic
  • Chores
    • Added internal compiler attribute support for .NET 6+ compatibility
Review Change Stack
@coderabbitai
coderabbitaiBot
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aaa1ad1f-5a33-4e9d-8c85-1adec053cf97
📥 Commits
Reviewing files that changed from the base of the PR and between 4b97eb1 and f39e154.
📒 Files selected for processing (15)
  • QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs
  • QRCoder/Extensions/StringExtensions.cs
  • QRCoder/PayloadGenerator.cs
  • QRCoder/PayloadGenerator/BezahlCode.cs
  • QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs
  • QRCoder/PayloadGenerator/ContactData.cs
  • QRCoder/PayloadGenerator/Girocode.cs
  • QRCoder/PayloadGenerator/Mail.cs
  • QRCoder/PayloadGenerator/OneTimePassword.cs
  • QRCoder/PayloadGenerator/RussiaPaymentOrder.cs
  • QRCoder/PayloadGenerator/SwissQrCode.cs
  • QRCoder/PayloadGenerator/Url.cs
  • QRCoder/PayloadGenerator/WiFi.cs
  • QRCoder/PdfByteQRCode.cs
  • QRCoder/QRCodeGenerator/Polynom.cs
📝 Walkthrough
Walkthrough
This PR systematically refactors QRCoder's payload generators to use invariant-culture interpolated strings instead of string concatenation. It adds compiler attributes for pre-.NET 6 compatibility, introduces an AppendInvariant extension helper, and applies the pattern across payment, contact, authentication, and PDF generation classes.
Changes
Interpolated String Handler Refactoring
Layer / File(s)Summary
Compiler Attributes & StringExtensions Infrastructure
QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs, QRCoder/Extensions/StringExtensions.cs		Adds InterpolatedStringHandlerAttribute, InterpolatedStringHandlerArgumentAttribute, and CompilerFeatureRequiredAttribute (conditional for !NET6_0_OR_GREATER). Introduces AppendInvariant helper that accepts interpolated-string handler refs for invariant-culture appends, with existing numeric overloads refactored to delegate through it.
Core PayloadGenerator Updates
QRCoder/PayloadGenerator.cs		IsValidIban checksum computation replaces LINQ Aggregate with StringBuilder loop; EscapeInput switches per-character replacement to interpolation; NET5+ conditional code uses interpolated substring construction.
Simple String Format Changes
QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs, QRCoder/PayloadGenerator/Mail.cs, QRCoder/PayloadGenerator/Url.cs, QRCoder/PayloadGenerator/WiFi.cs		Straightforward conversions from string concatenation to string interpolation for URL prefixes, query parameters, and HEX-string wrapping—no behavioral changes.
OneTimePassword OTP Query Building
QRCoder/PayloadGenerator/OneTimePassword.cs		HOTP counter, TOTP period, issuer:label combination, and common query fields refactored from sb.Append concatenation to StringExtensions.AppendInvariant with interpolation.
Payment & Financial Payload Builders
QRCoder/PayloadGenerator/BezahlCode.cs, QRCoder/PayloadGenerator/Girocode.cs, QRCoder/PayloadGenerator/RussiaPaymentOrder.cs		BezahlCode non-contact/contact query construction, Girocode BCD payload assembly, and RussiaPaymentOrder mandatory fields refactored to use StringBuilder + AppendInvariant, preserving conditional field inclusion and encoding normalization.
Contact & Address Data Builders
QRCoder/PayloadGenerator/ContactData.cs, QRCoder/PayloadGenerator/SwissQrCode.cs		ContactData (MeCard and vCard output) and SwissQrCode (contact block and full payload) refactored from concatenation to StringBuilder + AppendInvariant, maintaining address ordering rules and conditional formatting by output type/version. Formatting comments updated.
PDF Byte Generation
QRCoder/PdfByteQRCode.cs		PDF object construction (catalog, pages, content stream, xref table, trailer) switched from concatenation to StringBuilder + AppendInvariant; path rectangle commands and color RGB strings use interpolation. xref offset tracking and stream length computation preserved.
Polynomial String Representation
QRCoder/QRCodeGenerator/Polynom.cs		Polynomial term formatting updated to use AppendInvariant with interpolated algebraic notation instead of direct Append concatenation.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
  • Shane32/QRCoder#635: Modifies the same PDF generation code paths in PdfByteQRCode.cs (GetGraphic, CreatePathFromModules, ColorToPdfRgb).
Suggested labels
refactoring, performance
Suggested reviewers
  • gfoidl
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: replacing string concatenation with StringBuilder and invariant interpolation throughout the codebase.
Docstring Coverage✅ PassedDocstring coverage is 93.10% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@kamilla11
kamilla11
commented
May 26, 2026

Copy link


Copy Markdown

Author
I also want to warn you that IDE0055 errors occurred during the build, which are not present in <NoWarn>$(NoWarn);IDE0005;CA1510;</NoWarn>, which triggers configuration errors <TreatWarningsAsErrors>. These errors are not related to the code I changed.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kamilla11

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Replace string concatenation with StringBuilder and invariant interpolation - #696
Open
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Open
Replace string concatenation with StringBuilder and invariant interpolation#696
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Conversation
@kamilla11
@kamilla11kamilla11
commented
May 26, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary
Closes issue #648.
  • Replace string concatenation with StringBuilder or string interpolation.
  • Introduce StringExtensions.AppendInvariant(StringBuilder, …) as a single cross-TFM API.
  • Add polyfill attributes (InterpolatedStringHandlerAttribute, etc.) for targets below .NET 6 so the compiler can emit correct interpolation code.
Extension method sb.AppendInvariant("...") on .NET 6+ is not possible (CS8944), so a static call is used StringExtensions.AppendInvariant(sb, "...")
Summary by CodeRabbit
  • Refactor
    • Optimized string building operations across payload generators for improved memory efficiency
    • Enhanced invariant culture string handling in payment and QR code formats
    • Streamlined PDF generation string construction logic
  • Chores
    • Added internal compiler attribute support for .NET 6+ compatibility
Review Change Stack
@coderabbitai
coderabbitaiBot
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aaa1ad1f-5a33-4e9d-8c85-1adec053cf97
📥 Commits
Reviewing files that changed from the base of the PR and between 4b97eb1 and f39e154.
📒 Files selected for processing (15)
  • QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs
  • QRCoder/Extensions/StringExtensions.cs
  • QRCoder/PayloadGenerator.cs
  • QRCoder/PayloadGenerator/BezahlCode.cs
  • QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs
  • QRCoder/PayloadGenerator/ContactData.cs
  • QRCoder/PayloadGenerator/Girocode.cs
  • QRCoder/PayloadGenerator/Mail.cs
  • QRCoder/PayloadGenerator/OneTimePassword.cs
  • QRCoder/PayloadGenerator/RussiaPaymentOrder.cs
  • QRCoder/PayloadGenerator/SwissQrCode.cs
  • QRCoder/PayloadGenerator/Url.cs
  • QRCoder/PayloadGenerator/WiFi.cs
  • QRCoder/PdfByteQRCode.cs
  • QRCoder/QRCodeGenerator/Polynom.cs
📝 Walkthrough
Walkthrough
This PR systematically refactors QRCoder's payload generators to use invariant-culture interpolated strings instead of string concatenation. It adds compiler attributes for pre-.NET 6 compatibility, introduces an AppendInvariant extension helper, and applies the pattern across payment, contact, authentication, and PDF generation classes.
Changes
Interpolated String Handler Refactoring
Layer / File(s)Summary
Compiler Attributes & StringExtensions Infrastructure
QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs, QRCoder/Extensions/StringExtensions.cs		Adds InterpolatedStringHandlerAttribute, InterpolatedStringHandlerArgumentAttribute, and CompilerFeatureRequiredAttribute (conditional for !NET6_0_OR_GREATER). Introduces AppendInvariant helper that accepts interpolated-string handler refs for invariant-culture appends, with existing numeric overloads refactored to delegate through it.
Core PayloadGenerator Updates
QRCoder/PayloadGenerator.cs		IsValidIban checksum computation replaces LINQ Aggregate with StringBuilder loop; EscapeInput switches per-character replacement to interpolation; NET5+ conditional code uses interpolated substring construction.
Simple String Format Changes
QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs, QRCoder/PayloadGenerator/Mail.cs, QRCoder/PayloadGenerator/Url.cs, QRCoder/PayloadGenerator/WiFi.cs		Straightforward conversions from string concatenation to string interpolation for URL prefixes, query parameters, and HEX-string wrapping—no behavioral changes.
OneTimePassword OTP Query Building
QRCoder/PayloadGenerator/OneTimePassword.cs		HOTP counter, TOTP period, issuer:label combination, and common query fields refactored from sb.Append concatenation to StringExtensions.AppendInvariant with interpolation.
Payment & Financial Payload Builders
QRCoder/PayloadGenerator/BezahlCode.cs, QRCoder/PayloadGenerator/Girocode.cs, QRCoder/PayloadGenerator/RussiaPaymentOrder.cs		BezahlCode non-contact/contact query construction, Girocode BCD payload assembly, and RussiaPaymentOrder mandatory fields refactored to use StringBuilder + AppendInvariant, preserving conditional field inclusion and encoding normalization.
Contact & Address Data Builders
QRCoder/PayloadGenerator/ContactData.cs, QRCoder/PayloadGenerator/SwissQrCode.cs		ContactData (MeCard and vCard output) and SwissQrCode (contact block and full payload) refactored from concatenation to StringBuilder + AppendInvariant, maintaining address ordering rules and conditional formatting by output type/version. Formatting comments updated.
PDF Byte Generation
QRCoder/PdfByteQRCode.cs		PDF object construction (catalog, pages, content stream, xref table, trailer) switched from concatenation to StringBuilder + AppendInvariant; path rectangle commands and color RGB strings use interpolation. xref offset tracking and stream length computation preserved.
Polynomial String Representation
QRCoder/QRCodeGenerator/Polynom.cs		Polynomial term formatting updated to use AppendInvariant with interpolated algebraic notation instead of direct Append concatenation.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
  • Shane32/QRCoder#635: Modifies the same PDF generation code paths in PdfByteQRCode.cs (GetGraphic, CreatePathFromModules, ColorToPdfRgb).
Suggested labels
refactoring, performance
Suggested reviewers
  • gfoidl
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: replacing string concatenation with StringBuilder and invariant interpolation throughout the codebase.
Docstring Coverage✅ PassedDocstring coverage is 93.10% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@kamilla11
kamilla11
commented
May 26, 2026

Copy link


Copy Markdown

Author
I also want to warn you that IDE0055 errors occurred during the build, which are not present in <NoWarn>$(NoWarn);IDE0005;CA1510;</NoWarn>, which triggers configuration errors <TreatWarningsAsErrors>. These errors are not related to the code I changed.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kamilla11

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Replace string concatenation with StringBuilder and invariant interpolation - #696
Open
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Open
Replace string concatenation with StringBuilder and invariant interpolation#696
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Conversation
@kamilla11
@kamilla11kamilla11
commented
May 26, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary
Closes issue #648.
  • Replace string concatenation with StringBuilder or string interpolation.
  • Introduce StringExtensions.AppendInvariant(StringBuilder, …) as a single cross-TFM API.
  • Add polyfill attributes (InterpolatedStringHandlerAttribute, etc.) for targets below .NET 6 so the compiler can emit correct interpolation code.
Extension method sb.AppendInvariant("...") on .NET 6+ is not possible (CS8944), so a static call is used StringExtensions.AppendInvariant(sb, "...")
Summary by CodeRabbit
  • Refactor
    • Optimized string building operations across payload generators for improved memory efficiency
    • Enhanced invariant culture string handling in payment and QR code formats
    • Streamlined PDF generation string construction logic
  • Chores
    • Added internal compiler attribute support for .NET 6+ compatibility
Review Change Stack
@coderabbitai
coderabbitaiBot
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aaa1ad1f-5a33-4e9d-8c85-1adec053cf97
📥 Commits
Reviewing files that changed from the base of the PR and between 4b97eb1 and f39e154.
📒 Files selected for processing (15)
  • QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs
  • QRCoder/Extensions/StringExtensions.cs
  • QRCoder/PayloadGenerator.cs
  • QRCoder/PayloadGenerator/BezahlCode.cs
  • QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs
  • QRCoder/PayloadGenerator/ContactData.cs
  • QRCoder/PayloadGenerator/Girocode.cs
  • QRCoder/PayloadGenerator/Mail.cs
  • QRCoder/PayloadGenerator/OneTimePassword.cs
  • QRCoder/PayloadGenerator/RussiaPaymentOrder.cs
  • QRCoder/PayloadGenerator/SwissQrCode.cs
  • QRCoder/PayloadGenerator/Url.cs
  • QRCoder/PayloadGenerator/WiFi.cs
  • QRCoder/PdfByteQRCode.cs
  • QRCoder/QRCodeGenerator/Polynom.cs
📝 Walkthrough
Walkthrough
This PR systematically refactors QRCoder's payload generators to use invariant-culture interpolated strings instead of string concatenation. It adds compiler attributes for pre-.NET 6 compatibility, introduces an AppendInvariant extension helper, and applies the pattern across payment, contact, authentication, and PDF generation classes.
Changes
Interpolated String Handler Refactoring
Layer / File(s)Summary
Compiler Attributes & StringExtensions Infrastructure
QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs, QRCoder/Extensions/StringExtensions.cs		Adds InterpolatedStringHandlerAttribute, InterpolatedStringHandlerArgumentAttribute, and CompilerFeatureRequiredAttribute (conditional for !NET6_0_OR_GREATER). Introduces AppendInvariant helper that accepts interpolated-string handler refs for invariant-culture appends, with existing numeric overloads refactored to delegate through it.
Core PayloadGenerator Updates
QRCoder/PayloadGenerator.cs		IsValidIban checksum computation replaces LINQ Aggregate with StringBuilder loop; EscapeInput switches per-character replacement to interpolation; NET5+ conditional code uses interpolated substring construction.
Simple String Format Changes
QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs, QRCoder/PayloadGenerator/Mail.cs, QRCoder/PayloadGenerator/Url.cs, QRCoder/PayloadGenerator/WiFi.cs		Straightforward conversions from string concatenation to string interpolation for URL prefixes, query parameters, and HEX-string wrapping—no behavioral changes.
OneTimePassword OTP Query Building
QRCoder/PayloadGenerator/OneTimePassword.cs		HOTP counter, TOTP period, issuer:label combination, and common query fields refactored from sb.Append concatenation to StringExtensions.AppendInvariant with interpolation.
Payment & Financial Payload Builders
QRCoder/PayloadGenerator/BezahlCode.cs, QRCoder/PayloadGenerator/Girocode.cs, QRCoder/PayloadGenerator/RussiaPaymentOrder.cs		BezahlCode non-contact/contact query construction, Girocode BCD payload assembly, and RussiaPaymentOrder mandatory fields refactored to use StringBuilder + AppendInvariant, preserving conditional field inclusion and encoding normalization.
Contact & Address Data Builders
QRCoder/PayloadGenerator/ContactData.cs, QRCoder/PayloadGenerator/SwissQrCode.cs		ContactData (MeCard and vCard output) and SwissQrCode (contact block and full payload) refactored from concatenation to StringBuilder + AppendInvariant, maintaining address ordering rules and conditional formatting by output type/version. Formatting comments updated.
PDF Byte Generation
QRCoder/PdfByteQRCode.cs		PDF object construction (catalog, pages, content stream, xref table, trailer) switched from concatenation to StringBuilder + AppendInvariant; path rectangle commands and color RGB strings use interpolation. xref offset tracking and stream length computation preserved.
Polynomial String Representation
QRCoder/QRCodeGenerator/Polynom.cs		Polynomial term formatting updated to use AppendInvariant with interpolated algebraic notation instead of direct Append concatenation.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
  • Shane32/QRCoder#635: Modifies the same PDF generation code paths in PdfByteQRCode.cs (GetGraphic, CreatePathFromModules, ColorToPdfRgb).
Suggested labels
refactoring, performance
Suggested reviewers
  • gfoidl
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: replacing string concatenation with StringBuilder and invariant interpolation throughout the codebase.
Docstring Coverage✅ PassedDocstring coverage is 93.10% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@kamilla11
kamilla11
commented
May 26, 2026

Copy link


Copy Markdown

Author
I also want to warn you that IDE0055 errors occurred during the build, which are not present in <NoWarn>$(NoWarn);IDE0005;CA1510;</NoWarn>, which triggers configuration errors <TreatWarningsAsErrors>. These errors are not related to the code I changed.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kamilla11

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Replace string concatenation with StringBuilder and invariant interpolation - #696
Open
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Open
Replace string concatenation with StringBuilder and invariant interpolation#696
kamilla11 wants to merge 1 commit into
Shane32:masterfrom 
kamilla11:refactor/string_concatenation_replacement
Conversation
@kamilla11
@kamilla11kamilla11
commented
May 26, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary
Closes issue #648.
  • Replace string concatenation with StringBuilder or string interpolation.
  • Introduce StringExtensions.AppendInvariant(StringBuilder, …) as a single cross-TFM API.
  • Add polyfill attributes (InterpolatedStringHandlerAttribute, etc.) for targets below .NET 6 so the compiler can emit correct interpolation code.
Extension method sb.AppendInvariant("...") on .NET 6+ is not possible (CS8944), so a static call is used StringExtensions.AppendInvariant(sb, "...")
Summary by CodeRabbit
  • Refactor
    • Optimized string building operations across payload generators for improved memory efficiency
    • Enhanced invariant culture string handling in payment and QR code formats
    • Streamlined PDF generation string construction logic
  • Chores
    • Added internal compiler attribute support for .NET 6+ compatibility
Review Change Stack
@coderabbitai
coderabbitaiBot
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aaa1ad1f-5a33-4e9d-8c85-1adec053cf97
📥 Commits
Reviewing files that changed from the base of the PR and between 4b97eb1 and f39e154.
📒 Files selected for processing (15)
  • QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs
  • QRCoder/Extensions/StringExtensions.cs
  • QRCoder/PayloadGenerator.cs
  • QRCoder/PayloadGenerator/BezahlCode.cs
  • QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs
  • QRCoder/PayloadGenerator/ContactData.cs
  • QRCoder/PayloadGenerator/Girocode.cs
  • QRCoder/PayloadGenerator/Mail.cs
  • QRCoder/PayloadGenerator/OneTimePassword.cs
  • QRCoder/PayloadGenerator/RussiaPaymentOrder.cs
  • QRCoder/PayloadGenerator/SwissQrCode.cs
  • QRCoder/PayloadGenerator/Url.cs
  • QRCoder/PayloadGenerator/WiFi.cs
  • QRCoder/PdfByteQRCode.cs
  • QRCoder/QRCodeGenerator/Polynom.cs
📝 Walkthrough
Walkthrough
This PR systematically refactors QRCoder's payload generators to use invariant-culture interpolated strings instead of string concatenation. It adds compiler attributes for pre-.NET 6 compatibility, introduces an AppendInvariant extension helper, and applies the pattern across payment, contact, authentication, and PDF generation classes.
Changes
Interpolated String Handler Refactoring
Layer / File(s)Summary
Compiler Attributes & StringExtensions Infrastructure
QRCoder/Attributes/InterpolatedStringHandlerAttributes.cs, QRCoder/Extensions/StringExtensions.cs		Adds InterpolatedStringHandlerAttribute, InterpolatedStringHandlerArgumentAttribute, and CompilerFeatureRequiredAttribute (conditional for !NET6_0_OR_GREATER). Introduces AppendInvariant helper that accepts interpolated-string handler refs for invariant-culture appends, with existing numeric overloads refactored to delegate through it.
Core PayloadGenerator Updates
QRCoder/PayloadGenerator.cs		IsValidIban checksum computation replaces LINQ Aggregate with StringBuilder loop; EscapeInput switches per-character replacement to interpolation; NET5+ conditional code uses interpolated substring construction.
Simple String Format Changes
QRCoder/PayloadGenerator/BitcoinLikeCryptoCurrencyAddress.cs, QRCoder/PayloadGenerator/Mail.cs, QRCoder/PayloadGenerator/Url.cs, QRCoder/PayloadGenerator/WiFi.cs		Straightforward conversions from string concatenation to string interpolation for URL prefixes, query parameters, and HEX-string wrapping—no behavioral changes.
OneTimePassword OTP Query Building
QRCoder/PayloadGenerator/OneTimePassword.cs		HOTP counter, TOTP period, issuer:label combination, and common query fields refactored from sb.Append concatenation to StringExtensions.AppendInvariant with interpolation.
Payment & Financial Payload Builders
QRCoder/PayloadGenerator/BezahlCode.cs, QRCoder/PayloadGenerator/Girocode.cs, QRCoder/PayloadGenerator/RussiaPaymentOrder.cs		BezahlCode non-contact/contact query construction, Girocode BCD payload assembly, and RussiaPaymentOrder mandatory fields refactored to use StringBuilder + AppendInvariant, preserving conditional field inclusion and encoding normalization.
Contact & Address Data Builders
QRCoder/PayloadGenerator/ContactData.cs, QRCoder/PayloadGenerator/SwissQrCode.cs		ContactData (MeCard and vCard output) and SwissQrCode (contact block and full payload) refactored from concatenation to StringBuilder + AppendInvariant, maintaining address ordering rules and conditional formatting by output type/version. Formatting comments updated.
PDF Byte Generation
QRCoder/PdfByteQRCode.cs		PDF object construction (catalog, pages, content stream, xref table, trailer) switched from concatenation to StringBuilder + AppendInvariant; path rectangle commands and color RGB strings use interpolation. xref offset tracking and stream length computation preserved.
Polynomial String Representation
QRCoder/QRCodeGenerator/Polynom.cs		Polynomial term formatting updated to use AppendInvariant with interpolated algebraic notation instead of direct Append concatenation.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
  • Shane32/QRCoder#635: Modifies the same PDF generation code paths in PdfByteQRCode.cs (GetGraphic, CreatePathFromModules, ColorToPdfRgb).
Suggested labels
refactoring, performance
Suggested reviewers
  • gfoidl
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: replacing string concatenation with StringBuilder and invariant interpolation throughout the codebase.
Docstring Coverage✅ PassedDocstring coverage is 93.10% which is sufficient. The required threshold is 80.00%.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@kamilla11
kamilla11
commented
May 26, 2026

Copy link


Copy Markdown

Author
I also want to warn you that IDE0055 errors occurred during the build, which are not present in <NoWarn>$(NoWarn);IDE0005;CA1510;</NoWarn>, which triggers configuration errors <TreatWarningsAsErrors>. These errors are not related to the code I changed.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kamilla11